Re: [HACKERS] Re: [HACKERS] Patch für MAP_HUGETLB for mmap() shared memory

2013-06-29 Thread Andres Freund
Hi, On 2013-06-28 23:03:22 -0400, Bruce Momjian wrote: Did we decide against specifying huge pages in Postgres? I don't think so. We need somebody to make some last modifications to the patch though and Christian doesn't seem to have the time atm. I think the bigger memory (size of the per

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-29 Thread Heikki Linnakangas
On 27.06.2013 17:20, Antonin Houska wrote: I was curious about the new layout of the data page, so I spent a while looking into the code. It's interesting, but I suspect 2 things are not o.k.: * gindatapage.c:dataIsEnoughSpace() - 'i++' in the for loop should probably be 'j++', otherwise it

Re: [HACKERS] checking variadic any argument in parser - should be array

2013-06-29 Thread Pavel Stehule
2013/6/28 Jeevan Chalke jeevan.cha...@enterprisedb.com: Hi Pavel, On Fri, Jun 28, 2013 at 2:53 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2013/6/27 Jeevan Chalke jeevan.cha...@enterprisedb.com: Hi Pavel, I had a look over your new patch and it looks good to me. My

[HACKERS] GIN low hanging fruit

2013-06-29 Thread Heikki Linnakangas
While profiling Alexander's patches, I noticed that a lot of time is spent in ginCompareItemPointers: 47,59% postmaster postgres gingetbitmap 46,73% postmaster postgres ginCompareItemPointers 2,31% postmaster postgres FunctionCall8Coll 1,54% postmaster postgres callConsistentFn

Re: [HACKERS] psql and pset without any arguments

2013-06-29 Thread Marc Mamin
Von: pgsql-hackers-ow...@postgresql.org [pgsql-hackers-ow...@postgresql.org]quot; im Auftrag von quot;Gilles Darold [gilles.dar...@dalibo.com] I was looking at psql 8.3 documention about \pset options and saw that there was the following note : Note: It is an error to call \pset without

[HACKERS] proposal: simple date constructor from numeric values

2013-06-29 Thread Pavel Stehule
Hello long time I am thinking about simple function for creating date or timestamp values based on numeric types without necessity to create format string. some like ansi_date(year, month, day) and ansi_timestamp(year, month, day, hour, minuts, sec, msec, offset) What do you think about this

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-29 Thread Antonin Houska
On 06/29/2013 11:00 AM, Heikki Linnakangas wrote: On 27.06.2013 17:20, Antonin Houska wrote: I was curious about the new layout of the data page, so I spent a while looking into the code. It's interesting, but I suspect 2 things are not o.k.: * gindatapage.c:dataIsEnoughSpace() - 'i++' in the

Re: [HACKERS] psql and pset without any arguments

2013-06-29 Thread Erik Rijkers
On Sat, June 29, 2013 01:08, Gilles Darold wrote: Here is a sample output: (postgres@[local]:5494) [postgres] \pset Output format is aligned. Border style is 2. Expanded display is used automatically. Null display is NULL. Field separator

Re: [HACKERS] psql and pset without any arguments

2013-06-29 Thread Pavel Stehule
2013/6/29 Erik Rijkers e...@xs4all.nl: On Sat, June 29, 2013 01:08, Gilles Darold wrote: Here is a sample output: (postgres@[local]:5494) [postgres] \pset Output format is aligned. Border style is 2. Expanded display is used automatically. Null

Re: [HACKERS] [GENERAL] pg_upgrade -u

2013-06-29 Thread Bruce Momjian
On Fri, Jun 28, 2013 at 11:59:58PM -0400, Peter Eisentraut wrote: On 6/28/13 9:43 PM, Bruce Momjian wrote: On Fri, Jun 28, 2013 at 09:15:31PM -0400, Peter Eisentraut wrote: On 6/28/13 6:06 PM, Bruce Momjian wrote: On Wed, May 29, 2013 at 09:44:00AM -0400, Peter Eisentraut wrote: On

[HACKERS] pg_ctl and -h/help

2013-06-29 Thread Bruce Momjian
In studying pg_upgrade's handling of --help, I noticed that pg_ctl supports -h for help, but it is the only tool to do so, and -h is not documented. I propose we remove -h for help in pg_ctl, and have it support only -? and --help. -- Bruce Momjian br...@momjian.ushttp://momjian.us

Re: [HACKERS] [PATCH] Add session_preload_libraries configuration parameter

2013-06-29 Thread Robins
On 12 June 2013 22:12, Peter Eisentraut pete...@gmx.net wrote: This is like shared_preload_libraries except that it takes effect at backend start and can be changed without a full postmaster restart. It is like local_preload_libraries except that it is still only settable by a superuser.

Re: [HACKERS] Patch to add support of IF NOT EXISTS to others CREATE statements

2013-06-29 Thread Fabrízio de Royes Mello
On Thu, Jun 20, 2013 at 1:24 PM, Peter Eisentraut pete...@gmx.net wrote: On 6/20/13 11:04 AM, Robert Haas wrote: I kind of don't see the point of having IF NOT EXISTS for things that have OR REPLACE, and am generally in favor of implementing OR REPLACE rather than IF NOT EXISTS where

Re: [HACKERS] Patch to add support of IF NOT EXISTS to others CREATE statements

2013-06-29 Thread Fabrízio de Royes Mello
On Mon, Jun 24, 2013 at 8:05 AM, Andres Freund and...@2ndquadrant.com wrote: I'd argue if we go that way - which seems to be a good idea - we really ought to make a complete pass and add it to all commands where it's currently missing. Yeah... this is my purpose, but I decide do that in two

Re: [HACKERS] psql and pset without any arguments

2013-06-29 Thread Gilles Darold
Le 29/06/2013 13:55, Erik Rijkers a écrit : On Sat, June 29, 2013 01:08, Gilles Darold wrote: Here is a sample output: (postgres@[local]:5494) [postgres] \pset Output format is aligned. Border style is 2. Expanded display is used automatically.

Re: [HACKERS] New regression test time

2013-06-29 Thread Robert Haas
On Jun 29, 2013, at 12:36 AM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: I see two problems with this report: 1. it creates a new installation for each run, But that's the normal way of running the tests anyway, isn't it? 2. it only uses the serial schedule. make check uses the parallel

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Bruce Momjian
Is there a reason this patch was not applied? --- On Mon, Nov 12, 2012 at 05:14:57PM -0500, Andrew Dunstan wrote: vacuumlo is rather simpleminded about dealing with the list of LOs to be removed - it just fetches them as

Re: [HACKERS] Eliminating PD_ALL_VISIBLE, take 2

2013-06-29 Thread Robins
On 10 June 2013 00:17, Jeff Davis pg...@j-davis.com wrote: On Thu, 2013-05-30 at 10:07 -0700, Jeff Davis wrote: Come to think of it, even without the torn page checksum issue, do we really want to actively clear the all-visible flags after upgrade? Removed that from the patch and

Re: [HACKERS] [PATCH] Add session_preload_libraries configuration parameter

2013-06-29 Thread Robins
Number of new lines added not covered by tests: -107 (Wierd but, it seems to have reduced line coverage). But correct me if am not seeing the elephant in the room. My apologies. Number of new untested lines: 108 Robins

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Andrew Dunstan
Nobody seemed interested. But I do think it's a good idea still. cheers andrew On 06/29/2013 11:23 AM, Bruce Momjian wrote: Is there a reason this patch was not applied? --- On Mon, Nov 12, 2012 at 05:14:57PM -0500,

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Bruce Momjian
On Sat, Jun 29, 2013 at 11:33:54AM -0400, Andrew Dunstan wrote: Nobody seemed interested. But I do think it's a good idea still. Well, if no one replied, and you thought it was a good idea, then it was a good idea. ;-) -- Bruce Momjian br...@momjian.ushttp://momjian.us

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Joshua D. Drake
On 06/29/2013 08:35 AM, Bruce Momjian wrote: On Sat, Jun 29, 2013 at 11:33:54AM -0400, Andrew Dunstan wrote: Nobody seemed interested. But I do think it's a good idea still. Well, if no one replied, and you thought it was a good idea, then it was a good idea. ;-) I think it is a good

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Andrew Dunstan
On 06/29/2013 11:35 AM, Bruce Momjian wrote: On Sat, Jun 29, 2013 at 11:33:54AM -0400, Andrew Dunstan wrote: Nobody seemed interested. But I do think it's a good idea still. Well, if no one replied, and you thought it was a good idea, then it was a good idea. ;-) I try not to assume that

Re: [HACKERS] GIN improvements part 1: additional information

2013-06-29 Thread Heikki Linnakangas
On 29.06.2013 11:56, Heikki Linnakangas wrote: On 25.06.2013 01:03, Alexander Korotkov wrote: New revision of patch is attached. Now it includes some docs. Thanks! I'm looking into this in detail now. First, this patch actually contains two major things: 1. Pack item pointers more tightly

Re: [HACKERS] Request for Patch Feedback: Lag Lead Window Functions Can Ignore Nulls

2013-06-29 Thread Jeff Davis
On Mon, 2013-06-24 at 18:01 +0100, Nicholas White wrote: Good catch - I've attached a patch to address your point 1. It now returns the below (i.e. correctly doesn't fill in the saved value if the index is out of the window. However, I'm not sure whether (e.g.) lead-2-ignore-nulls means count

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-29 Thread Andrew Dunstan
On 06/26/2013 10:52 AM, Andrew Dunstan wrote: On 06/25/2013 11:29 AM, Cédric Villemain wrote: Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit : On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013 00:18:26, Andrew Dunstan a écrit : On 06/24/2013 04:02 PM, Cédric

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-29 Thread Cédric Villemain
[it seems my first email didn't make it, sent again] Le mercredi 26 juin 2013 16:52:01, Andrew Dunstan a écrit : On 06/25/2013 11:29 AM, Cédric Villemain wrote: Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit : On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-29 Thread Cédric Villemain
Le samedi 29 juin 2013 19:54:53, Andrew Dunstan a écrit : On 06/26/2013 10:52 AM, Andrew Dunstan wrote: On 06/25/2013 11:29 AM, Cédric Villemain wrote: Le mardi 25 juin 2013 17:18:51, Andrew Dunstan a écrit : On 06/24/2013 07:24 PM, Cédric Villemain wrote: Le mardi 25 juin 2013 00:18:26,

Re: [HACKERS] vacuumlo - use a cursor

2013-06-29 Thread Bruce Momjian
On Sat, Jun 29, 2013 at 12:21:11PM -0400, Andrew Dunstan wrote: On 06/29/2013 11:35 AM, Bruce Momjian wrote: On Sat, Jun 29, 2013 at 11:33:54AM -0400, Andrew Dunstan wrote: Nobody seemed interested. But I do think it's a good idea still. Well, if no one replied, and you thought it was a good

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-29 Thread Andrew Dunstan
On 06/29/2013 02:27 PM, Cédric Villemain wrote: I haven't seen a response to this. One thing we are missing is documentation. Given that I'm inclined to commit all of this (i.e. cedric's patches 1,2,3, and 4 plus my addition). I did so I sent the mail again. I believe your addition need some

Re: [HACKERS] checking variadic any argument in parser - should be array

2013-06-29 Thread Pavel Stehule
Hello updated patch - precious Assert, more comments Regards Pavel 2013/6/29 Pavel Stehule pavel.steh...@gmail.com: 2013/6/28 Jeevan Chalke jeevan.cha...@enterprisedb.com: Hi Pavel, On Fri, Jun 28, 2013 at 2:53 AM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello 2013/6/27 Jeevan

Re: [HACKERS] Spin Lock sleep resolution

2013-06-29 Thread Jeff Janes
On Fri, Jun 28, 2013 at 2:46 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 27.06.2013 17:30, Robert Haas wrote: On Wed, Jun 26, 2013 at 5:49 PM, Jeff Janesjeff.ja...@gmail.com wrote: If we think the patch has a risk of introducing subtle errors, then it probably can't be

Re: [HACKERS] New regression test time

2013-06-29 Thread Josh Berkus
I see two problems with this report: 1. it creates a new installation for each run, Yes, I'm running make check 2. it only uses the serial schedule. Um, no: parallel group (19 tests): limit prepare copy2 plancache xml returning conversion rowtypes largeobject temp truncate polymorphism

Re: [HACKERS] Bugfix and new feature for PGXS

2013-06-29 Thread Josh Berkus
On 06/29/2013 11:42 AM, Andrew Dunstan wrote: I think we can survive for now without an additional tool. What I did was a proof of concept, it was not intended as a suggestion that we should install prep_buildtree. I am only suggesting that, in addition to your changes, if USE_VPATH is set

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-29 Thread Joe Conway
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2013 01:37 PM, Liming Hu wrote: please remove dameraulevenshteinnocompatible related stuff, I just followed the template you created. dameraulevenshteinnocompatible was used in my first testing. diff -cNr

Re: [HACKERS] New regression test time

2013-06-29 Thread Andrew Dunstan
On 06/29/2013 03:57 PM, Josh Berkus wrote: I see two problems with this report: 1. it creates a new installation for each run, Yes, I'm running make check 2. it only uses the serial schedule. Um, no: parallel group (19 tests): limit prepare copy2 plancache xml returning conversion

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-29 Thread Liming Hu
On 6/29/2013 1:37 PM, Joe Conway wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/25/2013 01:37 PM, Liming Hu wrote: please remove dameraulevenshteinnocompatible related stuff, I just followed the template you created. dameraulevenshteinnocompatible was used in my first testing. diff

Re: [HACKERS] New regression test time

2013-06-29 Thread Josh Berkus
On 06/29/2013 02:14 PM, Andrew Dunstan wrote: AIUI: They do test feature use and errors that have cropped up in the past that we need to beware of. They don't test every bug we've ever had, nor do they exercise every piece of code. If we don't have a test for it, then we can break it in the

Re: [HACKERS] New regression test time

2013-06-29 Thread Dann Corbit
-Original Message- From: pgsql-hackers-ow...@postgresql.org [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Josh Berkus Sent: Saturday, June 29, 2013 3:00 PM To: Andrew Dunstan Cc: Alvaro Herrera; pgsql-hackers@postgresql.org; Robins Tharakan Subject: Re: [HACKERS] New regression

Re: [HACKERS] New regression test time

2013-06-29 Thread Andrew Dunstan
On 06/29/2013 05:59 PM, Josh Berkus wrote: Maybe there is a good case for these last two in a different set of tests. If we had a different set of tests, that would be a valid argument. But we don't, so it's not. And nobody has offered to write a feature to split our tests either. I have

Re: [HACKERS] New regression test time

2013-06-29 Thread Josh Berkus
Dividing the tests into different sections is as simple as creating one schedule file per section. Oh? Huh. I'd thought it would be much more complicated. Well, by all means, let's do it then. I'm not personally convinced that the existing regression tests all belong in the default

Re: [HACKERS] New regression test time

2013-06-29 Thread Claudio Freire
On Sat, Jun 29, 2013 at 7:58 PM, Josh Berkus j...@agliodbs.com wrote: Dividing the tests into different sections is as simple as creating one schedule file per section. Oh? Huh. I'd thought it would be much more complicated. Well, by all means, let's do it then. I think I should point

Re: [HACKERS] [PATCH] pgbench --throttle (submission 7 - with lag measurement)

2013-06-29 Thread Greg Smith
On 6/22/13 12:54 PM, Fabien COELHO wrote: After some poking around, and pursuing various red herrings, I resorted to measure the delay for calling PQfinish(), which is really the only special thing going around at the end of pgbench run... This wasn't what I was seeing, but it's related. I've

Re: [HACKERS] New regression test time

2013-06-29 Thread Stephen Frost
Josh, * Josh Berkus (j...@agliodbs.com) wrote: If we don't have a test for it, then we can break it in the future and not know we've broken it until .0 is released. Is that really a direction we're happy going in? To be fair, AIUI anyway, certain companies have much larger regression suites

Re: [HACKERS] request a new feature in fuzzystrmatch

2013-06-29 Thread Michael Paquier
On Sun, Jun 30, 2013 at 5:37 AM, Joe Conway m...@joeconway.com wrote: Actually, given that this change will create version 1.1 of the extension, I believe the 1.0 versions of the sql scripts should probably be removed entirely. Can someone with more knowledge of the extension facility comment

[HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Peter Eisentraut
./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’: ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions We could exclude that file from the check, but it's also easy to fix by making the

Re: [HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Tom Lane
Peter Eisentraut pete...@gmx.net writes: ./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’: ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions We could exclude that file from the check,

Re: [HACKERS] checksum_impl.h fails cpluspluscheck

2013-06-29 Thread Peter Geoghegan
On Sat, Jun 29, 2013 at 8:55 PM, Peter Eisentraut pete...@gmx.net wrote: ./src/include/storage/checksum_impl.h: In function ‘uint32 pg_checksum_block(char*, uint32)’: ./src/include/storage/checksum_impl.h:154: warning: comparison between signed and unsigned integer expressions On the

Re: [HACKERS] pg_ctl and -h/help

2013-06-29 Thread Michael Paquier
On Sat, Jun 29, 2013 at 10:45 PM, Bruce Momjian br...@momjian.us wrote: In studying pg_upgrade's handling of --help, I noticed that pg_ctl supports -h for help, but it is the only tool to do so, and -h is not documented. I propose we remove -h for help in pg_ctl, and have it support only -?