Re: [HACKERS] replication_reserved_connections

2013-07-28 Thread Atri Sharma
Sent from my iPad On 28-Jul-2013, at 5:53, Marko Tiikkaja ma...@joh.to wrote: Hi, Yesterday an interesting scenario was diagnosed on IRC. If you're running a synchronous slave and the connection to the slave is lost momentarily, your backends start naturally waiting for the slave to

Re: [HACKERS] improve Chinese locale performance

2013-07-28 Thread Martijn van Oosterhout
On Tue, Jul 23, 2013 at 10:34:21AM -0400, Robert Haas wrote: I pretty much lost interest in ICU upon reading that they use UTF-16 as their internal format. http://userguide.icu-project.org/strings#TOC-Strings-in-ICU The UTF-8 support has been steadily improving: For example,

Re: [HACKERS] replication_reserved_connections

2013-07-28 Thread Marko Tiikkaja
On 28/07/2013 08:51, Atri Sharma wrote: I would generally in agree with sharing super user reserved connections with replication.One thing I would like to explore is if we could potentially add some sort of priority system for avoiding contention between super user threads and replication

[HACKERS] Comparing toasted data (was improve Chinese locale performance)

2013-07-28 Thread Greg Stark
On Sun, Jul 28, 2013 at 10:39 AM, Martijn van Oosterhout klep...@svana.org wrote: The main issue with strxfrm() is its lame API. If it supported returning prefixes you'd be set, but as it is you need 10MB of memory just to transform a 10MB string, even if only the first few characers would be

Re: [HACKERS] replication_reserved_connections

2013-07-28 Thread Gibheer
On Sun, 28 Jul 2013 02:23:47 +0200 Marko Tiikkaja ma...@joh.to wrote: Hi, Yesterday an interesting scenario was diagnosed on IRC. If you're running a synchronous slave and the connection to the slave is lost momentarily, your backends start naturally waiting for the slave to reconnect.

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-28 Thread Greg Stark
On Sun, Jul 28, 2013 at 6:49 AM, David Fetter da...@fetter.org wrote: Are you still on this? Do you have questions or concerns? Still on this, I've just been a bit busy the past few days. -- greg -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] replication_reserved_connections

2013-07-28 Thread Marko Tiikkaja
On 2013-07-28 19:21, Gibheer wrote: I had the same problem and I created a patch to introduce a GUC for reserved_replication_connections as a seperate flag. You can find my patch here https://commitfest.postgresql.org/action/patch_view?id=1180 Oops. I guess I should've searched through the

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-28 Thread Greg Stark
On Wed, Jul 24, 2013 at 7:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: I don't see any workable fix that doesn't involve the funny token, though. Consider CREATE VIEW v AS SELECT ... FROM UNNEST(...) WITH ORDINALITY; CREATE VIEW v AS SELECT ... FROM UNNEST(...) WITH NO DATA; WITH ORDINALITY

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-28 Thread Tom Lane
Greg Stark st...@mit.edu writes: Instead of collapsing WITH TIME and WITH ORDINALITY into a single token why don't we just modify the WITH token to WITH_FOLLOWED_BY_TIME and WITH_FOLLOWED_BY_ORDINALITY but still keep the following token. Then we can just include those two tokens everywhere we

Re: [HACKERS] replication_reserved_connections

2013-07-28 Thread Andres Freund
On 2013-07-28 02:23:47 +0200, Marko Tiikkaja wrote: While you could limit the number of connections for non-replication roles, that's not always possible or desirable. I would like to introduce a way to reserve connection slots for replication. However, it's not clear how this would work. I

Re: [HACKERS] install libpq.dll in bin directory on Windows / Cygwin

2013-07-28 Thread Andrew Dunstan
On 07/25/2013 06:27 PM, MauMau wrote: From: Andrew Dunstan andrew.duns...@pgexperts.com on Windows it's necessary to have libpq.dll/cygpq.dll either in the PATH or in the same directory as client .exe files. The buildfarm client has for many years simply copied this dll from the installation

Re: [HACKERS] install libpq.dll in bin directory on Windows / Cygwin

2013-07-28 Thread Andres Freund
On 2013-07-28 15:37:49 -0400, Andrew Dunstan wrote: BTW, why is libpq.dll in lib necessary? For the above files? If so, we can remove libpq.dll from lib. Or, libpqwalreceiver.dll needs it? Not sure. Perhaps you could experiment and see if anything bad happens if libpq is just installed in

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-28 Thread Josh Berkus
I think if we can design conf.d separately for config files of management tools, then it is better to have postgresql.auto.conf to be in $PGDATA rather than in $PGDATA/conf.d One of the biggest current complaints about recovery.conf from Debian/Ubuntu users is the fact that it lives in

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-28 Thread Tom Lane
Josh Berkus j...@agliodbs.com writes: I think if we can design conf.d separately for config files of management tools, then it is better to have postgresql.auto.conf to be in $PGDATA rather than in $PGDATA/conf.d One of the biggest current complaints about recovery.conf from Debian/Ubuntu

[HACKERS] Re: [COMMITTERS] pgsql: Add GET DIAGNOSTICS ... PG_CONTEXT in PL/PgSQL

2013-07-28 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: OK. One possibly non-obvious point is that I think the field should be defined as context containing associated non-constant strings; this would mean in particular that CopyErrorData would need to change it to CurrentMemoryContext in the copied

[HACKERS] Evaluate arbitrary expression on tuple inside trigger function?

2013-07-28 Thread Tom Dunstan
Hi all I'm trying to hack a trigger function to evaluate an expression on the tuple that the trigger has been fired for, kinda like a check constraint. I looked at ExecRelCheck in execMain.c which does more-or-less what I want to do, and I have the parsed node tree all ready to go. The problem

[HACKERS] Bison 3.0 updates

2013-07-28 Thread Tom Lane
Buildfarm member anchovy has been failing for the last couple of days, evidently because its owner just couldn't wait to adopt bison 3.0, which is all of 3 days old. The failures look like cubeparse.y:42.1-13: warning: deprecated directive, use '%name-prefix' [-Wdeprecated]

Re: [HACKERS] Bison 3.0 updates

2013-07-28 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: Buildfarm member anchovy has been failing for the last couple of days, [...] I'm thinking we should apply this to all supported branches, in case somebody gets the idea to build an older branch with bleeding-edge tools. Any objections? Certainly

Re: [HACKERS] Bison 3.0 updates

2013-07-28 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: However, I comment on this mainly because anchovy has had issues with 9.1 and older for some time, which looks like an issue with GCC 4.8.0. Did you happen to resolve or identify what is happening there..? Yeah, we know about that:

Re: [HACKERS] Review: UNNEST (and other functions) WITH ORDINALITY

2013-07-28 Thread Andrew Gierth
I propose the following patch (which goes on top of the current ordinality one) to implement the suggested grammar changes. I think this is the cleanest way, and I've tested that it both passes regression and allows constructs like WITH time AS (...) to work. -- Andrew (irc:RhodiumToad) ***

Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: [HACKERS] Proposal for Allow postgresql.conf values to be changed via SQL [review])

2013-07-28 Thread Dimitri Fontaine
Tom Lane t...@sss.pgh.pa.us writes: One of the biggest current complaints about recovery.conf from Debian/Ubuntu users is the fact that it lives in $PGDATA. Won't we just get the same thing here? I don't think so, see below. I don't think that's the same case, but ... why exactly don't they