Re: [HACKERS] Custom Plan node

2013-10-05 Thread Kohei KaiGai
2013/10/3 Robert Haas robertmh...@gmail.com: I am a little less sanguine about the chances of a CustomJoin node working out well. I agree that we need something to handle join pushdown, but it seems to me that might be done by providing a Foreign Scan path into the joinrel rather than by

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-10-05 Thread Daniel Farina
On Fri, Oct 4, 2013 at 7:22 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Oct 3, 2013 at 5:11 PM, Sameer Thakur samthaku...@gmail.com wrote: On Wed, Oct 2, 2013 at 6:40 PM, Sameer Thakur samthaku...@gmail.com wrote: Looks pretty good. Do you want to package up the patch with your

Re: [HACKERS] Patch: FORCE_NULL option for copy COPY in CSV mode

2013-10-05 Thread Amit Kapila
On Sun, Sep 29, 2013 at 1:39 PM, Ian Lawrence Barwick barw...@gmail.com wrote: Hi, This patch implements the following TODO item: Allow COPY in CSV mode to control whether a quoted zero-length string is treated as NULL Currently this is always treated as a zero-length string,

Re: [HACKERS] Compression of full-page-writes

2013-10-05 Thread Amit Kapila
On Fri, Oct 4, 2013 at 10:49 AM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Sep 30, 2013 at 1:55 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Mon, Sep 30, 2013 at 10:04 AM, Fujii Masao masao.fu...@gmail.com wrote: On Mon, Sep 30, 2013 at 1:27 PM, KONDO Mitsumasa

Re: [HACKERS] [COMMITTERS] pgsql: Add DISCARD SEQUENCES command.

2013-10-05 Thread Michael Paquier
Hi, While having a look at this feature I found an assertion failure (commit 1310d4c): #2 0x00010eb7856d in ExceptionalCondition (conditionName=0x10ec3790b !(last_used_seq-last_valid), errorType=0x10ebe25e0 FailedAssertion, fileName=0x10ec37168 sequence.c, lineNumber=809) at assert.c:54 #3

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-10-05 Thread Sameer Thakur
Please find the patch attached Thanks for the patch! Here are the review comments: +OUT session_start timestamptz, +OUT introduced timestamptz, The patch exposes these columns in pg_stat_statements view. These should be documented. Yes, will add to documentation. I don't think

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-05 Thread Bruce Momjian
On Fri, Oct 4, 2013 at 10:42:46PM +0300, Oskari Saarenmaa wrote: Thanks for the offers, but it looks like ZFS doesn't actually implement a similar file level clone operation. See https://github.com/zfsonlinux/zfs/issues/405 for discussion on a feature request for it. ZFS does support

Re: [HACKERS] [PATCH] pg_upgrade: support for btrfs copy-on-write clones

2013-10-05 Thread Oskari Saarenmaa
05.10.2013 16:38, Bruce Momjian kirjoitti: On Fri, Oct 4, 2013 at 10:42:46PM +0300, Oskari Saarenmaa wrote: Thanks for the offers, but it looks like ZFS doesn't actually implement a similar file level clone operation. See https://github.com/zfsonlinux/zfs/issues/405 for discussion on a

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2013-10-05 Thread Sameer Thakur
On Sat, Oct 5, 2013 at 1:38 PM, Daniel Farina dan...@heroku.com wrote: On Fri, Oct 4, 2013 at 7:22 AM, Fujii Masao masao.fu...@gmail.com wrote: On Thu, Oct 3, 2013 at 5:11 PM, Sameer Thakur samthaku...@gmail.com wrote: On Wed, Oct 2, 2013 at 6:40 PM, Sameer Thakur samthaku...@gmail.com wrote:

[HACKERS] custom hash-based COUNT(DISTINCT) aggregate - unexpectedly high memory consumption

2013-10-05 Thread Tomas Vondra
Hi, I've been playing with a custom COUNT(DISTINCT) aggregate based on hash tables - it seems to be working as planned, except for memory consumption which is much higher than I expected. The code is available at https://github.com/tvondra/count_distinct and in short it works like this: 1)

Re: [HACKERS] pgbench progress report improvements - split 3 v2 - A

2013-10-05 Thread Noah Misch
On Thu, Sep 26, 2013 at 08:50:15PM +0200, Fabien COELHO wrote: Patch (4): Redefine latency as reported by pgbench and report lag more. Here is a first partial patch, which focusses on measuring latency and reporting the measure under --progress. This patch contains the features pertaining

Re: [HACKERS] plpgsql.print_strict_params

2013-10-05 Thread Marko Tiikkaja
On 04/10/2013 16:08, Robert Haas wrote: Yeah, that doesn't seem good. How about writing the grammar production as '#' K_PRINT_STRICT_PARAMS option_value where option_value := T_WORD | unreserved_keyword; Then you don't need to make ON and OFF keywords; you can just use strcmp() against the

Re: [HACKERS] pgbench - exclude pthread_create() from connection start timing

2013-10-05 Thread Noah Misch
On Tue, Oct 01, 2013 at 02:50:29PM +0200, Fabien COELHO wrote: I do not think that there is a clean and simple way to take the start/stop period into account when computing global performances of a run. The TPC-C benchmark tells to ignore the warmup/closure period, whatever they are, and only

Re: [HACKERS] 9.4 HEAD: select() failed in postmaster

2013-10-05 Thread Alvaro Herrera
MauMau escribió: From: Alvaro Herrera alvhe...@2ndquadrant.com Can you please send a fixup patch to what's already committed? OK, I'll send a patch against HEAD, which will be a few lines. Am I understanding the meaning of fixup patch? Yep, thanks. Please use the attached patch.

Re: [HACKERS] [COMMITTERS] pgsql: Add DISCARD SEQUENCES command.

2013-10-05 Thread Alvaro Herrera
Michael Paquier escribió: =# discard sequences ; DISCARD SEQUENCES =# select currval('foo'); ERROR: 55000: currval of sequence foo is not yet defined in this session LOCATION: currval_oid, sequence.c:780 =# select lastval(); The connection to the server was lost. Attempting reset: