Re: [HACKERS] walsender doesn't send keepalives when writes are pending

2014-02-22 Thread Andres Freund
On 2014-02-22 09:08:39 +0530, Amit Kapila wrote: The danger is rather that *no* keepalive is sent (with requestReply = true triggering a reply by the client) by the walsender. Try to run pg_receivexlog against a busy server with a low walsender timeout. Since we'll never get to sending a

Re: [HACKERS] Patch: show relation and tuple infos of a lock to acquire

2014-02-22 Thread Andres Freund
On 2014-02-22 11:53:24 +0530, Amit Kapila wrote: On Fri, Feb 21, 2014 at 4:55 PM, Christian Kruse christ...@2ndquadrant.com wrote: Hi, 1. New context added by this patch is display at wrong place [...] Do this patch expect to print the context at cancel request as well? To be

[HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-22 Thread Michael Paquier
Hi all, Please find attached a patch to dump pageinspect to 1.2. This simply changes page_header to use the new internal datatype pg_lsn instead of text. Regards, -- Michael diff --git a/contrib/pageinspect/Makefile b/contrib/pageinspect/Makefile index 0e267eb..ee78cb2 100644 ---

[HACKERS] commit fest 2014-01 week 5 report

2014-02-22 Thread Peter Eisentraut
Last week: Status Summary. Needs Review: 45, Waiting on Author: 13, Ready for Committer: 14, Committed: 38, Returned with Feedback: 4, Rejected: 2. Total: 116. This week: Status Summary. Needs Review: 43, Waiting on Author: 11, Ready for Committer: 12, Committed: 39, Returned with Feedback: 7,

Re: [HACKERS] [PATCH] Relocation of tablespaces in pg_basebackup

2014-02-22 Thread Peter Eisentraut
On 2/15/14, 7:05 PM, Peter Eisentraut wrote: I've been working on your patch. Attached is a version I'd be happy to commit. Please check that it's okay with you. Committed after some rebasing. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Dump pageinspect to 1.2: page_header with pg_lsn datatype

2014-02-22 Thread Alvaro Herrera
Michael Paquier escribió: Hi all, Please find attached a patch to dump pageinspect to 1.2. This simply changes page_header to use the new internal datatype pg_lsn instead of text. Uhm. Does this crash if you pg_upgrade a server that has 1.1 installed? -- Álvaro Herrera

[HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-02-22 Thread Rukh Meski
Hello hackers, I know you're busy wrapping up the 9.4 release, so please ignore this patch. ♜ update_delete_order_by_limit_v0.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-02-22 Thread Peter Geoghegan
On Sat, Feb 22, 2014 at 3:46 PM, Rukh Meski rukh.me...@yahoo.ca wrote: I know you're busy wrapping up the 9.4 release, so please ignore this patch. I think you should describe what the patch does, why you believe the feature is necessary, and perhaps how it compares to other, similar things. You

Re: [HACKERS] 9.5: UPDATE/DELETE .. ORDER BY .. LIMIT ..

2014-02-22 Thread Rukh Meski
On Saturday, February 22, 2014 11:57:06 PM, Peter Geoghegan p...@heroku.com wrote: I think you should describe what the patch does, why you believe the feature is necessary, and perhaps how it compares to other, similar things. You have documentation changes here, but that doesn't really tell us

Re: [HACKERS] Review: tests for client programs

2014-02-22 Thread Peter Eisentraut
On 2/9/14, 1:01 AM, Pavel Stehule wrote: b) Prepared tests fails when PostgreSQL server was up - should be checked and should to raise a valuable error message The original patch used a hard-coded port number, which was a mistake. I have changed this now to use a

Re: [HACKERS] Review: tests for client programs

2014-02-22 Thread Peter Eisentraut
On 2/17/14, 9:19 AM, Alvaro Herrera wrote: there can be option --with-client-tests and this option should to require IRC::Run A configure option seems a workable idea. In the future we might want to use the Perl test framework for other things, so perhaps --enable-perl-testing or

Re: [HACKERS] SSL: better default ciphersuite

2014-02-22 Thread Peter Eisentraut
On 2/2/14, 7:16 AM, Marko Kreen wrote: On Thu, Dec 12, 2013 at 04:32:07PM +0200, Marko Kreen wrote: Attached patch changes default ciphersuite to HIGH:MEDIUM:+3DES:!aNULL and also adds documentation about reasoning for it. This is the last pending SSL cleanup related patch:

[HACKERS] typemode for variable types

2014-02-22 Thread Mohsen SM
Hello. I have a new type similar to varchar. I want to fine how did I can to calculate typemod and where must I calculate typemod for this type. thanks.

Re: [HACKERS] Patch: show relation and tuple infos of a lock to acquire

2014-02-22 Thread Amit Kapila
On Sat, Feb 22, 2014 at 3:17 PM, Andres Freund and...@2ndquadrant.com wrote: On 2014-02-22 11:53:24 +0530, Amit Kapila wrote: In general, why I am suggesting to restrict display of newly added context for the case it is added to ensure that it doesn't get started displaying in other cases