Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

2014-04-13 Thread Christian Ullrich
* From: Amit Kapila > On Sun, Apr 13, 2014 at 5:59 PM, Christian Ullrich > wrote: > > There are some possible solutions: > > > > - pg_ctl could set an environment variable (unless it has to be > > compatible with postmasters from different versions, and it does > > not, does it?). > > Do yo

Re: [HACKERS] Including replication slot data in base backups

2014-04-13 Thread Michael Paquier
On Thu, Apr 10, 2014 at 12:36 AM, Robert Haas wrote: > On Tue, Apr 8, 2014 at 3:08 AM, Michael Paquier > wrote: >> On Tue, Apr 8, 2014 at 1:18 AM, Robert Haas wrote: >>> Not sure if this is exactly the right way to do it, but I agree that >>> something along those lines is a good idea. I also t

Re: [HACKERS] Signaling of waiting for a cleanup lock?

2014-04-13 Thread Amit Kapila
On Sun, Apr 13, 2014 at 9:14 PM, Andres Freund wrote: > On 2014-04-12 17:40:34 -0400, Robert Haas wrote: >> On Fri, Apr 11, 2014 at 10:28 AM, Andres Freund >> wrote: >> > VACUUM sometimes waits synchronously for a cleanup lock on a heap >> > page. Sometimes for a long time. Without reporting it

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

2014-04-13 Thread Amit Kapila
On Sun, Apr 13, 2014 at 5:59 PM, Christian Ullrich wrote: > There are some possible solutions: > > - pg_ctl could set an environment variable (unless it has to be compatible > with postmasters from different versions, and it does not, does it?). Do you mean to say use some existing environment

Re: [HACKERS] [COMMITTERS] pgsql: Add ANALYZE into regression tests

2014-04-13 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Sure, but I think Greg's point is that this could be tested by a > black-box functional test ("does it print something it shouldn't") > rather than a white-box test that necessarily depends on a whole lot > of *other* planner choices that don't have much to

Re: [HACKERS] [COMMITTERS] pgsql: Add ANALYZE into regression tests

2014-04-13 Thread Tom Lane
Stephen Frost writes: > * Greg Stark (st...@mit.edu) wrote: >> But the original goal seems like it would be easier and better done with an >> immutable function which lies and calls elog to leak information. That's >> the actual attack this is supposed to protect against anyways. > Sure, but ther

Re: [HACKERS] integrate pg_upgrade analyze_new_cluster.sh into vacuumdb

2014-04-13 Thread Robert Haas
On Sun, Apr 13, 2014 at 10:49 AM, Tom Lane wrote: > Simon Riggs writes: >> ISTM that this is the way ANALYZE should work when run on a table that >> has never been analysed before. Let's just do this logic within >> ANALYZE and be done. > > Can't. Not unless you intend to make ANALYZE do interna

Re: [HACKERS] Problem with txid_snapshot_in/out() functionality

2014-04-13 Thread Jan Wieck
On 04/13/14 14:22, Jan Wieck wrote: On 04/13/14 08:27, Marko Kreen wrote: I think you need to do SET_VARSIZE also here. Alternative is to move SET_VARSIZE after sort_snapshot(). And it seems the drop-double-txid logic should be added also to txid_snapshot_recv(). It seems weird to have it beh

Race condition between PREPARE TRANSACTION and COMMIT PREPARED (was Re: [HACKERS] Problem with txid_snapshot_in/out() functionality)

2014-04-13 Thread Heikki Linnakangas
On 04/12/2014 05:03 PM, Andres Freund wrote: >If we don't, aren't we letting other backends see non-self-consistent >state in regards to who holds which locks, for example? I think that actually works out ok, because the locks aren't owned by xids/xacts, but procs. Otherwise we'd be in deep trou

Re: [HACKERS] Fwd: Debug strategy for musl Postgres?

2014-04-13 Thread Andres Freund
Hi, On 2014-04-13 16:08:00 -0400, John Mudd wrote: > I built Postgres 9.3.4 from source on top of the musl C library, > http://www.musl-libc.org/ > I also built zlib, bzip2, ncurses, openssl, readline and Python using musl > as a foundation for Postgres. > > I'm using musl to increase the portabi

[HACKERS] Fwd: Debug strategy for musl Postgres?

2014-04-13 Thread John Mudd
Reposting from pgsql-bugs since this is not a bug. I built Postgres 9.3.4 from source on top of the musl C library, http://www.musl-libc.org/ I also built zlib, bzip2, ncurses, openssl, readline and Python using musl as a foundation for Postgres. I'm using musl to increase the portability of the

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2014-04-13 Thread David Rowley
> -Original Message- > From: Tom Lane [mailto:t...@sss.pgh.pa.us] > Sent: 14 April 2014 06:23 > To: Dean Rasheed > Cc: Florian Pflug; David Rowley; Kevin Grittner; Josh Berkus; Greg Stark; > PostgreSQL-development > Subject: Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions > (W

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2014-04-13 Thread Florian Pflug
On Apr13, 2014, at 20:23 , Tom Lane wrote: > Dean Rasheed writes: >> OK, I'm marking this ready for committer attention, on the >> understanding that that doesn't include the invtrans_minmax patch. > > I've finished reviewing/revising/committing this submission. Cool! Thanks! > Some notes: >

Re: [HACKERS] [PATCH] Negative Transition Aggregate Functions (WIP)

2014-04-13 Thread Tom Lane
Dean Rasheed writes: > OK, I'm marking this ready for committer attention, on the > understanding that that doesn't include the invtrans_minmax patch. I've finished reviewing/revising/committing this submission. Some notes: * I left out the EXPLAIN ANALYZE statistics, as I still feel that they'r

Re: [HACKERS] Problem with txid_snapshot_in/out() functionality

2014-04-13 Thread Jan Wieck
On 04/13/14 08:27, Marko Kreen wrote: On Sat, Apr 12, 2014 at 02:10:13PM -0400, Jan Wieck wrote: Since it doesn't seem to produce any side effects, I'd think that making the snapshot unique within txid_current_snapshot() and filtering duplicates on input should be sufficient and eligible for bac

Re: [HACKERS] test failure on latest source

2014-04-13 Thread Tom Lane
Andres Freund writes: > On 2014-04-12 16:35:48 -0400, Tom Lane wrote: >> In principle, that commit shouldn't have affected behavior for pg_hba >> entries with numeric address fields ... > Hm. getaddrinfo.c has this bit: > /* Unsupported flags. */ > if (flags & NI_NAMEREQD) >

Re: [HACKERS] test failure on latest source

2014-04-13 Thread Andres Freund
On 2014-04-12 16:35:48 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2014-04-12 19:45:59 +0200, Marco Atzeri wrote: > >> so it is only failing on recent trunk > > > Does it work on a commit before > > fc752505a99a4e2c781a070d3d42a25289c22e3c? > > In principle, that commit shouldn't have

Re: [HACKERS] Signaling of waiting for a cleanup lock?

2014-04-13 Thread Andres Freund
On 2014-04-12 17:40:34 -0400, Robert Haas wrote: > On Fri, Apr 11, 2014 at 10:28 AM, Andres Freund > wrote: > > VACUUM sometimes waits synchronously for a cleanup lock on a heap > > page. Sometimes for a long time. Without reporting it externally. > > Rather confusing ;). > > > > Since we only ta

Re: [HACKERS] Window function optimisation, allow pushdowns of items matching PARTITION BY clauses

2014-04-13 Thread Tom Lane
David Rowley writes: > On this thread > http://www.postgresql.org/message-id/52c6f712.6040...@student.kit.edu there > was some discussion around allowing push downs of quals that happen to be > in every window clause of the sub query. I've quickly put together a patch > which does this (see attach

Re: [HACKERS] Patch to fix a couple of compiler warnings from 80a5cf64

2014-04-13 Thread Tom Lane
David Rowley writes: > The attached patch fixes a couple of compiler warnings seen by the MSVC > build. Committed, thanks. > I'm not quite sure why I get 2 warnings rather than 8, but the attached > seems to make them go away, for what it's worth. I think it's complaining about the 2 cases wher

Re: [HACKERS] integrate pg_upgrade analyze_new_cluster.sh into vacuumdb

2014-04-13 Thread Tom Lane
Simon Riggs writes: > ISTM that this is the way ANALYZE should work when run on a table that > has never been analysed before. Let's just do this logic within > ANALYZE and be done. Can't. Not unless you intend to make ANALYZE do internal commits so that its output rows become visible to other t

[HACKERS] Re: Window function optimisation, allow pushdowns of items matching PARTITION BY clauses

2014-04-13 Thread Thomas Mayer
Hello David, thanks for your work. The results look promising. What I'm missing is a test case with multiple fields in the partition by clauses: -- should push down, because partid is part of all PARTITION BY clauses explain analyze select partid,n,m from ( select partid, count(*) over (p

Re: [HACKERS] PostgreSQL in Windows console and Ctrl-C

2014-04-13 Thread Christian Ullrich
* From: Amit Kapila > On Sat, Apr 12, 2014 at 12:36 PM, Christian Ullrich > wrote: > > * From: Amit Kapila > > > >> Another thing to decide about this fix is that whether it is okay to > >> fix it for CTRL+C and leave the problem open for CTRL+BREAK? > >> (The current option used (CREATE_NEW_PROC

Re: [HACKERS] Problem with txid_snapshot_in/out() functionality

2014-04-13 Thread Marko Kreen
On Sat, Apr 12, 2014 at 02:10:13PM -0400, Jan Wieck wrote: > Since it doesn't seem to produce any side effects, I'd think that > making the snapshot unique within txid_current_snapshot() and > filtering duplicates on input should be sufficient and eligible for > backpatching. Agreed. > The attach

Re: [HACKERS] integrate pg_upgrade analyze_new_cluster.sh into vacuumdb

2014-04-13 Thread Simon Riggs
On 4 April 2014 16:01, Andres Freund wrote: >> + const char *stage_commands[] = { >> + "SET default_statistics_target=1; SET >> vacuum_cost_delay=0;", >> + "SET default_statistics_target=10; RESET >> vacuum_cost_delay;", >> +

[HACKERS] Window function optimisation, allow pushdowns of items matching PARTITION BY clauses

2014-04-13 Thread David Rowley
On this thread http://www.postgresql.org/message-id/52c6f712.6040...@student.kit.edu there was some discussion around allowing push downs of quals that happen to be in every window clause of the sub query. I've quickly put together a patch which does this (see attached) I'm posting this just mainl

Re: [HACKERS] proposal: interprocess EXPLAIN PID

2014-04-13 Thread Pavel Stehule
Hello 2014-04-13 7:16 GMT+02:00 Amit Kapila : > On Fri, Apr 11, 2014 at 12:13 PM, Pavel Stehule > wrote: > > Hello > > > > I propose a enhancing of EXPLAIN statement about possibility get a plan > of > > other PostgreSQL process. > > Does this mean that you want to track plan (and other info Exp

Re: [HACKERS] WIP patch (v2) for updatable security barrier views

2014-04-13 Thread Dean Rasheed
On 13 April 2014 05:23, Stephen Frost wrote: > Alright, I've committed this with an updated note regarding the locking, > and a few additional regression tests That's awesome. Thank you very much. Regards, Dean -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan