On 27 November 2014 at 19:20, Tom Lane t...@sss.pgh.pa.us wrote:
The attached proposed patch adds bms_next_member() and replaces
bms_first_member() calls where it seemed to make sense. I've had a
hard time measuring much speed difference for this patch in isolation,
but in principle it should
On Thu, Nov 27, 2014 at 3:52 PM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp
wrote:
(2014/11/17 17:55), Ashutosh Bapat wrote:
Here are my review comments for patch fdw-inh-3.patch.
Thanks for the review!
Tests
---
1. It seems like you have copied from testcase inherit.sql to
Hi!
On Fri, Nov 21, 2014 at 8:12 AM, Michael Paquier michael.paqu...@gmail.com
wrote:
Please find attached a simple patch adding fillfactor as storage parameter
for GIN indexes. The default value is the same as the one currently aka 100
to have the pages completely packed when a GIN index is
On Sat, Nov 22, 2014 at 2:20 AM, Peter Geoghegan p...@heroku.com wrote:
On Mon, Jan 13, 2014 at 9:17 AM, Alexander Korotkov
aekorot...@gmail.com wrote:
This patch was split from thread:
http://www.postgresql.org/message-id/CAPpHfdscOX5an71nHd8WSUH6GNOCf=V7wgDaTXdDd9=gon-...@mail.gmail.com
On Fri, Nov 28, 2014 at 8:20 AM, Tom Lane t...@sss.pgh.pa.us wrote:
The attached proposed patch adds bms_next_member() and replaces
bms_first_member() calls where it seemed to make sense. I've had a
hard time measuring much speed difference for this patch in isolation,
but in principle it
On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch n...@leadboat.com wrote:
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
Sure. I'll first issue git revert 9f80f48, then apply the attached
patch.
Since libpq
On Wed, Nov 26, 2014 at 4:05 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 8:17 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 3:40 AM, Andres Freund and...@2ndquadrant.com
wrote:
On 2014-08-14 14:37:22 -0400, Robert Haas wrote:
On Thu,
27 nov 2014 kl. 16:03 skrev Tom Lane t...@sss.pgh.pa.us:
Another issue is that (AFAIK) ICU doesn't support any non-Unicode
encodings, which means that a build supporting *only* ICU collations is a
nonstarter IMO.
The patch I originally wrote replaces strwcoll but for keeps the original
On Fri, Nov 28, 2014 at 07:55:29PM +0900, Fujii Masao wrote:
On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch n...@leadboat.com wrote:
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
Sure. I'll first issue git
Dean Rasheed dean.a.rash...@gmail.com writes:
On 27 November 2014 at 19:20, Tom Lane t...@sss.pgh.pa.us wrote:
The attached proposed patch adds bms_next_member() and replaces
bms_first_member() calls where it seemed to make sense.
There is another micro-optimisation that you could make in
David Rowley dgrowle...@gmail.com writes:
I have to say I don't really like the modifying of the loop iterator that's
going on here:
col = -1;
while ((col = bms_next_member(rte-modifiedCols, col)) = 0)
{
col += FirstLowInvalidHeapAttributeNumber;
/* do stuff */
col -=
On 11/27/14 3:10 PM, Tom Lane wrote:
I'm not too happy with that approach, because packagers are going to
tend to think they should package any files installed by install-world.
The entire point of this change, IMO, is that the test modules should
*not* get installed, certainly not by normal
Julien Tachoires jul...@gmail.com writes:
2011/12/15 Alvaro Herrera alvhe...@commandprompt.com:
Uhm, surely you could compare the original toast tablespace to the heap
tablespace, and if they differ, handle appropriately when creating the
new toast table? =A0Just pass down the toast
In light of the recent discussions about using ICU on OS X, I looked
into the Core Foundation locale functions (Core Foundation = traditional
Mac API in OS X, as opposed to the Unix/POSIX APIs).
Attached is a proof of concept patch that just about works for the
sorting aspects. (The ctype
Christoph Berg c...@df7cb.de writes:
Re: Petr Jelinek 2014-11-25 5474efea.2040...@2ndquadrant.com
Patch committed.
Before I go and rebase that recovery.conf - GUC patch on top of
this... is it final?
Thanks!
I'm a bit late to the party, but wouldn't
recovery_target_action = ...
On 28/11/14 17:46, Alex Shulgin wrote:
Christoph Berg c...@df7cb.de writes:
Re: Petr Jelinek 2014-11-25 5474efea.2040...@2ndquadrant.com
Patch committed.
Before I go and rebase that recovery.conf - GUC patch on top of
this... is it final?
I think so, perhaps sans the name mentioned
On 2014-11-27 15:51:51 -0500, Tom Lane wrote:
Josh Berkus j...@agliodbs.com writes:
So test_decoding is fairly useful for users demonstrating that decoding
works, especially if they're also testing an external decoding module
and are unsure of where their replication problem is located, or
David Rowley dgrowle...@gmail.com writes:
A while back when I was benchmarking the planner time during my trials with
anti/semi join removals, I wrote a patch to change the usage pattern for
cases such as:
if (bms_membership(a) != BMS_SINGLETON)
return; /* nothing to do */
singleton =
On 11/27/2014 12:51 PM, Tom Lane wrote:
So test_decoding is fairly useful for users demonstrating that decoding
works, especially if they're also testing an external decoding module
and are unsure of where their replication problem is located, or what's
wrong with their HBA settings. For
Peter Eisentraut wrote:
On 11/27/14 3:10 PM, Tom Lane wrote:
I'm not too happy with that approach, because packagers are going to
tend to think they should package any files installed by install-world.
The entire point of this change, IMO, is that the test modules should
*not* get
Josh Berkus j...@agliodbs.com writes:
On 11/26/2014 12:48 PM, Tom Lane wrote:
Wouldn't it be better if it said
ERROR: invalid input syntax for array: [potter,chef,programmer]
DETAIL: Dimension value is missing.
which is comparable to what you'd get out of most other input functions
that
hubert depesz lubaczewski wrote:
On Sat, Nov 22, 2014 at 3:29 AM, Alvaro Herrera alvhe...@2ndquadrant.com
wrote:
I won't push this right away because I want to add the cross-type stuff
to the tests, to ensure I haven't bollixed anything; I ran a few quick
manual tests and everything
All,
I have attached a patch that addresses the current suggestions and
recommendations:
* Add 'get_all_role_attributes' SQL function - returns a text array
representation of the attributes from a value passed to it.
Example:
postgres=# SELECT rolname, get_all_role_attributes(rolattr) AS
On Sat, Nov 29, 2014 at 8:18 AM, Tom Lane t...@sss.pgh.pa.us wrote:
David Rowley dgrowle...@gmail.com writes:
A while back when I was benchmarking the planner time during my trials
with
anti/semi join removals, I wrote a patch to change the usage pattern for
cases such as:
if
Hi all,
When pg_event_trigger_dropped_objects is run in a context that is not
the one of an event trigger, currently the error code
ERRCODE_FEATURE_NOT_SUPPORTED is returned. Wouldn't it be better to
have an error to define an out-of-context instead? It seems that it
would be a good thing to have
25 matches
Mail list logo
