Re: [HACKERS] NUMERIC private methods?

2014-12-16 Thread Heikki Linnakangas
On 12/16/2014 08:34 AM, David Fetter wrote: Folks, While noodling with some weighted statistics https://github.com/davidfetter/weighted_stats, I noticed I was having to jump through a lot of hoops because of all the private methods in numeric.c, especially NumericVar. Would there be some major

Re: [HACKERS] Streaming replication and WAL archive interactions

2014-12-16 Thread Borodin Vladimir
12 дек. 2014 г., в 16:46, Heikki Linnakangas hlinnakan...@vmware.com написал(а): There have been a few threads on the behavior of WAL archiving, after a standby server is promoted [1] [2]. In short, it doesn't work as you might expect. The standby will start archiving after it's promoted,

Re: [HACKERS] TABLESAMPLE patch

2014-12-16 Thread Petr Jelinek
On 16/12/14 08:43, Jaime Casanova wrote: On Wed, Dec 10, 2014 at 6:24 PM, Petr Jelinek p...@2ndquadrant.com wrote: Hello, Attached is a basic implementation of TABLESAMPLE clause. It's SQL standard clause and couple of people tried to submit it before so I think I don't need to explain in

Re: [HACKERS] NUMERIC private methods?

2014-12-16 Thread Andrew Gierth
Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: Heikki Looking at the weighed_stats code, this probably illustrates Heikki the hoops you had to jump through: Actually that hoop-jumping expression is almost irrelevant. The part that hurts (and yes, it's performance that's at

Re: [HACKERS] pg_rewind in contrib

2014-12-16 Thread Satoshi Nagayasu
Hi, On 2014/12/12 23:13, Heikki Linnakangas wrote: Hi, I'd like to include pg_rewind in contrib. I originally wrote it as an external project so that I could quickly get it working with the existing versions, and because I didn't feel it was quite ready for production use yet. Now, with

Re: [HACKERS] GiST kNN search queue (Re: KNN-GiST with recheck)

2014-12-16 Thread Heikki Linnakangas
On 12/15/2014 11:59 PM, Jeff Janes wrote: On Mon, Dec 15, 2014 at 5:08 AM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Here's a new version of the patch. It now uses the same pairing heap code that I posted in the other thread (advance local xmin more aggressivley,

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-16 Thread Amit Kapila
On Tue, Dec 16, 2014 at 12:58 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Sun, Dec 14, 2014 at 11:54 AM, Amit Kapila amit.kapil...@gmail.com wrote: On Sat, Dec 13, 2014 at 10:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Sorry, I was not paying very close attention to this thread and

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 15/12/14 19:08, Robert Haas wrote: On Sun, Dec 14, 2014 at 2:24 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: However if it were posted as part of patchset with a subject of [PATCH] gram.y: add EXCLUDED pseudo-alias to bison grammar then this may pique my interest enough to

Re: [HACKERS] pg_rewind in contrib

2014-12-16 Thread Heikki Linnakangas
On 12/16/2014 11:23 AM, Satoshi Nagayasu wrote: Hi, On 2014/12/12 23:13, Heikki Linnakangas wrote: Hi, I'd like to include pg_rewind in contrib. I originally wrote it as an external project so that I could quickly get it working with the existing versions, and because I didn't

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 15/12/14 19:24, Andrew Dunstan wrote: On 12/15/2014 02:08 PM, Robert Haas wrote: On Sun, Dec 14, 2014 at 2:24 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: However if it were posted as part of patchset with a subject of [PATCH] gram.y: add EXCLUDED pseudo-alias to bison

Re: [HACKERS] pg_rewind in contrib

2014-12-16 Thread Satoshi Nagayasu
On 2014/12/16 18:37, Heikki Linnakangas wrote: On 12/16/2014 11:23 AM, Satoshi Nagayasu wrote: pg_rewind assumes that the source PostgreSQL has, at least, one checkpoint after getting promoted. I think the target timeline id in the pg_control file to be read is only available after the first

Re: [HACKERS] Using 128-bit integers for sum, avg and statistics aggregates

2014-12-16 Thread David Rowley
On 14 November 2014 at 13:57, Andreas Karlsson andr...@proxel.se wrote: On 11/13/2014 03:38 AM, Alvaro Herrera wrote: configure is a generated file. If your patch touches it but not configure.in, there is a problem. Thanks for pointing it out, I have now fixed it. Hi Andreas, These

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Craig Ringer
On 12/16/2014 05:53 PM, Mark Cave-Ayland wrote: In practice, people don't tend to post updates to individual patches in that way. Exactly. Much like if you push a new revision of a working branch, you repost all the changesets - or should. -- Craig Ringer

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 15/12/14 19:27, Robert Haas wrote: On Sun, Dec 14, 2014 at 4:53 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: What I find frustrating is that I've come back from a workflow where I've been reviewing/testing patches within months of joining a project because the barrier for

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Simon Riggs
On 15 December 2014 at 19:52, Josh Berkus j...@agliodbs.com wrote: On 12/15/2014 11:27 AM, Robert Haas wrote: I feel like we used to be better at encouraging people to participate in the CF even if they were not experts, and to do the best they can based on what they did know. That was a

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 04:57, Noah Misch wrote: But that doesn't mean we should be turning anyone away. We should not. +1. Some of the best reviews I've seen are ones where the reviewer expressed doubts about the review's quality, so don't let such doubts keep you from participating. Every defect

[HACKERS] Possibly a comment typo in xlogrecord.h

2014-12-16 Thread Rahila Syed
Hello, The comment before declaration of XLogRecordBlockHeader says * 'data_length' is the length of the payload data associated with this, * and includes the possible full-page image, and rmgr-specific data. It IIUC, data_length does not include associated full page image length. Attached

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Marko Tiikkaja
On 12/16/14 11:26 AM, Mark Cave-Ayland wrote: On 15/12/14 19:27, Robert Haas wrote: So, there are certainly some large patches that do that, and they typically require a very senior reviewer. But there are lots of small patches too, touching little enough that you can learn enough to give them

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 07:33, David Rowley wrote: On 16 December 2014 at 18:18, Josh Berkus j...@agliodbs.com mailto:j...@agliodbs.com wrote: Man. You're equating stuff that's not the same. You didn't get your way (and I'm tentatively on your side onthat one) and take that to imply

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 10:49, Marko Tiikkaja wrote: On 12/16/14 11:26 AM, Mark Cave-Ayland wrote: On 15/12/14 19:27, Robert Haas wrote: So, there are certainly some large patches that do that, and they typically require a very senior reviewer. But there are lots of small patches too, touching little

Re: [HACKERS] NUMERIC private methods?

2014-12-16 Thread David Fetter
On Tue, Dec 16, 2014 at 09:01:47AM +, Andrew Gierth wrote: Heikki == Heikki Linnakangas hlinnakan...@vmware.com writes: Heikki Looking at the weighed_stats code, this probably illustrates Heikki the hoops you had to jump through: Actually that hoop-jumping expression is almost

Re: [HACKERS] KNN-GiST with recheck

2014-12-16 Thread Heikki Linnakangas
On 10/06/2014 12:36 PM, Emre Hasegeli wrote: Thanks. The main question now is design of this patch. Currently, it does all the work inside access method. We already have some discussion of pro and cons of this method. I would like to clarify alternatives now. I can see following way: 1.

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Claudio Freire
On Tue, Dec 16, 2014 at 8:09 AM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: For the spare time that I have for review, one of these projects requires me to download attachment(s), apply them to a git tree (hopefully it still applies), run a complete make check regression series, try

Re: [HACKERS] Possibly a comment typo in xlogrecord.h

2014-12-16 Thread Heikki Linnakangas
On 12/16/2014 12:44 PM, Rahila Syed wrote: Hello, The comment before declaration of XLogRecordBlockHeader says * 'data_length' is the length of the payload data associated with this, * and includes the possible full-page image, and rmgr-specific data. It IIUC, data_length does not include

Re: [HACKERS] Commitfest problems

2014-12-16 Thread David Fetter
On Tue, Dec 16, 2014 at 11:09:34AM +, Mark Cave-Ayland wrote: On 16/12/14 07:33, David Rowley wrote: On 16 December 2014 at 18:18, Josh Berkus j...@agliodbs.com mailto:j...@agliodbs.com wrote: Man. You're equating stuff that's not the same. You didn't get your way

Re: [HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-16 Thread Alex Shulgin
Jim Nasby jim.na...@bluetreble.com writes: https://commitfest.postgresql.org/action/patch_view?id=1661 (apologies for not replying to the thread; I can't find it in my inbox) Patch applies and passes make check. Code formatting looks good. Jim, The regression test partially tests this. It

[HACKERS] .gitignore config.cache and comment about regression.(out|diff)

2014-12-16 Thread Jim Nasby
config.cache is created when you pass -C to configure, which speeds it up considerably (3.5s vs 16.5 on my laptop). It would be nice to just ignore the cache file it generates. Originally this patch also ignored the regression output files, until I realized why that was a bad idea. Add a

Re: [HACKERS] moving Orafce from pgFoundry - pgFoundry management

2014-12-16 Thread Marc Fournier
Project disabled on pgfoundry … do you want me to remove the mailing lists and all those archives? Or leave them there … ? On Dec 13, 2014, at 9:18 AM, David Fetter da...@fetter.org wrote: On Sat, Dec 13, 2014 at 11:19:08AM +0100, Pavel Stehule wrote: Hi a Orafce package on pgFoundry

Re: [HACKERS] [PATCH] explain sortorder

2014-12-16 Thread Timmer, Marius
Hi Mike, Now I've replaced the spaces at the beginning of the lines with tabs. Quotes() in the expected/explain_sortorder.out-File caused failing „make check“. So I changed them to single quotes('). I’ve added the corrected patch as attachment. Kind regards, Marius

Re: [HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-16 Thread Alvaro Herrera
Alex Shulgin wrote: Jim Nasby jim.na...@bluetreble.com writes: The test also adds 2.5 seconds of forced pg_sleep. I think that's both bad and unnecessary. When I removed the sleeps I still saw times of less than 0.1 seconds. Well, I never liked that part, but the stats don't get updated

Re: [HACKERS] WALWriter active during recovery

2014-12-16 Thread Heikki Linnakangas
On 12/15/2014 08:51 PM, Simon Riggs wrote: Currently, WALReceiver writes and fsyncs data it receives. Clearly, while we are waiting for an fsync we aren't doing any other useful work. Following patch starts WALWriter during recovery and makes it responsible for fsyncing data, allowing

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Michael Paquier
On Tue, Dec 16, 2014 at 8:35 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Dec 16, 2014 at 3:46 AM, Robert Haas robertmh...@gmail.com wrote: On Sat, Dec 13, 2014 at 9:36 AM, Michael Paquier michael.paqu...@gmail.com wrote: Something to be aware of btw is that this patch

Re: [HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-16 Thread Alex Shulgin
Alvaro Herrera alvhe...@2ndquadrant.com writes: Another idea would be exposing pgstat_report_stat(true) at SQL level. That would eleminate the need for explicit pg_sleep(=0.5), but we'll still need the wait_for_... call to make sure the collector has picked it up. We already have a stats

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Alvaro Herrera
Michael Paquier wrote: And here are attached fresh patches reducing the WAL record size to what it is in head when the compression switch is off. Looking at the logic in xlogrecord.h, the block header stores the hole length and hole offset. I changed that a bit to store the length of raw

Re: [HACKERS] Logical Decoding follows timelines

2014-12-16 Thread Heikki Linnakangas
On 12/15/2014 08:54 PM, Simon Riggs wrote: Currently, it doesn't. This patch is a WIP version of doing that, but only currently attempts to do this in the WALSender. Objective is to allow cascaded logical replication. Very WIP, but here for comments. With the patch, XLogSendLogical uses the

Re: [HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-16 Thread Alvaro Herrera
Alex Shulgin wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Another idea would be exposing pgstat_report_stat(true) at SQL level. That would eleminate the need for explicit pg_sleep(=0.5), but we'll still need the wait_for_... call to make sure the collector has picked it up.

Re: [HACKERS] WALWriter active during recovery

2014-12-16 Thread Andres Freund
On 2014-12-16 16:12:40 +0200, Heikki Linnakangas wrote: On 12/15/2014 08:51 PM, Simon Riggs wrote: Currently, WALReceiver writes and fsyncs data it receives. Clearly, while we are waiting for an fsync we aren't doing any other useful work. Following patch starts WALWriter during recovery

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Michael Paquier
On Tue, Dec 16, 2014 at 11:24 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: And here are attached fresh patches reducing the WAL record size to what it is in head when the compression switch is off. Looking at the logic in xlogrecord.h, the block header stores

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Alvaro Herrera
Hi Andrew, Did you have a chance to review this? Alvaro Herrera wrote: Andrew Dunstan wrote: On 11/29/2014 10:09 PM, Alvaro Herrera wrote: Anyway I just pushed this src/test/modules/ patch, which has implications for buildfarm: these new test modules are not invoked except

Re: [HACKERS] Comment typo in typedef struct BrinTuple

2014-12-16 Thread Heikki Linnakangas
On 12/15/2014 09:04 AM, Amit Langote wrote: Hi, Find attached that does: -* mt_info is laid out in the following fashion: +* bt_info is laid out in the following fashion: snip-comment uint8 bt_info; } BrinTuple; Thanks. Fixed along with a bunch of other misc

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 13:37, Claudio Freire wrote: For the second project, I can skim through my inbox daily picking up specific areas I work on/are interested in, hit reply to add a couple of lines of inline comments to the patch and send feedback to the author/list in just a few minutes. Notice

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Michael Paquier
On Tue, Dec 16, 2014 at 11:30 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Dec 16, 2014 at 11:24 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Michael Paquier wrote: And here are attached fresh patches reducing the WAL record size to what it is in head when the

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 13:44, David Fetter wrote: On Tue, Dec 16, 2014 at 11:09:34AM +, Mark Cave-Ayland wrote: On 16/12/14 07:33, David Rowley wrote: On 16 December 2014 at 18:18, Josh Berkus j...@agliodbs.com mailto:j...@agliodbs.com wrote: Man. You're equating stuff that's not the same.

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Merlin Moncure
On Mon, Dec 15, 2014 at 5:37 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Tue, Dec 16, 2014 at 5:14 AM, Merlin Moncure mmonc...@gmail.com wrote: OTOH, Our built in compressor as we all know is a complete dog in terms of cpu when stacked up against some more modern implementations.

Re: [HACKERS] On partitioning

2014-12-16 Thread Robert Haas
On Mon, Dec 15, 2014 at 6:55 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: Robert wrote: On Sun, Dec 14, 2014 at 9:12 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: This means if a user puts arbitrary expressions in a partition definition, say, ... FOR VALUES

Re: [HACKERS] NUMERIC private methods?

2014-12-16 Thread Tom Lane
Heikki Linnakangas hlinnakan...@vmware.com writes: On 12/16/2014 08:34 AM, David Fetter wrote: While noodling with some weighted statistics https://github.com/davidfetter/weighted_stats, I noticed I was having to jump through a lot of hoops because of all the private methods in numeric.c,

Re: [HACKERS] On partitioning

2014-12-16 Thread Claudio Freire
On Tue, Dec 16, 2014 at 12:15 PM, Robert Haas robertmh...@gmail.com wrote: langote_amit...@lab.ntt.co.jp wrote: Robert wrote: On Sun, Dec 14, 2014 at 9:12 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: This means if a user puts arbitrary expressions in a partition definition, say,

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Claudio Freire
On Tue, Dec 16, 2014 at 11:47 AM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: On 16/12/14 13:37, Claudio Freire wrote: For the second project, I can skim through my inbox daily picking up specific areas I work on/are interested in, hit reply to add a couple of lines of inline

Re: [HACKERS] Postgres TR for missing chunk

2014-12-16 Thread Robert Haas
On Tue, Dec 16, 2014 at 1:02 AM, M Tarkeshwar Rao m.tarkeshwar@ericsson.com wrote: Can you please tell me the how can I track the which bugs are fixed in which release and when they will be fixed, We don't have a bug tracker, but you can look at the mailing list threads and the source code

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mark Cave-Ayland
On 16/12/14 15:42, Claudio Freire wrote: Also with a submission from git, you can near 100% guarantee that the author has actually built and run the code before submission. I don't see how. Forks don't have travis ci unless you add it, or am I mistaken? Well as I mentioned in my last

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 09:31 AM, Alvaro Herrera wrote: Hi Andrew, Did you have a chance to review this? Oh, darn, not yet. I will try to take a look today. cheers andrew -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] speedup tidbitmap patch: cache page

2014-12-16 Thread Teodor Sigaev
I've been having a look at this and I'm wondering about a certain scenario: In tbm_add_tuples, if tbm_page_is_lossy() returns true for a given block, and on the next iteration of the loop we have the same block again, have you benchmarked any caching code to store if tbm_page_is_lossy() returned

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 04:34 AM, Amit Kapila wrote: On Tue, Dec 16, 2014 at 12:58 PM, Amit Kapila amit.kapil...@gmail.com mailto:amit.kapil...@gmail.com wrote: On Sun, Dec 14, 2014 at 11:54 AM, Amit Kapila amit.kapil...@gmail.com mailto:amit.kapil...@gmail.com wrote: On Sat, Dec 13, 2014 at 10:48

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Robert Haas
On Tue, Dec 16, 2014 at 2:33 AM, David Rowley dgrowle...@gmail.com wrote: I'd just like to add something which might be flying below the radar of more senior people. There are people out there (ike me) working on PostgreSQL more for the challenge and perhaps the love of the product, who make

Re: [HACKERS] pg_basebackup vs. Windows and tablespaces

2014-12-16 Thread Heikki Linnakangas
On 12/16/2014 06:30 PM, Andrew Dunstan wrote: I'm not clear why human readability is the major criterion here. As for that, it will be quite difficult for a human to distinguish a name with a space at the end from one without. I really think a simple encoding scheme would be much the best. For

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Robert Haas
On Tue, Dec 16, 2014 at 12:18 AM, Josh Berkus j...@agliodbs.com wrote: On 12/15/2014 07:34 PM, Andres Freund wrote: On 2014-12-15 16:14:30 -0800, Josh Berkus wrote: Read the thread on this list where I suggested crediting reviewers in the release notes. Man. You're equating stuff that's not

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Andy Colson
On 12/16/2014 4:32 AM, Simon Riggs wrote: On 15 December 2014 at 19:52, Josh Berkus j...@agliodbs.com wrote: On 12/15/2014 11:27 AM, Robert Haas wrote: I feel like we used to be better at encouraging people to participate in the CF even if they were not experts, and to do the best they can

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Mike Blackwell
On Tue, Dec 16, 2014 at 10:15 AM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote: Well as I mentioned in my last email, practically all developers will rebase and run make check on their patched tree before submitting to the list. ​Even when this is true, and with people new to the

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-16 Thread Robert Haas
On Tue, Dec 16, 2014 at 12:21 AM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Hello, I have a favor for you committers. I confirmed that this issue the another have been fixed in the repository, thank you. Then, could you please give me when the next release of 9.2.10 is to

Re: [HACKERS] Postgres TR for missing chunk

2014-12-16 Thread Tom Lane
Jaime Casanova ja...@2ndquadrant.com writes: You know, that toast table name ringed a bell. Look at this thread maybe this is your problem, and if it is then is already fixed and you should update. http://www.postgresql.org/message-id/12138.1336019...@sss.pgh.pa.us That was about transient

Re: [HACKERS] [Bug] Inconsistent result for inheritance and FOR UPDATE.

2014-12-16 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Tue, Dec 16, 2014 at 12:21 AM, Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote: Then, could you please give me when the next release of 9.2.10 is to come? We seem not to have had a new release of 9.2 since July, which is an awfully long

Re: [HACKERS] speedup tidbitmap patch: hash BlockNumber

2014-12-16 Thread Teodor Sigaev
I think this suggestion is misguided, and the patch itself needs rethinking. Instead of doing this, let's hack dynahash.c itself to substitute a shim like this when it's told function == tag_hash and keysize == sizeof(uint32). Then we can remove any similar shims that already exist, and

Re: [HACKERS] WALWriter active during recovery

2014-12-16 Thread Simon Riggs
On 16 December 2014 at 14:12, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/15/2014 08:51 PM, Simon Riggs wrote: Currently, WALReceiver writes and fsyncs data it receives. Clearly, while we are waiting for an fsync we aren't doing any other useful work. Following patch starts

Re: [HACKERS] 9.5 release scheduling (was Re: logical column ordering)

2014-12-16 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: 2. It's not clear that we're going to have a particularly-impressive list of major features for 9.5. So far we've got RLS and BRIN. I expect that GROUPING SETS is far enough along that it should be possible to get it in before development ends, and

Re: [HACKERS] compress method for spgist - 2

2014-12-16 Thread Teodor Sigaev
For some datatypes, the compress method might be useful even if the leaf type is the same as the column type. For example, you could allow indexing text datums larger than the page size, with a compress function that just truncates the input. Agree, and patch allows to use compress method in

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Josh Berkus
On 12/16/2014 08:48 AM, Mike Blackwell wrote: On Tue, Dec 16, 2014 at 10:15 AM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk mailto:mark.cave-ayl...@ilande.co.ukwrote: Well as I mentioned in my last email, practically all developers will rebase and run make check on their patched

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Stephen Frost
* Craig Ringer (cr...@2ndquadrant.com) wrote: It's not like development on a patch series is difficult. You commit small fixes and changes, then you 'git rebase -i' and reorder them to apply to the appropriate changesets. Or you can do a 'rebase -i' and in 'e'dit mode make amendments to

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-12-16 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: Do you have real numbers about the performance impact that this module has when plugged in the server? If yes, it would be good to get an idea of how much audit costs and if it has a clear performance impact this should be documented to warn

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Stephen Frost
David, * David Rowley (dgrowle...@gmail.com) wrote: I'd just like to add something which might be flying below the radar of more senior people. There are people out there (ike me) working on PostgreSQL more for the challenge and perhaps the love of the product, who make absolutely zero

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Atri Sharma
On Wed, Dec 17, 2014 at 12:03 AM, Stephen Frost sfr...@snowman.net wrote: David, * David Rowley (dgrowle...@gmail.com) wrote: I'd just like to add something which might be flying below the radar of more senior people. There are people out there (ike me) working on PostgreSQL more for

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: Including all of the other names of people who made important contributions, many of which consisted of reviewing, would make that release note item - and many others - really, really long, so I'm not in favor of that. Crediting reviewers is

Re: [HACKERS] On partitioning

2014-12-16 Thread Josh Berkus
On 12/15/2014 10:55 AM, Robert Haas wrote: This means if a user puts arbitrary expressions in a partition definition, say, ... FOR VALUES extract(month from current_date) TO extract(month from current_date + interval '3 months'), we make sure that those expressions are pre-computed

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-16 Thread Jeff Janes
On Mon, Dec 15, 2014 at 5:05 PM, Peter Geoghegan p...@heroku.com wrote: Maybe IGNORE is defined as a macro in MinGW? Try s/IGNORE/IGNORE_P/g throughout the patch. BTW, the gcc -E flag does this. So figure out what exact arguments MinGW's gcc is passed in the ordinary course of compiling

Re: [HACKERS] Streaming replication and WAL archive interactions

2014-12-16 Thread Heikki Linnakangas
On 12/16/2014 10:24 AM, Borodin Vladimir wrote: 12 дек. 2014 г., в 16:46, Heikki Linnakangas hlinnakan...@vmware.com написал(а): There have been a few threads on the behavior of WAL archiving, after a standby server is promoted [1] [2]. In short, it doesn't work as you might expect. The

Re: [HACKERS] REVIEW: Track TRUNCATE via pgstat

2014-12-16 Thread Alex Shulgin
Alvaro Herrera alvhe...@2ndquadrant.com writes: Alex Shulgin wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Another idea would be exposing pgstat_report_stat(true) at SQL level. That would eleminate the need for explicit pg_sleep(=0.5), but we'll still need the wait_for_...

Re: [HACKERS] Doing better at HINTing an appropriate column within errorMissingColumn()

2014-12-16 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: So my two cents is that when considering a qualified name, this patch should take levenshtein distance across the two components equally. There's no good reason to suppose that typos will attack one name component more (nor less) than the other. Agreed

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 01:38 PM, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: Including all of the other names of people who made important contributions, many of which consisted of reviewing, would make that release note item - and many others - really, really long, so I'm not in

Re: [HACKERS] advance local xmin more aggressively

2014-12-16 Thread Jeff Janes
On Wed, Dec 10, 2014 at 3:46 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Dec 10, 2014 at 3:28 PM, Heikki Linnakangas hlinnakan...@vmware.com wrote: Care to code it up? Here you are. That was quick. You need to add a semicolon to the end of line 20 in pairingheap.c. In

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 11:22 AM, Andrew Dunstan wrote: On 12/16/2014 09:31 AM, Alvaro Herrera wrote: Hi Andrew, Did you have a chance to review this? Oh, darn, not yet. I will try to take a look today. I have pushed this change, and crake will be running the code. See

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-12-16 Thread Simon Riggs
On 16 December 2014 at 18:28, Stephen Frost sfr...@snowman.net wrote: For the sake of the archives, the idea I had been trying to propose is to use a role's permissions as a mechanism to define what should be audited. An example is: My understanding is that was done. -- Simon Riggs

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Alvaro Herrera
Andrew Dunstan wrote: I have pushed this change, and crake will be running the code. See https://github.com/PGBuildFarm/client-code/commit/d656c1c3ce46f290791c5ba5ede2f8ac8dfa342e Crake just uploaded its first test results with the testmodules stuff working:

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 04:02 PM, Alvaro Herrera wrote: Andrew Dunstan wrote: I have pushed this change, and crake will be running the code. See https://github.com/PGBuildFarm/client-code/commit/d656c1c3ce46f290791c5ba5ede2f8ac8dfa342e Crake just uploaded its first test results with the testmodules

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-16 Thread Peter Geoghegan
On Tue, Dec 16, 2014 at 11:08 AM, Jeff Janes jeff.ja...@gmail.com wrote: Your new version 1.7 of the patches fixes that issue, as well as the OID conflict. Good. You're probably aware that I maintain a stress testing suite for the patch here: https://github.com/petergeoghegan/upsert In the

[HACKERS] POLA violation with \c service=

2014-12-16 Thread David Fetter
Folks, I've noticed that psql's \c function handles service= requests in a way that I can only characterize as broken. This came up in the context of connecting to a cloud hosting service named after warriors or a river or something, whose default hostnames are long, confusing, and easy to

Re: [HACKERS] Logical Decoding follows timelines

2014-12-16 Thread Simon Riggs
On 16 December 2014 at 14:25, Heikki Linnakangas hlinnakan...@vmware.com wrote: On 12/15/2014 08:54 PM, Simon Riggs wrote: Currently, it doesn't. This patch is a WIP version of doing that, but only currently attempts to do this in the WALSender. Objective is to allow cascaded logical

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Tom Lane
Andrew Dunstan and...@dunslane.net writes: I have pushed this change, and crake will be running the code. See https://github.com/PGBuildFarm/client-code/commit/d656c1c3ce46f290791c5ba5ede2f8ac8dfa342e Any brave buildfarm owners on *nix can try it by replacing their copy of run_build.pl

Re: [HACKERS] pgaudit - an auditing extension for PostgreSQL

2014-12-16 Thread Stephen Frost
* Simon Riggs (si...@2ndquadrant.com) wrote: On 16 December 2014 at 18:28, Stephen Frost sfr...@snowman.net wrote: For the sake of the archives, the idea I had been trying to propose is to use a role's permissions as a mechanism to define what should be audited. An example is: My

Re: [HACKERS] INSERT ... ON CONFLICT {UPDATE | IGNORE}

2014-12-16 Thread Gavin Flower
On 17/12/14 10:11, Peter Geoghegan wrote: On Tue, Dec 16, 2014 at 11:08 AM, Jeff Janes jeff.ja...@gmail.com wrote: Your new version 1.7 of the patches fixes that issue, as well as the OID conflict. Good. You're probably aware that I maintain a stress testing suite for the patch here:

Re: [alvhe...@2ndquadrant.com: Re: [HACKERS] no test programs in contrib]

2014-12-16 Thread Andrew Dunstan
On 12/16/2014 04:44 PM, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: I have pushed this change, and crake will be running the code. See https://github.com/PGBuildFarm/client-code/commit/d656c1c3ce46f290791c5ba5ede2f8ac8dfa342e Any brave buildfarm owners on *nix can try it by

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Stephen Frost
* Andrew Dunstan (and...@dunslane.net) wrote: On 12/16/2014 01:38 PM, Stephen Frost wrote: * Robert Haas (robertmh...@gmail.com) wrote: It has been proposed that we do a general list of people at the bottom of the release notes who helped review during that cycle. That would be less

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Joshua D. Drake
This whole conversation reminds me of an interview I just read: https://opensource.com/business/14/12/interview-jono-bacon-xprize-director-community -- Command Prompt, Inc. - http://www.commandprompt.com/ 503-667-4564 PostgreSQL Support, Training, Professional Services and Development High

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Tom Lane
Stephen Frost sfr...@snowman.net writes: So, when I was first getting started with PG however many years ago, I was ecstatic to see my name show up in a commit message. Hugely increasing our release notes to include a bunch of names all shoved together without any indication of what was done

[HACKERS] PrivateRefCount patch has got issues

2014-12-16 Thread Tom Lane
I just happened to look into bufmgr.c for the first time in awhile, and noticed the privaterefcount-is-no-longer-a-simple-array stuff. It doesn't look too well thought out to me. In particular, PinBuffer_Locked calls GetPrivateRefCountEntry while holding a buffer-header spinlock. That seems

Re: [HACKERS] Commitfest problems

2014-12-16 Thread Jaime Casanova
On Tue, Dec 16, 2014 at 11:32 AM, Robert Haas robertmh...@gmail.com wrote: It has been proposed that we do a general list of people at the bottom of the release notes who helped review during that cycle. That would be less intrusive and possibly a good idea, but would we credit the people

Re: [HACKERS] [REVIEW] Re: Compression of full-page-writes

2014-12-16 Thread Michael Paquier
On Wed, Dec 17, 2014 at 12:12 AM, Merlin Moncure mmonc...@gmail.com wrote: Compressing *one* file with lz4 and a quick/n/dirty plgz i hacked out of the source (borrowing heavily from https://github.com/maropu/pglz_bench/blob/master/pglz_bench.cpp), I tested the results: lz4 real time:

Re: [HACKERS] POLA violation with \c service=

2014-12-16 Thread David G Johnston
I do indeed see this behavior in some very quick testing using 9.3 David Fetter wrote I've noticed that psql's \c function handles service= requests in a way that I can only characterize as broken. Looking at the docs the fact it attempts to treat service=foo as anything other than a

Re: [HACKERS] On partitioning

2014-12-16 Thread Amit Langote
On 17-12-2014 AM 12:15, Robert Haas wrote: On Mon, Dec 15, 2014 at 6:55 PM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: Robert wrote: I would expect that to fail, just as it would fail if you tried to build an index using a volatile expression. Oops, wrong example, sorry. In case of

Re: [HACKERS] On partitioning

2014-12-16 Thread Amit Langote
On 17-12-2014 AM 12:28, Claudio Freire wrote: On Tue, Dec 16, 2014 at 12:15 PM, Robert Haas robertmh...@gmail.com wrote: I'm not really sure what you are getting here. An otherwise-good expression basically means a constant. Index expressions have to be things that always produce the same

Re: [HACKERS] On partitioning

2014-12-16 Thread Robert Haas
On Tue, Dec 16, 2014 at 1:45 PM, Josh Berkus j...@agliodbs.com wrote: Yes, I wasn't saying that expressions should be used when *creating* the partitions, which strikes me as a bad idea for several reasons. Expressions should be usable when SELECTing data from the partitions. Right now, they

Re: [HACKERS] On partitioning

2014-12-16 Thread Josh Berkus
On 12/16/2014 05:52 PM, Robert Haas wrote: But in a more complicated case where the value there isn't known until runtime, yeah, it scans everything. I'm not sure what the best way to fix that is. If the partition bounds were stored in a structured way, as we've been discussing, then the

  1   2   >