Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Tom Lane
David Fetter da...@fetter.org writes: One issue with this patch is that it is not localized. If someone goes and changes the S_LOCK implementation for one of the platforms below, or adds a new platform, etc., without changing this comment too, this comment becomes confusingly obsolete.

Re: [HACKERS] Upper-case error in docs regarding PQmakeEmptyPGresult

2015-04-05 Thread Fujii Masao
On Mon, Apr 6, 2015 at 11:40 AM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, I just spotted that PQmakeEmptyPGresult is named PQmakeEmptyPGResult in one place (not Result, but result) in the docs. A patch is attached. Pushed. Thanks! Regards, -- Fujii Masao -- Sent via

Re: [HACKERS] pg_rewind and log messages

2015-04-05 Thread Michael Paquier
On Mon, Apr 6, 2015 at 12:57 PM, Fujii Masao masao.fu...@gmail.com wrote: (1) It outputs an error message to stdout not stderr. (2) The tool name should be added at the head of log message as follows, but not in pg_rewind. pg_basebackup: no target directory specified Agreed. That's

[HACKERS] Upper-case error in docs regarding PQmakeEmptyPGresult

2015-04-05 Thread Michael Paquier
Hi all, I just spotted that PQmakeEmptyPGresult is named PQmakeEmptyPGResult in one place (not Result, but result) in the docs. A patch is attached. Regards, -- Michael diff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgml index c08e6b6..b5533cd 100644 --- a/doc/src/sgml/libpq.sgml +++

[HACKERS] Re: [HACKERS] GSoC 2015 proposal: Improve the performance of “ALTER TABLE .. SET LOGGED / UNLOGGED” statement

2015-04-05 Thread Fabrízio de Royes Mello
On Thu, Apr 2, 2015 at 3:24 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Mar 25, 2015 at 9:46 PM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: http://www.postgresql.org/message-id/ca+tgmozm+-0r7h0edpzzjbokvvq+gavkchmno4fypveccw-...@mail.gmail.com I like the idea of the

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-05 Thread Alvaro Herrera
Fabrízio de Royes Mello wrote: Ok guys. The attached patch refactor the reloptions adding a new field lockmode in relopt_gen struct and a new method to determine the required lock level from an option list. We need determine the appropriate lock level for each reloption: I don't think

[HACKERS] pg_rewind and log messages

2015-04-05 Thread Fujii Masao
Hi, I found that pg_rewind has several problems about its log messages. (1) It outputs an error message to stdout not stderr. (2) The tool name should be added at the head of log message as follows, but not in pg_rewind. pg_basebackup: no target directory specified (3) if

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2015-04-05 Thread Andreas Karlsson
On 04/05/2015 05:56 PM, Simon Riggs wrote: Committed. We move forwards, slowly but surely. Thanks for the patch. Thanks to you and the reviewers for helping me out with this patch! -- Andreas Karlsson -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2015-04-05 Thread Simon Riggs
On 5 April 2015 at 19:19, Michael Paquier michael.paqu...@gmail.com wrote: Cool! Thanks for showing up. Visibility Activity. How is REINDEX CONCURRENTLY doing? -- Simon Riggs http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, RemoteDBA, Training Services

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Artem Luzyanin
Hello, Thank you very much for your feedback! I will work on the changes as soon as I can.  Respectfully, Artem Luzyanin On Sunday, April 5, 2015 5:45 PM, Tom Lane t...@sss.pgh.pa.us wrote: David Fetter da...@fetter.org writes: One issue with this patch is that it is not localized. 

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2015-04-05 Thread Michael Paquier
On Mon, Apr 6, 2015 at 12:56 AM, Simon Riggs si...@2ndquadrant.com wrote: On 7 February 2015 at 20:05, Andreas Karlsson andr...@proxel.se wrote: On 01/30/2015 07:48 AM, Michael Paquier wrote: Looking at the latest patch, it seems that in AlterTableGetLockLevel@tablecmds.c we ought to put

Re: [HACKERS] Doubt about AccessExclusiveLock in ALTER TABLE .. SET ( .. );

2015-04-05 Thread Fabrízio de Royes Mello
On Wed, Apr 1, 2015 at 1:45 AM, Noah Misch n...@leadboat.com wrote: On Tue, Mar 31, 2015 at 01:17:03PM -0400, Robert Haas wrote: On Tue, Mar 31, 2015 at 9:11 AM, Fabrízio de Royes Mello fabriziome...@gmail.com wrote: Attached a very WIP patch to reduce lock level when setting autovacuum

[HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread Artem Luzyanin
Hello,   I am new to PostgreSQLcommunity, but I would like to become a contributer eventually. I have readthrough your Submitting Patch guide and decided to follow Start with submitting a patch that is small anduncontroversial to help them understand you, and to get you familiar with

Re: [HACKERS] PATCH: Reducing lock strength of trigger and foreign key DDL

2015-04-05 Thread Simon Riggs
On 7 February 2015 at 20:05, Andreas Karlsson andr...@proxel.se wrote: On 01/30/2015 07:48 AM, Michael Paquier wrote: Looking at the latest patch, it seems that in AlterTableGetLockLevel@tablecmds.c we ought to put AT_ReAddConstraint, AT_AddConstraintRecurse and AT_ProcessedConstraint under

[HACKERS] Column mis-spelling hints vs case folding

2015-04-05 Thread Tom Lane
A newbie error that we see *constantly* is misunderstanding identifier case-folding rules. ISTM that commit e529cd4ff missed a chance to help with that. You do get a hint for this: regression=# create table t1 (foo int, Bar int); CREATE TABLE regression=# select bar from t1; ERROR: column bar

[HACKERS] Bringing text abbreviation debug output under the control of trace_sort

2015-04-05 Thread Peter Geoghegan
Attached patch makes trace_sort control abbreviation debug output for the text opclass, which makes it consistent with the numeric opclass. This seems better than relying on someone going to the trouble of building Postgres themselves to debug cases where abbreviation is the wrong thing, which

Re: [HACKERS] PATCH: Spinlock Documentation

2015-04-05 Thread David Fetter
On Sun, Apr 05, 2015 at 06:50:59PM +, Artem Luzyanin wrote: Hello,  I am new to PostgreSQLcommunity, but I would like to become a contributer eventually. I have readthrough your Submitting Patch guide and decided to follow Start with submitting a patch that is small anduncontroversial