Re: [HACKERS] deparsing utility commands

2015-04-18 Thread Amit Kapila
On Thu, Apr 9, 2015 at 9:44 PM, Alvaro Herrera wrote: > > Alvaro Herrera wrote: > > Executive summary: > > > > There is now a CommandDeparse_hook; > > deparse_utility_command is provided as an extension, intended for 9.6; > > rest of patch would be pushed to 9.5. > > Actually here's another approa

Re: [HACKERS] Supporting src/test/modules in MSVC builds

2015-04-18 Thread Michael Paquier
On Fri, Apr 17, 2015 at 11:41 AM, Alvaro Herrera wrote: > Andrew Dunstan wrote: >> >> On 04/16/2015 07:42 PM, Michael Paquier wrote: >> > >> >>>Then if all goes well we can apply the third patch and I'll fix the >> >>>buildfarm client for the forthcoming release to run the tests on MSVC >> >>>buil

Re: [HACKERS] TABLESAMPLE patch

2015-04-18 Thread Michael Paquier
On Sat, Apr 18, 2015 at 8:38 PM, Michael Paquier wrote: > On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote: >> On 10/04/15 06:46, Michael Paquier wrote: >>> 13) Some regression tests with pg_tablesample_method would be welcome. >> >> Not sure what you mean by that. > > I meant a sanity check o

Re: [HACKERS] mogrify and indent features for jsonb

2015-04-18 Thread Dmitry Dolgov
Sorry for late reply. Here is a slightly improved version of the patch with the new `h_atoi` function, I hope this implementation will be more appropriate. On 13 March 2015 at 23:30, Petr Jelinek wrote: > On 01/03/15 16:49, Andrew Dunstan wrote: > >> >> On 03/01/2015 05:03 AM, Petr Jelinek wrote

Re: [HACKERS] Buildfarm client version 4.15 released

2015-04-18 Thread Andrew Dunstan
Unfortunately, this release contained a bug that only affects MSVC builds, which would silently fail on HEAD. There is a bug fix release available at or you can just pick up the fixed version of run_build.pl (the only thin

Re: [HACKERS] TABLESAMPLE patch

2015-04-18 Thread Michael Paquier
On Fri, Apr 17, 2015 at 10:54 PM, Petr Jelinek wrote: > On 10/04/15 06:46, Michael Paquier wrote: >> 13) Some regression tests with pg_tablesample_method would be welcome. > > Not sure what you mean by that. I meant a sanity check on pg_tablesample_method to be sure that tsminit, tsmnextblock and