Re: [HACKERS] Missing psql tab-completion for ALTER FOREIGN TABLE

2015-04-30 Thread Etsuro Fujita
On 2015/04/30 1:59, Robert Haas wrote: On Mon, Apr 27, 2015 at 2:50 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Here is a patch to add missing tab-completion for ALTER FOREIGN TABLE. I'll add this to the next CF. Committed, thanks. Thanks! Best regards, Etsuro Fujita -- Sent via

Re: [HACKERS] [RFC] sepgsql: prohibit users to relabel objects

2015-04-30 Thread Denis Kirjanov
Oh, I wasn't aware of that. Any hints where to look at? Thanks! PS: sorry for top posting. - Original Message - From: Robert Haas robertmh...@gmail.com To: Denis Kirjanov k...@linux-powerpc.org Cc: pgsql-hackers@postgresql.org, Alexey Zhuchkov ale...@itsirius.su, Denis Kirjanov

Re: [HACKERS] How about to have relnamespace and relrole?

2015-04-30 Thread Kyotaro HORIGUCHI
Hello, I fonund that pg_proc.h got modified so rebased and rearranged the patchset merging the recent fixes. regards, I sent the previous mail unfinished. At Thu, 09 Apr 2015 17:25:10 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI horiguchi.kyot...@lab.ntt.co.jp wrote in

Re: [HACKERS] Minor improvement to config.sgml

2015-04-30 Thread Etsuro Fujita
On 2015/04/30 7:06, Robert Haas wrote: On Thu, Apr 16, 2015 at 3:30 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Attached is a small patch to mark up on with literal in doc/src/sgml/config.sgml. Committed. Thanks for picking this up! Best regards, Etsuro Fujita -- Sent via

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-30 Thread Pavel Stehule
2015-04-30 10:24 GMT+02:00 Marko Tiikkaja ma...@joh.to: Hi Pavel, This doesn't seem to be what I thought we had agreed on. For example: =# create function barf() returns void as $$ begin raise notice without context 'hello world'; end $$ language plpgsql; CREATE FUNCTION =# create

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-30 Thread Pavel Stehule
2015-04-28 19:44 GMT+02:00 Jim Nasby jim.na...@bluetreble.com: On 4/28/15 1:16 AM, Pavel Stehule wrote: I think it can't be any clearer than the proposed plpgsql.display_context_min_messages client_min_context. It's doing the same thing as min_messages does, just

Re: [HACKERS] ATSimpleRecursion() and inheritance foreign parents

2015-04-30 Thread Etsuro Fujita
On 2015/04/29 4:35, Tom Lane wrote: Etsuro Fujita fujita.ets...@lab.ntt.co.jp writes: On 2015/04/28 15:17, Amit Langote wrote: The code at the beginning of ATSimpleRecursion() looks like - if (recurse rel-rd_rel-relkind == RELKIND_RELATION) Not sure if it's great idea, but now that foreign

Re: [HACKERS] Missing importing option of postgres_fdw

2015-04-30 Thread Etsuro Fujita
On 2015/04/30 2:10, Robert Haas wrote: On Mon, Apr 27, 2015 at 7:47 AM, Michael Paquier michael.paqu...@gmail.com wrote: Authorizing ALTER FOREIGN TABLE as query string that a FDW can use with IMPORT FOREIGN SCHEMA is a different feature than what is proposed in this patch, aka an option for

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-30 Thread Marko Tiikkaja
Hi Pavel, This doesn't seem to be what I thought we had agreed on. For example: =# create function barf() returns void as $$ begin raise notice without context 'hello world'; end $$ language plpgsql; CREATE FUNCTION =# create function foof() returns void as $$ begin perform barf(); end $$

Re: [HACKERS] Minor typo in doc: replication-origins.sgml

2015-04-30 Thread Magnus Hagander
On Thu, Apr 30, 2015 at 7:23 AM, Amit Langote langote_amit...@lab.ntt.co.jp wrote: Hi, Attached does: s/pg_replication_origin_xact-setup/pg_replication_origin_xact_setup/g or, (s/-/_/g) Applied, thanks. -- Magnus Hagander Me: http://www.hagander.net/ Work:

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-04-30 Thread Fujii Masao
On Thu, Apr 30, 2015 at 12:57 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Wed, Apr 29, 2015 at 12:17 AM, David Steele da...@pgmasters.net wrote: On 4/28/15 2:14 AM, Sawada Masahiko wrote: On Fri, Apr 24, 2015 at 3:23 AM, David Steele da...@pgmasters.net wrote: I've also added some

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-30 Thread Sawada Masahiko
On Fri, Apr 24, 2015 at 11:21 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Apr 24, 2015 at 1:31 AM, Jim Nasby jim.na...@bluetreble.com wrote: On 4/23/15 11:06 AM, Petr Jelinek wrote: On 23/04/15 17:45, Bruce Momjian wrote: On Thu, Apr 23, 2015 at 09:45:38AM -0400, Robert Haas

Re: [HACKERS] PL/pgSQL, RAISE and error context

2015-04-30 Thread Pavel Stehule
2015-04-30 10:50 GMT+02:00 Pavel Stehule pavel.steh...@gmail.com: 2015-04-30 10:24 GMT+02:00 Marko Tiikkaja ma...@joh.to: Hi Pavel, This doesn't seem to be what I thought we had agreed on. For example: =# create function barf() returns void as $$ begin raise notice without context

[HACKERS] bugfix: incomplete implementation of errhidecontext

2015-04-30 Thread Pavel Stehule
Hi current implementation of errhidecontext is not complete: 1. it sends context to client 2. it collect context although it will not be displayed Attached patch fixing it commit 7ee40ad6e5233f0ca2a5c10d1afcfb5d035164e6 Author: root root@localhost.localdomain Date: Thu Apr 30 11:59:45 2015

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Sawada Masahiko
On Fri, Apr 10, 2015 at 2:52 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Apr 9, 2015 at 1:14 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Apr 8, 2015 at 10:53 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Wed, Apr 8, 2015 at 1:09 PM, Fujii Masao

Re: [HACKERS] alternative compression algorithms?

2015-04-30 Thread Robert Haas
On Wed, Apr 29, 2015 at 9:12 PM, Tomas Vondra tomas.von...@2ndquadrant.com wrote: The whole script (doing a lot of estimates) takes 1:50 with pglz and only 1:25 with lz4. That's ~25-30% improvement. Still pretty good -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] CTE optimization fence on the todo list?

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 12:44 AM, Chris Rogers teuk...@gmail.com wrote: Has there been any movement on this in the last couple years? I could really use the ability to optimize across CTE boundaries, and it seems like a lot of other people could too. I'm not aware that anyone is working on

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Sawada Masahiko
On Thu, Apr 30, 2015 at 8:39 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 6:37 AM, Sawada Masahiko sawada.m...@gmail.com wrote: Attached v10 patch is latest version patch. The syntax is, REINDEX { INDEX | ... } name [ WITH ] [ VERBOSE ] That is, WITH clause is

Re: [HACKERS] Precedence of NOT LIKE, NOT BETWEEN, etc

2015-04-30 Thread Bruce Momjian
On Wed, Apr 8, 2015 at 01:14:38PM -0400, Tom Lane wrote: Greg Stark st...@mit.edu writes: On Tue, Feb 24, 2015 at 5:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: Also, it strikes me that we could significantly reduce, maybe even fully eliminate, the funny behaviors around the existing

[HACKERS] Loss of some parts of the function definition

2015-04-30 Thread Sergey Grinko
Hi, Dear developers, I have a request to you. Now create a script in the application of its function parameters and return values can be declared using %TYPE. However, when you save the script is stored inside the server only what is considered his body. Thus, we obtain: 1) loss of the custom

Re: [HACKERS] Re: [BUGS] BUG #11805: Missing SetServiceStatus call during service shutdown in pg_ctl (Windows only)

2015-04-30 Thread Robert Haas
On Sat, Mar 21, 2015 at 9:00 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Mar 20, 2015 at 9:48 PM, Bruce Momjian br...@momjian.us wrote: On Tue, Oct 28, 2014 at 07:02:41AM +, krystian.bi...@gmail.com wrote: The following bug has been logged on the website: Bug reference:

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-04-30 Thread Bruce Momjian
On Thu, Apr 30, 2015 at 08:46:55AM -0400, Robert Haas wrote: On Wed, Apr 15, 2015 at 3:38 PM, Qingqing Zhou zhouqq.postg...@gmail.com wrote: In executor context, outerPlanState(node) is the same as node-ss.ps.lefttree. We follow this in most places except a few. This patch clean up the

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Simon Riggs
On 25 April 2015 at 01:12, Amit Kapila amit.kapil...@gmail.com wrote: On Sat, Apr 25, 2015 at 1:58 AM, Jim Nasby jim.na...@bluetreble.com wrote: On 4/23/15 10:40 PM, Amit Kapila wrote: I agree with you and what I think one of the major reasons of bloat is that Index segment doesn't

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 8:05 AM, Simon Riggs si...@2ndquadrant.com wrote: A much better idea is to work out how to avoid index bloat at cause. If we are running an UPDATE and we cannot get a cleanup lock, we give up and do a non-HOT update, causing the index to bloat. It seems better to wait

Re: [HACKERS] json_populate_record issue - TupleDesc reference leak

2015-04-30 Thread Pavel Stehule
Still issue is not fixed still create type pt as (a int, b int); postgres=# select json_populate_record('(10,20)'::pt, '{}'); WARNING: TupleDesc reference leak: TupleDesc 0x7f413ca325b0 (16560,-1) still referenced 2015-04-30 14:32 GMT+02:00 Bruce Momjian br...@momjian.us: On Thu, Feb 26,

Re: [HACKERS] Disabling trust/ident authentication configure option

2015-04-30 Thread Robert Haas
On Thu, Apr 16, 2015 at 9:55 AM, Bernd Helmle maili...@oopsware.de wrote: PostgreSQL is deployed as part of a larger technical solution (e.g. a Telecommunication system) and a field engineer has to install/upgrade this solution. The engineer is a specialist in the Telco domain and has only

Re: [HACKERS] BRIN range operator class

2015-04-30 Thread Robert Haas
On Mon, Apr 6, 2015 at 5:17 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Thanks for the updated patch; I will at it as soon as time allows. (Not really all that soon, regrettably.) Judging from a quick look, I think patches 1 and 5 can be committed quickly; they imply no changes to

Re: [HACKERS] configure can't detect proper pthread flags

2015-04-30 Thread Robert Haas
On Wed, Apr 8, 2015 at 2:31 AM, Max Filippov jcmvb...@gmail.com wrote: On Sat, Mar 21, 2015 at 2:06 AM, Max Filippov jcmvb...@gmail.com wrote: On Fri, Mar 20, 2015 at 3:43 PM, Max Filippov jcmvb...@gmail.com wrote: Ok, one more attempt: maybe instead of checking that stderr is empty we could

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 12:31 AM, Amit Kapila amit.kapil...@gmail.com wrote: I think I am missing something here, but when this second evaluation is needed. Basically what I understand from index insertion is that it evaluates the value to be inserted in index before calling nbtree module and

Re: [HACKERS] [RFC] sepgsql: prohibit users to relabel objects

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 4:13 AM, Denis Kirjanov k...@itsirius.su wrote: Oh, I wasn't aware of that. Any hints where to look at? Unfortunately, I don't really understand in detail how to write selinux policies, so no. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise

Re: [HACKERS] json_populate_record issue - TupleDesc reference leak

2015-04-30 Thread Bruce Momjian
On Thu, Feb 26, 2015 at 05:31:44PM -0500, Tom Lane wrote: Andrew Dunstan and...@dunslane.net writes: This doesn't look quite right. Shouldn't we unconditionally release the Tupledesc before the returns at lines 2118 and 2127, just as we do at the bottom of the function at line 2285? I

[HACKERS] feature freeze and beta schedule

2015-04-30 Thread Peter Eisentraut
The schedule https://wiki.postgresql.org/wiki/PgCon_2014_Developer_Meeting#9.5_Schedule calls for beta in June. In light of that, the core team has agreed to call for feature freeze on May 15 That means that all patches that add or change features should be committed by then. If you have

Re: [HACKERS] Loss of some parts of the function definition

2015-04-30 Thread Pavel Stehule
Hi 2015-04-30 13:44 GMT+02:00 Sergey Grinko sergey.gri...@gmail.com: Hi, Dear developers, I have a request to you. Now create a script in the application of its function parameters and return values can be declared using %TYPE. However, when you save the script is stored inside the server

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-04-30 Thread Robert Haas
On Wed, Apr 15, 2015 at 3:38 PM, Qingqing Zhou zhouqq.postg...@gmail.com wrote: In executor context, outerPlanState(node) is the same as node-ss.ps.lefttree. We follow this in most places except a few. This patch clean up the outliers and might save us a few instructions by removing

Re: [HACKERS] Re: [BUGS] BUG #11805: Missing SetServiceStatus call during service shutdown in pg_ctl (Windows only)

2015-04-30 Thread Michael Paquier
On Thu, Apr 30, 2015 at 9:53 PM, Robert Haas robertmh...@gmail.com wrote: On Sat, Mar 21, 2015 at 9:00 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Mar 20, 2015 at 9:48 PM, Bruce Momjian br...@momjian.us wrote: On Tue, Oct 28, 2014 at 07:02:41AM +, krystian.bi...@gmail.com

Re: [HACKERS] Loss of some parts of the function definition

2015-04-30 Thread Sergey Grinko
I agree that it is better to show what really works. I propose to allow additional option through a source code which is made on the basis of a compilation of metadata. This will solve the problem. 2015-04-30 16:19 GMT+03:00 Pavel Stehule pavel.steh...@gmail.com: 2015-04-30 15:08 GMT+02:00

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 6:37 AM, Sawada Masahiko sawada.m...@gmail.com wrote: Attached v10 patch is latest version patch. The syntax is, REINDEX { INDEX | ... } name [ WITH ] [ VERBOSE ] That is, WITH clause is optional. I thought we agreed on moving this earlier in the command:

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-04-30 Thread Kouhei Kaigai
On Sun, Apr 26, 2015 at 10:00 PM, Kouhei Kaigai kai...@ak.jp.nec.com wrote: The attached patch v13 is revised one according to the suggestion by Robert. Thanks. The last hunk in foreign.c is a useless whitespace change. Sorry, my oversight. + /* actually, not shift members */

Re: [HACKERS] configure can't detect proper pthread flags

2015-04-30 Thread Max Filippov
On Thu, Apr 30, 2015 at 3:51 PM, Robert Haas robertmh...@gmail.com wrote: On Wed, Apr 8, 2015 at 2:31 AM, Max Filippov jcmvb...@gmail.com wrote: On Sat, Mar 21, 2015 at 2:06 AM, Max Filippov jcmvb...@gmail.com wrote: On Fri, Mar 20, 2015 at 3:43 PM, Max Filippov jcmvb...@gmail.com wrote: Ok,

Re: [HACKERS] Precedence of NOT LIKE, NOT BETWEEN, etc

2015-04-30 Thread Tom Lane
Bruce Momjian br...@momjian.us writes: On Wed, Apr 8, 2015 at 01:14:38PM -0400, Tom Lane wrote: Greg Stark st...@mit.edu writes: On Tue, Feb 24, 2015 at 5:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: Also, it strikes me that we could significantly reduce, maybe even fully eliminate, the funny

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:02 AM, Bruce Momjian br...@momjian.us wrote: On Thu, Apr 30, 2015 at 08:46:55AM -0400, Robert Haas wrote: On Wed, Apr 15, 2015 at 3:38 PM, Qingqing Zhou zhouqq.postg...@gmail.com wrote: In executor context, outerPlanState(node) is the same as node-ss.ps.lefttree.

Re: [HACKERS] Loss of some parts of the function definition

2015-04-30 Thread Pavel Stehule
2015-04-30 15:34 GMT+02:00 Sergey Grinko sergey.gri...@gmail.com: I agree that it is better to show what really works. I propose to allow additional option through a source code which is made on the basis of a compilation of metadata. This will solve the problem. You can to teach PostgreSQL

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Amit Kapila
On Thu, Apr 30, 2015 at 5:03 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 12:31 AM, Amit Kapila amit.kapil...@gmail.com wrote: I think I am missing something here, but when this second evaluation is needed. Basically what I understand from index insertion is that

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:46 AM, Amit Kapila amit.kapil...@gmail.com wrote: As the index expression contain table columns and all the functions or operators used in expression must be IMMUTABLE, won't that guarantee to avoid such a situation? The concern is that they might be labeled as

Re: [HACKERS] contrib/fuzzystrmatch/dmetaphone.c license

2015-04-30 Thread Bruce Momjian
On Wed, Feb 25, 2015 at 08:36:49PM -0500, Andrew Dunstan wrote: I doubt we want to rip it out without some suitable replacement -- do we? That's more than 10 years ago. I remember creating this for my then work at the North Carolina State Highway Patrol and sending it to Joe, but that's

Re: [HACKERS] Moving on to close the current CF 2015-02

2015-04-30 Thread Michael Paquier
On Wed, Apr 29, 2015 at 1:10 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Apr 17, 2015 at 4:57 PM, Magnus Hagander mag...@hagander.net wrote: On Fri, Apr 17, 2015 at 9:23 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Apr 17, 2015 at 4:22 PM, Michael Paquier wrote:

Re: [HACKERS] Turning recovery.conf into GUCs

2015-04-30 Thread Michael Paquier
On Sat, Feb 21, 2015 at 6:45 AM, Peter Eisentraut pete...@gmx.net wrote: On 2/19/15 4:33 PM, Josh Berkus wrote: On 02/19/2015 12:23 PM, Peter Eisentraut wrote: On 1/6/15 4:22 PM, Peter Eisentraut wrote: That said, there is a much simpler way to achieve that specific functionality: Expose all

Re: [HACKERS] feature freeze and beta schedule

2015-04-30 Thread Peter Eisentraut
On 4/30/15 12:01 PM, Robert Haas wrote: So generally we have stamped in late April or early May and released in September, but last year we didn't release until December. I assume that if we stamp beta1 in June instead of May, that's going to somewhat delay the final release as well, but I'm

[HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Joshua D. Drake
Alright folks, So I have this error: postgres[21118]: [8-1] ERROR: unexpected data beyond EOF in block 9 of relation base/430666195/430666206 Which produces this lovely hint: postgres[21118]: [8-2] HINT: This has been seen to occur with buggy kernels; consider updating your system.

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-04-30 Thread Qingqing Zhou
On Thu, Apr 30, 2015 at 8:02 AM, Robert Haas robertmh...@gmail.com wrote: I don't mind the MSDOS newlines, but the UTF-16le bit is inconvenient. UTF-8 would be much better, so I don't have to figure out how to convert. The patch is generated via github windows tool and that's possibly why. I

Re: [HACKERS] Relation extension scalability

2015-04-30 Thread Qingqing Zhou
On Fri, Apr 17, 2015 at 11:19 AM, Qingqing Zhou zhouqq.postg...@gmail.com wrote: Most commercial database employs a DMS storage model, where it manages object mapping and freespace itself. So different objects are sharing storage within several files. Surely it has historic reasons, but it

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:15 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Apr 30, 2015 at 8:39 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 6:37 AM, Sawada Masahiko sawada.m...@gmail.com wrote: Attached v10 patch is latest version patch. The syntax is,

Re: [HACKERS] pg_upgrade: quote directory names in delete_old_cluster script

2015-04-30 Thread Bruce Momjian
On Wed, Apr 29, 2015 at 11:59:26PM -0300, Alvaro Herrera wrote: Bruce Momjian wrote: I have developed the attached patch to use platform-specific quoting of path names. Part of me wonders about initdb's existing DIR_SEP and QUOTE_PATH definitions ... seems messy to reinvent these things

Re: [HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Alvaro Herrera
Joshua D. Drake wrote: Alright folks, So I have this error: postgres[21118]: [8-1] ERROR: unexpected data beyond EOF in block 9 of relation base/430666195/430666206 Which produces this lovely hint: postgres[21118]: [8-2] HINT: This has been seen to occur with buggy kernels;

Re: [HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Joshua D. Drake
On 04/30/2015 10:28 AM, Alvaro Herrera wrote: Joshua D. Drake wrote: Alright folks, So I have this error: postgres[21118]: [8-1] ERROR: unexpected data beyond EOF in block 9 of relation base/430666195/430666206 Which produces this lovely hint: postgres[21118]: [8-2] HINT: This has been

Re: [HACKERS] feature freeze and beta schedule

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 12:52 PM, Peter Eisentraut pete...@gmx.net wrote: On 4/30/15 12:01 PM, Robert Haas wrote: So generally we have stamped in late April or early May and released in September, but last year we didn't release until December. I assume that if we stamp beta1 in June instead

[HACKERS] cost_index() and path row estimate.

2015-04-30 Thread Bernd Helmle
While looking into a customer performance problem, i saw this in costsize.c, cost_index() (9.3.6, but it looks the same in HEAD): /* Mark the path with the correct row estimate */ if (path-path.param_info) { path-path.rows = path-path.param_info-ppi_rows;

Re: [HACKERS] BRIN range operator class

2015-04-30 Thread Alvaro Herrera
Robert Haas wrote: On Mon, Apr 6, 2015 at 5:17 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Thanks for the updated patch; I will at it as soon as time allows. (Not really all that soon, regrettably.) Judging from a quick look, I think patches 1 and 5 can be committed quickly;

Re: [HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Joshua D. Drake
On 04/30/2015 12:09 PM, Alvaro Herrera wrote: Joshua D. Drake wrote: I take that back, it appears this table is heavily deleted from and also uses the lo_manage() triggers. Well, if it's heavily deleted, then it's probably also heavily vacuumed and from time to time empty pages at the tail

Re: [HACKERS] pgbench -f and vacuum

2015-04-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Wed, Feb 11, 2015 at 2:00 PM, Jeff Janes jeff.ja...@gmail.com wrote: But as far as what has been discussed on the central topic of this thread, I think that doing the vacuum and making the failure for non-existent tables be non-fatal when -f is

Re: [HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Alvaro Herrera
Joshua D. Drake wrote: I take that back, it appears this table is heavily deleted from and also uses the lo_manage() triggers. Well, if it's heavily deleted, then it's probably also heavily vacuumed and from time to time empty pages at the tail are removed by vacuum. It might also be the

Re: [HACKERS] initdb -S and tablespaces

2015-04-30 Thread Robert Haas
On Thu, Apr 16, 2015 at 9:24 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: Here's a variation of the earlier patch that follows all links in PGDATA. Does this look more like what you had in mind? I'm really confused by the additional control-file field. It is documented as indicating

Re: [HACKERS] alter user/role CURRENT_USER

2015-04-30 Thread Alvaro Herrera
Kyotaro HORIGUCHI wrote: Thank you for completing this and very sorry not to respond these days. I understood that it is committed after I noticed that rebasing my code failed.. You'd do well to check your email, I guess :-) Although after committed, I found some issues as I looked on

Re: [HACKERS] pgbench -f and vacuum

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 4:17 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Feb 11, 2015 at 2:00 PM, Jeff Janes jeff.ja...@gmail.com wrote: But as far as what has been discussed on the central topic of this thread, I think that doing the vacuum and

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-04-30 Thread Robert Haas
On Tue, Mar 31, 2015 at 3:02 PM, Tomas Vondra tomas.von...@2ndquadrant.com wrote: attached is v4 of the patch implementing adaptive ndistinct estimator. So, I took a look at this today. It's interesting work, but it looks more like a research project than something we can commit to 9.5. As far

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-04-30 Thread Kouhei Kaigai
On Thu, Apr 30, 2015 at 9:16 AM, Kouhei Kaigai kai...@ak.jp.nec.com wrote: It seems to me the code block for T_ForeignScan and T_CustomScan in setrefs.c are a bit large. It may be better to have a separate function like T_IndexOnlyScan. How about your opinion? Either way is OK with me.

Re: [HACKERS] ERROR: unexpected data beyond EOF

2015-04-30 Thread Joshua D. Drake
I take that back, it appears this table is heavily deleted from and also uses the lo_manage() triggers. -- Command Prompt, Inc. - http://www.commandprompt.com/ 503-667-4564 PostgreSQL Centered full stack support, consulting and development. Announcing I'm offended is basically telling the

Re: [HACKERS] parallel mode and parallel contexts

2015-04-30 Thread Robert Haas
On Wed, Apr 29, 2015 at 12:23 PM, Robert Haas robertmh...@gmail.com wrote: So, I think it makes sense to split up this patch in two. There's no real debate, AFAICS, about anything in the patch other than the heavyweight locking stuff. So I'd like to go ahead and commit the rest. That's

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2015-04-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: Tom, you're listed as the committer for this in the CF app. Are you still planning to take care of this? It seems that time is beginning to run short. Yeah, I will address this (and start looking at GROUPING SETS) next week. I'm out of town right now.

Re: [HACKERS] pgbench -f and vacuum

2015-04-30 Thread Robert Haas
On Wed, Feb 11, 2015 at 2:00 PM, Jeff Janes jeff.ja...@gmail.com wrote: But as far as what has been discussed on the central topic of this thread, I think that doing the vacuum and making the failure for non-existent tables be non-fatal when -f is provided would be an improvement. Or maybe

Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-04-30 Thread Pavel Stehule
2015-04-29 9:26 GMT+02:00 Pavel Stehule pavel.steh...@gmail.com: Hi all I am looking on this patch. I can confirm 10-15% speedup - and the idea behind this patch looks well. This patch http://www.postgresql.org/message-id/4146.1425872...@sss.pgh.pa.us contains two parts a) relative

Re: [HACKERS] [PATCH] HINT: pg_hba.conf changed since last config reload

2015-04-30 Thread Peter Eisentraut
On 12/20/14 12:11 PM, Steve Singer wrote: On 12/19/2014 10:41 AM, Alex Shulgin wrote: I don't think so. The scenario this patch relies on assumes that the DBA will remember to look in the log if something goes wrong, and in your case there would be a message like the following: WARNING:

Re: [HACKERS] EvalPlanQual behaves oddly for FDW queries involving system columns

2015-04-30 Thread Robert Haas
On Thu, Apr 16, 2015 at 2:55 AM, Etsuro Fujita fujita.ets...@lab.ntt.co.jp wrote: Ah, you are right. FOR NO KEY UPDATE and FOR KEY SHARE would be useful in the Postgres FDW if we assume the user performs those properly based on information about keys for a remote table. Sorry, my explanation

Re: [HACKERS] Faster setup_param_list() in plpgsql

2015-04-30 Thread Pavel Stehule
Review: What this patch does - it change a mechanism, how a values of variables are transmitted to SPI. In previous variant values are copied to ParamListInfo before every evaluation of any expression. New mechanism is smarter. It refresh only ROW, REC values when are marked as dirty (when these

Re: [HACKERS] BuildTupleFromCStrings Memory Documentation?

2015-04-30 Thread Tom Lane
Jason Petersen ja...@citusdata.com writes: Within the core codebase, BuildTupleFromCStrings is often called within a temporary memory context cleared after the call. In dblink.c, this is justified as being needed to “[clean up] not only the data we have direct access to, but any cruft the

Re: [HACKERS] feature freeze and beta schedule

2015-04-30 Thread Michael Paquier
On Fri, May 1, 2015 at 1:55 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 12:52 PM, Peter Eisentraut pete...@gmx.net wrote: On 4/30/15 12:01 PM, Robert Haas wrote: So generally we have stamped in late April or early May and released in September, but last year we didn't

Re: [HACKERS] pg_rewind test race condition..?

2015-04-30 Thread Heikki Linnakangas
On 04/29/2015 06:03 AM, Stephen Frost wrote: * Heikki Linnakangas (hlinn...@iki.fi) wrote: --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -7173,7 +7173,10 @@ StartupXLOG(void) * than is appropriate now that we're not in standby mode anymore.

Re: [HACKERS] initdb -S and tablespaces

2015-04-30 Thread Alvaro Herrera
Robert Haas wrote: On Thu, Apr 30, 2015 at 6:18 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Also, it seems awfully unfortunate to me that we're duplicating a whole pile of code into xlog.c here. Maybe there's no way to avoid the code duplication, but pre_sync_fname() seems like

Re: [HACKERS] initdb -S and tablespaces

2015-04-30 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Thu, Apr 30, 2015 at 6:44 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Ah, so that's not the duplicate code that I was remembering -- I think it's walkdir() or something like that, which is in initdb IIRC. Yeah, walkdir() is there too. But

Re: [HACKERS] procost for to_tsvector

2015-04-30 Thread Bruce Momjian
On Wed, Mar 11, 2015 at 02:40:16PM +, Andrew Gierth wrote: An issue that comes up regularly on IRC is that text search queries, especially on relatively modest size tables or for relatively non-selective words, often misplan as a seqscan based on the fact that to_tsvector has procost=1.

Re: [HACKERS] initdb -S and tablespaces

2015-04-30 Thread Abhijit Menon-Sen
At 2015-04-30 15:37:44 -0400, robertmh...@gmail.com wrote: 1. It doesn't do that. As soon as we fsync the data directory, we reset the flag. That's not what ever disabled means to me. Could you suggest an acceptable alternative wording? I can't immediately think of anything better than

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

2015-04-30 Thread Christian Ullrich
* Andrew Dunstan: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the plpython regression tests. The only relevant commit seems to be the transforms feature. Here's what

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-04-30 Thread Tomas Vondra
Hi, On 04/30/15 22:57, Robert Haas wrote: On Tue, Mar 31, 2015 at 3:02 PM, Tomas Vondra tomas.von...@2ndquadrant.com wrote: attached is v4 of the patch implementing adaptive ndistinct estimator. So, I took a look at this today. It's interesting work, but it looks more like a research project

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-04-30 Thread Heikki Linnakangas
On 04/27/2015 11:02 PM, Peter Geoghegan wrote: On Mon, Apr 27, 2015 at 8:31 PM, Heikki Linnakangas hlinn...@iki.fi wrote: I thought we had an ironclad scheme to prevent deadlocks like this, so I'd like to understand why that happens. Okay. I think I know how it happens (I was always

Re: [HACKERS] shared_libperl, shared_libpython

2015-04-30 Thread Peter Eisentraut
On 4/28/15 11:48 PM, Tom Lane wrote: My preference would be to rip all that out and let the compiler or linker decide when it doesn't want to link something. Works for me, assuming that we get an understandable failure message and not, say, a plperl.so that mysteriously doesn't work. Well,

Re: [HACKERS] Reducing tuple overhead

2015-04-30 Thread Amit Kapila
On Thu, Apr 30, 2015 at 7:24 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 9:46 AM, Amit Kapila amit.kapil...@gmail.com wrote: As the index expression contain table columns and all the functions or operators used in expression must be IMMUTABLE, won't that guarantee

[HACKERS] BuildTupleFromCStrings Memory Documentation?

2015-04-30 Thread Jason Petersen
Within the core codebase, BuildTupleFromCStrings is often called within a temporary memory context cleared after the call. In dblink.c, this is justified as being needed to “[clean up] not only the data we have direct access to, but anycruft the I/O functions might leak”.I wrote a pretty minimal

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-04-30 Thread Bruce Momjian
On Tue, Mar 10, 2015 at 02:51:30PM -0400, Robert Haas wrote: On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch attached. I'll commit this if there are no objections. Robert, are you going to apply

Re: [HACKERS] Final Patch for GROUPING SETS

2015-04-30 Thread Noah Misch
On Thu, Apr 30, 2015 at 05:35:26AM +0100, Andrew Gierth wrote: Andres == Andres Freund and...@anarazel.de writes: + * TODO: AGG_HASHED doesn't support multiple grouping sets yet. Andres Are you intending to resolve this before an eventual commit? Original plan was to tackle

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

2015-04-30 Thread Peter Eisentraut
On 4/30/15 2:49 PM, Andrew Dunstan wrote: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the plpython regression tests. The only relevant commit seems to be the transforms

Re: [HACKERS] One question about security label command

2015-04-30 Thread Kohei KaiGai
2015-05-01 7:40 GMT+09:00 Alvaro Herrera alvhe...@2ndquadrant.com: Kouhei Kaigai wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: The idea of making the regression test entirely independent of the system's policy would presumably solve this problem, so I'd kind of like to see progress on

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-04-30 Thread Tomas Vondra
On 05/01/15 00:18, Robert Haas wrote: On Thu, Apr 30, 2015 at 5:31 PM, Heikki Linnakangas hlinn...@iki.fi wrote: You can override the ndistinct estimate with ALTER TABLE. I think that's enough for an escape hatch. I'm not saying that isn't nice to have, but I don't think it really helps

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-04-30 Thread Sawada Masahiko
On Fri, May 1, 2015 at 1:38 AM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 9:15 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Apr 30, 2015 at 8:39 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Apr 30, 2015 at 6:37 AM, Sawada Masahiko

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-04-30 Thread Pavel Stehule
It is done Dne 1.5.2015 3:11 napsal uživatel Bruce Momjian br...@momjian.us: On Tue, Mar 10, 2015 at 02:51:30PM -0400, Robert Haas wrote: On Tue, Mar 10, 2015 at 2:32 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 1. funcname_signature_string 2. get_rule_expr Thanks. Patch

Re: [HACKERS] initdb -S and tablespaces

2015-04-30 Thread Abhijit Menon-Sen
At 2015-04-30 16:56:17 -0700, t...@sss.pgh.pa.us wrote: As for the notion that this needs to be back-patched, I would say no. Not even just the fsync after crash part? I could separate that out from the control file changes and try to eliminate the duplication. I think that would be worth

Re: [HACKERS] One question about security label command

2015-04-30 Thread Alvaro Herrera
Kouhei Kaigai wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: The idea of making the regression test entirely independent of the system's policy would presumably solve this problem, so I'd kind of like to see progress on that front. Apologies, I guess it wasn't clear, but that's what

Re: [HACKERS] collations in shared catalogs?

2015-04-30 Thread Bruce Momjian
On Thu, Apr 30, 2015 at 08:16:09AM -0700, Tom Lane wrote: Bruce Momjian br...@momjian.us writes: On 2015-02-25 12:08:32 -0500, Tom Lane wrote: The most obvious fix is to change provider to a NAME column. Where are we on this? Not done yet, but we should make a point of making that fix

Re: [HACKERS] Broken handling of NULLs in TG_ARGV

2015-04-30 Thread Tom Lane
Jim Nasby jim.na...@bluetreble.com writes: plpgsql's handling of NULLs in TG_ARGV turns actual nulls into text 'null'. Hopefully we can all agree that's broken. You apparently have not read the CREATE TRIGGER reference page very carefully: arguments An optional

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-04-30 Thread Robert Haas
On Thu, Apr 30, 2015 at 1:44 PM, Qingqing Zhou zhouqq.postg...@gmail.com wrote: On Thu, Apr 30, 2015 at 8:02 AM, Robert Haas robertmh...@gmail.com wrote: I don't mind the MSDOS newlines, but the UTF-16le bit is inconvenient. UTF-8 would be much better, so I don't have to figure out how to

Re: [HACKERS] One question about security label command

2015-04-30 Thread Alvaro Herrera
Stephen Frost wrote: Hi, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: Could you provide a buildfarm animal that runs the sepgsql test in all branches on a regular basis? Would be great if KaiGai can, of course, but I'm planning to stand one up here soon in any case. I don't

  1   2   >