Re: [HACKERS] Improving replay of XLOG_BTREE_VACUUM records

2015-05-01 Thread Jim Nasby
On 5/1/15 11:19 AM, Vladimir Borodin wrote: There are situations in which vacuuming big btree index causes stuck in WAL replaying on hot standby servers for quite a long time. I’ve described the problem in more details in this thread [0]. Below in that thread Kevin Grittner proposed a good way

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David G. Johnston
On Fri, May 1, 2015 at 3:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: Assuming that that sketch is accurate, it would take more code to provide a new user-visible knob to enable/disable the behavior than it would to implement the optimization, which makes me pretty much -1 on providing such a

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Peter Geoghegan
On Fri, May 1, 2015 at 5:27 PM, Andrew Gierth and...@tao11.riddles.org.uk wrote: Also as I've pointed out, it's not even clear that there is a regression at all, since I've already shown that changes of several percent in timings of sort operations can be caused by irrelevant noise factors. To

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Tom Lane
David Steele da...@pgmasters.net writes: On 5/1/15 5:39 PM, Tom Lane wrote: I doubt that the spec says anything about it one way or another. However, there are a lot of cases where we definitely can't push constraints into a WITH: * Data-modifying query in the WITH, eg UPDATE RETURNING ---

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Peter Geoghegan
On Fri, May 1, 2015 at 3:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: Assuming that that sketch is accurate, it would take more code to provide a new user-visible knob to enable/disable the behavior than it would to implement the optimization, which makes me pretty much -1 on providing such a

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
On 5/1/15 6:32 PM, Peter Geoghegan wrote: On Fri, May 1, 2015 at 3:30 PM, Tom Lane t...@sss.pgh.pa.us wrote: Assuming that that sketch is accurate, it would take more code to provide a new user-visible knob to enable/disable the behavior than it would to implement the optimization, which makes

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Andrew Gierth
Andres == Andres Freund and...@anarazel.de writes: Andres * Abbreviated key support for Datum sorts Andres Unfortunately the discussion about potential performance Andres regression has been largely sidestepped by bickering over Andres minutiae. Andres = ? There isn't a potential

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Amit Kapila
On Fri, May 1, 2015 at 10:07 PM, Andres Freund and...@anarazel.de wrote: On 2015-04-30 08:39:45 -0400, Peter Eisentraut wrote: If you have spare cycles, there are a number of relevant patches still open in the commit fest. I was wondering what the actual state of the commitfest is. I'm

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-01 Thread Peter Eisentraut
On 4/30/15 6:05 AM, Fujii Masao wrote: The specification of session audit logging seems to be still unclear to me. As I had mentioned previously, I would prefer session audit logging to be integrated with the normal statement logging configuration. -- Sent via pgsql-hackers mailing list

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Josh Berkus
On 05/01/2015 03:30 PM, Tom Lane wrote: Assuming that that sketch is accurate, it would take more code to provide a new user-visible knob to enable/disable the behavior than it would to implement the optimization, which makes me pretty much -1 on providing such a knob. We should either do it

Re: [HACKERS] Reducing tuple overhead

2015-05-01 Thread Jim Nasby
On 4/30/15 7:37 AM, Robert Haas wrote: On Thu, Apr 30, 2015 at 8:05 AM, Simon Riggs si...@2ndquadrant.com wrote: A much better idea is to work out how to avoid index bloat at cause. If we are running an UPDATE and we cannot get a cleanup lock, we give up and do a non-HOT update, causing the

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Andrew Gierth
Tom == Tom Lane t...@sss.pgh.pa.us writes: In the OP, he suggested on the order of 100. Maybe we could just go with 100. Tom I'm OK with that in view of 87h9trs0zm@news-spur.riddles.org.uk Note that the results from that post suggest 100 as a bare minimum, higher values would be

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Tom Lane
Andrew Gierth and...@tao11.riddles.org.uk writes: Tom == Tom Lane t...@sss.pgh.pa.us writes: In the OP, he suggested on the order of 100. Maybe we could just go with 100. Tom I'm OK with that in view of 87h9trs0zm@news-spur.riddles.org.uk Note that the results from that post suggest

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Petr Jelinek
On 01/05/15 18:37, Andres Freund wrote: I was wondering what the actual state of the commitfest is. I'm thus going through all the open items. Here's my thoughts: Cool. * Sequence Access Method There's been some back and forth between Petr and Heikki on this lately. = Maybe there's

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 09:39:43AM -0400, Robert Haas wrote: On Fri, May 1, 2015 at 9:13 AM, Bruce Momjian br...@momjian.us wrote: On Fri, May 1, 2015 at 07:57:27AM -0400, Robert Haas wrote: On Thu, Apr 30, 2015 at 9:34 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Mar 11, 2015 at

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Andres Freund
On 2015-05-01 10:03:01 -0400, Robert Haas wrote: Maybe we could just go with 100. +1 Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Reducing tuple overhead

2015-05-01 Thread Amit Kapila
On Thu, Apr 30, 2015 at 5:35 PM, Simon Riggs si...@2ndquadrant.com wrote: On 25 April 2015 at 01:12, Amit Kapila amit.kapil...@gmail.com wrote: On Sat, Apr 25, 2015 at 1:58 AM, Jim Nasby jim.na...@bluetreble.com wrote: On 4/23/15 10:40 PM, Amit Kapila wrote: I agree with you and what I

Re: [HACKERS] initdb start server recommendation

2015-05-01 Thread Euler Taveira
On 01-05-2015 11:14, Bruce Momjian wrote: Currently initdb outputs suggested text on starting the server: Success. You can now start the database server using: /u/pgsql/bin/postgres -D /u/pgsql/data or /u/pgsql/bin/pg_ctl -D /u/pgsql/data -l logfile

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Andres Freund
On 2015-03-28 17:24:36 -0400, Tom Lane wrote: I wrote: [ expanded-arrays-1.0.patch ] This is overdue for a rebase; attached. No functional changes, but some of what was in the original patch has already been merged, and other parts were superseded. What are your plans with this WRT 9.5?

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Andres Freund
On 2015-05-01 10:06:42 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 9:58 AM, Andres Freund and...@anarazel.de wrote: would you rather have EXCLUDED.data refer to the tuple version from VALUES (or a SELECT or ...) or to version from the BEFORE trigger? I think it would be completely

Re: [HACKERS] One question about security label command

2015-05-01 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: Stephen Frost wrote: * Alvaro Herrera (alvhe...@2ndquadrant.com) wrote: Could you provide a buildfarm animal that runs the sepgsql test in all branches on a regular basis? Would be great if KaiGai can, of course, but I'm

Re: [HACKERS] cache invalidation for PL/pgsql functions

2015-05-01 Thread Fabrízio de Royes Mello
Em sexta-feira, 1 de maio de 2015, Robert Haas robertmh...@gmail.com escreveu: On Fri, May 1, 2015 at 9:09 AM, Marko Tiikkaja ma...@joh.to javascript:; wrote: On 2015-04-28 19:43, Robert Haas wrote: I guess the root of the problem is that PL/plgsql's cache invalidation logic only

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 10:03:01AM -0400, Robert Haas wrote: On Fri, May 1, 2015 at 10:01 AM, Bruce Momjian br...@momjian.us wrote: Andrew did the research to support a higher value, but even 10 should be an improvement over what we have now. Yes, I saw that, but I didn't see him

Re: [HACKERS] INSERT ... ON CONFLICT syntax issues

2015-05-01 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: On the other hand it's way more convenient to specify a single constraint name than several columns and a predicate. I'm pretty sure there's situations where I a) rather live with a smaller chance of error during a replacement of the constraint b) if

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 10:10 AM, Andres Freund and...@anarazel.de wrote: On 2015-05-01 10:06:42 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 9:58 AM, Andres Freund and...@anarazel.de wrote: would you rather have EXCLUDED.data refer to the tuple version from VALUES (or a SELECT or ...) or

Re: [HACKERS] initdb start server recommendation

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 10:14 AM, Bruce Momjian br...@momjian.us wrote: Currently initdb outputs suggested text on starting the server: Success. You can now start the database server using: /u/pgsql/bin/postgres -D /u/pgsql/data or /u/pgsql/bin/pg_ctl

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Heikki Linnakangas
On 04/30/2015 11:09 PM, Peter Geoghegan wrote: I've been unable to reproduce the unprincipled deadlock using the same test case as before. However, the exclusion constraint code now livelocks. Here is example output from a stress-testing session: ... [Fri May 1 04:45:35 2015] normal exit at

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 10:49 AM, Andres Freund and...@anarazel.de wrote: One idea is to decide that an INSERT with an ON CONFLICT UPDATE handler is still an INSERT. Period. So the INSERT triggers run, the UPDATE triggers don't, and that's it. I think that'd be much worse. OK. Well, in

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: OK. In that case, I'm a lot less sure what the right decision is. It seems weird for both the BEFORE INSERT and BEFORE UPDATE triggers to get a crack at the same tuple, so your way might be better after all. But on the other hand, the BEFORE

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 10:01 AM, Bruce Momjian br...@momjian.us wrote: Andrew did the research to support a higher value, but even 10 should be an improvement over what we have now. Yes, I saw that, but I didn't see him recommend an actual number. Can someone recommend a number now? Tom

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Andres Freund
On 2015-05-01 10:21:27 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 10:10 AM, Andres Freund and...@anarazel.de wrote: On 2015-05-01 10:06:42 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 9:58 AM, Andres Freund and...@anarazel.de wrote: would you rather have EXCLUDED.data refer to

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 10:24 AM, Andres Freund and...@anarazel.de wrote: Well, it's a BEFORE INSERT trigger, not a BEFORE UPDATE, that's why I'm not so sure that argument applies. Would the BEFORE UPDATE trigger even fire in this case? BEFORE UPDATE triggers fire for INSERT ... ON CONFLICT

Re: [HACKERS] initdb start server recommendation

2015-05-01 Thread Andrew Dunstan
On 05/01/2015 10:14 AM, Bruce Momjian wrote: Currently initdb outputs suggested text on starting the server: Success. You can now start the database server using: /u/pgsql/bin/postgres -D /u/pgsql/data or /u/pgsql/bin/pg_ctl -D /u/pgsql/data -l

Re: [HACKERS] initdb -S and tablespaces

2015-05-01 Thread Abhijit Menon-Sen
At 2015-05-01 09:57:28 -0400, robertmh...@gmail.com wrote: If you don't object to this version, I'll commit it. Looks fine to me, thank you. As for the non-backpatchable 0002, I agree with Andres that it should be included in 9.5; but I take it you're still not convinced? Should I add that to

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Andres Freund
On 2015-05-01 10:39:35 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 10:24 AM, Andres Freund and...@anarazel.de wrote: The BEFORE UPDATE would catch things in this case. OK. In that case, I'm a lot less sure what the right decision is. It seems weird for both the BEFORE INSERT and

Re: [HACKERS] alter user/role CURRENT_USER

2015-05-01 Thread Kyotaro HORIGUCHI
Hello, At Thu, 30 Apr 2015 17:12:25 -0300, Alvaro Herrera alvhe...@2ndquadrant.com wrote in 20150430201225.gv4...@alvh.no-ip.org Kyotaro HORIGUCHI wrote: Thank you for completing this and very sorry not to respond these days. I understood that it is committed after I noticed that

[HACKERS] Race condition when starting and stopping test server in TestLib.pm?

2015-05-01 Thread Michael Paquier
Hi all, Within the last couple of days hamster has failed twice when running TAP tests because it was not able to start a test server with start_test_server: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hamsterdt=2015-04-30%2019%3A07%3A31

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Peter Geoghegan
On Thu, Apr 30, 2015 at 7:00 PM, Heikki Linnakangas hlinn...@iki.fi wrote: To fix that, we need to fix the livelock insurance check so that A does not wait for B here. Because B is not a speculative insertion, A should cancel its speculative insertion and retry instead. (I pushed the one-line

Re: [HACKERS] Make more portable TAP tests of initdb

2015-05-01 Thread Michael Paquier
On Thu, Apr 30, 2015 at 12:17 PM, Noah Misch n...@leadboat.com wrote: On Wed, Apr 15, 2015 at 02:59:55PM +0900, Michael Paquier wrote: On Wed, Apr 15, 2015 at 2:38 PM, Noah Misch wrote: Solaris 10 ships Perl 5.8.4, and RHEL 5.11 ships Perl 5.8.8. Therefore, Perl installations lacking

Re: [HACKERS] Providing catalog view to pg_hba.conf file - Patch submission

2015-05-01 Thread Andres Freund
On 2015-04-08 19:19:29 +0100, Greg Stark wrote: I'm not sure what the best way to handle the hand-off from patch contribution to reviewer/committer. If I start tweaking things then you send in a new version it's actually more work to resolve the conflicts. I think at this point it's easiest if

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Andres Freund
On 2015-04-30 08:39:45 -0400, Peter Eisentraut wrote: If you have spare cycles, there are a number of relevant patches still open in the commit fest. I was wondering what the actual state of the commitfest is. I'm thus going through all the open items. Here's my thoughts: * fsync $PGDATA

Re: [HACKERS] pg_dump: CREATE TABLE + CREATE RULE vs. relreplident

2015-05-01 Thread Bruce Momjian
On Thu, Mar 12, 2015 at 03:14:48PM +0100, Andres Freund wrote: Hi, On 2015-03-12 14:25:24 +0100, Marko Tiikkaja wrote: My colleague Per Lejontand brought to my attention that when dumping views with circular dependencies from a postgres version older than 9.4 using a recent pg_dump, the

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Andres Freund
On 2015-05-01 13:05:19 -0400, Simon Riggs wrote: On 1 May 2015 at 12:37, Andres Freund and...@anarazel.de wrote: * fastbloat Not too big, I think it should be easy to commit this. = Keep in 'ready for committer' Will commit soon Cool. * Allow snapshot too old error, to prevent

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: On 2015-04-30 08:39:45 -0400, Peter Eisentraut wrote: If you have spare cycles, there are a number of relevant patches still open in the commit fest. I was wondering what the actual state of the commitfest is. I'm thus going through all

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Kevin Grittner
- Original Message - From: Stephen Frost sfr...@snowman.net To: Andres Freund and...@anarazel.de Cc: Peter Eisentraut pete...@gmx.net; pgsql-hackers pgsql-hackers@postgresql.org Sent: Friday, May 1, 2015 12:16 PM Subject: Re: [HACKERS] feature freeze and beta schedule Andres, *

[HACKERS] Improving replay of XLOG_BTREE_VACUUM records

2015-05-01 Thread Vladimir Borodin
Hi all.There are situations in which vacuuming big btree index causes stuck in WAL replaying on hot standby servers for quite a long time. I’ve described the problem in more details in this thread [0]. Below in that thread Kevin Grittner proposed a good way for improving btree scans so that btree

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Peter Geoghegan
On Fri, May 1, 2015 at 9:37 AM, Andres Freund and...@anarazel.de wrote: * Abbreviated key support for Datum sorts Unfortunately the discussion about potential performance regression has been largely sidestepped by bickering over minutiae. = ? There really is no discussion about

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Simon Riggs
On 1 May 2015 at 12:37, Andres Freund and...@anarazel.de wrote: * fastbloat Not too big, I think it should be easy to commit this. = Keep in 'ready for committer' Will commit soon * Turning off HOT for larger SQL queries Seems to have degenerated into a discussion of not really

Re: [HACKERS] cache invalidation for PL/pgsql functions

2015-05-01 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: On Fri, May 1, 2015 at 9:09 AM, Marko Tiikkaja ma...@joh.to wrote: We recently hit a similar case in our production environment. What was annoying about it is that there didn't seem to be a way for the application to fix the issue by itself, short of

Re: [HACKERS] recovery_target_action = pause hot_standby = off

2015-05-01 Thread Bruce Momjian
On Mon, Mar 16, 2015 at 11:39:26AM +0100, Andres Freund wrote: On 2015-03-16 07:52:20 +, Simon Riggs wrote: On 15 March 2015 at 22:38, Andres Freund and...@2ndquadrant.com wrote: Sorry, I don't buy this. If I have recovery_target_action = 'pause' in the config file, I want it to

Re: [HACKERS] Replication, am I missing something

2015-05-01 Thread Joshua D. Drake
On 05/01/2015 09:28 AM, Andres Freund wrote: On 2015-05-01 09:24:17 -0700, Joshua D. Drake wrote: Origin: select pg_start_backup('my_backup',TRUE); Subscriber: rsync -auvk db1:/var/lib/pgsql/data data Origin: select pg_stop_backup(); Subscriber: remove backup_label Subscriber: start

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Andres Freund
On 2015-05-01 09:35:08 -0700, Tom Lane wrote: Andres Freund and...@anarazel.de writes: What are your plans with this WRT 9.5? I'd like to get it committed into 9.5. I've been hoping somebody would do a performance review. Ok. I'll try to have a look, but it'll be the second half of next

[HACKERS] Replication, am I missing something

2015-05-01 Thread Joshua D. Drake
-hackers, In the flurry of releases, I want to make sure I haven't missed something. Here is an example of how I will take a base backup: Origin: select pg_start_backup('my_backup',TRUE); Subscriber: rsync -auvk db1:/var/lib/pgsql/data data Origin: select pg_stop_backup(); Subscriber: remove

Re: [HACKERS] Help needed for PL/Ruby

2015-05-01 Thread Szymon Guz
On 29 April 2015 at 21:45, Szymon Guz mabew...@gmail.com wrote: Hi Devrim, I will take a look at this. regards, Szymon On 29 April 2015 at 18:24, Devrim Gündüz dev...@gunduz.org wrote: Hi, Anyone? :) Regards, Devrim On Wed, 2015-03-18 at 15:19 +0200, Devrim Gündüz wrote: Hi,

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Pavel Stehule
2015-05-01 18:35 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Andres Freund and...@anarazel.de writes: On 2015-03-28 17:24:36 -0400, Tom Lane wrote: This is overdue for a rebase; attached. No functional changes, but some of what was in the original patch has already been merged, and other

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

2015-05-01 Thread Andrew Dunstan
On 05/01/2015 08:57 AM, Andrew Dunstan wrote: On 04/30/2015 09:09 PM, Christian Ullrich wrote: * Andrew Dunstan: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the

Re: [HACKERS] Replication, am I missing something

2015-05-01 Thread Andres Freund
On 2015-05-01 09:24:17 -0700, Joshua D. Drake wrote: Origin: select pg_start_backup('my_backup',TRUE); Subscriber: rsync -auvk db1:/var/lib/pgsql/data data Origin: select pg_stop_backup(); Subscriber: remove backup_label Subscriber: start postgresql You remove backup_label? Huh? That'll

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-03-28 17:24:36 -0400, Tom Lane wrote: This is overdue for a rebase; attached. No functional changes, but some of what was in the original patch has already been merged, and other parts were superseded. What are your plans with this WRT 9.5?

Re: [HACKERS] Use outerPlanState() consistently in executor code

2015-05-01 Thread Qingqing Zhou
On Thu, Apr 30, 2015 at 5:04 PM, Tom Lane t...@sss.pgh.pa.us wrote: I think I'd have done many of these as + PlanState *outerPlan = outerPlanState(node); rather than finding assorted random places to initialize the variables. Agreed. Attached patch is revision along this line.

Re: [HACKERS] pg_dump: CREATE TABLE + CREATE RULE vs. relreplident

2015-05-01 Thread Andres Freund
On 2015-05-01 13:03:39 -0400, Bruce Momjian wrote: Applied and backpatched to 9.4. Ah. Forgot about that. Thanks! Andres .oO(bugtracker?) -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Andres Freund
On 2015-05-01 09:49:50 -0700, Peter Geoghegan wrote: On Fri, May 1, 2015 at 9:37 AM, Andres Freund and...@anarazel.de wrote: * Abbreviated key support for Datum sorts Unfortunately the discussion about potential performance regression has been largely sidestepped by bickering over

Re: [HACKERS] pg_xlog_replay_resume() considered armed and dangerous

2015-05-01 Thread Bruce Momjian
On Thu, Mar 12, 2015 at 04:08:02PM +0100, Andres Freund wrote: Hi, I think it's quite confusing that a function named pg_xlog_replay_resume() can cause a node to be promoted. That this is happened is kind of documented in the recovery.conf section of the manual: The intended use of the

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Kevin Grittner
Stephen Frost sfr...@snowman.net wrote: Andres Freund (and...@anarazel.de) wrote: * Allow snapshot too old error, to prevent bloat http://archives.postgresql.org/message-id/1361166406.1897609.1424371443904.JavaMail.yahoo%40mail.yahoo.com talked about a new version that afaics never

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Pavel Stehule
2015-05-01 20:53 GMT+02:00 Pavel Stehule pavel.steh...@gmail.com: 2015-05-01 20:11 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I am looking on this patch, but it cannot be applied now. lxml2 -lssl -lcrypto -lrt -lcrypt -ldl -lm -o postgres

Re: [HACKERS] initdb -S and tablespaces

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 8:42 AM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: At 2015-05-01 08:10:16 -0400, robertmh...@gmail.com wrote: It seems to me that, at a minimum, it would be good to split those controversial and definitely not-back-patchable changes into their own patch. OK, split

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Andres Freund
On 2015-04-26 18:02:06 -0700, Peter Geoghegan wrote: Remaining challenges = So I did the executor changes I'd mentioned downthread, and Peter agreed that it'd quite workable. Right now this, besides cleanup, docs and syntax leaves only one real issue I know of. Which is the

Re: [HACKERS] initdb -S and tablespaces

2015-05-01 Thread Andres Freund
Hi, I agree that splitting the patch into two separate ones is a good one. On 2015-05-01 09:57:28 -0400, Robert Haas wrote: If you don't object to this version, I'll commit it. I believe this part *should* be back-patched, but Tom seemed to disagree, for reasons I'm not really clear on.

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 9:58 AM, Andres Freund and...@anarazel.de wrote: Right now this, besides cleanup, docs and syntax leaves only one real issue I know of. Which is the question what EXCLUDED actually refers to. Consider a table blarg(key int primary key, data text); with a BEFORE INSERT

[HACKERS] initdb start server recommendation

2015-05-01 Thread Bruce Momjian
Currently initdb outputs suggested text on starting the server: Success. You can now start the database server using: /u/pgsql/bin/postgres -D /u/pgsql/data or /u/pgsql/bin/pg_ctl -D /u/pgsql/data -l logfile start I am now thinking pg_ctl should

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Petr Jelinek
On 01/05/15 16:10, Andres Freund wrote: On 2015-05-01 10:06:42 -0400, Robert Haas wrote: On Fri, May 1, 2015 at 9:58 AM, Andres Freund and...@anarazel.de wrote: would you rather have EXCLUDED.data refer to the tuple version from VALUES (or a SELECT or ...) or to version from the BEFORE

Re: [HACKERS] pg_rewind test race condition..?

2015-05-01 Thread Stephen Frost
Heikki, * Heikki Linnakangas (hlinn...@iki.fi) wrote: On 04/29/2015 06:03 AM, Stephen Frost wrote: Forcing a checkpoint in the regression tests and then providing a better error message sounds reasonable to me. I agree that it's very unlikely to happen in the real world, even when you're

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: Test for 3000 elements: Original Patch Integer55sec 8sec Numeric 341sec 8sec Quicksort is about 3x faster -- so a benefit of this patch is clear. Yeah, the patch should pretty much blow the

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Tom Lane
Robert Haas robertmh...@gmail.com writes: In the OP, he suggested on the order of 100. Maybe we could just go with 100. I'm OK with that in view of 87h9trs0zm@news-spur.riddles.org.uk and some experiments of my own, but I wonder why we are only thinking of to_tsvector. Isn't to_tsquery,

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Andres Freund
On 2015-05-01 11:11:14 -0700, Tom Lane wrote: Pavel Stehule pavel.steh...@gmail.com writes: I am looking on this patch, but it cannot be applied now. lxml2 -lssl -lcrypto -lrt -lcrypt -ldl -lm -o postgres utils/fmgrtab.o:(.rodata+0x2678): undefined reference to `array_append'

Re: [HACKERS] Implementing SQL ASSERTION

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 6:36 PM, Joe Wildish joe-postgresql@elusive.cx wrote: I’m wondering if there are other people out there working on implementing SQL ASSERTION functionality? I’ve recently spent a bit of time looking to implement the execution models described in “Applied

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-05-01 11:11:14 -0700, Tom Lane wrote: What are you trying to apply it to? I see array_append() in src/backend/utils/adt/array_userfuncs.c in HEAD. Also, are you checking the 1.1 version of the patch? That's very likely due to the transforms

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Tom Lane
Pavel Stehule pavel.steh...@gmail.com writes: I am looking on this patch, but it cannot be applied now. lxml2 -lssl -lcrypto -lrt -lcrypt -ldl -lm -o postgres utils/fmgrtab.o:(.rodata+0x2678): undefined reference to `array_append' utils/fmgrtab.o:(.rodata+0x2698): undefined reference to

Re: [HACKERS] cost_index() and path row estimate.

2015-05-01 Thread Tom Lane
Bernd Helmle maili...@oopsware.de writes: While looking into a customer performance problem, i saw this in costsize.c, cost_index() (9.3.6, but it looks the same in HEAD): ... What i'm wondering is the else branch, where the baserel row estimate is assigned to the IndexPath. However, it

Re: [HACKERS] Manipulating complex types as non-contiguous structures in-memory

2015-05-01 Thread Pavel Stehule
2015-05-01 20:11 GMT+02:00 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I am looking on this patch, but it cannot be applied now. lxml2 -lssl -lcrypto -lrt -lcrypt -ldl -lm -o postgres utils/fmgrtab.o:(.rodata+0x2678): undefined reference to `array_append'

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-01 Thread Sawada Masahiko
On Fri, May 1, 2015 at 6:24 AM, David Steele da...@pgmasters.net wrote: On 4/30/15 6:05 AM, Fujii Masao wrote: On Thu, Apr 30, 2015 at 12:57 PM, Sawada Masahiko sawada.m...@gmail.com wrote: I have changed the status this to Ready for Committer. The specification of session audit logging

Re: [HACKERS] Loss of some parts of the function definition

2015-05-01 Thread Jim Nasby
On 4/30/15 6:44 AM, Sergey Grinko wrote: Now create a script in the application of its function parameters and return values can be declared using %TYPE. However, when you save the script is stored inside the server only what is considered his body. Thus, we obtain: ... We actually mung things

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Peter Geoghegan
On Fri, May 1, 2015 at 7:47 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Hmm, so it was stuck for half an hour at that point? Why do you think it was a livelock? This is the same server that I shared credentials with you for. Feel free to ssh in and investigate it yourself. I logged in,

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Robert Haas
On Fri, May 1, 2015 at 4:53 PM, Jim Nasby jim.na...@bluetreble.com wrote: ISTR a comment to the effect of the SQL standard effectively requires current behavior. I'd be astonished. The SQL standard doesn't even know that there is such a thing as an index, so I presume it doesn't dictate the

Re: [HACKERS] Broken handling of NULLs in TG_ARGV

2015-05-01 Thread Jim Nasby
On 4/30/15 6:44 PM, Tom Lane wrote: There isn't any such thing as a genuine SQL NULL argument; the examples you provided are just text strings, not SQL NULLs. In order to make them be actual nulls, we would have to redefine the arguments as being expressions of some sort, which is problematic

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Jim Nasby
On 4/30/15 6:35 AM, Robert Haas wrote: On Thu, Apr 30, 2015 at 12:44 AM, Chris Rogers teuk...@gmail.com wrote: Has there been any movement on this in the last couple years? I could really use the ability to optimize across CTE boundaries, and it seems like a lot of other people could too.

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Tom Lane
Jim Nasby jim.na...@bluetreble.com writes: On 4/30/15 6:35 AM, Robert Haas wrote: On Thu, Apr 30, 2015 at 12:44 AM, Chris Rogers teuk...@gmail.com wrote: I could really use the ability to optimize across CTE boundaries, and it seems like a lot of other people could too. I'm not aware that

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread Peter Geoghegan
On Fri, May 1, 2015 at 2:36 PM, Robert Haas robertmh...@gmail.com wrote: On Fri, May 1, 2015 at 4:53 PM, Jim Nasby jim.na...@bluetreble.com wrote: ISTR a comment to the effect of the SQL standard effectively requires current behavior. I'd be astonished. The SQL standard doesn't even know

Re: [HACKERS] CTE optimization fence on the todo list?

2015-05-01 Thread David Steele
On 5/1/15 5:39 PM, Tom Lane wrote: Jim Nasby jim.na...@bluetreble.com writes: On 4/30/15 6:35 AM, Robert Haas wrote: On Thu, Apr 30, 2015 at 12:44 AM, Chris Rogers teuk...@gmail.com wrote: I could really use the ability to optimize across CTE boundaries, and it seems like a lot of other

Re: [HACKERS] Missing importing option of postgres_fdw

2015-05-01 Thread Etsuro Fujita
On 2015/04/30 17:15, Etsuro Fujita wrote: On 2015/04/30 2:10, Robert Haas wrote: On Mon, Apr 27, 2015 at 7:47 AM, Michael Paquier michael.paqu...@gmail.com wrote: Authorizing ALTER FOREIGN TABLE as query string that a FDW can use with IMPORT FOREIGN SCHEMA is a different feature than what is

Re: [HACKERS] Auditing extension for PostgreSQL (Take 2)

2015-05-01 Thread David Steele
On 5/1/15 5:58 AM, Sawada Masahiko wrote: On Fri, May 1, 2015 at 6:24 AM, David Steele da...@pgmasters.net wrote: May 15th is the feature freeze, so that does give a little time. It's not clear to me what a self-contained part of the patch would be. If you have specific ideas on what could

Re: [HACKERS] initdb -S and tablespaces

2015-05-01 Thread Abhijit Menon-Sen
At 2015-05-01 08:10:16 -0400, robertmh...@gmail.com wrote: It seems to me that, at a minimum, it would be good to split those controversial and definitely not-back-patchable changes into their own patch. OK, split here (0002*). I do mind putting it into xlog.c instead of some place that's

Re: [HACKERS] transforms vs. CLOBBER_CACHE_ALWAYS

2015-05-01 Thread Andrew Dunstan
On 04/30/2015 09:09 PM, Christian Ullrich wrote: * Andrew Dunstan: friarbird is a FreeBSD buildfarm animal running with -DCLOBBER_CACHE_ALWAYS. It usually completes a run in about 6.5 hours. However, it's been stuck since Monday running the plpython regression tests. The only relevant commit

Re: Custom/Foreign-Join-APIs (Re: [HACKERS] [v9.5] Custom Plan API)

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 5:21 PM, Kouhei Kaigai kai...@ak.jp.nec.com wrote: I wanted to submit the v14 after the above items get clarified. The attached patch (v14) includes all what you suggested in the previous message. Committed, after heavily working over the documentation, and with some

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to this. Can you show me the commit? --- Dne 1.5.2015 3:11 napsal uživatel

Re: [HACKERS] PATCH: adaptive ndistinct estimator v4

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:20 PM, Tomas Vondra tomas.von...@2ndquadrant.com wrote: I agree that this is not ready for 9.5 - it was meant as an experiment (hence printing the estimate in a WARNING, to make it easier to compare the value to the current estimator). Without that it'd be much more

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 9:34 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Mar 11, 2015 at 02:40:16PM +, Andrew Gierth wrote: An issue that comes up regularly on IRC is that text search queries, especially on relatively modest size tables or for relatively non-selective words, often

Re: [HACKERS] Proposal : REINDEX xxx VERBOSE

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 11:05 PM, Sawada Masahiko sawada.m...@gmail.com wrote: VACUUM has both syntax: with parentheses and without parentheses. I think we should have both syntax for REINDEX like VACUUM does because it would be pain to put parentheses whenever we want to do REINDEX. Are the

Re: [HACKERS] initdb -S and tablespaces

2015-05-01 Thread Robert Haas
On Thu, Apr 30, 2015 at 11:29 PM, Abhijit Menon-Sen a...@2ndquadrant.com wrote: 2. I don't know why it's part of this patch. In 20150115133245.gg5...@awork2.anarazel.de, Andres explained his rationale as follows: «What I am thinking of is that, currently, if you start the server

Re: [HACKERS] cache invalidation for PL/pgsql functions

2015-05-01 Thread Marko Tiikkaja
On 2015-04-28 19:43, Robert Haas wrote: I guess the root of the problem is that PL/plgsql's cache invalidation logic only considers the pg_proc row's TID and xmin when deciding whether to recompile. For base types that's probably OK, but for composite types, not so much. Thoughts? We

Re: [HACKERS] procost for to_tsvector

2015-05-01 Thread Bruce Momjian
On Fri, May 1, 2015 at 07:57:27AM -0400, Robert Haas wrote: On Thu, Apr 30, 2015 at 9:34 PM, Bruce Momjian br...@momjian.us wrote: On Wed, Mar 11, 2015 at 02:40:16PM +, Andrew Gierth wrote: An issue that comes up regularly on IRC is that text search queries, especially on relatively

  1   2   >