Re: [HACKERS] Parallel Seq Scan

2015-07-01 Thread Kouhei Kaigai
a. Infrastructure for parallel execution, like some of the stuff in execparallel.c, heapam.c,tqueue.c, etc and all other generic (non-nodes specific) code. Did you consider passing tuples through the tqueue by reference rather than copying? The page should be pinned by the worker

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 07:52, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao masao.fu...@gmail.com wrote: WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and pg_xlogdump don't seem to properly handle .paritial WAL file. I think that we

[HACKERS] hola-importante

2015-07-01 Thread Milton Labanda
Espero que esto te llegue a tiempo, hice un viaje a Manchester, Inglaterra. Y se me fue robado el bolso con mi Pasaporte Internacional, Tarjetas de Crédito dentro. La Embajada está deseando ayudarme con dejarme tomar un vuelo sin mi Pasaporte, solo que tengo que pagar por el billete y cubrir las

Re: [HACKERS] NULL passed as an argument to memcmp() in parse_func.c

2015-07-01 Thread Andres Freund
On 2015-07-01 10:51:49 -0400, Tom Lane wrote: The problem is that there are multiple risks to manage here. If I were to back-patch that patch, it would actively break any third-party extensions that might be using the formerly-considered-valid technique of passing a NULL array pointer to

[HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Andres Freund
Hi, During the 9.5 cycle, and earlier, the topic of increasing our minimum bar for compilers came up a bunch of times. Specifically whether we still should continue to use C90 as a baseline. I think the time has come to rely at least on some newer features. At the very least I think we should

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Peter Geoghegan
On Wed, Jul 1, 2015 at 9:14 AM, Andres Freund and...@anarazel.de wrote: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it and we go through some ugly lengths to avoid relying

Re: [HACKERS] Refactoring speculative insertion with unique indexes a little

2015-07-01 Thread Peter Geoghegan
On Wed, Jul 1, 2015 at 10:45 AM, Peter Geoghegan p...@heroku.com wrote: On Tue, Jun 30, 2015 at 11:19 AM, Heikki Linnakangas hlinn...@iki.fi wrote: I agree it would be cleaner to have a separate CHECK_UNIQUE_XXX code for speculative insertions. You've defined CHECK_UNIQUE_SPECULATIVE as like

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Josh Berkus
All: Replying to multiple people below. On 07/01/2015 07:15 AM, Fujii Masao wrote: On Tue, Jun 30, 2015 at 2:40 AM, Josh Berkus j...@agliodbs.com wrote: You're confusing two separate things. The primary manageability problem has nothing to do with altering the parameter. The main problem

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Andres Freund
On 2015-07-01 11:19:40 +0100, Simon Riggs wrote: What tricks are being used?? Please explain why taking 2 locks is bad here, yet works fine elsewhere. I didn't say anything about 'bad'. It's more complicated than one lock. Suddenly you have to care about lock ordering and such. The algorithms

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Fujii Masao
On Tue, Jun 30, 2015 at 2:40 AM, Josh Berkus j...@agliodbs.com wrote: On 06/29/2015 01:01 AM, Michael Paquier wrote: On Mon, Jun 29, 2015 at 4:20 AM, Josh Berkus j...@agliodbs.com wrote: Right. Well, another reason we should be using a system catalog and not a single GUC ... The problem by

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 8:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch attached. +#define XLogFileNameExtended(fname, tli, log, seg) Move

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Andres Freund
On 2015-07-01 09:08:11 +0100, Simon Riggs wrote: On 1 July 2015 at 09:00, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jun 30, 2015 at 12:32 PM, Simon Riggs si...@2ndquadrant.com a. the semantics of new LWLock (CommitLock) introduced by patch seems to be different in the sense that

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch attached. +#define XLogFileNameExtended(fname, tli, log, seg) Move this macro to xlog_internal.h because it's used both in pg_standby and

Re: [HACKERS] pg_rewind failure by file deletion in source server

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 2:21 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 06/29/2015 09:44 AM, Michael Paquier wrote: On Mon, Jun 29, 2015 at 4:55 AM, Heikki Linnakangas wrote: But we'll still need to handle the pg_xlog symlink case somehow. Perhaps it would be enough to special-case

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Amit Kapila
On Wed, Jul 1, 2015 at 1:38 PM, Simon Riggs si...@2ndquadrant.com wrote: On 1 July 2015 at 09:00, Amit Kapila amit.kapil...@gmail.com wrote: I think it will be better to partition it or use it in some other way to avoid two concurrent writers block at it, however if you want to first see the

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jun 10, 2015 at 2:41 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, While looking at the code of pg_archivecleanup.c, I noticed that there is some code present to detect if a given string has the format of a WAL segment file name or of a backup file. The recent commit

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 11:14, Andres Freund and...@anarazel.de wrote: On 2015-07-01 09:08:11 +0100, Simon Riggs wrote: On 1 July 2015 at 09:00, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jun 30, 2015 at 12:32 PM, Simon Riggs si...@2ndquadrant.com a. the semantics of new LWLock

Re: [HACKERS] Parallel Seq Scan

2015-07-01 Thread Amit Kapila
On Wed, Jul 1, 2015 at 1:21 PM, Jeff Davis pg...@j-davis.com wrote: On Wed, 2015-07-01 at 11:07 +0530, Amit Kapila wrote: For what you are asking to change name for? There are still some places, at least in the comments, that call it a parallel sequential scan. In the initial version of

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 11:11, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Jul 1, 2015 at 1:38 PM, Simon Riggs si...@2ndquadrant.com wrote: On 1 July 2015 at 09:00, Amit Kapila amit.kapil...@gmail.com wrote: I think it will be better to partition it or use it in some other way to

Re: [HACKERS] Unneeded NULL-pointer check in FreeSpaceMapTruncateRel

2015-07-01 Thread Michael Paquier
On Tue, Jun 30, 2015 at 9:57 PM, Andres Freund and...@anarazel.de wrote: On 2015-06-30 21:53:07 +0900, Michael Paquier wrote: In the category of nitpicky-code-style-issues, FreeSpaceMapTruncateRel is doing a NULL-pointer check for something that has been dereferenced on all the code paths

Re: [HACKERS] pg_basebackup and replication slots

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 10:33 AM, Peter Eisentraut wrote: (If you're looking at the patch and wondering why there is no code to actually do anything with the replication slot, that's because the code that does the WAL streaming is already aware of replication slots because of the pg_receivexlog

Re: [HACKERS] drop/truncate table sucks for large values of shared buffers

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 15:39, Amit Kapila amit.kapil...@gmail.com wrote: Okay. I think we can maintain the list in similar way as we do for UNLINK_RELATION_REQUEST in RememberFsyncRequest(), but why to wait till 64 tables? I meant once per checkpoint cycle OR every N tables, whichever is sooner.

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-01 Thread Sawada Masahiko
On Thu, May 28, 2015 at 11:34 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Apr 30, 2015 at 8:07 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Apr 24, 2015 at 11:21 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Apr 24, 2015 at 1:31 AM, Jim Nasby

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Peter Eisentraut
On 7/1/15 10:15 AM, Fujii Masao wrote: One approach to address this problem is to introduce something like unlogged system catalog. I'm not sure if that causes another big problem, though... Yeah, like the data disappearing after a crash. ;-) -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Sawada Masahiko
On Tue, Jun 30, 2015 at 2:40 AM, Josh Berkus j...@agliodbs.com wrote: On 06/29/2015 01:01 AM, Michael Paquier wrote: You're confusing two separate things. The primary manageability problem has nothing to do with altering the parameter. The main problem is: if there is more than one synch

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-01 Thread Simon Riggs
On 30 April 2015 at 12:07, Sawada Masahiko sawada.m...@gmail.com wrote: This patch lack some point: documentation, comment in source code, etc, so it's WIP patch yet, but I think that it's enough to discuss about this. Code comments exist to indicate the intention of sections of code. They

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Peter Eisentraut
On 6/26/15 1:46 AM, Michael Paquier wrote: - k(elt1,elt2,eltN) means that we need for the k elements in the set to return true (aka commit confirmation). - k[elt1,elt2,eltN] means that we need for the first k elements in the set to return true. I think the difference between (...) and [...]

Re: [HACKERS] drop/truncate table sucks for large values of shared buffers

2015-07-01 Thread Amit Kapila
On Tue, Jun 30, 2015 at 12:10 PM, Simon Riggs si...@2ndquadrant.com wrote: On 30 June 2015 at 07:34, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jun 30, 2015 at 11:00 AM, Simon Riggs si...@2ndquadrant.com wrote: On 30 June 2015 at 05:02, Amit Kapila amit.kapil...@gmail.com wrote:

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Peter Eisentraut
On 6/26/15 1:12 PM, Josh Berkus wrote: If we're going to do quorum, multi-set synchrep, then we need to have a real management interface. Like, we really ought to have a system catalog and some built in functions to manage this instead, e.g. pg_add_synch_set(set_name NAME, quorum INT,

Re: [HACKERS] Macro nesting hell

2015-07-01 Thread Alvaro Herrera
Tom Lane wrote: Last night my ancient HP compiler spit up on HEAD: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelondt=2015-07-01%2001%3A30%3A18 complaining thus: cpp: brin_pageops.c, line 626: error 4018: Macro param too large after substitution - use -H option. I was able

Re: [HACKERS] pg_basebackup and replication slots

2015-07-01 Thread Peter Eisentraut
On 7/1/15 8:37 AM, Michael Paquier wrote: On Wed, Jul 1, 2015 at 10:33 AM, Peter Eisentraut wrote: (If you're looking at the patch and wondering why there is no code to actually do anything with the replication slot, that's because the code that does the WAL streaming is already aware of

Re: [HACKERS] NULL passed as an argument to memcmp() in parse_func.c

2015-07-01 Thread Tom Lane
Piotr Stefaniak postg...@piotr-stefaniak.me writes: On 06/27/2015 11:47 PM, Tom Lane wrote: Given the utter lack of any evidence that this actually causes any problems in the field, I don't feel a need to back-patch this change. I'm under the impression that you don't care about not avoiding

[HACKERS] Macro nesting hell

2015-07-01 Thread Tom Lane
Last night my ancient HP compiler spit up on HEAD: http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pademelondt=2015-07-01%2001%3A30%3A18 complaining thus: cpp: brin_pageops.c, line 626: error 4018: Macro param too large after substitution - use -H option. I was able to revive pademelon by

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Peter Eisentraut
On 6/26/15 2:53 PM, Josh Berkus wrote: I would also suggest that if I lose this battle and we decide to go with a single stringy GUC, that we at least use JSON instead of defining our out, proprietary, syntax? Does JSON have a natural syntax for a set without order? -- Sent via

Re: [HACKERS] Freeze avoidance of very large table.

2015-07-01 Thread Fujii Masao
On Thu, Jul 2, 2015 at 12:13 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, May 28, 2015 at 11:34 AM, Sawada Masahiko sawada.m...@gmail.com wrote: On Thu, Apr 30, 2015 at 8:07 PM, Sawada Masahiko sawada.m...@gmail.com wrote: On Fri, Apr 24, 2015 at 11:21 AM, Sawada Masahiko

[HACKERS] 9.6 commitfest schedule

2015-07-01 Thread Alvaro Herrera
Fellow hackers, As discussed at PGCon's developer meeting, this is the schedule for the upcoming commitfests: CF1: July 1 to July 31 2015 CF2: September 1 to September 30 2015 CF3: November 1 to November 30 2015 CF4: Januart 2 to January 31 2016 CF5: March 1 to March 31 2016 Feature Freeze:

Re: [HACKERS] Parallel Seq Scan

2015-07-01 Thread Gavin Flower
On 01/07/15 17:37, Amit Kapila wrote: On Tue, Jun 30, 2015 at 4:00 AM, Jeff Davis pg...@j-davis.com mailto:pg...@j-davis.com wrote: [Jumping in without catching up on entire thread. [...] . 2. Where is the speedup coming from? How much of it is CPU and IO overlapping (i.e. not leaving

Re: [HACKERS] NULL passed as an argument to memcmp() in parse_func.c

2015-07-01 Thread Tom Lane
Andres Freund and...@anarazel.de writes: On 2015-07-01 10:51:49 -0400, Tom Lane wrote: The problem is that there are multiple risks to manage here. If I were to back-patch that patch, it would actively break any third-party extensions that might be using the formerly-considered-valid

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Tom Lane
Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it pademelon doesn't. Also, I think there are some other non-gcc animals that nominally

Re: [HACKERS] 9.6 commitfest schedule

2015-07-01 Thread Robert Haas
On Wed, Jul 1, 2015 at 3:19 PM, Alvaro Herrera alvhe...@2ndquadrant.com wrote: Also, I'm pleased to announce that Heikki Linnakangas has agreed to be our beloved commitfest manager for CF1; he will be starting on it sometime in the next couple dozen hours or so. Beware, as by now he has

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Andres Freund
On 2015-07-01 16:33:24 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it pademelon doesn't. Oh. I'd gone

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Oskari Saarenmaa
01.07.2015, 23:33, Tom Lane kirjoitti: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it pademelon doesn't. HP-UX 10.20 was

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Tom Lane
Joshua D. Drake j...@commandprompt.com writes: On 07/01/2015 01:33 PM, Tom Lane wrote: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Tom Lane
Peter Geoghegan p...@heroku.com writes: On Wed, Jul 1, 2015 at 9:14 AM, Andres Freund and...@anarazel.de wrote: The list of features, in the order of perceived importance, that might be worthwhile thinking about are: * static inline * variadic macros * designated initializers (e.g.

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Joshua D. Drake
On 07/01/2015 01:33 PM, Tom Lane wrote: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that does not support it pademelon doesn't. Other reasoning aside,

Re: [HACKERS] Refactoring speculative insertion with unique indexes a little

2015-07-01 Thread Peter Geoghegan
On Tue, Jun 30, 2015 at 11:19 AM, Heikki Linnakangas hlinn...@iki.fi wrote: I agree it would be cleaner to have a separate CHECK_UNIQUE_XXX code for speculative insertions. You've defined CHECK_UNIQUE_SPECULATIVE as like CHECK_UNIQUE_PARTIAL, but you don't have to insert the index tuple if

Re: [HACKERS] Refactoring speculative insertion with unique indexes a little

2015-07-01 Thread Peter Geoghegan
On Wed, Jul 1, 2015 at 10:45 AM, Peter Geoghegan p...@heroku.com wrote: You can construct a theoretical case where lock starvation occurs with unique constraint enforcement. I think it helps with nbtree here that someone will reliably *not* see a conflict when concurrently inserting, because

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao masao.fu...@gmail.com wrote: WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and pg_xlogdump don't seem to properly handle .paritial WAL file. I think that we should fix at least pg_archivecleanup, otherwise, in the system using

Re: [HACKERS] Solaris testers wanted for strxfrm() behavior

2015-07-01 Thread Noah Misch
On Tue, Jun 30, 2015 at 09:45:08AM -0400, Tom Lane wrote: Noah Misch n...@leadboat.com writes: On Sun, Jun 28, 2015 at 07:00:14PM -0400, Tom Lane wrote: Another idea would be to make a test during postmaster start to see if this bug exists, and fail if so. I'm generally on board with the

Re: [HACKERS] Parallel Seq Scan

2015-07-01 Thread Jeff Davis
On Wed, 2015-07-01 at 11:07 +0530, Amit Kapila wrote: For what you are asking to change name for? There are still some places, at least in the comments, that call it a parallel sequential scan. a. Infrastructure for parallel execution, like some of the stuff in execparallel.c,

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Amit Kapila
On Tue, Jun 30, 2015 at 12:32 PM, Simon Riggs si...@2ndquadrant.com wrote: ClogControlLock contention is high at commit time. This appears to be due to the fact that ClogControlLock is acquired in Exclusive mode prior to marking commit, which then gets starved by backends running

Re: [HACKERS] pg_rewind failure by file deletion in source server

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 2:21 AM, Heikki Linnakangas hlinn...@iki.fi wrote: Hmm. I'm starting to think that pg_rewind should ignore pg_xlog entirely. In any non-trivial scenarios, just copying all the files from pg_xlog isn't enough anyway, and you need to set up a recovery.conf after running

Re: [HACKERS] Reducing ClogControlLock contention

2015-07-01 Thread Simon Riggs
On 1 July 2015 at 09:00, Amit Kapila amit.kapil...@gmail.com wrote: On Tue, Jun 30, 2015 at 12:32 PM, Simon Riggs si...@2ndquadrant.com wrote: ClogControlLock contention is high at commit time. This appears to be due to the fact that ClogControlLock is acquired in Exclusive mode prior to

Re: [HACKERS] error message diff with Perl 5.22.0

2015-07-01 Thread Tom Lane
Alex Hunsaker bada...@gmail.com writes: (What about the back branches? :D) Indeed. dangomushi is complaining about this in the back branches now. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Simon Riggs
On 2 July 2015 at 03:00, Rahila Syed rahilasye...@gmail.com wrote: Yes, I suggest just a single column on pg_stat_activity called pct_complete Reporting remaining time also can be crucial to make decisions regarding continuing or aborting VACUUM. The same has been suggested in the thread

[HACKERS] Asynchronous execution on FDW

2015-07-01 Thread Kyotaro HORIGUCHI
Hello. This is the new version of FDW async exection feature. The status of this feature is as follows, as of the last commitfest. - Async execution is valuable to have. - But do the first kick in ExecInit phase is wrong. So the design outline of this version is as following, - The patch set

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Amit Langote
On 2015-07-02 AM 11:41, Rahila Syed wrote: Hello, I though about the possibilities of progress visualization - and one possibility is one or two special column in pg_stat_activity table - this info can be interesting for VACUUM started by autovacuum too. Thank you for suggestion. The

Re: [HACKERS] assessing parallel-safety

2015-07-01 Thread Amit Kapila
On Thu, May 21, 2015 at 10:19 PM, Robert Haas robertmh...@gmail.com wrote: On Sat, Mar 21, 2015 at 2:30 PM, Thom Brown t...@linux.com wrote: Looks like one of the patches I applied is newer than the one in your list: HEAD Commit-id: 13a10c0ccd984643ef88997ac177da7c4b7e46a6

Re: [HACKERS] Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file

2015-07-01 Thread Amit Kapila
On Sat, Jun 27, 2015 at 12:54 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jun 15, 2015 at 2:52 PM, Amit Kapila amit.kapil...@gmail.com wrote: Attached patch provides a fix as per above discussion. I think we should emit some LOG messages here. When we detect the file is there:

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 11:58 PM, Sawada Masahiko wrote: On Tue, Jun 30, 2015 at 2:40 AM, Josh Berkus wrote: BTW, ALTER SYSTEM is a strong reason to use JSON for the synch rep GUC (assuming it's one parameter) instead of some custom syntax. If it's JSON, we can validate it in psql, whereas if

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 5:14 PM, Simon Riggs si...@2ndquadrant.com wrote: On 1 July 2015 at 07:52, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 12:39 PM, Fujii Masao masao.fu...@gmail.com wrote: WAL-related tools, i.e., pg_archivecleanup, pg_resetxlog and

Re: ctidscan as an example of custom-scan (Re: [HACKERS] [v9.5] Custom Plan API)

2015-07-01 Thread Kouhei Kaigai
Folks, Moved this patch to next CF 2015-02 because of lack of review(ers). Do we still need this patch as contrib module? It was originally required it as example of custom-scan interface last summer, however, here was no strong requirement after that, then, it was bumped to v9.6 development

[HACKERS] Re: Removing SSL renegotiation (Was: Should we back-patch SSL renegotiation fixes?)

2015-07-01 Thread Noah Misch
On Sat, Jun 27, 2015 at 06:13:36PM +0200, Andres Freund wrote: On 2015-06-27 12:10:49 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: On 2015-06-27 15:07:05 +0900, Michael Paquier wrote: +1 for removing on master and just disabling on back-branches. The problem with

Re: [HACKERS] pg_file_settings view vs. Windows

2015-07-01 Thread Noah Misch
On Sat, Jun 27, 2015 at 07:20:43PM -0400, Tom Lane wrote: Tatsuo Ishii is...@postgresql.org writes: I noticed that in EXEC_BACKEND builds (ie, Windows) the pg_file_settings view doesn't act as its author presumably intended. Specifically, it reads as empty until/unless the current session

Re: [HACKERS] Support for N synchronous standby servers - take 2

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 11:45 PM, Peter Eisentraut pete...@gmx.net wrote: On 6/26/15 1:46 AM, Michael Paquier wrote: - k(elt1,elt2,eltN) means that we need for the k elements in the set to return true (aka commit confirmation). - k[elt1,elt2,eltN] means that we need for the first k elements in

Re: [HACKERS] error message diff with Perl 5.22.0

2015-07-01 Thread Michael Paquier
On Thu, Jul 2, 2015 at 11:56 AM, Tom Lane t...@sss.pgh.pa.us wrote: Alex Hunsaker bada...@gmail.com writes: (What about the back branches? :D) Indeed. dangomushi is complaining about this in the back branches now. Yep, perl 5.22 is used there. -- Michael -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Sameer Thakur
Hello, Thank you for suggestion. The design with hooks and a separate view was mainly to keep most of the code outside core as the feature proposed is specific to VACUUM command. Also, having a separate view can give more flexibility in terms of displaying various progress parameters. FWIW ,there

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Guillaume Lelarge
Le 2 juil. 2015 7:28 AM, Simon Riggs si...@2ndquadrant.com a écrit : On 2 July 2015 at 03:00, Rahila Syed rahilasye...@gmail.com wrote: Yes, I suggest just a single column on pg_stat_activity called pct_complete Reporting remaining time also can be crucial to make decisions regarding

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Michael Paquier
On Thu, Jul 2, 2015 at 10:37 AM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 9:53 PM, Fujii Masao wrote: +/* Length of XLog file name */ +#define XLOG_DATA_FNAME_LEN 24 Shorten the name of this macro variable, to XLOG_FNAME_LEN, for more code readability. Thanks. You have more talent

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Rahila Syed
Hello, Thank you for suggestions. Yes, I suggest just a single column on pg_stat_activity called pct_complete Reporting remaining time also can be crucial to make decisions regarding continuing or aborting VACUUM. The same has been suggested in the thread below,

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2015-07-01 Thread Rahila Syed
Hello, I though about the possibilities of progress visualization - and one possibility is one or two special column in pg_stat_activity table - this info can be interesting for VACUUM started by autovacuum too. Thank you for suggestion. The design with hooks and a separate view was mainly to

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Tom Lane
Andres Freund and...@anarazel.de writes: Since, buildfarm/quiet inline test issues aside, pademelon is the only animal not supporting inlines and varargs, I think we should just go ahead and start to use both. I'm good with using inlines, since as I pointed out upthread, that won't actually

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Andres Freund
On 2015-07-01 19:05:08 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: Since, buildfarm/quiet inline test issues aside, pademelon is the only animal not supporting inlines and varargs, I think we should just go ahead and start to use both. I'm good with using inlines,

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Andres Freund
On 2015-07-01 23:39:06 +0200, Andres Freund wrote: On 2015-07-01 16:33:24 -0400, Tom Lane wrote: Andres Freund and...@anarazel.de writes: At the very least I think we should start to rely on 'static inline's working. There is not, and hasn't been for a while, any buildfarm animal that

Re: [HACKERS] Raising our compiler requirements for 9.6

2015-07-01 Thread Andres Freund
On 2015-07-02 00:15:14 +0200, Andres Freund wrote: animal OS compiler inline quiet inline varargs brolga cygwin gcc-4.3 yy 4.3 obviously supports varargs. Human error. pademelonHP-UX 10.2 HP C

Re: [HACKERS] More logging for autovacuum

2015-07-01 Thread Gurjeet Singh
On Fri, Aug 17, 2007 at 3:14 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Gregory Stark wrote: I'm having trouble following what's going on with autovacuum and I'm finding the existing logging insufficient. In particular that it's only logging vacuum runs *after* the vacuum

Re: [HACKERS] raw output from copy

2015-07-01 Thread Pavel Golub
Hello Pavel. I looked through the patch. Sources are OK. However I didn't find any docs and test cases. Would you please provide me with short description on this feature and why it is important. Because I didn't manage to find the old Andrew Dunstan's post either. On Sat, Apr 11, 2015 at 12:26

Re: [HACKERS] Parallel Seq Scan

2015-07-01 Thread Amit Langote
On 2015-07-01 PM 02:37, Amit Kapila wrote: In terms of completeness, I think we should add some documentation for this patch, one way is to update about the execution mechanism in src/backend/access/transam/README.parallel and then explain about new configuration knobs in documentation

Re: [HACKERS] WAL-related tools and .paritial WAL file

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 2:52 PM, Amit Kapila amit.kapil...@gmail.com wrote: On Wed, Jul 1, 2015 at 9:09 AM, Fujii Masao masao.fu...@gmail.com wrote: Also regarding pg_xlogdump, we can just document, for example, please get rid of .paritial suffix from the WAL file name if you want to dump it

Re: [HACKERS] Bug in bttext_abbrev_convert()

2015-07-01 Thread Michael Paquier
On Wed, Jul 1, 2015 at 2:38 PM, Peter Geoghegan p...@heroku.com wrote: On Tue, Jun 30, 2015 at 10:35 PM, Peter Geoghegan p...@heroku.com wrote: The regression tests have zero coverage for this tuplesort_performsort() btspool2 case. That's a fairly common case to have no coverage for, and that

Re: [HACKERS] drop/truncate table sucks for large values of shared buffers

2015-07-01 Thread Amit Kapila
On Wed, Jul 1, 2015 at 8:26 PM, Simon Riggs si...@2ndquadrant.com wrote: On 1 July 2015 at 15:39, Amit Kapila amit.kapil...@gmail.com wrote: Okay. I think we can maintain the list in similar way as we do for UNLINK_RELATION_REQUEST in RememberFsyncRequest(), but why to wait till 64 tables?

Re: [HACKERS] error message diff with Perl 5.22.0

2015-07-01 Thread Alex Hunsaker
On Sat, Jun 6, 2015 at 7:03 PM, Peter Eisentraut pete...@gmx.net wrote: With the recently released Perl 5.22.0, the tests fail thus: -ERROR: Global symbol $global requires explicit package name at line 3. -Global symbol $other_global requires explicit package name at line 4. +ERROR: Global

Re: [HACKERS] Expending the use of xlog_internal.h's macros

2015-07-01 Thread Fujii Masao
On Wed, Jul 1, 2015 at 9:53 PM, Fujii Masao masao.fu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:58 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Wed, Jul 1, 2015 at 8:18 PM, Fujii Masao wrote: On Wed, Jul 1, 2015 at 8:16 PM, Fujii Masao wrote: I updated the patch as follows. Patch