Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-10-03 Thread Amit Langote
Hi, On 2016/10/04 13:26, Ashutosh Bapat wrote: >>> >>> Why always rollback any dangling transaction? There can be a case that >>> a foreign server has a dangling transaction which needs to be >>> committed because the portions of that transaction on the other shards >>> are committed. >> >>

Re: [HACKERS] Hash Indexes

2016-10-03 Thread Amit Kapila
On Tue, Oct 4, 2016 at 10:06 AM, Amit Kapila wrote: > On Thu, Sep 29, 2016 at 8:27 PM, Amit Kapila wrote: >> On Thu, Sep 29, 2016 at 6:04 AM, Robert Haas wrote: >>> On Wed, Sep 28, 2016 at 3:04 PM, Robert Haas

[HACKERS] Un-include access/heapam.h

2016-10-03 Thread Amit Langote
I noticed that un-including access/heapam.h from the following files leaves things just fine. src/backend/commands/aggregatecmds.c src/backend/commands/collationcmds.c src/backend/commands/conversioncmds.c src/backend/commands/lockcmds.c It seems any calls into heapam.c that there used to be

Re: [HACKERS] Hash Indexes

2016-10-03 Thread Amit Kapila
On Thu, Sep 29, 2016 at 8:27 PM, Amit Kapila wrote: > On Thu, Sep 29, 2016 at 6:04 AM, Robert Haas wrote: >> On Wed, Sep 28, 2016 at 3:04 PM, Robert Haas wrote: >> >> As I was looking at the old text regarding deadlock risk,

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-10-03 Thread Ashutosh Bapat
>> >> Why always rollback any dangling transaction? There can be a case that >> a foreign server has a dangling transaction which needs to be >> committed because the portions of that transaction on the other shards >> are committed. > > Right, we can heuristically make a decision whether we do

Re: [HACKERS] multivariate statistics (v19)

2016-10-03 Thread Michael Paquier
On Mon, Oct 3, 2016 at 8:25 PM, Heikki Linnakangas wrote: > Yeah. The idea was to use something like pg_node_tree to store all the > different kinds of statistics, the histogram, the MCV, and the functional > dependencies, in one datum. Or JSON, maybe. It sounds better than an

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-10-03 Thread Masahiko Sawada
On Wed, Sep 28, 2016 at 3:30 PM, Ashutosh Bapat wrote: > On Wed, Sep 28, 2016 at 10:43 AM, Masahiko Sawada > wrote: >> On Tue, Sep 27, 2016 at 9:06 PM, Ashutosh Bapat >> wrote: >>> On Tue, Sep 27, 2016 at

Re: [HACKERS] Tracking wait event for latches

2016-10-03 Thread Michael Paquier
On Tue, Oct 4, 2016 at 1:55 AM, Robert Haas wrote: > On Mon, Oct 3, 2016 at 3:30 AM, Michael Paquier > wrote: >> [ new patch ] > > I think this is unnecessarily awkward for callers; the attached > version takes a different approach which I think

Re: [HACKERS] pageinspect: Hash index support

2016-10-03 Thread Michael Paquier
On Mon, Oct 3, 2016 at 9:52 PM, Jesper Pedersen wrote: > Maybe "Returned with Feedback" is more appropriate, as there is still > development left. I have switched it to "waiting on author". -- Michael -- Sent via pgsql-hackers mailing list

[HACKERS] pnstrdup considered armed and dangerous

2016-10-03 Thread Andres Freund
Hi, A colleage of me just wrote innocent looking code like char *shardRelationName = pnstrdup(relationName, NAMEDATALEN); which is at the moment wrong if relationName isn't preallocated to NAMEDATALEN size. /* * pnstrdup * Like pstrdup(), but append null byte to a *

Re: [HACKERS] Question / requests.

2016-10-03 Thread Alvaro Herrera
Robert Haas wrote: > On Fri, Sep 30, 2016 at 11:20 AM, Francisco Olarte > wrote: > > After some messages due to vacuumdb auto-deadlocking itself on the > > system tables when doing paralell vacuum of a full database I > > suggested adding some flags to make vacuumdb

Re: [HACKERS] proposal: psql \setfileref

2016-10-03 Thread Gilles Darold
Le 03/10/2016 à 23:03, Robert Haas a écrit : > On Mon, Oct 3, 2016 at 3:54 PM, Gilles Darold wrote: >> 4) An other problem is that like this this patch will allow anyone to upload >> into a >> column the content of any system file that can be read by postgres system >> user

Re: [HACKERS] proposal: psql \setfileref

2016-10-03 Thread Robert Haas
On Mon, Oct 3, 2016 at 3:54 PM, Gilles Darold wrote: > 4) An other problem is that like this this patch will allow anyone to upload > into a > column the content of any system file that can be read by postgres system user > and then allow non system user to read its content.

Re: [HACKERS] asynchronous execution

2016-10-03 Thread Robert Haas
On Wed, Sep 28, 2016 at 12:30 AM, Amit Khandekar wrote: > On 24 September 2016 at 06:39, Robert Haas wrote: >> Since Kyotaro Horiguchi found that my previous design had a >> system-wide performance impact due to the ExecProcNode changes, I >>

Re: [HACKERS] Learning to hack Postgres - Keeping track of ctids

2016-10-03 Thread Robert Haas
On Mon, Oct 3, 2016 at 4:30 PM, Emrul wrote: > I suspect you're right. I've looked at the code and it will be very difficult > (especially if I want to do it as an extension rather than patching > Postgres) and with all the stuff I'd need to do to make it work you're also > right

Re: [HACKERS] Learning to hack Postgres - Keeping track of ctids

2016-10-03 Thread Emrul
I suspect you're right. I've looked at the code and it will be very difficult (especially if I want to do it as an extension rather than patching Postgres) and with all the stuff I'd need to do to make it work you're also right that it probably won't improve upon just using primary key Ids. I've

Re: [HACKERS] Question / requests.

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 11:20 AM, Francisco Olarte wrote: > After some messages due to vacuumdb auto-deadlocking itself on the > system tables when doing paralell vacuum of a full database I > suggested adding some flags to make vacuumdb process schemas. I was > asked

Re: [HACKERS] Learning to hack Postgres - Keeping track of ctids

2016-10-03 Thread Robert Haas
On Thu, Sep 29, 2016 at 4:15 PM, Emrul wrote: > What I'd like to do is store a reference to all the links from one record > using an array type that stores links to all related tables. > > At first, I've succeeded in doing this using primary key Ids and this works > fine.

[HACKERS] Re: [GENERAL] Understanding “max_wal_size” and “min_wal_size” parameters default values from postgresql.conf file

2016-10-03 Thread otar shavadze
Thank you very much On Mon, Oct 3, 2016 at 11:46 PM, Tom Lane wrote: > otar shavadze writes: > > name | setting | unit-- > > max_wal_size | 64 | > > min_wal_size | 5| > > > I have 2 questions: > > >

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Pavel Stehule
2016-10-03 22:03 GMT+02:00 Tom Lane : > Pavel Stehule writes: > > 2016-10-03 21:54 GMT+02:00 Robert Haas : > >> On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: > >>> Personally I'm on the edge of washing my

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Tom Lane
Pavel Stehule writes: > 2016-10-03 21:54 GMT+02:00 Robert Haas : >> On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: >>> Personally I'm on the edge of washing my hands of the whole thing... >> The hand-washing strategy has a

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Pavel Stehule
2016-10-03 21:54 GMT+02:00 Robert Haas : > On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: > > Well, alternatively, can we get a consensus for doing that? People > > did speak against removing PL source code from \df+ altogether, but > > maybe they're

Re: [HACKERS] proposal: psql \setfileref

2016-10-03 Thread Gilles Darold
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, failed Spec compliant: tested, failed Documentation:not tested Contents & Purpose == This patch adds a new

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
On 2016-10-03 15:40:12 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2016-10-03 14:49:20 -0400, Tom Lane wrote: > >> ... ignoring unresolved symbols in shlibs is the default > >> on Linux, and while you can make it throw errors, that just leads to > >> errors for all

Re: [HACKERS] Showing parallel status in \df+

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 8:47 PM, Tom Lane wrote: > Well, alternatively, can we get a consensus for doing that? People > did speak against removing PL source code from \df+ altogether, but > maybe they're willing to reconsider if the alternative is doing nothing. > >

Re: [HACKERS] "Re: Question about grant create on database and pg_dump/pg_dumpall

2016-10-03 Thread Robert Haas
On Thu, Sep 29, 2016 at 11:29 AM, Tom Lane wrote: > The fundamental thing we have to do in order to move forward on this is > to rethink what's the division of labor between pg_dump and pg_dumpall. > I find the patch as presented quite unacceptable because it's made no >

Re: [HACKERS] [GENERAL] Understanding “max_wal_size” and “min_wal_size” parameters default values from postgresql.conf file

2016-10-03 Thread Tom Lane
otar shavadze writes: > name | setting | unit-- > max_wal_size | 64 | > min_wal_size | 5| > I have 2 questions: > 1) Why these values doesn't match default values, which are shown in docs? > I never changed config

Re: [HACKERS] [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.

2016-10-03 Thread Robert Haas
On Mon, Oct 3, 2016 at 3:33 PM, Kevin Grittner wrote: >> Anyway, we've probably beaten this horse to death. > > Just to be sure of that, I'll cite the Chicago Manual of Style (my > preferred style guide), which seems to chart a course somewhere in > the middle: > >

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Tom Lane
Andres Freund writes: > On 2016-10-03 14:49:20 -0400, Tom Lane wrote: >> ... ignoring unresolved symbols in shlibs is the default >> on Linux, and while you can make it throw errors, that just leads to >> errors for all the references into the core backend. Not very helpful.

Re: [HACKERS] contrib/pg_visibility craps out in assert-enabled builds

2016-10-03 Thread Tom Lane
Robert Haas writes: > On Fri, Sep 30, 2016 at 10:24 PM, Tom Lane wrote: >> The problem seems to be that HeapTupleSatisfiesVacuum asserts >> Assert(ItemPointerIsValid(>t_self)); >> while collect_corrupt_items hasn't bothered to set up the t_self >> field

Re: [HACKERS] [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.

2016-10-03 Thread Kevin Grittner
On Mon, Oct 3, 2016 at 9:22 AM, Tom Lane wrote: > Robert Haas writes: >> Sure, I'm not arguing with trying to be formal. The grammatical rule >> that you're describing doesn't exist for me, though. I believe that >> "that" can only introduce a

Re: [HACKERS] Proposal: ON UPDATE REMOVE foreign key action

2016-10-03 Thread Vitaly Burovoy
On 10/3/16, Kirill Berezin wrote: > *One-line Summary:* On foreign key update we unable to remove all depended > records. Currently we have "ON REMOVE CASCADE DELETE", but no "ON UPDATE > CASCADE DELETE". We can only update field to NULL or DEFAULT. I think there are three

Re: [HACKERS] Rename max_parallel_degree?

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 12:23 PM, Julien Rouhaud wrote: > I've already fixed every other issues mentioned upthread, but I'm facing > a problem for this one. Assuming that the bgworker classes are supposed > to be mutually exclusive, I don't see a simple and clean way

Re: [HACKERS] contrib/pg_visibility craps out in assert-enabled builds

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 10:24 PM, Tom Lane wrote: > So I tried using pg_visibility's pg_check_visible() as part of > testing the business with pg_upgrade generating faulty visibility > maps on bigendian servers, and it instantly generated an assert > failure here: > > #2

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
On 2016-10-03 14:49:20 -0400, Tom Lane wrote: > > On 2016-10-03 12:29:18 -0400, Tom Lane wrote: > >> The patch seems pretty successful in terms of being noninvasive to > >> the code. I think the major objection to it would be that we no > >> longer have any direct compiler-verified connection

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Tom Lane
Andres Freund writes: > On 2016-10-03 12:29:18 -0400, Tom Lane wrote: >> The patch seems pretty successful in terms of being noninvasive to >> the code. I think the major objection to it would be that we no >> longer have any direct compiler-verified connection between the >>

Re: [HACKERS] Macro customizable hashtable / bitmapscan & aggregation perf

2016-10-03 Thread Andres Freund
Hi, On 2016-10-03 13:26:09 +0200, Arthur Silva wrote: > On Sat, Oct 1, 2016 at 2:44 AM, Andres Freund wrote: > A couple of comments. > * 80% occupancy is a bit conservative for RH hashing, it works well up to > 90% if you use the early stops due to distance. So that TODO is

Re: [HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Andres Freund
Hi, On 2016-10-03 12:29:18 -0400, Tom Lane wrote: > The patch seems pretty successful in terms of being noninvasive to > the code. I think the major objection to it would be that we no > longer have any direct compiler-verified connection between the > signatures of the called functions in

Re: [HACKERS] pgbench more operators & functions

2016-10-03 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> It already is a script, it's just hardwired as a string constant in > >> pgbench.c rather than being a separate file. I think Fabien is > >> suggesting that it could

Re: [HACKERS] pgbench more operators & functions

2016-10-03 Thread Tom Lane
Stephen Frost writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> It already is a script, it's just hardwired as a string constant in >> pgbench.c rather than being a separate file. I think Fabien is >> suggesting that it could be changed to more nearly approximate the >>

Re: [HACKERS] pgbench more operators & functions

2016-10-03 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Fabien COELHO (coe...@cri.ensmp.fr) wrote: > >> Indeed, some kind of "if" is needed, for instance to implement > >> "tpc-b" correctly. > > > That's an interesting point.. Have you thought about ripping out

Re: [HACKERS] Hash Indexes

2016-10-03 Thread Tom Lane
Jeff Janes writes: > I've done a simple comparison using pgbench's default transaction, in which > all the primary keys have been dropped and replaced with indexes of either > hash or btree type, alternating over many rounds. > I run 'pgbench -c16 -j16 -T 900 -M prepared'

Re: [HACKERS] Hash Indexes

2016-10-03 Thread Jeff Janes
On Thu, Sep 29, 2016 at 5:14 PM, Robert Haas wrote: > On Thu, Sep 29, 2016 at 8:07 PM, Peter Geoghegan wrote: > > On Wed, Sep 28, 2016 at 8:06 PM, Andres Freund > wrote: > >> On 2016-09-28 15:04:30 -0400, Robert Haas wrote: > >>>

Re: [HACKERS] Tracking wait event for latches

2016-10-03 Thread Robert Haas
On Mon, Oct 3, 2016 at 3:30 AM, Michael Paquier wrote: > [ new patch ] I think this is unnecessarily awkward for callers; the attached version takes a different approach which I think will be more convenient. The attached version also (1) moves a lot more of the logic

Re: [HACKERS] pgbench more operators & functions

2016-10-03 Thread Tom Lane
Stephen Frost writes: > * Fabien COELHO (coe...@cri.ensmp.fr) wrote: >> In the attached patched I only included pg operators, plus "xor" >> which I feel is missing and does not seem to harm. > I'm pretty sure we should hold off on adding 'xor' until it's actually > in PG

[HACKERS] Removing link-time cross-module refs in contrib

2016-10-03 Thread Tom Lane
Pursuant to Andres' suggestion in https://www.postgresql.org/message-id/20161002223927.57xns3arkdg4h...@alap3.anarazel.de attached is a draft patch that gets rid of link-time references from hstore_plpython to both hstore and plpython. I've verified that this allows "LOAD 'hstore_plpython'" to

[HACKERS] Proposal: ON UPDATE REMOVE foreign key action

2016-10-03 Thread Kirill Berezin
*One-line Summary:* On foreign key update we unable to remove all depended records. Currently we have "ON REMOVE CASCADE DELETE", but no "ON UPDATE CASCADE DELETE". We can only update field to NULL or DEFAULT. *Business Use-case:* Cache expiration on hash/version update. Revoke all access on

Re: [HACKERS] pgbench more operators & functions

2016-10-03 Thread Stephen Frost
Fabien, * Fabien COELHO (coe...@cri.ensmp.fr) wrote: > >>bitwise: <<, >>, &, |, ^/#, ~ > >>comparisons: =/==, <>/!=, <, <=, >, >= > >>logical: and/&&, or/||, xor/^^, not, ! > > > >I'm not sure that we want to introduce operators '&&', '||' as logical > >'and' and 'or' when those have specific

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2016-10-03 Thread Daniel Verite
Craig Ringer wrote: > I think it's mostly of interest to app authors and driver developers > and that's what it's aimed at. pg_restore could benefit a lot too. Wouldn't pgbench benefit from it? It was mentioned some time ago [1], in relationship to the \into construct, how client-server

Re: [HACKERS] COPY command with RLS bug

2016-10-03 Thread Stephen Frost
* Michael Paquier (michael.paqu...@gmail.com) wrote: > On Sat, Oct 1, 2016 at 3:11 AM, Stephen Frost wrote: > > Comments and testing welcome, of course, though it's looking pretty good > > to me at this point and I'll likely commit it in another day or two > > unless issues

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-10-03 Thread Tom Lane
Robert Haas writes: > I think the tests for PQserverVersion(conn) / 100 >= 1000 are strange. > I submit that either PQserverVersion(conn) >= 10 or > PQserverVersion(conn) / 1 >= 10 is an easier-to-understand test. > I vote for the first style. +1, that's the way

Re: [HACKERS] [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.

2016-10-03 Thread Tom Lane
Robert Haas writes: > Sure, I'm not arguing with trying to be formal. The grammatical rule > that you're describing doesn't exist for me, though. I believe that > "that" can only introduce a restrictive clause, whereas "which" can > introduce either a descriptive or a

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-10-03 Thread Christoph Berg
Re: Michael Paquier 2016-09-30

Re: [HACKERS] Patch to implement pg_current_logfile() function

2016-10-03 Thread Christoph Berg
Hi Gilles, I've just tried v4 of the patch. The OID you picked for pg_current_logfile doesn't work anymore, but after increasing it randomly by 1, it compiles. I like the added functionality, especially that "select pg_read_file(pg_current_logfile());" just works. What bugs me is the new

Re: [HACKERS] Decoding proacl

2016-10-03 Thread Stephen Frost
Greetings Bene, * Benedikt Grundmann (bgrundm...@janestreet.com) wrote: > I'm trying to understand how to decode proacl in pg_proc. The > documentation says: > > PostgreSQL grants default privileges on some types of objects to PUBLIC. > ... EXECUTE privilege for functions; ... Also, these

Re: [HACKERS] [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.

2016-10-03 Thread Robert Haas
On Mon, Oct 3, 2016 at 8:51 AM, Tom Lane wrote: > Robert Haas writes: >> Why do you keep insisting on changing case where I've written "which" >> to instead say "that" in situations where AFAIK either is perfectly >> correct? I find such changes at

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-10-03 Thread Robert Haas
On Fri, Sep 30, 2016 at 1:45 AM, Michael Paquier wrote: > As there have been no reviews at code level, I am moving that to the next CF. Code review of 0001: I think the tests for PQserverVersion(conn) / 100 >= 1000 are strange. I submit that either

Re: [HACKERS] pageinspect: Hash index support

2016-10-03 Thread Jesper Pedersen
On 09/29/2016 04:02 PM, Peter Eisentraut wrote: On 9/29/16 4:00 PM, Peter Eisentraut wrote: Since the commit fest is drawing to a close, I'll set this patch as returned with feedback. Actually, the CF app informs me that moving to the next CF is more appropriate, so I have done that. Ok,

Re: [HACKERS] [COMMITTERS] pgsql: Copy-editing for contrib/pg_visibility documentation.

2016-10-03 Thread Tom Lane
Robert Haas writes: > Why do you keep insisting on changing case where I've written "which" > to instead say "that" in situations where AFAIK either is perfectly > correct? I find such changes at best neutral, and in some cases > worse. What I was taught in school was

Re: [HACKERS] pgbench - allow backslash continuations in \set expressions

2016-10-03 Thread Christoph Berg
Re: Fabien COELHO 2016-10-03 > > I "\set" a bunch of lengthy SQL commands in there, e.g. > > I agree that this looks like a desirable feature, however I would tend to > see that as material for another independent patch. Sure, my question was by no

Re: [HACKERS] WIP: Covering + unique indexes.

2016-10-03 Thread Anastasia Lubennikova
03.10.2016 05:22, Michael Paquier: On Tue, Sep 27, 2016 at 12:17 AM, Anastasia Lubennikova wrote: Ok, I'll write it in a few days. Marked as returned with feedback per last emails exchanged. The only complaint about this patch was a lack of README, which is

Re: [HACKERS] pgbench - allow backslash continuations in \set expressions

2016-10-03 Thread Fabien COELHO
Hello Christoph, Attached patch does what is described in the title, hopefully. Continuations in other pgbench backslash-commands should be dealt with elsewhere... Would (a similar version of) that patch also apply to .psqlrc? Pgbench has its own lexer & parser for \set expressions, so the

Re: [HACKERS] Tuplesort merge pre-reading

2016-10-03 Thread Peter Geoghegan
On Mon, Oct 3, 2016 at 3:39 AM, Heikki Linnakangas wrote: >> Can't you just use state->tapeRange, and remove the "continue"? I >> recommend referring to "now-exhausted input tapes" here, too. > > > Don't think so. result_tape == tapeRange only when the merge was done in a >

Re: [HACKERS] Patch to implement pg_current_logfile() function

2016-10-03 Thread Karl O. Pinc
On Mon, 3 Oct 2016 13:35:16 +0900 Michael Paquier wrote: > > Moved to next CF, the patch still applies. Karl, you have registered > to review this patch a couple of months back but nothing happened. I > have removed your name for now. If you have time, don't hesitate

Re: [HACKERS] Macro customizable hashtable / bitmapscan & aggregation perf

2016-10-03 Thread Arthur Silva
On Sat, Oct 1, 2016 at 2:44 AM, Andres Freund wrote: > Hi, > > On 2016-07-26 17:43:33 -0700, Andres Freund wrote: > > In the attached patch I've attached simplehash.h, which can be > > customized by a bunch of macros, before being inlined. There's also a > > patch using this

Re: [HACKERS] multivariate statistics (v19)

2016-10-03 Thread Heikki Linnakangas
On 10/03/2016 04:46 AM, Michael Paquier wrote: On Fri, Sep 30, 2016 at 8:10 PM, Heikki Linnakangas wrote: This patch set is in pretty good shape, the only problem is that it's so big that no-one seems to have the time or courage to do the final touches and commit it. Did you

[HACKERS] Decoding proacl

2016-10-03 Thread Benedikt Grundmann
I'm trying to understand how to decode proacl in pg_proc. The documentation says: PostgreSQL grants default privileges on some types of objects to PUBLIC. ... EXECUTE privilege for functions; ... Also, these initial default privilege settings can be changed using the ALTER DEFAULT PRIVILEGES

Re: [HACKERS] asynchronous execution

2016-10-03 Thread Kyotaro HORIGUCHI
Thank you for the thought. At Fri, 23 Sep 2016 21:09:03 -0400, Robert Haas wrote in > [ Adjusting subject line to reflect the actual topic of discussion better. ] > > On Fri, Sep 23, 2016 at 9:29 AM,

Re: [HACKERS] pgbench - allow backslash continuations in \set expressions

2016-10-03 Thread Christoph Berg
Re: Fabien COELHO 2016-10-03 > > Attached patch does what is described in the title, hopefully. Continuations > in other pgbench backslash-commands should be dealt with elsewhere... Would (a similar version of) that patch also apply to .psqlrc? I

Re: [HACKERS] Tuplesort merge pre-reading

2016-10-03 Thread Heikki Linnakangas
On 09/30/2016 04:08 PM, Peter Geoghegan wrote: On Thu, Sep 29, 2016 at 4:10 PM, Heikki Linnakangas wrote: Bah, I fumbled the initSlabAllocator() function, attached is a fixed version. This looks much better. It's definitely getting close. Thanks for being considerate of my

Re: [HACKERS] WIP: About CMake v2

2016-10-03 Thread Stas Kelvich
> On 17 Sep 2016, at 20:21, Yury Zhuravlev wrote: > > Michael Paquier wrote: >> On Sat, Sep 17, 2016 at 1:40 AM, Yury Zhuravlev >> wrote: >>> Michael Paquier wrote: >>> I merged master to my branch and I spent time to porting all changes.

[HACKERS] pgbench - allow backslash continuations in \set expressions

2016-10-03 Thread Fabien COELHO
Attached patch does what is described in the title, hopefully. Continuations in other pgbench backslash-commands should be dealt with elsewhere... Also attached is a small test script. While looking at the code, I noticed that newline is \n. Maybe it should be (\r|\n|\r\n) to allow for

Re: [HACKERS] Backporting PostgresNode.pm

2016-10-03 Thread Michael Paquier
On Mon, Oct 3, 2016 at 4:51 PM, Craig Ringer wrote: > Tom mentioned in "9.6 TAP tests and extensions" [1] that > > "[I]n the past we've often regretted it when we failed > to back-patch TAP infrastructure fixes all the way back to 9.4." > > [...] > > If folks think this is

Re: [HACKERS] pg_hba_file_settings view patch

2016-10-03 Thread Vitaly Burovoy
On 10/2/16, Michael Paquier wrote: > On Mon, Oct 3, 2016 at 3:25 PM, Vitaly Burovoy > wrote: >> I guess for ability to use filtering like: >> >> SELECT * FROM pg_hba_rules WHERE options->>radiusserver LIKE >> '%.example.com'; >> >> I think it

[HACKERS] Backporting PostgresNode.pm

2016-10-03 Thread Craig Ringer
Hi all Tom mentioned in "9.6 TAP tests and extensions" [1] that "[I]n the past we've often regretted it when we failed to back-patch TAP infrastructure fixes all the way back to 9.4." So maybe we should do just that? Backpatch to add PostgresNode.pm, RecursiveCopy.pm, and the changes to

Re: [HACKERS] Tracking wait event for latches

2016-10-03 Thread Michael Paquier
On Mon, Oct 3, 2016 at 12:35 PM, Thomas Munro wrote: > Hmm. I like the use of pgstat in that name. It helps with the > confusion created by the overloading of the term 'wait event' in the > pg_stat_activity view and the WaitEventSet API, by putting it into a >

Re: [HACKERS] pg_hba_file_settings view patch

2016-10-03 Thread Michael Paquier
On Mon, Oct 3, 2016 at 3:25 PM, Vitaly Burovoy wrote: > I guess for ability to use filtering like: > > SELECT * FROM pg_hba_rules WHERE options->>radiusserver LIKE '%.example.com'; > > I think it would be harder if options is an array of strings... With unnest() and a

Re: [HACKERS] pg_hba_file_settings view patch

2016-10-03 Thread Vitaly Burovoy
On 10/2/16, Michael Paquier wrote: > + push_jsonb_string_key(, "map"); > + push_jsonb_string_value(, hba->usermap); > [...] > + > + options > + jsonb > + Configuration options set for authentication method > + > Why is it an advantage to