Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On Tue, Oct 25, 2016 at 1:17 PM, Tom Lane wrote: > Michael Paquier writes: >> Well... Coming back to the subject, are there any recommendations from >> committers? -std=c89 in CFLAGS does not seem to help much to detect >> extra commas in enums,

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

On Tue, Oct 18, 2016 at 1:51 AM, Shay Rojansky wrote: > The current macaddr datatype needs to be kept for some time by renaming >> it without changing OID and use the newer one for further usage. >> > > From the point of view of a driver maintainer... Npgsql looks up data > types

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

Michael Paquier writes: > Well... Coming back to the subject, are there any recommendations from > committers? -std=c89 in CFLAGS does not seem to help much to detect > extra commas in enums, even if this has been added in C99. My opinion is don't worry about it. The

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

On Mon, Oct 24, 2016 at 2:48 PM, Dilip Kumar wrote: > On Fri, Oct 21, 2016 at 7:57 AM, Dilip Kumar wrote: >> On Thu, Oct 20, 2016 at 9:03 PM, Tomas Vondra >> wrote: >> >>> In the results you've posted on 10/12, you've

Re: [HACKERS] emergency outage requiring database restart

Merlin Moncure wrote: > On Mon, Oct 24, 2016 at 6:01 PM, Merlin Moncure wrote: > > Corruption struck again. > > This time got another case of view busted -- attempting to create > > gives missing 'type' error. > > Call it a hunch -- I think the problem is in pl/sh. I've

Re: [HACKERS] [PATCH] Logical decoding timeline following take II

On 24 October 2016 at 23:49, Petr Jelinek wrote: > Hi Craig, > > On 01/09/16 06:08, Craig Ringer wrote: >> Hi all >> >> Attached is a rebased and updated logical decoding timeline following >> patch for 10.0. >> >> This is a pre-requisite for the pending work on logical

Re: [HACKERS] [BUG] pg_basebackup from disconnected standby fails

Hi, At Mon, 24 Oct 2016 15:55:58 +0900, Michael Paquier wrote in > On Mon, Oct 24, 2016 at 1:39 PM, Amit Kapila wrote: > > On Mon, Oct 24, 2016 at 9:18 AM, Kyotaro HORIGUCHI

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On Tue, Oct 25, 2016 at 2:34 PM, Peter Eisentraut wrote: > On 10/24/16 8:37 PM, Michael Paquier wrote: >> Well... Coming back to the subject, are there any recommendations from >> committers? -std=c89 in CFLAGS does not seem to help much to detect >> extra commas

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On 10/24/16 8:37 PM, Michael Paquier wrote: > Well... Coming back to the subject, are there any recommendations from > committers? -std=c89 in CFLAGS does not seem to help much to detect > extra commas in enums, even if this has been added in C99. The only option that gives you a warning for this

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Fri, Oct 7, 2016 at 5:47 PM, Peter Geoghegan wrote: > Work is still needed on: > > * Cost model. Should probably attempt to guess final index size, and > derive calculation of number of workers from that. Also, I'm concerned > that I haven't given enough thought to the low

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On Tue, Oct 25, 2016 at 6:59 AM, Tom Lane wrote: > Fabien COELHO writes: >>> An alternative that would be worth considering is to adopt a uniform >>> rule of // for line-ending comments and /* for all other uses. > >> Why not. As far as comments are

Re: [HACKERS] emergency outage requiring database restart

On Mon, Oct 24, 2016 at 6:01 PM, Merlin Moncure wrote: > On Thu, Oct 20, 2016 at 1:52 PM, Merlin Moncure wrote: >> On Wed, Oct 19, 2016 at 2:39 PM, Merlin Moncure wrote: >>> On Wed, Oct 19, 2016 at 9:56 AM, Bruce Momjian

Re: [HACKERS] emergency outage requiring database restart

On Thu, Oct 20, 2016 at 1:52 PM, Merlin Moncure wrote: > On Wed, Oct 19, 2016 at 2:39 PM, Merlin Moncure wrote: >> On Wed, Oct 19, 2016 at 9:56 AM, Bruce Momjian wrote: >>> On Wed, Oct 19, 2016 at 08:54:48AM -0500, Merlin Moncure wrote:

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

Fabien COELHO writes: >> An alternative that would be worth considering is to adopt a uniform >> rule of // for line-ending comments and /* for all other uses. > Why not. As far as comments are concerned, editors usually highlight them > in some color, and my eyes get used

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. This is probably a matter of

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On 24/10/16 21:11, Stephen Frost wrote: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> Alvaro Herrera writes: >>> Fabien COELHO wrote: I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of

Re: [HACKERS] Press Release Draft - 2016-10-27 Cumulative Update

> On Oct 24, 2016, at 2:59 PM, Tom Lane wrote: > > Jonathan Katz writes: >> Below is the draft of the press release for the update this Thursday: > >>

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

I find it annoying that "//" comments are not supported, or having to declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. Yeah. Personally, I'd want

Re: [HACKERS] Patch: Implement failover on libpq connect level.

Robert Haas wrote: > While I was experimenting with this today, I discovered a problem of > interpretation related to IPv6 addresses. Internally, a postgresql:// > URL and a connection string are converted into the same format, so > postgresql://a,b/ means just the same thing as host=a,b. I

Re: [HACKERS] Press Release Draft - 2016-10-27 Cumulative Update

> On Oct 24, 2016, at 2:49 PM, Robert Haas wrote: > > On Mon, Oct 24, 2016 at 1:14 PM, Jonathan Katz > wrote: >> Hello, >> >> Below is the draft of the press release for the update this Thursday: >> >>

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On 10/24/16 11:57 AM, Robert Haas wrote: > Today, since the host part can't include a > port specifier, it's regarded as part of the IP address, and I think > it would probably be a bad idea to change that, as I believe Victor's > patch would. He seems to have it in mind that we could allow

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On 10/24/16 6:36 AM, Thom Brown wrote: > So should it be the case that it disallows UNIX socket addresses > entirely? I can't imagine a list of UNIX socket addresses being that > useful. But maybe a mixed list of Unix-domain sockets and TCP connections? The nice thing is that is it currently

Re: [HACKERS] Rename max_parallel_degree?

On 10/12/16 7:58 PM, Robert Haas wrote: > I don't think it's wrong that the handling is done there, though. The > process that is registering the background worker is well-placed to > check whether there are already too many, and if it does not then the > slot is consumed at least temporarily

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

On Mon, Oct 24, 2016 at 03:03:19PM -0400, Tom Lane wrote: > Alvaro Herrera writes: > > Fabien COELHO wrote: > >> I find it annoying that "//" comments are not supported, or having to > >> declare variables at the beginning of a block instead of when first used... > > >

Re: [HACKERS] PL/Python adding support for multi-dimensional arrays

Hi 2016-10-14 10:53 GMT+02:00 Heikki Linnakangas : > On 10/11/2016 08:56 AM, Pavel Stehule wrote: > >> 2016-10-11 7:49 GMT+02:00 Heikki Linnakangas : >> >> Unfortunately there are cases that are fundamentally ambiguous. >>> >>> create type comptype as (intarray

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On Wed, 19 Oct 2016 12:04:27 -0400 Robert Haas wrote: > On Thu, Oct 13, 2016 at 5:53 AM, Victor Wagner > wrote: > > On Thu, 13 Oct 2016 12:30:59 +0530 > > Mithun Cy wrote: > >> On Fri, Sep 30, 2016 at 2:14 PM, Victor

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

* Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > Fabien COELHO wrote: > >> I find it annoying that "//" comments are not supported, or having to > >> declare variables at the beginning of a block instead of when first used... > > > I think some c99

Re: [HACKERS] Press Release Draft - 2016-10-27 Cumulative Update

Jonathan Katz writes: > Below is the draft of the press release for the update this Thursday: >

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

Alvaro Herrera writes: > Fabien COELHO wrote: >> I find it annoying that "//" comments are not supported, or having to >> declare variables at the beginning of a block instead of when first used... > I think some c99 features would be nice (variadic macros for one), but

Re: [HACKERS] Press Release Draft - 2016-10-27 Cumulative Update

On Mon, Oct 24, 2016 at 1:14 PM, Jonathan Katz wrote: > Hello, > > Below is the draft of the press release for the update this Thursday: > >

Re: [HACKERS] FSM corruption leading to errors

Alvaro Herrera writes: > Tom Lane wrote: >> Also, we could at least discount the FSM root page and first intermediate >> page, no? That is, the upper limit could be >> >> pg_relation_size(oid::regclass, 'fsm') / 2 - >> 2*current_setting('block_size')::BIGINT >> >> I

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

Fabien COELHO wrote: > I find it annoying that "//" comments are not supported, or having to > declare variables at the beginning of a block instead of when first used... I think some c99 features would be nice (variadic macros for one), but those particular two get a big "meh" from me. .oO( I

Re: [HACKERS] FSM corruption leading to errors

Tom Lane wrote: > Ah, scratch that, after rereading the FSM README I see it's correct, > because there's a binary tree within each page; I'd only remembered > that there was a search tree of pages. > > Also, we could at least discount the FSM root page and first intermediate > page, no? That

Re: [HACKERS] Renaming of pg_xlog and pg_clog

Bruce Momjian wrote: > On Mon, Oct 24, 2016 at 11:59:42AM -0300, Alvaro Herrera wrote: > > There is one difference though, which is that the really destructive > > use of pg_resetxlog is the one that removes pg_xlog files. The other > > uses that simply set flags in the control file are not as

[HACKERS] Press Release Draft - 2016-10-27 Cumulative Update

Hello, Below is the draft of the press release for the update this Thursday: https://git.postgresql.org/gitweb/?p=press.git;a=blob;f=update_releases/current/update_201610.md;h=aac4d0b36f3f3017d319ac617eff901efe0c10c0;hb=880dc99766ee0e608e95d9c0f36ce3cde59f470f

Re: [HACKERS] FSM corruption leading to errors

On Mon, Oct 24, 2016 at 9:47 PM, Tom Lane wrote: > > > Also, we could at least discount the FSM root page and first intermediate > page, no? That is, the upper limit could be > > pg_relation_size(oid::regclass, 'fsm') / 2 - > 2*current_setting('block_size')::BIGINT >

Re: [HACKERS] Add PGDLLEXPORT to PG_FUNCTION_INFO_V1

Tom Lane wrote: > I poked at this a little bit. AFAICT, the only actual cross-file > references are in contrib/ltree/, which has quite a few. Maybe we > could hold our noses and attach PGDLLEXPORT to the declarations in > ltree.h. > > hstore's HSTORE_POLLUTE macro would also need

Re: [HACKERS] [PATCH] Logical decoding timeline following take II

Hi Craig, On 01/09/16 06:08, Craig Ringer wrote: > Hi all > > Attached is a rebased and updated logical decoding timeline following > patch for 10.0. > > This is a pre-requisite for the pending work on logical decoding on > standby servers and simplified failover of logical decoding. > I went

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On Wed, Oct 19, 2016 at 7:26 PM, Peter van Hardenberg wrote: > Supporting different ports on different servers would be a much appreciated > feature (I can't remember if it was Kafka or Cassandra that didn't do this > and it was very annoying.) > > Remember, as the connection string

Re: [HACKERS] FSM corruption leading to errors

Michael Paquier writes: > Release notes refer to this page for methods to fix corrupted instances: > https://wiki.postgresql.org/wiki/Free_Space_Map_Problems > I just typed something based on Pavan's upper method, feel free to > jump in and improve it as necessary.

Re: [HACKERS] FSM corruption leading to errors

I wrote: > It looks to me like this is approximating the highest block number that > could possibly have an FSM entry as size of the FSM fork (in bytes) > divided by 2. But the FSM stores one byte per block. There is overhead > for the FSM search tree, but in a large relation it's not going to

Re: [HACKERS] FSM corruption leading to errors

On Mon, Oct 24, 2016 at 9:34 PM, Tom Lane wrote: > > SELECT blkno, pg_freespace(oid::regclass, blkno) > FROM generate_series(pg_relation_size(oid::regclass) / > current_setting('block_size')::BIGINT, > pg_relation_size(oid::regclass, 'fsm') /

Re: [HACKERS] [PATCH] Send catalog_xmin separately in hot standby feedback

Hi Craig, On 05/09/16 11:28, Craig Ringer wrote: > On 5 September 2016 at 14:44, Craig Ringer wrote: >> On 5 September 2016 at 12:40, Craig Ringer wrote: >>> Hi all >>> >>> Currently hot standby feedback sends GetOldestXmin()'s result to the >>>

Re: [HACKERS] Renaming of pg_xlog and pg_clog

On Mon, Oct 24, 2016 at 11:59:42AM -0300, Alvaro Herrera wrote: > Bruce Momjian wrote: > > On Sat, Oct 22, 2016 at 11:18:28PM +0300, Greg Stark wrote: > > > > I think the apt-get behaviour was specifically designed to ensure it > > > couldn't easily be put into a script which I would have said

Re: [HACKERS] Renaming of pg_xlog and pg_clog

Bruce Momjian wrote: > On Sat, Oct 22, 2016 at 11:18:28PM +0300, Greg Stark wrote: > > I think the apt-get behaviour was specifically designed to ensure it > > couldn't easily be put into a script which I would have said was > > desirable -- except I suspect there are situations where Postgres >

Re: [HACKERS] Hash Indexes

On Mon, Oct 24, 2016 at 8:00 PM, Amit Kapila wrote: > On Thu, Sep 29, 2016 at 6:04 AM, Robert Haas wrote: >> On Wed, Sep 28, 2016 at 3:04 PM, Robert Haas wrote: > > > Thanks for the valuable feedback. > Forgot to mention

[HACKERS] repmgr: this node should be a standby

Hello, I am using repmgr 3.2 (PostgreSQL 9.6.0), postgresql-9.5. I have a master, a slave and a third server for my setup. The third server is used to house the rep mgr database. my config is as below : ===MASTER= cluster=test node=1 node_name=node1 conninfo='host=192.168.2.33 user=repuser

Re: [HACKERS] On conflict update & hint bits

On Sun, Oct 23, 2016 at 3:42 PM, Tom Lane wrote: > The business about not throwing a serialization failure due to actions > of our own xact does seem worth fixing now, but if I understand correctly, > we can deal with that by adding a test for xmin-is-our-own-xact into > the

Re: [HACKERS] Renaming of pg_xlog and pg_clog

On Sat, Oct 22, 2016 at 11:18:28PM +0300, Greg Stark wrote: > On Fri, Oct 21, 2016 at 9:03 PM, Stephen Frost wrote: > > WARNING: The following essential packages will be removed. > > This should NOT be done unless you know exactly what you are doing! > > login > > 0

Re: [HACKERS] issue with track_commit_timestamp and server restart

Alvaro Herrera writes: > Now let's discuss a release note entry for 9.5 and 9.6, shall we? The text in your commit message seems sufficient from here. On it now (although if somebody doesn't fix anon git PDQ, we're not releasing today anyway).

Re: [HACKERS] issue with track_commit_timestamp and server restart

Now let's discuss a release note entry for 9.5 and 9.6, shall we? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] issue with track_commit_timestamp and server restart

Craig Ringer wrote: > I initially could'n't see this when tested on 8f1fb7d with a > src/test/recovery/t test script. But it turns out it's OK on immediate > shutdown and crash recovery, but not on clean shutdown and restart. Oh, oops. > The attached patch adds a TAP test to src/test/recovery

Re: [HACKERS] On conflict update & hint bits

Konstantin Knizhnik writes: > Just for information: I know that you are working on this issue, but as > far as we need to proceed further with our testing of multimaster, > I have done the following obvious changes and it fixes the problem (at > least this assertion

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On Wed, 19 Oct 2016 20:15:38 -0400 Robert Haas wrote: > > Some more comments: > > - I am pretty doubtful that the changes to connectOptions2() work as > intended. I think that's only going to be called before actualhost > and actualport could possibly get set. I don't

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On Mon, 24 Oct 2016 11:36:31 +0100 Thom Brown wrote: > > - It's pretty clear that this isn't going to work if the host list > > includes a mix of hostnames and UNIX socket addresses. The code > > that handles the UNIX socket address case is totally separate from > > the code

Re: [HACKERS] Aggregate Push Down - Performing aggregation on foreign server

On Sat, Oct 22, 2016 at 9:09 PM, Tom Lane wrote: > brolga is still not terribly happy with this patch: it's choosing not to > push down the aggregates in one of the queries. While I failed to > duplicate that result locally, investigation suggests that brolga's result > is

Re: [HACKERS] Patch: Implement failover on libpq connect level.

On 20 October 2016 at 01:15, Robert Haas wrote: > > On Wed, Oct 19, 2016 at 12:04 PM, Robert Haas wrote: > > On Thu, Oct 13, 2016 at 5:53 AM, Victor Wagner wrote: > >> On Thu, 13 Oct 2016 12:30:59 +0530 > >> Mithun Cy

Re: [HACKERS] Speed up Clog Access by increasing CLOG buffers

On Fri, Oct 21, 2016 at 7:57 AM, Dilip Kumar wrote: > On Thu, Oct 20, 2016 at 9:03 PM, Tomas Vondra > wrote: > >> In the results you've posted on 10/12, you've mentioned a regression with 32 >> clients, where you got 52k tps on master but only

Re: [HACKERS] Push down more full joins in postgres_fdw

On 2016/10/22 17:19, Ashutosh Bapat wrote: Review for postgres-fdw-more-full-join-pushdown-v6 patch. The patch applies cleanly and regression is clean (make check in regress directory and that in postgres_fdw). Thanks for the review! Here are some comments. 1. Because of the following code

[HACKERS] Microvacuum support for Hash Index

Hi All, I have added a microvacuum support for hash index access method and attached is the v1 patch for the same. The patch basically takes care of the following things: 1. Firstly, it changes the marking of dead tuples from 'tuple-at-a-time' to 'page-at-a-time' during hash index scan. For this

Re: [HACKERS] issue with track_commit_timestamp and server restart

On 24/10/2016 06:58, Craig Ringer wrote: > On 22 October 2016 at 19:51, Julien Rouhaud wrote: >> I just noticed that if track_commit_timestamp is enabled, the >> oldestCommitTsXid and newestCommitTsXid don't persist after a server >> restart, so you can't ask for the

Re: [HACKERS] Rename max_parallel_degree?

On Thu, Oct 13, 2016 at 5:28 AM, Robert Haas wrote: > On Wed, Oct 12, 2016 at 8:13 AM, Peter Eisentraut > wrote: >> On 10/4/16 10:16 AM, Julien Rouhaud wrote: >>> Please find attached v9 of the patch, adding the parallel worker class >>>

Re: [HACKERS] [BUG] pg_basebackup from disconnected standby fails

On Mon, Oct 24, 2016 at 1:26 PM, Amit Kapila wrote: > On Fri, Oct 21, 2016 at 10:32 PM, Robert Haas wrote: >> 2. In perform_base_backup(), if the endptr returned by >> do_pg_stop_backup() precedes the end of the checkpoint record returned >> by

Re: [HACKERS] On conflict update & hint bits

On 24.10.2016 00:49, Peter Geoghegan wrote: On Sun, Oct 23, 2016 at 2:46 PM, Tom Lane wrote: What's bothering me is (a) it's less than 24 hours to release wrap and (b) this patch changes SSI-relevant behavior and hasn't been approved by Kevin. I'm not familiar enough

Re: [HACKERS] [BUG] pg_basebackup from disconnected standby fails

On Mon, Oct 24, 2016 at 1:39 PM, Amit Kapila wrote: > On Mon, Oct 24, 2016 at 9:18 AM, Kyotaro HORIGUCHI > wrote: >> Thank you for looking and retelling this. +1. >> At Fri, 21 Oct 2016 13:02:21 -0400, Robert Haas

Re: [HACKERS] Minor code improvement to postgresGetForeignJoinPaths

On Mon, Oct 24, 2016 at 7:56 AM, Tatsuro Yamada wrote: > Hi, > > The last argument of create_foreignscan_path called by > postgresGetForeignJoinPaths is > set to NULL, but it would be suitable to set it to NIL because the argument > type is List. > > Please find

Re: [HACKERS] [COMMITTERS] pgsql: Remove extra comma at end of enum list

C99-specific feature, and wasn't intentional in the first place. Per buildfarm member mylodon This is the second time I see that in the last couple of weeks. Would it be better to use some custom CFLAGS to detect that earlier in the review process? I have never much used gcc's std or clang

Re: [HACKERS] Gather Merge

On Thu, Oct 20, 2016 at 1:12 PM, Amit Kapila wrote: > On Tue, Oct 18, 2016 at 5:29 PM, Rushabh Lathia > wrote: > > On Mon, Oct 17, 2016 at 2:26 PM, Amit Kapila > > wrote: > >> > >> There is lot of common code between