Re: [HACKERS] Parallel bitmap heap scan

2016-11-22 Thread Dilip Kumar
On Wed, Nov 23, 2016 at 7:24 AM, Robert Haas wrote: > So, I had a brief look at this tonight. This is not a full review, > but just some things I noticed: Thanks for the review.. > > + *Update snpashot info in heap scan descriptor. > > Typo. Also, why should we

Re: [HACKERS] IF (NOT) EXISTS in psql-completion

2016-11-22 Thread Pavel Stehule
Hi 2016-11-15 12:26 GMT+01:00 Kyotaro HORIGUCHI : > Hello, I rebased this patch on the current master. > > At Mon, 31 Oct 2016 10:15:48 +0900 (Tokyo Standard Time), Kyotaro > HORIGUCHI wrote in < >

Re: [HACKERS] patch: function xmltable

2016-11-22 Thread Pavel Stehule
2016-11-22 21:47 GMT+01:00 Alvaro Herrera : > I found the whole TableExprGetTupleDesc() function a bit odd in > nodeFuncs.c, so I renamed it to ExecTypeFromTableExpr() and moved it to > execTuples.c -- but only because that's where ExecTypeFromTL and others > already

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Peter Geoghegan
On Tue, Nov 22, 2016 at 8:45 PM, Tom Lane wrote: > Peter Geoghegan writes: >> The best thing by far about an alternative design like this is that it >> performs *consistently*. > > Really? I think it just moves the issues somewhere else. Definitely, yes. *

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Pavan Deolasee
On Wed, Nov 23, 2016 at 10:07 AM, Peter Geoghegan wrote: > On Tue, Nov 22, 2016 at 8:18 PM, Tom Lane wrote: > > Ultimately, I doubt that update-in-place buys much that we don't already > > have with HOT updates (which postdate this old conversation, btw). >

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Mark Kirkwood
On 23/11/16 16:31, Tom Lane wrote: Robert Haas writes: [ Let's invent Oracle-style UNDO logs ] I dunno. I remember being told years ago, by an ex-Oracle engineer, that he thought our approach was better. I don't recall all the details of the conversation but I think

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Tom Lane
Peter Geoghegan writes: > The best thing by far about an alternative design like this is that it > performs *consistently*. Really? I think it just moves the issues somewhere else. regards, tom lane -- Sent via pgsql-hackers mailing list

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Peter Geoghegan
On Tue, Nov 22, 2016 at 8:18 PM, Tom Lane wrote: > Ultimately, I doubt that update-in-place buys much that we don't already > have with HOT updates (which postdate this old conversation, btw). > If you want MVCC semantics, you need to hold both versions of the tuple >

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Amit Kapila
On Wed, Nov 23, 2016 at 9:48 AM, Tom Lane wrote: > Peter Geoghegan writes: >> On Tue, Nov 22, 2016 at 7:31 PM, Tom Lane wrote: >>> Oracle spends a lot of time on this, and it's really cache-inefficient >>> because the data is spread all

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Peter Geoghegan
On Tue, Nov 22, 2016 at 7:01 PM, Robert Haas wrote: > This basic DO-UNDO-REDO protocol has been well-understood for > decades. FWIW, while this is basically true, the idea of repurposing UNDO to be usable for MVCC is definitely an Oracleism. Mohan's ARIES paper says

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Amit Kapila
On Wed, Nov 23, 2016 at 9:32 AM, Peter Geoghegan wrote: > On Tue, Nov 22, 2016 at 7:31 PM, Tom Lane wrote: >>> - Reading a page that has been recently modified gets significantly >>> more expensive; it is necessary to read the associated UNDO entries >>> and

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Tom Lane
Peter Geoghegan writes: > On Tue, Nov 22, 2016 at 7:31 PM, Tom Lane wrote: >> Oracle spends a lot of time on this, and it's really cache-inefficient >> because the data is spread all over. This was what this guy felt in >> circa 2001; I'd have to think that

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Peter Geoghegan
On Tue, Nov 22, 2016 at 7:31 PM, Tom Lane wrote: >> - Reading a page that has been recently modified gets significantly >> more expensive; it is necessary to read the associated UNDO entries >> and do a bunch of calculation that is significantly more complex than >> what is

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 10:41 PM, Peter Geoghegan wrote: > On Tue, Nov 22, 2016 at 7:39 PM, Robert Haas wrote: >>> Heikki's been fooling with some ideas that I think have more promise. >>> I wish he'd get to the point of presenting them publicly rather

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Peter Geoghegan
On Tue, Nov 22, 2016 at 7:39 PM, Robert Haas wrote: >> Heikki's been fooling with some ideas that I think have more promise. >> I wish he'd get to the point of presenting them publicly rather than >> just over beers at conferences. > > That would be good, too! I was told

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 10:31 PM, Tom Lane wrote: > Robert Haas writes: >> [ Let's invent Oracle-style UNDO logs ] > > I dunno. I remember being told years ago, by an ex-Oracle engineer, > that he thought our approach was better. I don't recall all

Re: [HACKERS] UNDO and in-place update

2016-11-22 Thread Tom Lane
Robert Haas writes: > [ Let's invent Oracle-style UNDO logs ] I dunno. I remember being told years ago, by an ex-Oracle engineer, that he thought our approach was better. I don't recall all the details of the conversation but I think his key point was basically this: >

Re: [HACKERS] [WIP] [B-Tree] Keep indexes sorted by heap physical location

2016-11-22 Thread Peter Geoghegan
On Mon, Nov 21, 2016 at 5:15 PM, Claudio Freire wrote: >> There are a couple >> of tricky issues with that that you'd have to look out for, like >> making sure that the high key continues to hold a real TID, which at a >> glance looks like something that just happens

[HACKERS] Alternative MATERIALIZED VIEW design and implementation with history table and other features

2016-11-22 Thread Nico Williams
I love MATERIALIZED VIEWs. But we needed a method for recording deltas from REFRESHes, and that's not supported. So I coded up my own version of materialized views, in PlPgSQL, that does provide a history feature. Besides a history feature, this includes the ability to record changes made to a

[HACKERS] UNDO and in-place update

2016-11-22 Thread Robert Haas
PostgreSQL tables and indexes not infrequently become bloated, and this bloat is difficult to reverse once it has occurred. When a row is updated, a new row version is created and the space occupied by the old version can be eventually be recycled. Since there is always a short delay and

Re: [HACKERS] Parallel bitmap heap scan

2016-11-22 Thread Robert Haas
On Wed, Oct 19, 2016 at 11:53 AM, Dilip Kumar wrote: > I found one defect in v2 patch, that I induced during last rebasing. > That is fixed in v3. So, I had a brief look at this tonight. This is not a full review, but just some things I noticed: + *Update

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-22 Thread Tom Lane
Haribabu Kommi writes: > On Wed, Nov 23, 2016 at 1:42 AM, Tom Lane wrote: >> The precedent of int4/int8/float4/float8 is that SQL data types should >> be named after their length in bytes. So I'd be inclined to call this >> "macaddr8" not

Re: [HACKERS] WIP: Barriers

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 4:42 PM, Thomas Munro wrote: > On Tue, Nov 1, 2016 at 5:03 PM, Thomas Munro >> Here's a new version which is rebased and adds support for passing >> wait_event through to pg_stat_activity. > > Here's a version updated for the new conditional

Re: [HACKERS] btree_gin and btree_gist for enums

2016-11-22 Thread Andrew Dunstan
I won't have time to fix this before the end of the Commitfest -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-22 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 1:42 AM, Tom Lane wrote: > Haribabu Kommi writes: > > Any suggestions for the name to be used for the new datatype the can > > work for both 48 and 64 bit MAC addresses? > > The precedent of int4/int8/float4/float8 is that

[HACKERS] Re: [COMMITTERS] pgsql: Doc: improve documentation about composite-value usage.

2016-11-22 Thread David G. Johnston
On Tue, Nov 22, 2016 at 3:56 PM, Tom Lane wrote: > Doc: improve documentation about composite-value usage. > > Create a section specifically for the syntactic rules around whole-row > variable usage, such as expansion of "foo.*". This was previously > documented only

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-22 Thread Haribabu Kommi
Hi All, The commitfest status summary after three weeks of progress: Needs review: 59 Waiting on author: 28 Ready for Commiter: 16 Commited: 35 Moved to next CF: 0 Rejected: 5 Returned with feedback: 4 TOTAL: 147 Overall progress of completion - 29% week-1 progress of completion - 9% week-2

Re: [HACKERS] delta relations in AFTER triggers

2016-11-22 Thread Jim Nasby
On 11/21/16 3:49 AM, Craig Ringer wrote: After going through that experience, I now agree with Kevin: an > interface where a new SPI interface lets PLs push a named tuplestore > into the SPI connection to make it available to SQL seems like the > simplest and tidiest way. That also offers a

Re: [HACKERS] [PATCH] Reload SSL certificates on SIGHUP

2016-11-22 Thread Michael Paquier
On Wed, Nov 23, 2016 at 5:48 AM, Michael Banck wrote: > On Fri, Nov 11, 2016 at 07:42:05PM +0100, Andreas Karlsson wrote: >> On 11/11/2016 07:40 PM, Andreas Karlsson wrote: >> >Here is a new version of the patch with the only differences; >> > >> >1) The SSL tests have

Re: [HACKERS] WIP: Barriers

2016-11-22 Thread Thomas Munro
On Tue, Nov 1, 2016 at 5:03 PM, Thomas Munro wrote: > On Thu, Aug 18, 2016 at 1:55 PM, Thomas Munro > wrote: >> On Tue, Aug 16, 2016 at 1:55 AM, Robert Haas wrote: >>> If we're going to remove barrier.h, I

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Alvaro Herrera
Andres Freund wrote: > On 2016-11-22 16:15:58 -0500, Tom Lane wrote: > > Maybe a workable compromise would be to leave the file present, and have > > the stats collector re-write it every (say) five minutes. Then I'd be > > okay with having an immediate shutdown skip writing the file; you'd be >

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Andres Freund
On 2016-11-22 16:15:58 -0500, Tom Lane wrote: > Alvaro Herrera writes: > > Well, the problem is that the stats data is not on disk while the system > > is in operation, as far as I recall -- it's only in the collector's > > local memory. On shutdown we tell it to write

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 4:15 PM, Tom Lane wrote: > Alvaro Herrera writes: >> Well, the problem is that the stats data is not on disk while the system >> is in operation, as far as I recall -- it's only in the collector's >> local memory. On shutdown

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Tom Lane
Alvaro Herrera writes: > Well, the problem is that the stats data is not on disk while the system > is in operation, as far as I recall -- it's only in the collector's > local memory. On shutdown we tell it to write it down to a file, and on > startup we tell it to read

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-11-22 Thread Corey Huinker
On Tue, Nov 22, 2016 at 3:29 PM, Tom Lane wrote: > Corey Huinker writes: > > In 9.4, I encountered a complaint about flex 2.6.0. After a little > research > > it seems that a fix for that made it into versions 9.3+, but not 9.4. > > Er ... what? See

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 3:52 PM, Tom Lane wrote: > Robert Haas writes: >> I agree. However, in many cases, the major cost of a fast shutdown is >> getting the dirty data already in the operating system buffers down to >> disk, not in writing out

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Tom Lane
Andres Freund writes: > But I'm a bit confused too - does this make any sort of difference? > Because the startup path for crash recovery is like this: > pgstat_reset_all(); > so it seems quite inconsequential whether we write out pgstat, because > we're going to

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-22 Thread Robert Haas
On Sun, Nov 13, 2016 at 9:02 PM, Tsunakawa, Takayuki wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Robert Haas >> Great, committed. There's still potentially more work to be done here, >> because my

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Andres Freund
Hi, On 2016-11-22 15:49:27 -0500, Robert Haas wrote: > I think you are almost right. When the server is running, there are > files in pg_stat_tmp but not pg_stat; when it is shut down, there are > files in pg_stat but not pg_stat_tmp. Of course the data can never be > ONLY in the collector's

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Tom Lane
Robert Haas writes: > I agree. However, in many cases, the major cost of a fast shutdown is > getting the dirty data already in the operating system buffers down to > disk, not in writing out shared_buffers itself. The latter is > probably a single-digit number of

Re: [HACKERS] [PATCH] Reload SSL certificates on SIGHUP

2016-11-22 Thread Michael Banck
Hi, On Fri, Nov 11, 2016 at 07:42:05PM +0100, Andreas Karlsson wrote: > On 11/11/2016 07:40 PM, Andreas Karlsson wrote: > >Here is a new version of the patch with the only differences; > > > >1) The SSL tests have been changed to use reload rather than restart > > > >2) Rebased on master > > And

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 3:34 PM, Alvaro Herrera wrote: >> OK, that's possible, but I'm not sure. I think there are two separate >> issues here. One is whether we should nuke the stats file on >> recovery, and the other is whether we should force a final write of >> the

Re: [HACKERS] patch: function xmltable

2016-11-22 Thread Alvaro Herrera
I found the whole TableExprGetTupleDesc() function a bit odd in nodeFuncs.c, so I renamed it to ExecTypeFromTableExpr() and moved it to execTuples.c -- but only because that's where ExecTypeFromTL and others already live. I would have liked to move it to tupdesc.c instead, but it requires

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Alvaro Herrera
Robert Haas wrote: > On Tue, Nov 22, 2016 at 1:37 PM, Alvaro Herrera > wrote: > >> > Yes, I am, and I disagree with you. The current decision on this point > >> > was made ages ago, before autovacuum even existed let alone relied on > >> > the stats for proper

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-11-22 Thread Tom Lane
Corey Huinker writes: > In 9.4, I encountered a complaint about flex 2.6.0. After a little research > it seems that a fix for that made it into versions 9.3+, but not 9.4. Er ... what? See 1ba874505. regards, tom lane -- Sent via

Re: [HACKERS] postgres 9.3 postgres_fdw ::LOG: could not receive data from client: Connection reset by peer

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 5:05 AM, Vladimir Svedov wrote: > Hi, > Sorry - tried to reproduce on other machine and gather all statements. And > failed > Installed 9.3 (which has those symptoms) and still can't reproduce. > Must be platform specific, not version Probably the

Re: [HACKERS] Logical decoding on standby

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 1:49 AM, Craig Ringer wrote: > On 22 November 2016 at 10:20, Craig Ringer wrote: >> I'm currently looking at making detection of replay conflict with a >> slot work by separating the current catalog_xmin into two effective >>

Re: [HACKERS] Declarative partitioning - another take

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 4:15 AM, Amit Langote wrote: >> The easiest thing to do might be to just enforce that all of the >> partition key columns have to be not-null when the range-partitioned >> table is defined, and reject any attempt to DROP NOT NULL on them >>

Re: [HACKERS] dblink get_connect_string() passes FDW option "updatable" to the connect string, connection fails.

2016-11-22 Thread Corey Huinker
> > > >> It looks like this might be fairly easy to fix by having >> get_connect_string() use is_valid_dblink_option() to check each >> option name, and silently ignore options that are inappropriate. >> > > From what I can tell, it is very straightforward, the context oids are set > up just a few

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 1:37 PM, Alvaro Herrera wrote: >> > Yes, I am, and I disagree with you. The current decision on this point >> > was made ages ago, before autovacuum even existed let alone relied on >> > the stats for proper functioning. The tradeoff you're

Re: [HACKERS] condition variables

2016-11-22 Thread Robert Haas
On Mon, Nov 21, 2016 at 11:48 PM, Thomas Munro wrote: > Here's a version that works that way, though it allows you to call > ConditionVariablePrepareToSleep *optionally* before you enter your > loop, in case you expect to have to wait and would rather avoid the >

Re: [HACKERS] amcheck (B-Tree integrity checking tool)

2016-11-22 Thread Peter Geoghegan
On Sun, Nov 20, 2016 at 3:42 PM, Robert Haas wrote: > OK. If it's not reasonable to continue checking after an ERROR, then > I think ERROR is the way to go. If somebody really doesn't like that > lack of flexibility (in either direction), they can propose a change > later

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Alvaro Herrera
Robert Haas wrote: > On Tue, Nov 22, 2016 at 12:54 PM, Tom Lane wrote: > > Robert Haas writes: > >> But that's not what is at issue here. The issue is whether, when > >> asked to exit immediately, all processes should exit immediately, or > >> whether

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 12:54 PM, Tom Lane wrote: > Robert Haas writes: >> But that's not what is at issue here. The issue is whether, when >> asked to exit immediately, all processes should exit immediately, or >> whether it would be better for all

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Tom Lane
Robert Haas writes: > But that's not what is at issue here. The issue is whether, when > asked to exit immediately, all processes should exit immediately, or > whether it would be better for all processes except one to exit > immediately and the last one exit

Re: [HACKERS] Logical Replication WIP

2016-11-22 Thread Erik Rijkers
On 2016-11-20 19:02, Petr Jelinek wrote: 0001-Add-support-for-TE...cation-slots-v8.patch.gz (~8 KB) 0002-Refactor-libpqwalreceiver-v8.patch.gz (~9 KB) 0003-Add-PUBLICATION-catalogs-and-DDL-v8.patch.gz (~30 KB) 0004-Add-SUBSCRIPTION-catalog-and-DDL-v8.patch.gz (~27 KB)

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-22 Thread Jon Nelson
On Tue, Nov 22, 2016 at 8:42 AM, Tom Lane wrote: > Haribabu Kommi writes: > > Any suggestions for the name to be used for the new datatype the can > > work for both 48 and 64 bit MAC addresses? > > The precedent of int4/int8/float4/float8 is that

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Robert Haas
On Tue, Nov 22, 2016 at 10:59 AM, Tom Lane wrote: > It's already the case that the pgstats code writes the stats data under a > temporary file name and then renames it into place atomically. So the > prospects for corrupt data are not large, and I do not think that the >

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Tom Lane
"Tsunakawa, Takayuki" writes: > From: Tom Lane [mailto:t...@sss.pgh.pa.us] >> The point I was trying to make is that I think the forced-removal behavior >> is not desirable, and therefore committing a patch that makes it be graven >> in stone is not desirable

Re: [HACKERS] Push down more full joins in postgres_fdw

2016-11-22 Thread Ashutosh Bapat
> > >> There is a already a function to build targetlist for a given relation >> build_tlist_to_deparse(), which does the same thing as this code for a >> join or >> base relation and when there are no local conditions. Why don't we use >> that >> function instead of duplicating that logic? If

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-22 Thread Tom Lane
Haribabu Kommi writes: > Any suggestions for the name to be used for the new datatype the can > work for both 48 and 64 bit MAC addresses? The precedent of int4/int8/float4/float8 is that SQL data types should be named after their length in bytes. So I'd be inclined to

Re: [HACKERS] Logical Replication WIP

2016-11-22 Thread Erik Rijkers
and the attachment... On 2016-11-22 14:55, Erik Rijkers wrote: On 2016-11-20 19:06, Petr Jelinek wrote: 0004-Add-SUBSCRIPTION-catalog-and-DDL-v8.patch.gz This patch contains 2 tabs which break the html build when using 'make oldhtml': $ ( cd

Re: [HACKERS] Logical Replication WIP

2016-11-22 Thread Erik Rijkers
On 2016-11-20 19:06, Petr Jelinek wrote: 0004-Add-SUBSCRIPTION-catalog-and-DDL-v8.patch.gz This patch contains 2 tabs which break the html build when using 'make oldhtml': $ ( cd /var/data1/pg_stuff/pg_sandbox/pgsql.logical_replication/doc/src/sgml; time make oldhtml ) make check-tabs

Re: [HACKERS] Improvements in psql hooks for variables

2016-11-22 Thread Daniel Verite
Stephen Frost wrote: > That certainly doesn't feel right. I'm thinking that if we're going to > throw an error back to the user about a value being invalid then we > shouldn't change the current value. > > My initial thought was that perhaps we should pass the current value to >

Re: [HACKERS] Postgres abort found in 9.3.11

2016-11-22 Thread K S, Sandhya (Nokia - IN/Bangalore)
Hello, The setup is made of hot-standby architecture and the issue is seen during normal run with normal load of 50% insert and 50% delete operation. During startup of the standby node, we copy the data directory from the active postgres using pg_basebackup. Meanwhile we are trying to create a

Re: [HACKERS] Forbid use of LF and CR characters in database and role names

2016-11-22 Thread Michael Paquier
On Tue, Nov 22, 2016 at 5:55 PM, Ideriha, Takeshi wrote: > Here's a summary for what I tested in RHEL7.0, details follow. Thanks for the review. > [Summary] > 1. apply patch and make world > -> failed because was mistakenly coded . > > 2.correct this mistake

Re: [HACKERS] Declarative partitioning - another take

2016-11-22 Thread Rushabh Lathia
Hi Amit, I was just reading through your patches and here are some quick review comments for 0001-Catalog-and-DDL-for-partitioned-tables-17.patch. Review comments for 0001-Catalog-and-DDL-for-partitioned-tables-17.patch: 1) @@ -1102,9 +1104,10 @@ heap_create_with_catalog(const char *relname,

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2016-11-22 Thread Etsuro Fujita
Hi Rushabh, On 2016/11/22 19:05, Rushabh Lathia wrote: I started reviewing the patch and here are few initial review points and questions for you. Thanks for the review! 1) -static void deparseExplicitTargetList(List *tlist, List **retrieved_attrs, +static void

Re: [HACKERS] condition variables

2016-11-22 Thread Kyotaro HORIGUCHI
At Tue, 22 Nov 2016 17:48:07 +1300, Thomas Munro wrote in

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-11-22 Thread Mithun Cy
An updated patch with some fixes for bugs reported earlier, A. failover_to_new_master_v4.patch Default value "any" is added to target_server_type parameter during its definition. B. libpq-failover-smallbugs_02.patch Fixed the issue raised by [PATCH] pgpassfile connection option

Re: [HACKERS] Danger of automatic connection reset in psql

2016-11-22 Thread Pavel Stehule
2016-11-22 13:02 GMT+01:00 Oleksandr Shulgin : > On Tue, Nov 22, 2016 at 5:28 AM, Pavel Stehule > wrote: > >> >> 2016-11-22 3:46 GMT+01:00 Robert Haas : >> >>> On Mon, Nov 21, 2016 at 4:55 AM, Oleksandr Shulgin >>>

Re: [HACKERS] Danger of automatic connection reset in psql

2016-11-22 Thread Oleksandr Shulgin
On Tue, Nov 22, 2016 at 5:28 AM, Pavel Stehule wrote: > > 2016-11-22 3:46 GMT+01:00 Robert Haas : > >> On Mon, Nov 21, 2016 at 4:55 AM, Oleksandr Shulgin >> wrote: >> > On Tue, Nov 15, 2016 at 4:10 PM, Jim Nasby

Re: [HACKERS] sequence data type

2016-11-22 Thread Haribabu Kommi
Hi Vik and Vinayak, This is a gentle reminder. you both are assigned as reviewer's to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you

Re: [HACKERS] identity columns

2016-11-22 Thread Haribabu Kommi
Hi Vitaly, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet on the new patch in this commitfest. Please share your review about the patch. This will help us in smoother operation of commitfest. Please

Re: [HACKERS] raw output from copy

2016-11-22 Thread Haribabu Kommi
Hi, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your review.

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-11-22 Thread Haribabu Kommi
Hi Craig, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your review.

Re: [HACKERS] Push down more full joins in postgres_fdw

2016-11-22 Thread Etsuro Fujita
On 2016/11/22 18:28, Ashutosh Bapat wrote: The comments should explain why is the assertion true. +/* Shouldn't be NIL */ +Assert(tlist != NIL); +/* Should be same length */ +Assert(list_length(tlist) == list_length(foreignrel->reltarget->exprs)); Will revise.

Re: [HACKERS] patch proposal

2016-11-22 Thread Haribabu Kommi
Hi Abhijit, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your

Re: [HACKERS] GiST support for UUIDs

2016-11-22 Thread Haribabu Kommi
On Wed, Nov 2, 2016 at 3:49 AM, Adam Brusselback wrote: > So I apologize in advance if I didn't follow the processes exactly, I was > going to attempt to review this to move it along, but ran into issues > applying the patch cleanly to master. I fixed the issues I was

[HACKERS] [PATCH] ALTER DEFAULT PRIVILEGES with GRANT/REVOKE ON SCHEMAS

2016-11-22 Thread Matheus de Oliveira
Hi all, I noticed that we have no option to set default privileges for newly created schemas, other than calling GRANT explicitly. At work I use ALTER DEFAULT PRIVILEGE (ADP) command extensively, as the developers are permitted to manage DDL on the databases, and all work fine except for when a

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-22 Thread Ashutosh Bapat
On Fri, Nov 18, 2016 at 12:23 PM, Haribabu Kommi wrote: > > > On Thu, Nov 17, 2016 at 10:13 PM, Ashutosh Bapat > wrote: >> >> On Wed, Nov 16, 2016 at 4:40 PM, Ashutosh Bapat >> wrote: >> > make check run

Re: [HACKERS] Push down more UPDATEs/DELETEs in postgres_fdw

2016-11-22 Thread Rushabh Lathia
I started reviewing the patch and here are few initial review points and questions for you. 1) -static void deparseExplicitTargetList(List *tlist, List **retrieved_attrs, +static void deparseExplicitTargetList(bool is_returning, + List *tlist, +

Re: [HACKERS] postgres 9.3 postgres_fdw ::LOG: could not receive data from client: Connection reset by peer

2016-11-22 Thread Vladimir Svedov
Hi, Sorry - tried to reproduce on other machine and gather all statements. And failed Installed 9.3 (which has those symptoms) and still can't reproduce. Must be platform specific, not version 2016-11-21 21:58 GMT+00:00 Kevin Grittner : > On Mon, Nov 21, 2016 at 8:32 AM,

Re: [HACKERS] [RFC] Should we fix postmaster to avoid slow shutdown?

2016-11-22 Thread Ashutosh Bapat
On Tue, Nov 22, 2016 at 12:26 PM, Tsunakawa, Takayuki wrote: > From: Tom Lane [mailto:t...@sss.pgh.pa.us] >> The point I was trying to make is that I think the forced-removal behavior >> is not desirable, and therefore committing a patch that makes it be graven >>

Re: [HACKERS] Re: Use procsignal_sigusr1_handler and RecoveryConflictInterrupt() from walsender?

2016-11-22 Thread Kyotaro HORIGUCHI
No that's not right. At Tue, 22 Nov 2016 17:45:34 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20161122.174534.266086549.horiguchi.kyot...@lab.ntt.co.jp> > Hello, > > At Tue, 22 Nov 2016 12:35:56 +0800, Craig Ringer > wrote

Re: [HACKERS] Push down more full joins in postgres_fdw

2016-11-22 Thread Ashutosh Bapat
The comments should explain why is the assertion true. +/* Shouldn't be NIL */ +Assert(tlist != NIL); +/* Should be same length */ +Assert(list_length(tlist) == list_length(foreignrel->reltarget->exprs)); > > OK, I'd like to propose referencing to

Re: [HACKERS] Fix checkpoint skip logic on idle systems by tracking LSN progress

2016-11-22 Thread Kyotaro HORIGUCHI
I almost forgot this. At Mon, 21 Nov 2016 15:44:08 +0900 (Tokyo Standard Time), Kyotaro HORIGUCHI wrote in <20161121.154408.47398334.horiguchi.kyot...@lab.ntt.co.jp> > Hello, > > At Mon, 21 Nov 2016 14:41:27 +0900, Michael Paquier >

Re: [HACKERS] Measuring replay lag

2016-11-22 Thread Thomas Munro
On Tue, Nov 8, 2016 at 2:35 PM, Masahiko Sawada wrote: > replay_lag_sample_interval is 1s by default but I got 1000s by SHOW command. > postgres(1:36789)=# show replay_lag_sample_interval ; > replay_lag_sample_interval > > 1000s > (1 row)

Re: [HACKERS] Forbid use of LF and CR characters in database and role names

2016-11-22 Thread Ideriha, Takeshi
Hi, Here's a summary for what I tested in RHEL7.0, details follow. [Summary] 1. apply patch and make world -> failed because was mistakenly coded . 2.correct this mistake and make check-world -> got 1 failed test: "'pg_dumpall with \n\r in database name'" because test script cannot

Re: [HACKERS] pg_recvlogical --endpos

2016-11-22 Thread Okano, Naoki
On Monday, November 21, 2016 1:08 PM Craig Ringer wrote: > I've updated the patch for this. It's already posted on the logical > decoding timeline following thread, so I'll avoid repeating it here. > >

Re: [HACKERS] Proposal : For Auto-Prewarm.

2016-11-22 Thread Ashutosh Bapat
> you assigned as reviewer to the current patch in the 11-2016 commitfest. > But you haven't shared your review yet. Please share your views about > the patch. This will help us in smoother operation of commitfest. > Thanks for the reminder. Mithun has not provided a patch addressing the

Re: [HACKERS] Re: Use procsignal_sigusr1_handler and RecoveryConflictInterrupt() from walsender?

2016-11-22 Thread Kyotaro HORIGUCHI
Hello, At Tue, 22 Nov 2016 12:35:56 +0800, Craig Ringer wrote in > On 22 November 2016 at 11:35, Kyotaro HORIGUCHI > wrote: > > Hello, > > > > At Mon, 21 Nov 2016