Re: [HACKERS] Fixing matching of boolean index columns to sort ordering

2017-01-12 Thread Michael Paquier
On Wed, Dec 14, 2016 at 12:18 AM, David G. Johnston wrote: > On Mon, Dec 12, 2016 at 10:08 PM, Tom Lane wrote: >> >> Every WHERE clause is a >> >> boolean expression, so there's no principled reason why such a rule >> wouldn't result in

Re: [HACKERS] Push down more full joins in postgres_fdw

2017-01-12 Thread Etsuro Fujita
On 2017/01/12 18:25, Ashutosh Bapat wrote: On Wed, Jan 11, 2017 at 5:45 PM, Etsuro Fujita wrote: On 2017/01/05 21:11, Ashutosh Bapat wrote: IIUC, for a relation with use_remote_estimates we will deparse the query twice and will build the targetlist twice.

Re: [HACKERS] Misplacement of function declaration in contrib/postgres_fdw/postgres_fdw.h

2017-01-12 Thread Etsuro Fujita
On 2017/01/12 13:52, Ashutosh Bapat wrote: On Thu, Jan 12, 2017 at 8:49 AM, Etsuro Fujita wrote: While working on pushing down more joins/updates to the remote, I noticed that in contrib/postgres_fdw/postgres_fdw.h the declaration of get_jointype_name is misplaced

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-01-12 Thread Masahiko Sawada
On Fri, Jan 13, 2017 at 3:20 PM, Ashutosh Bapat wrote: >>> >> >> Long time passed since original patch proposed by Ashutosh, so I >> explain again about current design and functionality of this feature. >> If you have any question, please feel free to ask. > >

Re: [HACKERS] plpgsql - additional extra checks

2017-01-12 Thread Pavel Stehule
2017-01-13 2:46 GMT+01:00 Jim Nasby : > On 1/11/17 5:54 AM, Pavel Stehule wrote: > >> +too_many_rows >> + >> + >> + When result is assigned to a variable by INTO >> clause, >> + checks if query returns more than one row. In this case the >>

Re: [HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Ashutosh Bapat
On Thu, Jan 12, 2017 at 6:39 PM, Tom Lane wrote: > Ashutosh Bapat writes: >> The member root in foreign_glob_cxt isn't used anywhere by >> postgres_fdw code. Without that member the code compiles and >> regression passes. The member was added

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-01-12 Thread Ashutosh Bapat
>> > > Long time passed since original patch proposed by Ashutosh, so I > explain again about current design and functionality of this feature. > If you have any question, please feel free to ask. Thanks for the summary. > > Parameters > == [ snip ] > > Cluster-wide atomic commit >

Re: [HACKERS] Packages: Again

2017-01-12 Thread Pavel Stehule
2017-01-13 3:07 GMT+01:00 Joshua D. Drake : > On 01/12/2017 03:35 PM, Craig Ringer wrote: > >> >> > >> So far that's all "that'd be nice, but isn't a technical barrier" stuff. >> >> Package variables for example. When _do_ you _need_ them? For what? (I'm >> aware of some

Re: [HACKERS] pg_background contrib module proposal

2017-01-12 Thread amul sul
On Tue, Jan 10, 2017 at 7:09 AM, Jim Nasby wrote: > On 1/9/17 7:22 AM, amul sul wrote: >> >> On Sun, Jan 8, 2017 at 8:50 AM, Jim Nasby >> wrote: >>> >>> >> [skipped...] >>> >>> >>> Oh, hmm. So I guess if you do that when the background process

Re: [HACKERS] Gather Merge

2017-01-12 Thread Rushabh Lathia
On Thu, Jan 12, 2017 at 8:50 AM, Robert Haas wrote: > On Sun, Dec 4, 2016 at 7:36 PM, Haribabu Kommi > wrote: > > On Thu, Nov 24, 2016 at 11:12 PM, Rushabh Lathia < > rushabh.lat...@gmail.com> > > wrote: > >> PFA latest patch with fix as well as

Re: [HACKERS] Cache Hash Index meta page.

2017-01-12 Thread Mithun Cy
On Wed, Jan 11, 2017 at 12:46 AM, Robert Haas wrote: > Can we adapt the ad-hoc caching logic in hashbulkdelete() to work with > this new logic? Or at least update the comments? I have introduced a new function _hash_getcachedmetap in patch 11 [1] with this hashbulkdelete()

Re: [HACKERS] Cache Hash Index meta page.

2017-01-12 Thread Mithun Cy
On Fri, Jan 6, 2017 at 11:43 AM, Amit Kapila wrote: > Few more comments: > 1. > no need to two extra lines, one is sufficient and matches the nearby > coding pattern. -- Fixed. > 2. > Do you see anywhere else in the code the pattern of using @ symbol in > comments

Re: [HACKERS] Patch to implement pg_current_logfile() function

2017-01-12 Thread Michael Paquier
On Thu, Jan 12, 2017 at 9:14 PM, Gilles Darold wrote: > Le 11/01/2017 à 08:39, Michael Paquier a écrit : >> On Wed, Dec 14, 2016 at 12:19 AM, Robert Haas wrote: >>> On Mon, Dec 12, 2016 at 4:31 AM, Gilles Darold >>>

Re: [HACKERS] Patch to implement pg_current_logfile() function

2017-01-12 Thread Michael Paquier
On Thu, Jan 12, 2017 at 9:55 PM, Karl O. Pinc wrote: > On Thu, 12 Jan 2017 13:14:28 +0100 > Gilles Darold wrote: > >> My bad, I was thinking that Karl has planned an update of the patch in >> his last post, sorry for my misunderstanding. > > I was, but

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-12 Thread Bruce Momjian
On Thu, Jan 12, 2017 at 10:17:52AM -0500, Tom Lane wrote: > Peter Eisentraut writes: > > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". > > In pg_upgrade, there is this code: > > ... > > I think the last line should be changed to

Re: [HACKERS] Packages: Again

2017-01-12 Thread Joshua D. Drake
On 01/12/2017 03:35 PM, Craig Ringer wrote: So far that's all "that'd be nice, but isn't a technical barrier" stuff. Package variables for example. When _do_ you _need_ them? For what? (I'm aware of some uses but "when you need them" helps us not at all). Well my answer would be,

Re: [HACKERS] Proposal for changes to recovery.conf API

2017-01-12 Thread Fujii Masao
On Thu, Jan 12, 2017 at 6:46 PM, Simon Riggs wrote: > On 12 January 2017 at 05:49, Fujii Masao wrote: >> On Wed, Jan 11, 2017 at 7:36 PM, Simon Riggs wrote: >>> On 11 January 2017 at 09:51, Fujii Masao

Re: [HACKERS] plpgsql - additional extra checks

2017-01-12 Thread Jim Nasby
On 1/11/17 5:54 AM, Pavel Stehule wrote: +too_many_rows + + + When result is assigned to a variable by INTO clause, + checks if query returns more than one row. In this case the assignment + is not deterministic usually - and it can be signal some issues in design.

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-01-12 Thread Peter Geoghegan
On Wed, Jan 11, 2017 at 7:37 PM, Thomas Munro wrote: > Hmm. Yes, that is an entirely bogus use of isInterXact. I am > thinking about how to fix that with refcounts. Cool. As I said, the way I'd introduce refcounts would not be very different from what I've

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Michael Paquier
On Thu, Jan 12, 2017 at 11:36 PM, Tom Lane wrote: > Peter Eisentraut writes: >> On 1/11/17 11:25 PM, Tom Lane wrote: >>> +1 for the concept, but I'm a bit worried about putting atooid() in >>> postgres_ext.h. That's going to impose on the

Re: [HACKERS] Packages: Again

2017-01-12 Thread Craig Ringer
On 13 Jan. 2017 00:54, "Joshua D. Drake" wrote: On 01/11/2017 04:12 PM, Craig Ringer wrote: What aspects / features of packages were the key issues? > Unfortunately we didn't get too far into it because the webinar was about Postgres specifically. That said, I have been

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Merlin Moncure
On Wed, Jan 11, 2017 at 6:29 PM, Josh Berkus wrote: > Hackers: > > You will have noticed that I haven't been very active for the past year. > My new work on Linux containers and Kubernetes has been even more > absorbing than I anticipated, and I just haven't had a lot of time

Re: [HACKERS] GSoC 2017

2017-01-12 Thread Pavel Stehule
2017-01-12 21:21 GMT+01:00 Jim Nasby : > On 1/10/17 1:53 AM, Alexander Korotkov wrote: > >> 1. What project ideas we have? >> > > Perhaps allowing SQL-only extensions without requiring filesystem files > would be a good project. > Implementation safe evaluation

Re: [HACKERS] Off-by-one oddity in minval for decreasing sequences

2017-01-12 Thread Andrew Dunstan
On 01/12/2017 03:12 PM, Jim Nasby wrote: On 1/10/17 8:07 AM, Robert Haas wrote: This seems like a sensible argument to me, but maybe somebody's got a contrary viewpoint? I suspect the number of users that use negative sequence values is so small that this is unlikely to be noticed. I can't

Re: [HACKERS] GSoC 2017

2017-01-12 Thread Jim Nasby
On 1/10/17 1:53 AM, Alexander Korotkov wrote: 1. What project ideas we have? Perhaps allowing SQL-only extensions without requiring filesystem files would be a good project. -- Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX Experts in Analytics, Data Architecture and PostgreSQL

Re: [HACKERS] Off-by-one oddity in minval for decreasing sequences

2017-01-12 Thread Jim Nasby
On 1/10/17 8:07 AM, Robert Haas wrote: This seems like a sensible argument to me, but maybe somebody's got a contrary viewpoint? I suspect the number of users that use negative sequence values is so small that this is unlikely to be noticed. I can't think of any risk to "closing the hole"

Re: [HACKERS] remove floats from bootstrap scanner/parser

2017-01-12 Thread Jim Nasby
On 1/9/17 9:11 PM, Alvaro Herrera wrote: I happened to notice that we have dead code to parse floating point numbers in the boostrap scanner/parser. This seems unused since forever -- or, more precisely, I couldn't find any floats in 8.2's postgres.bki (the oldest I have around). I would just

Re: [HACKERS] Write Ahead Logging for Hash Indexes

2017-01-12 Thread Jesper Pedersen
On 12/27/2016 01:58 AM, Amit Kapila wrote: After recent commit's 7819ba1e and 25216c98, this patch requires a rebase. Attached is the rebased patch. This needs a rebase after commit e898437. Best regards, Jesper -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Stephen Frost
Andres, * Andres Freund (and...@anarazel.de) wrote: > On January 12, 2017 10:50:18 AM PST, Stephen Frost wrote: > >* Andres Freund (and...@anarazel.de) wrote: > >> On 2017-01-12 13:40:50 -0500, Stephen Frost wrote: > >> > * Jim Nasby (jim.na...@bluetreble.com) wrote: > >> > >

Re: [HACKERS] pageinspect: Hash index support

2017-01-12 Thread Jesper Pedersen
Hi, On 01/11/2017 03:16 PM, Ashutosh Sharma wrote: I have rephrased it to make it more clear. Rebased, and removed the compile warn in hashfuncs.c Best regards, Jesper >From 8a07230b89b97280f0f1d645145da1fd140969c6 Mon Sep 17 00:00:00 2001 From: jesperpedersen

Re: [HACKERS] WARM and indirect indexes

2017-01-12 Thread Jim Nasby
On 1/11/17 8:09 PM, Pavan Deolasee wrote: The other thing the patch changes is how update-chain is maintained. In order to quickly find the root offset while updating a tuple, we now store the root offset in the t_ctid field of the last tuple in the chain and use a separate bit to mark

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Fabien COELHO
About having a pointer to the initial string from RawStmt, Query & PlannedStmt: I remembered one reason why we haven't done this: it's unclear how we'd handle copying if we do it. If, say, Query contains a "char *" pointer then you'd expect copyObject() to pstrdup that string, [..., So]

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Fabien COELHO
[...] it seems a lot cleaner to me. I agree. [...] It's safe in backend-legal encodings. Good:-) [...] The trouble for statements like EXPLAIN is that we replace the sub-statement during parse analysis, [...] Ok. So Node* is fine to keep it generic. -- Fabien. -- Sent via

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Stephen Frost
* Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I just don't buy this argument, at all. These functions names are > > certainly not the only things we're changing with PG10 and serious > > monitoring/backup/administration tools are almost certainly going to

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Andres Freund
On January 12, 2017 10:50:18 AM PST, Stephen Frost wrote: >* Andres Freund (and...@anarazel.de) wrote: >> On 2017-01-12 13:40:50 -0500, Stephen Frost wrote: >> > * Jim Nasby (jim.na...@bluetreble.com) wrote: >> > > The way I see it, either one person can spend an hour or

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Stephen Frost
* Andres Freund (and...@anarazel.de) wrote: > On 2017-01-12 13:40:50 -0500, Stephen Frost wrote: > > * Jim Nasby (jim.na...@bluetreble.com) wrote: > > > The way I see it, either one person can spend an hour or whatever > > > creating an extension once, or every postgres install that's using > > >

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Tom Lane
Stephen Frost writes: > I just don't buy this argument, at all. These functions names are > certainly not the only things we're changing with PG10 and serious > monitoring/backup/administration tools are almost certainly going to > have quite a bit to adjust to with the new

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Andres Freund
On 2017-01-12 13:40:50 -0500, Stephen Frost wrote: > Jim, > > * Jim Nasby (jim.na...@bluetreble.com) wrote: > > The way I see it, either one person can spend an hour or whatever > > creating an extension once, or every postgres install that's using > > any of these functions now has yet another

Re: [HACKERS] merging some features from plpgsql2 project

2017-01-12 Thread Jim Nasby
On 1/11/17 12:07 PM, Pavel Stehule wrote: PL/SQL = ADA + Oracle SQL; -- but sometimes the result is not perfect - Ada was not designed be integrated with SQL ... There is a language that is much better integrated with SQL - SQL/PSM I think it is worth considering ways to increase

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Stephen Frost
Jim, * Jim Nasby (jim.na...@bluetreble.com) wrote: > The way I see it, either one person can spend an hour or whatever > creating an extension once, or every postgres install that's using > any of these functions now has yet another hurdle to upgrading. I just don't buy this argument, at all.

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Tom Lane
I wrote: > Fabien COELHO writes: >> One point bothered me a bit when looking at the initial code, that your >> refactoring has not changed: the location is about a string which is not >> accessible from the node, so that the string must be kept elsewhere and >> passed as a

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Kevin Grittner
On Thu, Jan 12, 2017 at 12:12 PM, Tom Lane wrote: > Vladimir Rusinov writes: >> On Thu, Jan 12, 2017 at 4:57 PM, Euler Taveira wrote: >>> As Robert suggested in the other email: extension to create old names. > >> I don't follow the

Re: [HACKERS] WARM and indirect indexes

2017-01-12 Thread Robert Haas
On Wed, Jan 11, 2017 at 11:09 PM, Pavan Deolasee wrote: > I think as a developer of the patch, what I would like to know is what can > we do address concerns raised by you? What kind of tests you would like to > do to get confidence in the patch? Well, off the top of my

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Jim Nasby
On 1/12/17 10:12 AM, Tom Lane wrote: Yeah, I'm not terribly for the extension idea. Robert cited the precedent of contrib/tsearch2, but I think the history of that is a good argument against this: tsearch2 is still there 9 years later and there's no indication that we'll ever get rid of it. We

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Tom Lane
Fabien COELHO writes: >> [...] Furthermore, the output of pg_plan_queries is now always a list of >> PlannedStmt nodes, even for utility statements. > I stopped exactly there when I tried: I thought that changing that would > be enough to get a reject because it would be

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Roberto Mello
On Wed, Jan 11, 2017 at 8:29 PM, Josh Berkus wrote: > > For that reason, as of today, I am stepping down from the PostgreSQL > Core Team. Thank you for all your hard work and contributions to the project over the years Josh. Sometimes the work of PR and documentation (among

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Tom Lane
Vladimir Rusinov writes: > On Thu, Jan 12, 2017 at 4:57 PM, Euler Taveira wrote: >> As Robert suggested in the other email: extension to create old names. > I don't follow the reasoning for the extension. It seem to have downsides > of both

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Vladimir Rusinov
On Thu, Jan 12, 2017 at 4:57 PM, Euler Taveira wrote: > As Robert suggested in the other email: extension to create old names. I don't follow the reasoning for the extension. It seem to have downsides of both alternatives combined: we still break people's code, and we add

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Fabien COELHO
Hello Tom, Yeah, I doubt that this technique for getting the raw locations in the grammar+lexer works reliably. It worked reliably on all tests, and the assumption seemed sound to me, given the one-look-ahead property and that statement reductions can only triggered when ';' or end of

Re: [HACKERS] Improvements in psql hooks for variables

2017-01-12 Thread Tom Lane
"Daniel Verite" writes: > [ psql-var-hooks-v6.patch ] I took a quick look through this. It seems to be going in generally the right direction, but here's a couple of thoughts: * It seems like you're making life hard for yourself, and confusing for readers, by having

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Euler Taveira
On 12-01-2017 10:56, David Steele wrote: >> So, to sum up things on this thread, here are the votes about the use >> of aliases or a pure breakage: >> - No to aliases, shake the world: Stephen, Tom, David F, Vik, Bruce M => 5 >> - Yes to aliases: Michael P, Andres, Peter E., Cynthia S, Jim N, >>

Re: [HACKERS] Packages: Again

2017-01-12 Thread Joshua D. Drake
On 01/11/2017 04:12 PM, Craig Ringer wrote: What aspects / features of packages were the key issues? Unfortunately we didn't get too far into it because the webinar was about Postgres specifically. That said, I have been doing some followup. Here is some of it: because packages[1] o

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Euler Taveira
On 11-01-2017 21:29, Josh Berkus wrote: > For that reason, as of today, I am stepping down from the PostgreSQL > Core Team. > Thanks for your hard work! Your contributions were very important and valuable for community growth. I'm sure you will continue to advocate PostgreSQL. -- Euler

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Joshua D. Drake
On 01/12/2017 07:48 AM, Jonathan Katz wrote: On Jan 11, 2017, at 7:29 PM, Josh Berkus wrote: It's been a long, fun ride, and I'm proud of the PostgreSQL we have today: both the database, and the community. Thank you for sharing it with me. Thank you for all of your

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Vladimir Rusinov
On Thu, Jan 12, 2017 at 5:49 AM, Michael Paquier wrote: > The patch still updates a bunch of .po files. Those are normally > refreshed with the translation updates, so they had better be removed. > Other than that, the patch looks in good shape to me so switch to >

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Jonathan Katz
> On Jan 11, 2017, at 7:29 PM, Josh Berkus wrote: > > It's been a long, fun ride, and I'm proud of the PostgreSQL we have > today: both the database, and the community. Thank you for sharing it > with me. Thank you for all of your contributions to the PostgreSQL community

Re: [HACKERS] postgres_fdw bug in 9.6

2017-01-12 Thread Robert Haas
On Wed, Jan 11, 2017 at 2:45 AM, Etsuro Fujita wrote: > As I said before, that might be fine for 9.6, but I don't think it's a good > idea to search the pathlist because once we support parameterized foreign > join paths, which is on my TODOs, we would have to

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Dave Cramer
On 11 January 2017 at 16:29, Josh Berkus wrote: > Hackers: > > You will have noticed that I haven't been very active for the past year. > My new work on Linux containers and Kubernetes has been even more > absorbing than I anticipated, and I just haven't had a lot of time for

Re: [HACKERS] UNDO and in-place update

2017-01-12 Thread Robert Haas
On Wed, Jan 11, 2017 at 5:18 AM, Amit Kapila wrote: > Moving further, I have thought about consistent reads and different > formats for storing undo with pros and cons of each format. > > Consistent Reads > > If the page is modified by any

Re: [HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-12 Thread Tom Lane
Peter Eisentraut writes: > In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". > In pg_upgrade, there is this code: > ... > I think the last line should be changed to something like > fast ? "-m fast" : "-m smart"); Ugh.

[HACKERS] pg_upgrade vs. pg_ctl stop -m fast

2017-01-12 Thread Peter Eisentraut
In 9.5, the default pg_ctl stop mode was changed from "smart" to "fast". In pg_upgrade, there is this code: void stop_postmaster(bool fast) { ... exec_prog(SERVER_STOP_LOG_FILE, NULL, !fast, "\"%s/pg_ctl\" -w -D \"%s\" -o \"%s\" %s stop", cluster->bindir,

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Jesper Pedersen
On 01/11/2017 07:29 PM, Josh Berkus wrote: You will have noticed that I haven't been very active for the past year. My new work on Linux containers and Kubernetes has been even more absorbing than I anticipated, and I just haven't had a lot of time for PostgreSQL work. For that reason, as of

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Tom Lane
Peter Eisentraut writes: > On 1/11/17 11:25 PM, Tom Lane wrote: >> +1 for the concept, but I'm a bit worried about putting atooid() in >> postgres_ext.h. That's going to impose on the namespace of libpq-using >> applications, for instance. A more conservative

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread Robert Haas
On Thu, Jan 12, 2017 at 8:56 AM, David Steele wrote: >> So, to sum up things on this thread, here are the votes about the use >> of aliases or a pure breakage: >> - No to aliases, shake the world: Stephen, Tom, David F, Vik, Bruce M => 5 >> - Yes to aliases: Michael P,

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Tom Lane
Kyotaro HORIGUCHI writes: > At Fri, 30 Dec 2016 15:10:42 +0100 (CET), Fabien COELHO > wrote in >> - I cannot use the intermediate node trick suggested by Tom because >> it does not work for

Re: [HACKERS] parallelize queries containing subplans

2017-01-12 Thread Amit Kapila
On Thu, Jan 12, 2017 at 8:51 AM, Robert Haas wrote: > On Wed, Jan 11, 2017 at 9:58 PM, Amit Kapila wrote: >> The other alternative is to remember this information in SubPlan. We >> can retrieve parallel_safe information from best_path and can use

Re: [HACKERS] [PATCH] Fix minor race in commit_ts SLRU truncation vs lookups

2017-01-12 Thread Peter Eisentraut
On 12/29/16 4:28 AM, Craig Ringer wrote: > On 29 December 2016 at 16:51, Craig Ringer wrote: >> On 28 December 2016 at 22:16, Petr Jelinek >> wrote: >> >>> About the patch, it looks good to me for master with the minor exception >>> that:

Re: [HACKERS] Obsolete reference to ParallelMain() in a comment

2017-01-12 Thread Robert Haas
On Wed, Jan 11, 2017 at 2:38 AM, Amit Langote wrote: > The comment above ParallelQueryMain() still refers to ParallelMain() as > its caller which is no longer the case. Attached fixes that. Oops. Thanks, committed. -- Robert Haas EnterpriseDB:

Re: [HACKERS] [PATCH] Rename pg_switch_xlog to pg_switch_wal

2017-01-12 Thread David Steele
On 1/12/17 12:49 AM, Michael Paquier wrote: > On Thu, Jan 12, 2017 at 2:00 AM, Vladimir Rusinov wrote: >> On Tue, Jan 10, 2017 at 5:24 AM, Michael Paquier >> wrote: >>> As there are two school of thoughts on this thread, keeping your patch >>> with

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Peter Eisentraut
On 1/12/17 12:25 AM, Kuntal Ghosh wrote: > On Wed, Jan 11, 2017 at 9:42 PM, Peter Eisentraut > wrote: >> There are approximately 11 copies of atooid() and 3 of oid_cmp() or >> equivalent, and pending patches are proposing to add more. I propose >> these two

Re: [HACKERS] many copies of atooid() and oid_cmp()

2017-01-12 Thread Peter Eisentraut
On 1/11/17 11:25 PM, Tom Lane wrote: > Peter Eisentraut writes: >> There are approximately 11 copies of atooid() and 3 of oid_cmp() or >> equivalent, and pending patches are proposing to add more. I propose >> these two patches to collect them in central places.

Re: [HACKERS] Proposal for changes to recovery.conf API

2017-01-12 Thread Peter Eisentraut
On 1/11/17 5:27 AM, Simon Riggs wrote: > The main area of "design doubt" remains the implementation of the > recovery_target parameter set. Are we happy with the user interface > choices in the patch, given the understanding that the situation was > more comple than at first thought? Could you

Re: [HACKERS] BUG: pg_stat_statements query normalization issues with combined queries

2017-01-12 Thread Kyotaro HORIGUCHI
Hello, At Fri, 30 Dec 2016 15:10:42 +0100 (CET), Fabien COELHO wrote in > > Hello, > > >> Yeah, that's what I was thinking of. There aren't very many places > >> that > >> would need to know about that, I believe; [...] > > >

Re: [HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Tom Lane
Ashutosh Bapat writes: > The member root in foreign_glob_cxt isn't used anywhere by > postgres_fdw code. Without that member the code compiles and > regression passes. The member was added by d0d75c40. I looked at that > commit briefly but did not find any code

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Andrew Dunstan
On 01/11/2017 07:29 PM, Josh Berkus wrote: Hackers: You will have noticed that I haven't been very active for the past year. My new work on Linux containers and Kubernetes has been even more absorbing than I anticipated, and I just haven't had a lot of time for PostgreSQL work. For that

Re: [HACKERS] Patch to implement pg_current_logfile() function

2017-01-12 Thread Karl O. Pinc
On Thu, 12 Jan 2017 13:14:28 +0100 Gilles Darold wrote: > My bad, I was thinking that Karl has planned an update of the patch in > his last post, sorry for my misunderstanding. I was, but have been swept along by events and not gotten to it. Karl

Re: [HACKERS] Passing query string to workers

2017-01-12 Thread Robert Haas
On Wed, Jan 11, 2017 at 11:12 PM, Tom Lane wrote: > Robert Haas writes: >> On Wed, Jan 11, 2017 at 6:36 PM, Tom Lane wrote: >>> That would work, if you had a way to get at the active QueryDesc ... >>> but we don't pass that down to

[HACKERS] Unused member root in foreign_glob_cxt

2017-01-12 Thread Ashutosh Bapat
Hi, The member root in foreign_glob_cxt isn't used anywhere by postgres_fdw code. Without that member the code compiles and regression passes. The member was added by d0d75c40. I looked at that commit briefly but did not find any code using it there. So, possibly it's unused since it was

Re: [HACKERS] Parallel bitmap heap scan

2017-01-12 Thread Dilip Kumar
On Thu, Jan 12, 2017 at 5:22 PM, Rafia Sabih wrote: > Hello Dilip, > I was trying to test the performance of all the parallel query related > patches on TPC-H queries, I found that when parallel hash [1 ]and your > patch are applied then Q10 and Q14 were hanged,

Re: [HACKERS] Patch to implement pg_current_logfile() function

2017-01-12 Thread Gilles Darold
Le 11/01/2017 à 08:39, Michael Paquier a écrit : > On Wed, Dec 14, 2016 at 12:19 AM, Robert Haas wrote: >> On Mon, Dec 12, 2016 at 4:31 AM, Gilles Darold >> wrote: >>> Applied in last version of the patch v18 as well as removing of an >>> unused

Re: [HACKERS] Parallel Index-only scan

2017-01-12 Thread Rahila Syed
Hello, On applying the patch on latest master branch and running regression tests following failure occurs. I applied it on latest parallel index scan patches as given in the link above. *** /home/rahila/postgres/postgres/src/test/regress/expected/select_parallel.out 2017-01-03

Re: [HACKERS] Parallel bitmap heap scan

2017-01-12 Thread Rafia Sabih
On Wed, Jan 11, 2017 at 5:33 PM, tushar wrote: > > On 01/10/2017 05:16 PM, Dilip Kumar wrote: >> >> Please try attached patch and confirm from your >> side. > > Thanks,issue seems to be fixed now. > > > -- > regards,tushar > EnterpriseDB

Re: [HACKERS] Retiring from the Core Team

2017-01-12 Thread Masahiko Sawada
On Thu, Jan 12, 2017 at 9:29 AM, Josh Berkus wrote: > Hackers: > > For that reason, as of today, I am stepping down from the PostgreSQL > Core Team. > Thank you for all your efforts! Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-01-12 Thread Masahiko Sawada
On Fri, Dec 23, 2016 at 1:49 AM, Masahiko Sawada wrote: > On Fri, Dec 9, 2016 at 4:02 PM, Masahiko Sawada wrote: >> On Fri, Dec 9, 2016 at 3:02 PM, vinayak >> wrote: >>> On 2016/12/05 14:42, Ashutosh Bapat wrote:

Re: [HACKERS] WIP: [[Parallel] Shared] Hash

2017-01-12 Thread Rafia Sabih
On Thu, Jan 12, 2017 at 9:07 AM, Thomas Munro wrote: > On Wed, Jan 11, 2017 at 2:56 PM, Peter Geoghegan wrote: > > On Fri, Jan 6, 2017 at 12:01 PM, Thomas Munro > > wrote: > >> Here is a new WIP patch. I have

Re: [HACKERS] Proposal for changes to recovery.conf API

2017-01-12 Thread Simon Riggs
On 12 January 2017 at 05:49, Fujii Masao wrote: > On Wed, Jan 11, 2017 at 7:36 PM, Simon Riggs wrote: >> On 11 January 2017 at 09:51, Fujii Masao wrote: >> 5. recovery.conf parameters are all moved to postgresql.conf,

Re: [HACKERS] Push down more full joins in postgres_fdw

2017-01-12 Thread Ashutosh Bapat
On Wed, Jan 11, 2017 at 5:45 PM, Etsuro Fujita wrote: > On 2017/01/05 21:38, Ashutosh Bapat wrote: >> >> On Thu, Jan 5, 2017 at 5:51 PM, Etsuro Fujita >> wrote: >>> >>> On 2017/01/05 21:11, Ashutosh Bapat wrote: > > > On 2017/01/03