[HACKERS] [GSOC] [Weekly report 2] Eliminate O(N^2) scaling from rw-conflict tracking in serializable transactions

2017-06-14 Thread Mengxing Liu
Hi, all. In the last week, I replaced linked list with hash table in SerializableXact. I only replace inConflicts and outConflicts. The other linked lists, such as possibleUnsafeConflicts, I will modify them after other things work well. There are still some bugs: the abort rate is much

Re: [HACKERS] Default Partition for Range

2017-06-14 Thread Beena Emerson
Hello, PFA the updated patch. This is rebased over v21 patches of list partition. (http://www.mail-archive.com/pgsql-hackers@postgresql.org/msg316818.html) -- Beena Emerson EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company default_range_partition_v5.patch

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-06-14 Thread Amit Langote
Thanks for taking a look. On 2017/06/14 20:06, Ashutosh Bapat wrote: > On Wed, Jun 14, 2017 at 9:20 AM, Amit Langote > wrote: >> >> By the way, I mentioned an existing problem in one of the earlier emails >> on this thread about differing attribute numbers in the

[HACKERS] Misnaming of staext_dependencies_load

2017-06-14 Thread Kyotaro HORIGUCHI
Hello. It is annoying that only staext_dependencies_load is prefixed with "staext" (two t's) among several similar names prefixed by "statext"(three t's). Should we rename it to have the same prefix? regards, -- Kyotaro Horiguchi NTT Open Source Software Center diff --git

Re: [HACKERS] Proposal : For Auto-Prewarm.

2017-06-14 Thread Mithun Cy
On Mon, Jun 12, 2017 at 7:34 PM, Amit Kapila wrote: > On Mon, Jun 12, 2017 at 6:31 AM, Mithun Cy > wrote: > > Thanks, Amit, > > > > + /* Perform autoprewarm's task. */ > + if (todo_task == TASK_PREWARM_BUFFERPOOL && > +

Re: [HACKERS] Disallowing multiple queries per PQexec()

2017-06-14 Thread Pavel Stehule
2017-06-14 19:56 GMT+02:00 Andres Freund : > On 2017-06-12 10:32:57 -0400, Tom Lane wrote: > > "Daniel Verite" writes: > > > PGC_POSTMASTER implies that it's an instance-wide setting. > > > Is is intentional? I can understand that it's more secure for

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Pavel Stehule
2017-06-15 5:06 GMT+02:00 Andres Freund : > On 2017-06-14 20:02:27 -0700, Andres Freund wrote: > > On June 14, 2017 7:53:05 PM PDT, Pavel Stehule > wrote: > > >2017-06-14 19:49 GMT+02:00 Andres Freund : > > >> > These constraints

Re: [HACKERS] improve release-note for pg_current_logfile()

2017-06-14 Thread Tatsuo Ishii
>> Add function pg_current_logfile() to read syslog's current stderr and csvlog >> output file names (Gilles Darold) > > This confused me because "syslog" is one of method for logging as well > as stderr and csvlog. I guess it is intended syslogger, but I think that > "logging collector" is more

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Andres Freund
On 2017-06-14 20:02:27 -0700, Andres Freund wrote: > On June 14, 2017 7:53:05 PM PDT, Pavel Stehule > wrote: > >2017-06-14 19:49 GMT+02:00 Andres Freund : > >> > These constraints can slowdown creating/dropping database objects - > >> mainly > >> >

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Pavel Stehule
2017-06-15 5:02 GMT+02:00 Andres Freund : > > > On June 14, 2017 7:53:05 PM PDT, Pavel Stehule > wrote: > >2017-06-14 19:49 GMT+02:00 Andres Freund : > > > >> On 2017-06-14 06:05:24 +0200, Pavel Stehule wrote: > >> > 2017-06-14

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Andres Freund
On June 14, 2017 7:53:05 PM PDT, Pavel Stehule wrote: >2017-06-14 19:49 GMT+02:00 Andres Freund : > >> On 2017-06-14 06:05:24 +0200, Pavel Stehule wrote: >> > 2017-06-14 5:53 GMT+02:00 Peter Eisentraut < >> peter.eisentr...@2ndquadrant.com >> > >: >>

Re: [HACKERS] Assorted leaks of PGresults

2017-06-14 Thread Michael Paquier
On Thu, Jun 15, 2017 at 9:36 AM, Tom Lane wrote: > Coverity complained that libpqwalreceiver.c's libpqrcv_PQexec() > potentially leaks a PGresult. It's right: if PQconsumeInput() fails after > we've already collected at least one PGresult, the function just returns > NULL

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Pavel Stehule
2017-06-14 19:49 GMT+02:00 Andres Freund : > On 2017-06-14 06:05:24 +0200, Pavel Stehule wrote: > > 2017-06-14 5:53 GMT+02:00 Peter Eisentraut < > peter.eisentr...@2ndquadrant.com > > >: > > > > > On 6/13/17 17:08, Andres Freund wrote: > > > > I wondered before if we shouldn't

Re: [HACKERS] Update comments in nodeModifyTable.c

2017-06-14 Thread Etsuro Fujita
On 2017/06/07 0:30, Robert Haas wrote: On Mon, Jun 5, 2017 at 4:45 AM, Etsuro Fujita wrote: While working on [1], I noticed that the comment in ExecModifyTable: * Foreign table updates have a wholerow attribute when the *

Re: [HACKERS] type of release note of PG10

2017-06-14 Thread Tatsuo Ishii
> Hi, > > I found a typo in the PG10 release note and attached is a patch > to fix it. Fix committed. Thanks! -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via pgsql-hackers mailing list

Re: [HACKERS] Something is rotten in publication drop

2017-06-14 Thread Noah Misch
On Fri, Jun 09, 2017 at 11:45:58AM -0400, Tom Lane wrote: > Peter Eisentraut writes: > > On 6/8/17 23:53, Tom Lane wrote: > >> ! ERROR: publication "addr_pub" does not exist > > > The \d+ command attempts to print out any publications that the relation > > is

Re: [HACKERS] Race conditions with WAL sender PID lookups

2017-06-14 Thread Noah Misch
On Tue, Jun 13, 2017 at 11:16:54AM +0900, Michael Paquier wrote: > On Thu, Jun 8, 2017 at 1:15 PM, Michael Paquier > wrote: > > 3) In walreceiver.c's pg_stat_get_wal_receiver's: > > - Launch pg_stat_get_wal_receiver and take a checkpoint on it. > > - Pass the lookups of

Re: [HACKERS] GSoC 2017 weekly progress reports (week 2)

2017-06-14 Thread Alvaro Herrera
Shubham Barai wrote: > Hi, > > I have made some changes in tests and pushed them to my branch. > > Thanks for helping me out with testing. > > Now, current head produces false positives but, with my patch, it doesn't. > > Here is the link for updated tests: >

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-06-14 Thread Masahiko Sawada
On Thu, Jun 15, 2017 at 7:35 AM, Petr Jelinek wrote: > On 13/06/17 21:49, Peter Eisentraut wrote: >> On 6/13/17 02:33, Noah Misch wrote: Steps to reproduce - X cluster -> create 100 tables , publish all tables (create publication pub for all

[HACKERS] Assorted leaks of PGresults

2017-06-14 Thread Tom Lane
Coverity complained that libpqwalreceiver.c's libpqrcv_PQexec() potentially leaks a PGresult. It's right: if PQconsumeInput() fails after we've already collected at least one PGresult, the function just returns NULL without remembering to free last_result. That's easy enough to fix, just insert

Re: [HACKERS] logical replication: \dRp+ and "for all tables"

2017-06-14 Thread Mark Kirkwood
On 15/06/17 11:10, Tom Lane wrote: Jeff Janes writes: On Sat, Jun 10, 2017 at 7:42 AM, Tom Lane wrote: In the second place, this really fails to respond to what I'd call the main usability problem with \dRp+, which is that the all-tables property is

Re: [HACKERS] logical replication: \dRp+ and "for all tables"

2017-06-14 Thread David G. Johnston
On Wed, Jun 14, 2017 at 4:10 PM, Tom Lane wrote: > I was hoping we'd get some more votes in this thread, but it seems like > we've only got three, and by my count two of them are for just printing > "all tables". The following looks right - given a publication it would nice

Re: [HACKERS] subscription worker signalling wal writer too much

2017-06-14 Thread Andres Freund
On 2017-06-14 16:24:27 -0700, Jeff Janes wrote: > On Wed, Jun 14, 2017 at 3:20 PM, Andres Freund wrote: > > > On 2017-06-14 15:08:49 -0700, Jeff Janes wrote: > > > On Wed, Jun 14, 2017 at 11:55 AM, Jeff Janes > > wrote: > > > > > > > If I publish a

Re: [HACKERS] subscription worker signalling wal writer too much

2017-06-14 Thread Jeff Janes
On Wed, Jun 14, 2017 at 3:20 PM, Andres Freund wrote: > On 2017-06-14 15:08:49 -0700, Jeff Janes wrote: > > On Wed, Jun 14, 2017 at 11:55 AM, Jeff Janes > wrote: > > > > > If I publish a pgbench workload and subscribe to it, the subscription > > >

Re: [HACKERS] Document bug regarding read only transactions

2017-06-14 Thread Tatsuo Ishii
> It used to be true. Tom changed it in commit > 05d8a561ff85db1545f5768fe8d8dc9d99ad2ef7, back in 2010. Thank you for the info. For a record, I will add it to the commit message. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php

Re: [HACKERS] logical replication: \dRp+ and "for all tables"

2017-06-14 Thread Tom Lane
Jeff Janes writes: > On Sat, Jun 10, 2017 at 7:42 AM, Tom Lane wrote: >> In the second place, this really fails to respond to what I'd call >> the main usability problem with \dRp+, which is that the all-tables >> property is likely to lead to an

Re: [HACKERS] transition table behavior with inheritance appears broken

2017-06-14 Thread Andrew Gierth
> "Andrew" == Andrew Gierth writes: Andrew> I will post a further status update before 23:59 BST on 14th Andrew> Jun. Unfortunately I've been delayed over the past couple of days, but I have Thomas' latest patchset in hand and will be working on it over the

Re: [HACKERS] logical replication busy-waiting on a lock

2017-06-14 Thread Petr Jelinek
On 14/06/17 20:57, Andres Freund wrote: > Hi, > > On 2017-06-13 00:50:20 -0700, Andres Freund wrote: >> Just to be clear: The patch, after the first point above (which I did), >> looks ok. I'm just looking for comments. > > And pushed. > Thanks! -- Petr Jelinek

Re: [HACKERS] Get stuck when dropping a subscription during synchronizing table

2017-06-14 Thread Petr Jelinek
On 13/06/17 21:49, Peter Eisentraut wrote: > On 6/13/17 02:33, Noah Misch wrote: >>> Steps to reproduce - >>> X cluster -> create 100 tables , publish all tables (create publication pub >>> for all tables); >>> Y Cluster -> create 100 tables ,create subscription(create subscription sub >>>

Re: [HACKERS] memory fields from getrusage()

2017-06-14 Thread Justin Pryzby
On Tue, Jun 13, 2017 at 12:16:00PM -0400, Robert Haas wrote: > It might be worth adding platform-specific code for common platforms. All I care (which linux happily/happens to support) is maxrss; I was probably originally interested in this while digging into an issue with hash agg. I think it's

Re: [HACKERS] Buildfarm failures on woodlouse (in ecpg-check)

2017-06-14 Thread Christian Ullrich
* I wrote: If there is interest in fixing this issue that is apparently limited to VS 2013, I will try and produce a proper patch. Patch. Perhaps surprisingly, the bug is in the failing test cases themselves, not ecpg. The CRT has two modes for its locale implementation: When called in a

Re: [HACKERS] subscription worker signalling wal writer too much

2017-06-14 Thread Andres Freund
On 2017-06-14 15:08:49 -0700, Jeff Janes wrote: > On Wed, Jun 14, 2017 at 11:55 AM, Jeff Janes wrote: > > > If I publish a pgbench workload and subscribe to it, the subscription > > worker is signalling the wal writer thousands of times a second, once for > > every async

Re: [HACKERS] subscription worker signalling wal writer too much

2017-06-14 Thread Jeff Janes
On Wed, Jun 14, 2017 at 11:55 AM, Jeff Janes wrote: > If I publish a pgbench workload and subscribe to it, the subscription > worker is signalling the wal writer thousands of times a second, once for > every async commit. This has a noticeable performance cost. > I've

Re: [HACKERS] intermittent failures in Cygwin from select_parallel tests

2017-06-14 Thread Tom Lane
I wrote: > But surely the silent treatment should only apply to DSM_OP_CREATE? Oh ... scratch that, it *does* only apply to DSM_OP_CREATE. The lack of any other message before the 'could not map' failure must, then, mean that dsm_attach() couldn't find an entry in shared memory that it wanted to

Re: [HACKERS] intermittent failures in Cygwin from select_parallel tests

2017-06-14 Thread Tom Lane
Robert Haas writes: > On Wed, Jun 14, 2017 at 3:33 PM, Tom Lane wrote: >> So the first problem here is the lack of supporting information for the >> 'could not map' failure. > Hmm. I think I believed at the time I wrote dsm_attach() that > somebody

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Stephen Frost
Peter, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 6/13/17 18:11, Stephen Frost wrote: > >> Let's see a proposal in those terms then. How easy can you make it, > >> compared to existing OS-level solutions, and will that justify the > >> maintenance overhead? > > From the

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Peter Eisentraut
On 6/13/17 18:11, Stephen Frost wrote: >> Let's see a proposal in those terms then. How easy can you make it, >> compared to existing OS-level solutions, and will that justify the >> maintenance overhead? > From the original post on this thread, which included a WIP patch: > >

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Peter Eisentraut
On 6/14/17 05:04, Aleksander Alekseev wrote: > A few companies that hired system administrators that are too > lazy to read two or three man pages is not a reason to re-implement file > system encryption (or compression, or mirroring if that matters) in any > open source RDBMS. To be fair, we did

Re: [HACKERS] Document bug regarding read only transactions

2017-06-14 Thread Robert Haas
On Tue, Jun 13, 2017 at 10:08 PM, Tatsuo Ishii wrote: > In > https://www.postgresql.org/docs/10/static/hot-standby.html#hot-standby-users > > It is explained that read only transactions (not in standby) allow to > update sequences. > > In normal operation, read-only

Re: [HACKERS] RTE_NAMEDTUPLESTORE, enrtuples and comments

2017-06-14 Thread Robert Haas
On Tue, Jun 13, 2017 at 4:56 PM, Thomas Munro wrote: > On Wed, Jun 14, 2017 at 4:22 AM, Robert Haas wrote: >> I'm just trying to understand your comments so that I can have an >> intelligent opinion about what we should do from here. Given

Re: [HACKERS] pgbench tap tests & minor fixes

2017-06-14 Thread Nikolay Shaplov
В письме от 8 июня 2017 19:56:02 пользователь Fabien COELHO написал: > > So this should be fixed in both expr_scanner_get_substring cases, and keep > > last symbol only if it is not "\n". > > Indeed, this is a mess. The code assumes all stuff is a line ending with > '\n', but this is not always

Re: [HACKERS] intermittent failures in Cygwin from select_parallel tests

2017-06-14 Thread Robert Haas
On Wed, Jun 14, 2017 at 3:33 PM, Tom Lane wrote: > So the first problem here is the lack of supporting information for the > 'could not map' failure. Hmm. I think I believed at the time I wrote dsm_attach() that somebody might want to try to soldier on after failing to map a

Re: [HACKERS] Adding support for Default partition in partitioning

2017-06-14 Thread Robert Haas
On Wed, Jun 14, 2017 at 8:02 AM, Jeevan Ladhe wrote: > Here are the details of the patches in attached zip. > 0001. refactoring existing ATExecAttachPartition code so that it can be > used for > default partitioning as well > 0002. support for default partition

Re: [HACKERS] intermittent failures in Cygwin from select_parallel tests

2017-06-14 Thread Tom Lane
Yesterday lorikeet failed the select_parallel test in a new way: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=lorikeet=2017-06-13%2020%3A28%3A33 2017-06-13 16:44:57.247 EDT [59404ec9.2e78:1] ERROR: could not map dynamic shared memory segment 2017-06-13 16:44:57.248 EDT

Re: [HACKERS] logical replication busy-waiting on a lock

2017-06-14 Thread Andres Freund
Hi, On 2017-06-13 00:50:20 -0700, Andres Freund wrote: > Just to be clear: The patch, after the first point above (which I did), > looks ok. I'm just looking for comments. And pushed. - Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] subscription worker signalling wal writer too much

2017-06-14 Thread Jeff Janes
If I publish a pgbench workload and subscribe to it, the subscription worker is signalling the wal writer thousands of times a second, once for every async commit. This has a noticeable performance cost. I don't think it is ever necessary to signal the wal writer here, unless wal writer is

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Tom Lane
Piotr Stefaniak writes: > I would like to go a bit further than that. I see that GNU indent > doesn't recognize -V, but prints its version if you use the option > --version. I wish to implement the same option for FreeBSD indent, but > that would force a change in how

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Piotr Stefaniak
On 2017-06-14 17:05, Bruce Momjian wrote: > On Wed, Jun 14, 2017 at 10:38:40AM -0400, Tom Lane wrote: >> btw, I was slightly amused to notice that this version still calls itself >> >> $ indent -V >> pg_bsd_indent 1.3 >> >> Don't know what you plan to do with that program name, but we certainly >>

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Piotr Stefaniak
On 2017-06-14 19:31, Tom Lane wrote: > Does that test case pass for you? No, I broke it recently. Sorry. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Disallowing multiple queries per PQexec()

2017-06-14 Thread Andres Freund
On 2017-06-12 10:32:57 -0400, Tom Lane wrote: > "Daniel Verite" writes: > > PGC_POSTMASTER implies that it's an instance-wide setting. > > Is is intentional? I can understand that it's more secure for this not to > > be changeable in an existing session, but it's also

Re: [HACKERS] v10beta pg_catalog diagrams

2017-06-14 Thread Andres Freund
On 2017-06-14 06:05:24 +0200, Pavel Stehule wrote: > 2017-06-14 5:53 GMT+02:00 Peter Eisentraut >: > > > On 6/13/17 17:08, Andres Freund wrote: > > > I wondered before if we shouldn't introduce "information only" > > > unenforced foreign key constraints for the

Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-14 Thread Masahiko Sawada
On Wed, Jun 14, 2017 at 10:44 PM, Tom Lane wrote: > Masahiko Sawada writes: >> Currently $subject but should we use CatalogTupleDelete() instead? >> It's actually the same behavior though. Other functions use >> CatalogTupleXXX(). Attached patch. > >

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Tom Lane
Piotr Stefaniak writes: > On 2017-06-13 18:22, Tom Lane wrote: >> Also, I am wondering about the test cases under tests/. I do not >> see anything in the Makefile or elsewhere suggesting how those are >> to be used. It would sure be nice to have some quick

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-06-14 Thread Robert Haas
On Wed, Jun 14, 2017 at 6:15 AM, Ashutosh Bapat wrote: > PFA patch set addressing comments by Tom and Amit. LGTM. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] outfuncs.c utility statement support

2017-06-14 Thread Tom Lane
Peter Eisentraut writes: > So this seems to be a pretty basic bug. Some node fields of type char > may be zero, and so printing them as a zero byte just truncates the > whole output string. This could be fixed by printing chars like strings > with the full

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Bruce Momjian
On Wed, Jun 14, 2017 at 06:41:43PM +0300, Ants Aasma wrote: > On Wed, Jun 14, 2017 at 6:26 PM, Bruce Momjian wrote: > > Are you checking the CPU type or if AES instructions are enabled on the > > CPU? I ask this because I just realized in researching my new TLS talk > > that my

Re: [HACKERS] GSoC 2017 weekly progress reports (week 2)

2017-06-14 Thread Shubham Barai
Hi, I have made some changes in tests and pushed them to my branch. Thanks for helping me out with testing. Now, current head produces false positives but, with my patch, it doesn't. Here is the link for updated tests:

Re: [HACKERS] outfuncs.c utility statement support

2017-06-14 Thread Robert Haas
On Tue, Jun 13, 2017 at 11:59 PM, Amit Langote wrote: >> So this seems to be a pretty basic bug. Some node fields of type char >> may be zero, and so printing them as a zero byte just truncates the >> whole output string. This could be fixed by printing chars like

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Ants Aasma
On Wed, Jun 14, 2017 at 6:26 PM, Bruce Momjian wrote: > Are you checking the CPU type or if AES instructions are enabled on the > CPU? I ask this because I just realized in researching my new TLS talk > that my BIOS defaults to AES instructions disabled, and I had to > manually

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Bruce Momjian
On Wed, Jun 14, 2017 at 06:10:32PM +0300, Ants Aasma wrote: > On Tue, Jun 13, 2017 at 6:35 PM, Robert Haas wrote: > > Performance is likely to be poor on large databases, > > because every time a page transits between shared_buffers and the > > buffer cache we've got to

Re: [HACKERS] Disallowing multiple queries per PQexec()

2017-06-14 Thread Fabien COELHO
Hello Surafel, My 0.02€: I attach a patch that incorporate the comments and uses similar routines with the rest of the file rather than using command tag I'm not fully convinced by this feature: using multiple queries is a useful trick to reduce network-related latency by combining several

Re: [HACKERS] Broken hint bits (freeze)

2017-06-14 Thread Bruce Momjian
On Wed, Jun 14, 2017 at 07:45:17PM +0530, Amit Kapila wrote: > > Now, it seems we later added a doc section early on that talks about > > "Verify standby servers" so I have moved the wal_level section into that > > block, which should be safe. There is now no need to start/stop the new > > server

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Ants Aasma
On Tue, Jun 13, 2017 at 6:35 PM, Robert Haas wrote: > Of course, what would be even more useful is fine-grained encryption - > encrypt these tables (and the corresponding indexes, toast tables, and > WAL records related to any of that) with this key, encrypt these other >

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Bruce Momjian
On Wed, Jun 14, 2017 at 10:38:40AM -0400, Tom Lane wrote: > btw, I was slightly amused to notice that this version still calls itself > > $ indent -V > pg_bsd_indent 1.3 > > Don't know what you plan to do with that program name, but we certainly > need a version number bump so that pgindent can

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Bruce Momjian
On Tue, Jun 13, 2017 at 06:29:20PM -0400, Stephen Frost wrote: > > Isn't the leakage controlled by OS permissions, so is it really leakage, > > i.e., if you can see the leakage, you probably have bypassed the OS > > permissions and see the key and data anyway. > > The case I'm mainly considering

Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent run.)

2017-06-14 Thread Tom Lane
btw, I was slightly amused to notice that this version still calls itself $ indent -V pg_bsd_indent 1.3 Don't know what you plan to do with that program name, but we certainly need a version number bump so that pgindent can tell that it's got an up-to-date copy. 1.4? 2.0?

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Bruce Momjian
On Wed, Jun 14, 2017 at 04:13:57PM +0300, Aleksander Alekseev wrote: > > > While I agree that configuring full disk encryption is not technically > > > difficult, it requires much more privileged access to the system and > > > basically requires the support of a system administrator. In addition,

Re: [HACKERS] Broken hint bits (freeze)

2017-06-14 Thread Amit Kapila
On Wed, Jun 14, 2017 at 1:01 AM, Bruce Momjian wrote: > On Mon, Jun 12, 2017 at 06:31:11PM +0300, Vladimir Borodin wrote: >> What about the following sequence? >> >> 1. Run pg_upgrade on master, >> 2. Start it in single-user mode and stop (to get right wal_level in >>

Re: [HACKERS] Disallowing multiple queries per PQexec()

2017-06-14 Thread Surafel Temesgen
On Mon, Jun 12, 2017 at 5:22 PM, Daniel Verite wrote: > > > PGC_POSTMASTER implies that it's an instance-wide setting. > Is is intentional? I can understand that it's more secure for this not to > be changeable in an existing session, but it's also much less usable if you

Re: [HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-14 Thread Tom Lane
Masahiko Sawada writes: > Currently $subject but should we use CatalogTupleDelete() instead? > It's actually the same behavior though. Other functions use > CatalogTupleXXX(). Attached patch. Yeah, evidently that patch failed to track the effects of commits 2f5c9d9c9 et

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Aleksander Alekseev
> > While I agree that configuring full disk encryption is not technically > > difficult, it requires much more privileged access to the system and > > basically requires the support of a system administrator. In addition, > > if a volume is not available for encryption, PostgreSQL support for > >

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Aleksander Alekseev
Hi Kenneth, > > > File system encryption already exists and is well-tested. I don't see > > > any big advantages in re-implementing all of this one level up. You > > > would have to touch every single place in PostgreSQL backend and tool > > > code where a file is being read or written. Yikes.

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Kenneth Marshall
On Wed, Jun 14, 2017 at 12:04:26PM +0300, Aleksander Alekseev wrote: > Hi Ants, > > On Tue, Jun 13, 2017 at 09:07:49AM -0400, Peter Eisentraut wrote: > > On 6/12/17 17:11, Ants Aasma wrote: > > > I'm curious if the community thinks this is a feature worth having? > > > Even considering that

Re: [HACKERS] Adding support for Default partition in partitioning

2017-06-14 Thread Jeevan Ladhe
While rebasing the current set of patches to the latest source, I realized that it might be a good idea to split the default partitioning support patch further into two incremental patches, where the first patch for default partition support would prevent addition of any new partition if there

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-06-14 Thread Ashutosh Bapat
On Wed, Jun 14, 2017 at 9:20 AM, Amit Langote wrote: > > By the way, I mentioned an existing problem in one of the earlier emails > on this thread about differing attribute numbers in the table being > attached causing predicate_implied_by() to give up due to

Re: [HACKERS] A bug in mapping attributes in ATExecAttachPartition()

2017-06-14 Thread Ashutosh Bapat
PFA patch set addressing comments by Tom and Amit. 0001 is same as Robert's patch. On Wed, Jun 14, 2017 at 7:20 AM, Robert Haas wrote: > On Tue, Jun 13, 2017 at 5:28 PM, Tom Lane wrote: >> Robert Haas writes: >>> OK, I think I

Re: [HACKERS] WIP: Data at rest encryption

2017-06-14 Thread Aleksander Alekseev
Hi Ants, On Tue, Jun 13, 2017 at 09:07:49AM -0400, Peter Eisentraut wrote: > On 6/12/17 17:11, Ants Aasma wrote: > > I'm curious if the community thinks this is a feature worth having? > > Even considering that security experts would classify this kind of > > encryption as a checkbox feature. >

[HACKERS] RemoveSubscriptionRel uses simple_heap_delete

2017-06-14 Thread Masahiko Sawada
Hi, Currently $subject but should we use CatalogTupleDelete() instead? It's actually the same behavior though. Other functions use CatalogTupleXXX(). Attached patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center

[HACKERS] improve release-note for pg_current_logfile()

2017-06-14 Thread Yugo Nagata
Hi, When I am reading the PG 10 release-notes, I found the following item. > Add function pg_current_logfile() to read syslog's current stderr and csvlog > output file names (Gilles Darold) This confused me because "syslog" is one of method for logging as well as stderr and csvlog. I guess it