Re: [HACKERS] transition table behavior with inheritance appears broken

2017-06-24 Thread Noah Misch
On Fri, Jun 23, 2017 at 02:39:48PM +0100, Andrew Gierth wrote: > > "Noah" == Noah Misch writes: > > Noah> This PostgreSQL 10 open item is past due for your status update. > Noah> Kindly send a status update within 24 hours, > > oops, sorry! I forgot to include a date in

Re: [HACKERS] Race conditions with WAL sender PID lookups

2017-06-24 Thread Alvaro Herrera
Noah Misch wrote: > IMMEDIATE ATTENTION REQUIRED. This PostgreSQL 10 open item is long past due > for your status update. Please reacquaint yourself with the policy on open > item ownership[1] and then reply immediately. If I do not hear from you by > 2017-06-25 06:00 UTC, I will transfer this

Re: [HACKERS] REPLICA IDENTITY FULL

2017-06-24 Thread Tatsuo Ishii
> Thanks for the feedback. I have committed it after removing the > datumIsEqual() call. Thanks for the patch! I confirmed my examples now work. Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp -- Sent via

Re: [HACKERS] shift_sjis_2004 related autority files are remaining

2017-06-24 Thread Tatsuo Ishii
> I don't have a clear opinion on this particular issue, but I think we > should have clarity on why particular files or code exist. So why do > these files exist and the others don't? Is it just the license? I think so. Many of those files are from http://ftp.unicode.org. There's no license

Re: [HACKERS] subscription worker signalling wal writer too much

2017-06-24 Thread Andres Freund
Hi, On 2017-06-15 15:06:43 -0700, Jeff Janes wrote: > > Well, wal_writer_delay doesn't work if walwriter is in sleep mode, and > > this afaics would allow wal writer to go into sleep mode with half a > > page filled, and it'd not be woken up again until the page is filled. > > No? > > > > If it

Re: [HACKERS] FIPS mode?

2017-06-24 Thread Curtis Ruck
To utilize openssl FIPS, you have to explicitly enable it, per the FIPS user guide: https://www.openssl.org/docs/fips/UserGuide-2.0.pdf So, my target would be redhat/centos where openssl FIPS is certified/available, and then add a configuration parameter to enable it (much like Apache HTTPD's

Re: [HACKERS] FIPS mode?

2017-06-24 Thread Joe Conway
On 06/23/2017 10:51 PM, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Jun 24, 2017 at 12:56 PM, Curtis Ruck >> wrote: >>> If I clean this up some, maintain styleguide, what is the likely hood of >>> getting this included in

Re: [HACKERS] Code quality issues in ICU patch

2017-06-24 Thread Tom Lane
Peter Eisentraut writes: > On 6/23/17 12:31, Tom Lane wrote: >> icu_to_uchar() and icu_from_uchar(), and perhaps other places, are >> touchingly naive about integer overflow hazards in buffer size >> calculations. > Here is a patch that should address this. Ah,

Re: [HACKERS] Causal reads take II

2017-06-24 Thread Simon Riggs
On 3 January 2017 at 01:43, Thomas Munro wrote: > Here is a new version of my "causal reads" patch (see the earlier > thread from the 9.6 development cycle[1]), which provides a way to > avoid stale reads when load balancing with streaming replication. I'm very

Re: [HACKERS] Code quality issues in ICU patch

2017-06-24 Thread Peter Eisentraut
On 6/23/17 12:31, Tom Lane wrote: > icu_to_uchar() and icu_from_uchar(), and perhaps other places, are > touchingly naive about integer overflow hazards in buffer size > calculations. I call particular attention to this bit in > icu_from_uchar(): > > len_result =

Re: [HACKERS] Fix a typo in snapmgr.c

2017-06-24 Thread Simon Riggs
On 23 June 2017 at 19:25, Andres Freund wrote: > On 2017-06-23 19:21:57 +0100, Simon Riggs wrote: >> On 23 June 2017 at 08:23, Simon Riggs wrote: >> > On 23 June 2017 at 08:21, Andres Freund wrote: >> >> On 2017-06-07 10:17:31

[HACKERS] Modifing returning value of PQgetvalue.

2017-06-24 Thread Dmitry Igrishin
Hello, PQgetvalue returns a value of type char* (without const). But the documentation says: "The pointer returned by PQgetvalue points to storage that is part of the PGresult structure. *One should not modify the data it points to*" (my italics). Could someone tell me please, what wrong with