Hi
2017-09-09 1:24 GMT+02:00 Tom Lane :
> Tomas Vondra writes:
> > The translator has exactly the same context in both cases, and the
> > struggle to wrap it at 80 characters will be pretty much the same too.
>
> Really? With the old way, you had something under 60 characters to
> work in, now
Hi
2017-09-08 9:36 GMT+02:00 Jeevan Chalke :
> Hi Pavel,
>
> On Sat, May 20, 2017 at 11:55 AM, Pavel Stehule
> wrote:
>
>>
>>
>>
>> 2017-05-19 5:48 GMT+02:00 Pavel Stehule :
>>
>>>
>>>
>>> 2017-05-19 3:14 GMT+02:00 Peter Eisentraut <
>>> peter.eisentr...@2ndquadrant.com>:
>>>
On 5/15/17 14:
> >
> > SET x = .., y = .. SELECT ... ;
>
> This seems pretty ugly from a syntax perspective.
>
> We already have 'SET LOCAL', which manages scope to the current
> transaction. How about SET BLOCK which would set until you've left
> the current statement block?
>
This is reason why PRAGMA was des
Michael Paquier writes:
> On Sat, Sep 9, 2017 at 11:32 AM, Tom Lane wrote:
>> In a moment of idleness I tried to run the TAP tests on pademelon,
>> which is a mighty old and slow machine.
> How long did it take?
The last time I tried it, make check-world took about 3 hours IIRC.
But that was a
On Sat, Sep 9, 2017 at 11:32 AM, Tom Lane wrote:
> In a moment of idleness I tried to run the TAP tests on pademelon,
> which is a mighty old and slow machine.
How long did it take? Just wondering if that's actually the slowest
one or not to run the full set of recovery tests. This would be might
On Sat, Sep 2, 2017 at 5:22 AM, Peter Eisentraut
wrote:
>
> + --if-exists
> +
> +
> +Do not error out when --drop-slot or
> --start are
> +specified and a slot with the specified name does not exist.
> +
> +
> +
>
> I understand the --drop
On Fri, May 26, 2017 at 3:54 AM, Konstantin Knizhnik
wrote:
> Attached please find rebased version of the autoprepare patch based on Tom's
> proposal (perform analyze for tree with constant literals and then replace
> them with parameters).
> Also I submitted this patch for the Autum commitfest.
On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro wrote:
> On Mon, Aug 21, 2017 at 4:35 PM, Haribabu Kommi
> wrote:
> > On Tue, Aug 15, 2017 at 7:29 AM, Peter Eisentraut
> > wrote:
> >> On 4/4/17 01:06, Haribabu Kommi wrote:
> >> > Both pg_dump and pg_upgrade tests are passed. Updated patch attache
On Sat, Sep 9, 2017 at 3:05 AM, Robert Haas wrote:
> On Fri, Sep 8, 2017 at 10:08 AM, Jeevan Ladhe
> wrote:
> > Thanks Robert for taking care of this.
> > My V29 patch series[1] is based on this commit now.
>
> Committed 0001-0003, 0005 with assorted modifications, mostly
> cosmetic, but with so
On Thu, Jul 20, 2017 at 4:58 AM, Robert Haas wrote:
> On Wed, Jul 19, 2017 at 12:43 PM, Victor Drobny
> wrote:
>> Let me introduce new function for full text search query creation(which is
>> called 'queryto_tsquery'). It takes 'google like' query string and
>> translates it to tsquery.
>
> I ha
On Fri, Sep 8, 2017 at 11:07 PM, Alexander Kuzmenkov
wrote:
> Hi Rafia,
>
> I like the idea of reducing locking overhead by sending tuples in bulk. The
> implementation could probably be simpler: you could extend the API of shm_mq
> to decouple notifying the sender from actually putting data into
In a moment of idleness I tried to run the TAP tests on pademelon,
which is a mighty old and slow machine. Behold,
src/test/recovery/t/010_logical_decoding_timelines.pl fell over,
with the relevant section of its log contents being:
# testing logical timeline following with a filesystem-level cop
On Fri, Sep 8, 2017 at 3:13 PM, Robert Haas wrote:
> On Fri, Sep 8, 2017 at 1:17 AM, Amit Kapila wrote:
>> You are right. I have changed the ordering and passed OuterUserId via
>> FixedParallelState.
>
> This looks a little strange:
>
> +SetCurrentRoleId(fps->outer_user_id, fps->is_current_u
On Sat, Sep 9, 2017 at 3:33 AM, Peter Eisentraut
wrote:
> A couple of comments on this patch. I have attached a "fixup" patch on
> top of your v4 that should address them.
>
> - I think the bracketing of the LDAP URL synopsis is wrong.
+1
> - I have dropped the sentence that LDAP URL extensions
On Sat, Sep 9, 2017 at 3:36 AM, Peter Eisentraut
wrote:
> For additional entertainment I have written a test suite for this LDAP
> authentication functionality. It's not quite robust enough to be run by
> default, because it needs a full OpenLDAP installation, but it's been
> very helpful for rev
On Fri, Sep 8, 2017 at 1:38 PM, Ashutosh Bapat
wrote:
>> I also confirmed that the partition-pruning patch set works fine with this
>> patch instead of the patch on that thread with the same functionality,
>> which I will now drop from that patch set. Sorry about the wasted time.
>
> Thanks a lot
Tomas Vondra writes:
> The translator has exactly the same context in both cases, and the
> struggle to wrap it at 80 characters will be pretty much the same too.
Really? With the old way, you had something under 60 characters to
work in, now it's nearly 80. I don't buy that that's not a signif
Hi,
On 09/08/2017 07:25 AM, Fabien COELHO wrote:
>
> Hello,
>
>>> PSQL_HISTORY alternative location for the command history file
>>>
>>> I would prefer to revert to that more compact 9.6-formatting.
>>
>> There was a problem with line width .. its hard to respect 80 chars
>
> Yes.
>
>
On 8 September 2017 at 15:34, chiru r wrote:
> We have multiple SAP applications running on Oracle as backend and looking
> for an opportunity to migrate from Oracle to PostgreSQL. Has anyone ever
> deployed SAP on PostgreSQL community edition?
>
> Is PostgreSQL community involved in any future ro
On Fri, Sep 8, 2017 at 10:08 AM, Jeevan Ladhe
wrote:
> Thanks Robert for taking care of this.
> My V29 patch series[1] is based on this commit now.
Committed 0001-0003, 0005 with assorted modifications, mostly
cosmetic, but with some actual changes to describeOneTableDetails and
ATExecAttachParti
On Fri, Sep 8, 2017 at 2:09 PM, Tom Lane wrote:
> Pavel Stehule writes:
> > personally I prefer syntax without FOR keyword - because following
> keyword
> > must be reserved keyword
>
> > SET x = .., y = .. SELECT ... ;
>
> Nope. Most of the statement-starting keywords are *not* fully reserved;
Merlin Moncure writes:
> We already have 'SET LOCAL', which manages scope to the current
> transaction. How about SET BLOCK which would set until you've left
> the current statement block?
(1) I do not think this approach will play terribly well in any of the
PLs; their notions of statement bloc
Pavel Stehule writes:
> personally I prefer syntax without FOR keyword - because following keyword
> must be reserved keyword
> SET x = .., y = .. SELECT ... ;
Nope. Most of the statement-starting keywords are *not* fully reserved;
they don't need to be as long as they lead off the statement.
Bruce Momjian writes:
> On Wed, Jul 19, 2017 at 12:39:07PM -0400, Tom Lane wrote:
>> Yeah, I see nothing about 3f902354b in release-10.sgml either.
>> We've had varying policies over the years about whether to mention
>> internal API changes in the release notes or not, but this one
>> I think doe
On Fri, Sep 8, 2017 at 2:48 PM, Pavel Stehule wrote:
>
>
> 2017-09-08 21:21 GMT+02:00 Daniel Gustafsson :
>>
>> > On 08 Sep 2017, at 19:14, Simon Riggs wrote:
>> >
>> > On 6 September 2017 at 07:43, Robert Haas wrote:
>> >
>> >> LET custom_plan_tries = 0 IN SELECT ...
>> >
>> > Tom has pointed m
2017-09-08 21:21 GMT+02:00 Daniel Gustafsson :
> > On 08 Sep 2017, at 19:14, Simon Riggs wrote:
> >
> > On 6 September 2017 at 07:43, Robert Haas wrote:
> >
> >> LET custom_plan_tries = 0 IN SELECT ...
> >
> > Tom has pointed me at this proposal, since on another thread I asked
> > for something
Hi, Jesper
Thank you for reviewing.
On 2017-09-08 18:33, Jesper Pedersen wrote:
Hi,
On 07/18/2017 01:20 PM, Sokolov Yura wrote:
I'm sending rebased version with couple of one-line tweaks.
(less skip_wait_list on shared lock, and don't update spin-stat on
aquiring)
I have been running thi
Hi All,
We have multiple SAP applications running on Oracle as backend and looking
for an opportunity to migrate from Oracle to PostgreSQL. Has anyone ever
deployed SAP on PostgreSQL community edition?
Is PostgreSQL community involved in any future road-map of SAP application
deployment on Postgr
> On 08 Sep 2017, at 19:14, Simon Riggs wrote:
>
> On 6 September 2017 at 07:43, Robert Haas wrote:
>
>> LET custom_plan_tries = 0 IN SELECT ...
>
> Tom has pointed me at this proposal, since on another thread I asked
> for something very similar. (No need to reprise that discussion, but I
> w
Catalin Iacob writes:
> When reading this I also realized that the backend does send responses for
> every individual query in a multi-query request, it's only libpq's PQexec
> that throws away the intermediate results and only provides access to the
> last one.
If you want to see them all, you c
Hi Rafia,
I like the idea of reducing locking overhead by sending tuples in bulk.
The implementation could probably be simpler: you could extend the API
of shm_mq to decouple notifying the sender from actually putting data
into the queue (i.e., make shm_mq_notify_receiver public and make a
va
Hello,
Please find attached "blind" additional fixes for Windows & AIX.
- more nan/inf variants
- different message on non existing user
- illegal vs unrecognized options
I suspect that $windows_os is not true on "bowerbird", in order to fix it
the value of "$Config{osname}" is needed...
On 9/6/17 07:11, Thomas Munro wrote:
> After applying these patches cleanly on top of
> 0b554e4e63a4ba4852c01951311713e23acdae02 and running "./configure
> --enable-tap-tests --with-tcl --with-python --with-perl --with-ldap
> --with-icu && make && make check-world" I saw this failure:
Yes, some of
2017-09-08 19:14 GMT+02:00 Simon Riggs :
> On 6 September 2017 at 07:43, Robert Haas wrote:
>
> > LET custom_plan_tries = 0 IN SELECT ...
>
> Tom has pointed me at this proposal, since on another thread I asked
> for something very similar. (No need to reprise that discussion, but I
> wanted prep
On Wed, Sep 6, 2017 at 9:22 AM, Peter Eisentraut <
peter.eisentr...@2ndquadrant.com> wrote:
> On 8/18/17 05:28, Michael Banck wrote:
> >>> Rebased, squashed and slighly edited version attached. I've added this
> >>> to the 2017-07 commitfest now as well:
> >>>
> >>> https://commitfest.postgresql.o
On Thu, Sep 7, 2017 at 8:07 PM, Tom Lane wrote:
> I've pushed up an attempt at this:
>
>
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=b976499480bdbab6d69a11e47991febe53865adc
>
> Feel free to suggest improvements.
Thank you, this helps a lot. Especially since some of the beh
On 08/09/17 16:33, Peter Eisentraut wrote:
> A couple of comments on this patch. I have attached a "fixup" patch on
> top of your v4 that should address them.
>
> - I think the bracketing of the LDAP URL synopsis is wrong.
>
> - I have dropped the sentence that LDAP URL extensions are not
> sup
Here is a v12.
There is no changes in the code or documentation, only TAP tests are
added.
--
Fabien.diff --git a/doc/src/sgml/ref/pgbench.sgml b/doc/src/sgml/ref/pgbench.sgml
index f5db8d1..9ad82d4 100644
--- a/doc/src/sgml/ref/pgbench.sgml
+++ b/doc/src/sgml/ref/pgbench.sgml
@@ -818,6 +818,
On 6 September 2017 at 07:43, Robert Haas wrote:
> LET custom_plan_tries = 0 IN SELECT ...
Tom has pointed me at this proposal, since on another thread I asked
for something very similar. (No need to reprise that discussion, but I
wanted prepared queries to be able to do SET work_mem = X; SELECT
On 6 September 2017 at 07:43, Robert Haas wrote:
> LET custom_plan_tries = 0 IN SELECT ...
Tom has pointed me at this proposal, since on another thread I asked
for something very similar. (No need to reprise that discussion, but I
wanted prepared queries to be able to do SET work_mem = X; SELECT
On Thu, Sep 7, 2017 at 2:49 PM, Robert Haas wrote:
> On Thu, Sep 7, 2017 at 5:38 PM, Tomas Vondra
> wrote:
>> Do we need/want to repeat some of that benchmarking on these patches? I
>> don't recall how much this code changed since those benchmarks were done
>> in the 9.6 cycle.
>
> +1 for some ne
On 9/8/17 03:45, Aleksandr Parfenov wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation:tested, passed
>
> Hi P
On 2017-09-08 15:23, Thomas Munro wrote:
On Fri, Sep 8, 2017 at 9:03 PM, Victor Drobny
wrote:
Thank you very much for your review. In the attachment you can find v2
of
the patch.
FYI this version crashes for me:
test test_rbtree ... FAILED (test process exited with exit
code 2
For additional entertainment I have written a test suite for this LDAP
authentication functionality. It's not quite robust enough to be run by
default, because it needs a full OpenLDAP installation, but it's been
very helpful for reviewing this patch. Here it is.
--
Peter Eisentraut
A couple of comments on this patch. I have attached a "fixup" patch on
top of your v4 that should address them.
- I think the bracketing of the LDAP URL synopsis is wrong.
- I have dropped the sentence that LDAP URL extensions are not
supported. That sentence was written mainly to point out tha
Hi,
On 07/18/2017 01:20 PM, Sokolov Yura wrote:
I'm sending rebased version with couple of one-line tweaks.
(less skip_wait_list on shared lock, and don't update spin-stat on
aquiring)
I have been running this patch on a 2S/28C/56T/256Gb w/ 2 x RAID10 SSD
setup (1 to 375 clients on logged
Hello Tom,
Pushed, with some minor fooling with comments and after running it
through perltidy. (I have no opinions about Perl code formatting,
but perltidy does ...)
Why not. I do not like the result much, but it homogeneity is not a bad
thing.
The only substantive change I made was to
We are now a few days in on Commitfest 201709 and there has been lots of
activity on the patches. 22% of the patches have been committed* with another
10% being marked Ready for Committer. Thank you all for the hard work!
There is still a lot to do though, this fest has a recordbreaking 256 patc
On Fri, Sep 8, 2017 at 6:46 AM, Robert Haas wrote:
> On Thu, Sep 7, 2017 at 8:13 AM, Jeevan Ladhe
> wrote:
> > The fix would be much easier if the refactoring patch 0001 by Amul in
> hash
> > partitioning thread[2] is committed.
>
> Done.
>
Thanks Robert for taking care of this.
My V29 patch se
see subject.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Sep 8, 2017 at 3:59 PM, Amit Khandekar wrote:
> On 7 September 2017 at 11:05, Amit Kapila wrote:
>> On Thu, Aug 31, 2017 at 12:47 PM, Amit Khandekar
>> wrote:
>> 3.
>> +/*
>> + * exec_append_leader_next
>> + *
>> + * To be
Fabien COELHO writes:
> [ pgbench-tap-12.patch ]
Pushed, with some minor fooling with comments and after running it
through perltidy. (I have no opinions about Perl code formatting,
but perltidy does ...)
The only substantive change I made was to drop the test that attempted
to connect to no-su
Ashutosh Bapat wrote:
> On Thu, Aug 17, 2017 at 8:52 PM, Antonin Houska wrote:
> > Antonin Houska wrote:
> >
> >> Antonin Houska wrote:
> >>
> >> > This is a new version of the patch I presented in [1].
> >>
> >> Rebased.
> >>
> >> cat .git/refs/heads/master
> >> b9a3ef55b253d885081c2d0e9dc458
On Fri, Sep 8, 2017 at 6:45 AM, Robert Haas wrote:
> On Mon, Sep 4, 2017 at 6:38 AM, amul sul wrote:
> > I've updated patch to use an extended hash function (Commit #
> > 81c5e46c490e2426db243eada186995da5bb0ba7) for the partitioning.
>
> Committed 0001 after noticing that Jeevan Ladhe also foun
Jeevan Chalke wrote:
> 1.
> + if (aggref->aggvariadic ||
> + aggref->aggdirectargs || aggref->aggorder ||
> + aggref->aggdistinct || aggref->aggfilter)
>
> I did not understand, why you are not pushing aggregate in above cases?
> Can you please explain?
Currently I'm trying to implement infrast
On Fri, Sep 8, 2017 at 9:03 PM, Victor Drobny wrote:
> Thank you very much for your review. In the attachment you can find v2 of
> the patch.
FYI this version crashes for me:
test test_rbtree ... FAILED (test process exited with exit code 2)
It's trying to call rb->combiner which i
On Wed, Aug 23, 2017 at 4:43 PM, Jeevan Chalke <
jeevan.cha...@enterprisedb.com> wrote:
> Hi,
>
> Attached is the patch to implement partition-wise aggregation/grouping.
>
> As explained earlier, we produce a full aggregation for each partition when
> partition keys are leading group by clauses an
On Thu, May 18, 2017 at 9:13 AM, Amit Kapila
wrote:
> On Wed, May 17, 2017 at 5:17 PM, Robert Haas
> wrote:
> > On Wed, May 17, 2017 at 6:29 AM, Amit Kapila
> wrote:
> >> I think we can do this even without using an additional infomask bit.
> >> As suggested by Greg up thread, we can set Inval
On Wed, Aug 30, 2017 at 5:32 PM, Amit Khandekar wrote:
> Hi Rafia,
>
> On 17 August 2017 at 14:12, Amit Khandekar wrote:
>> But for all of the cases here, partial
>> subplans seem possible, and so even on HEAD it executed Partial
>> Append. So between a Parallel Append having partial subplans and
On Tue, Aug 15, 2017 at 10:13 AM, Masahiko Sawada wrote:
> On Wed, Jul 26, 2017 at 5:38 PM, Masahiko Sawada
> wrote:
>> On Sun, Mar 5, 2017 at 4:09 PM, Masahiko Sawada
>> wrote:
>>> On Sun, Mar 5, 2017 at 12:14 PM, David Steele wrote:
On 3/4/17 9:08 PM, Masahiko Sawada wrote:
> On Sa
On 7 September 2017 at 11:05, Amit Kapila wrote:
> On Thu, Aug 31, 2017 at 12:47 PM, Amit Khandekar
> wrote:
>> The last updated patch needs a rebase. Attached is the rebased version.
>>
>
> Few comments on the first read of the patch:
Thanks !
>
> 1.
> @@ -279,6 +347,7 @@ void
> ExecReScanAp
On 2017/09/05 14:11, Amit Khandekar wrote:
> Great, thanks. Just wanted to make sure someone is working on that,
> because, as you said, it is no longer an EIBO patch. Since you are
> doing that, I won't work on that.
Here is that patch (actually two patches). Sorry it took me a bit.
Description
On 2017/09/08 18:57, Robert Haas wrote:
>> As mentioned by Amit Langote in the above mail thread, he is going to
>> do changes for making RelationGetPartitionDispatchInfo() return the
>> leaf partitions in depth-first order. Once that is done, I will then
>> remove the hash table method for finding
On Thu, Sep 7, 2017 at 6:17 AM, Amit Khandekar wrote:
> On 3 September 2017 at 17:10, Amit Khandekar wrote:
>> After recent commit 30833ba154, now the partitions are expanded in
>> depth-first order. It didn't seem worthwhile rebasing my partition
>> walker changes onto the latest code. So in the
On Wed, Aug 30, 2017 at 10:12 PM, Tatsuro Yamada
wrote:
> 1. scanning heap
> 2. sort tuples
These two phases overlap, though. I believe progress reporting for
sorts is really hard. In the simple case where the data fits in
work_mem, none of the work of the sort gets done until all the data i
On Fri, Sep 8, 2017 at 1:17 AM, Amit Kapila wrote:
> You are right. I have changed the ordering and passed OuterUserId via
> FixedParallelState.
This looks a little strange:
+SetCurrentRoleId(fps->outer_user_id, fps->is_current_user_superuser);
The first argument says "outer" but the secon
On Fri, Sep 8, 2017 at 1:47 AM, Amit Langote
wrote:
> When I tried the attached patch, it doesn't seem to expand partitioning
> inheritance in step-wise manner as the patch's title says. I think the
> rewritten patch forgot to include Ashutosh's changes to
> expand_single_inheritance_child() wher
On Thu, Sep 7, 2017 at 10:35 PM, Tom Lane wrote:
> I think we might be best off just playing it straight and providing
> a config file that contains a section along these lines:
>
> # Parameters for OpenSSL. Leave these commented out if not using OpenSSL.
> #
> #ssl_ciphers = 'HIGH:MEDIUM:+3DES:!
Dear Tom,
Thank you very much for your review. In the attachment you can find v2
of the patch.
On 2017-09-07 01:38, Tom Lane wrote:
[ btw, please don't cc pgsql-hackers-owner, the list moderators don't
need the noise ]
Aleksander Alekseev writes:
I would say that this patch is in a pretty
On Fri, Sep 1, 2017 at 8:01 AM, Robert Haas wrote:
> On Thu, Aug 31, 2017 at 8:40 AM, amul sul wrote:
> > Fixed in the attached version.
>
> I fixed these up a bit and committed them. Thanks.
>
> I think this takes care of adding not only the infrastructure but
> support for all the core data t
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation:tested, passed
Hi Peter,
I looked through your patches and its look good to
On Fri, Sep 8, 2017 at 12:34 AM, Robert Haas wrote:
> On Tue, Sep 5, 2017 at 7:01 AM, Ashutosh Bapat
> wrote:
>> accumulate_append_subpath() is executed for every path instead of
>> every relation, so changing it would collect the same list multiple
>> times. Instead, I found the old way of assoc
Hi Pavel,
On Sat, May 20, 2017 at 11:55 AM, Pavel Stehule
wrote:
>
>
>
> 2017-05-19 5:48 GMT+02:00 Pavel Stehule :
>
>>
>>
>> 2017-05-19 3:14 GMT+02:00 Peter Eisentraut > com>:
>>
>>> On 5/15/17 14:34, Pavel Stehule wrote:
>>> > Now, I when I working on plpgsql_check, I have to check functio
Thank you for your notification.
At Tue, 5 Sep 2017 12:05:01 +0200, Daniel Gustafsson wrote in
> > On 13 Apr 2017, at 11:42, Kyotaro HORIGUCHI
> > wrote:
> >
> > At Thu, 13 Apr 2017 13:52:40 +0900, Michael Paquier
> > wrote in
> >
> >> On Tue, Apr 11, 2017 at 5:38 PM, Kyotaro HORIGUCHI
>
On Fri, Aug 25, 2017 at 11:16 AM, Jing Wang wrote:
> Hi all,
>
> Enclosed please find the updated patch with covering security labels on
> database.
>
> The patch cover the following commands:
>
i can't apply your patch cleanly i think it needs rebase
Regards
Surafel
75 matches
Mail list logo
