Re: [JDBC] [HACKERS] Channel binding support for SCRAM-SHA-256

2017-09-10 Thread Michael Paquier
On Mon, Aug 21, 2017 at 9:51 PM, Michael Paquier wrote: > On Tue, Jun 20, 2017 at 1:11 PM, Michael Paquier > wrote: >> With the tests directly in the patch, things are easy to run. WIth >> PG10 stabilization work, of course I don't expect

Re: [HACKERS] CLUSTER command progress monitor

2017-09-10 Thread Tatsuro Yamada
On 2017/09/08 18:55, Robert Haas wrote: On Wed, Aug 30, 2017 at 10:12 PM, Tatsuro Yamada wrote: 1. scanning heap 2. sort tuples These two phases overlap, though. I believe progress reporting for sorts is really hard. In the simple case where the data fits

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Amit Kapila
On Sun, Sep 10, 2017 at 9:56 PM, Tom Lane wrote: > Amit Kapila writes: >> On Sun, Sep 10, 2017 at 11:52 AM, Michael Paquier >> wrote: >>> Coordinating efforts here would be nice. If you, Amit K, are taking >>> care of a

Re: [HACKERS] The case for removing replacement selection sort

2017-09-10 Thread Peter Geoghegan
On Sun, Sep 10, 2017 at 5:59 PM, Tomas Vondra wrote: > OK, so 1MB, 4MB, 8MB, 32MB? Right. > Ah, so you suggest doing all the tests on current master, by only > tweaking the replacement_sort_tuples value? I've been testing master vs. > your patch, but I guess

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Michael Paquier
On Mon, Sep 11, 2017 at 1:26 AM, Tom Lane wrote: > FWIW, now that we've noticed the discrepancy, I'm for using > REGBUF_STANDARD or equivalent for all metapage calls. Even if it > saves no space, inconsistency is bad because it's confusing. OK, I don't mind having a more

Re: [HACKERS] Still another race condition in recovery TAP tests

2017-09-10 Thread Michael Paquier
On Sun, Sep 10, 2017 at 12:38 AM, Tom Lane wrote: > Michael Paquier writes: >> On Sat, Sep 9, 2017 at 1:43 PM, Tom Lane wrote: >>> Yeah, even if we fixed this particular call site, I'm sure the issue >>> would come up again.

Re: [HACKERS] The case for removing replacement selection sort

2017-09-10 Thread Tomas Vondra
On 09/11/2017 02:22 AM, Peter Geoghegan wrote: > On Sun, Sep 10, 2017 at 5:07 PM, Tomas Vondra > wrote: >> I'm currently re-running the benchmarks we did in 2016 for 9.6, but >> those are all sorts with a single column (see the attached script). But >> it'd be good

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-10 Thread Michael Paquier
On Mon, Sep 11, 2017 at 9:38 AM, Bossart, Nathan wrote: > I agree that it is nice to see when relations are skipped, but I do not > know if the WARNING messages would provide much value for this > particular use case (i.e. 'VACUUM;'). If a user does not provide a list > of

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-10 Thread Bossart, Nathan
On 9/9/17, 7:28 AM, "Michael Paquier" wrote: > In the duplicate patch, it seems to me that you can save one lookup at > the list of VacuumRelation items by checking for column duplicates > after checking that all the columns are defined. If you put the > duplicate check

Re: [HACKERS] The case for removing replacement selection sort

2017-09-10 Thread Peter Geoghegan
On Sun, Sep 10, 2017 at 5:07 PM, Tomas Vondra wrote: > I'm currently re-running the benchmarks we did in 2016 for 9.6, but > those are all sorts with a single column (see the attached script). But > it'd be good to add a few queries testing sorts with multiple keys.

Re: [HACKERS] Automatic testing of patches in commit fest

2017-09-10 Thread Thomas Munro
On Mon, Sep 11, 2017 at 12:10 PM, Jeff Janes wrote: > On Sun, Sep 10, 2017 at 4:40 PM, Michael Paquier >> http://commitfest.cputube.org/ > > This looks very interesting. But when I click on a "build: failing" icon, > it takes me to a generic

Re: [HACKERS] Automatic testing of patches in commit fest

2017-09-10 Thread Thomas Munro
On Mon, Sep 11, 2017 at 11:40 AM, Michael Paquier wrote: > Thomas Munro has hacked up a prototype of application testing > automatically if patches submitted apply and build: > http://commitfest.cputube.org/ > > I would recommend have a look at it from time to time if

Re: [HACKERS] Statement timeout behavior in extended queries

2017-09-10 Thread Andres Freund
Hi, On 2017-09-11 09:10:49 +0900, Tatsuo Ishii wrote: > If you don't mind, can you please commit/push the patch? Ok, will do so. Greetings, Andres Freund -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] Automatic testing of patches in commit fest

2017-09-10 Thread Jeff Janes
On Sun, Sep 10, 2017 at 4:40 PM, Michael Paquier wrote: > Hi all, > > Thomas Munro has hacked up a prototype of application testing > automatically if patches submitted apply and build: > http://commitfest.cputube.org/ > > I would recommend have a look at it from time

Re: [HACKERS] Statement timeout behavior in extended queries

2017-09-10 Thread Tatsuo Ishii
Andres, If you don't mind, can you please commit/push the patch? Best regards, -- Tatsuo Ishii SRA OSS, Inc. Japan English: http://www.sraoss.co.jp/index_en.php Japanese:http://www.sraoss.co.jp >> What do you think? I've not really tested this with the extended >> protocol, so I'd appreciate

Re: [HACKERS] The case for removing replacement selection sort

2017-09-10 Thread Tomas Vondra
On 09/11/2017 01:03 AM, Peter Geoghegan wrote: > On Sat, Sep 9, 2017 at 8:28 AM, Greg Stark wrote: >> This may be a bit "how long is a piece of string" but how do those two >> compare with string sorting in an interesting encoding/locale -- say >> /usr/share/dict/polish in pl_PL

[HACKERS] Automatic testing of patches in commit fest

2017-09-10 Thread Michael Paquier
Hi all, Thomas Munro has hacked up a prototype of application testing automatically if patches submitted apply and build: http://commitfest.cputube.org/ I would recommend have a look at it from time to time if you are a patch author (or a reviewer) as any failure may say that your patch has

Re: [HACKERS] [PATCH] Pattern based listeners for asynchronous messaging (LISTEN/NOTIFY)

2017-09-10 Thread Markus Sintonen
Hi Marko! Thanks for the good feedback. Good point on the pg_listening_channels(). Do you think we could change the interface of the function? At least PG v10 has changed functions elsewhere quite dramatically eg. related to xlog functions. We could change the pg_listening_channels() return type

[HACKERS] Constifying numeric.c's local vars

2017-09-10 Thread Andres Freund
Hi, For JIT inlining currently functions can't be inlined if they reference non-constant static variables. That's because there's no way, at least none I know of, to link to the correct variable, instead of duplicating, the linker explicitly renames symbols after all (that's the whole point of

Re: [HACKERS] The case for removing replacement selection sort

2017-09-10 Thread Peter Geoghegan
On Sat, Sep 9, 2017 at 8:28 AM, Greg Stark wrote: > This may be a bit "how long is a piece of string" but how do those two > compare with string sorting in an interesting encoding/locale -- say > /usr/share/dict/polish in pl_PL for example. It's certainly true that > people do sort

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2017-09-10 Thread Stephen Frost
Michael, * Michael Paquier (michael.paqu...@gmail.com) wrote: > As there begins to be many switches of this kind and much code > duplication, I think that some refactoring into a more generic switch > infrastructure would be nicer. I have been thinking about this also and agree that it would be

Re: [HACKERS] mysql_fdw + PG10: unrecognized node type: 217

2017-09-10 Thread Tom Lane
Christoph Berg writes: > I'm not sure if this is a bug in mysql_fdw, or in PG10: > ! ERROR: unrecognized node type: 217 Hm, nodetag 217 is T_List according to gdb. Wouldn't expect that failure in very many places. If you could get a stack trace from the errfinish call, it

[HACKERS] mysql_fdw + PG10: unrecognized node type: 217

2017-09-10 Thread Christoph Berg
Hi, I'm not sure if this is a bug in mysql_fdw, or in PG10: == running regression test queries== test mysql_fdw... FAILED *** 345,359 NOTICE: Found number Three NOTICE: Found number Four NOTICE: Found number Five ! NOTICE: Found

[HACKERS] relation mapping file checksum failure

2017-09-10 Thread Tom Lane
A pretty routine "make check-world" run on HEAD just blew up here, with the symptom 2017-09-10 14:27:33.318 EDT [2535] FATAL: relation mapping file "global/pg_filenode.map" contains incorrect checksum 2017-09-10 14:27:33.319 EDT [2519] LOG: autovacuum launcher process (PID 2535) exited with

Re: [HACKERS] Red-Black tree traversal tests

2017-09-10 Thread Tom Lane
I wrote: > In the meantime, here's my version. Notable changes: I went ahead and pushed this, with the removal of the preorder/postorder code, so we can see if the buildfarm finds out anything interesting. Feel free to continue to submit improvements though. One thing that occurred to me is

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Tom Lane
Amit Kapila writes: > On Sun, Sep 10, 2017 at 11:52 AM, Michael Paquier > wrote: >> Coordinating efforts here would be nice. If you, Amit K, are taking >> care of a patch for btree and hash > I think here we should first agree on what we want

[HACKERS] Re: DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-10 Thread Noah Misch
On Thu, Sep 07, 2017 at 04:53:12AM +, Noah Misch wrote: > On Wed, Sep 06, 2017 at 03:28:47PM +0900, Masahiko Sawada wrote: > > On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher wrote: > > > Arseny Sher writes: > > > > > >> Attached patch fixes this by

Re: [HACKERS] Red-black trees: why would anyone want preorder or postorder traversal?

2017-09-10 Thread Alexander Korotkov
On Sun, Sep 10, 2017 at 3:25 AM, Tom Lane wrote: > In short, therefore, I propose we rip out the DirectWalk and InvertedWalk > options along with their support code, and then drop the portions of > test_rbtree that are needed to exercise them. Any objections? > +1, I don't

Re: [HACKERS] log_destination=file

2017-09-10 Thread Dmitry Dolgov
> On 7 September 2017 at 15:46, Dmitry Dolgov <9erthali...@gmail.com> wrote: > > It seems that for this particular workload it was about 20-25% slower.‚Äč Hmm...looks like I provided misleading data, sorry. The numbers from previous email are correct and I'm able to reproduce them, but surprisingly

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Michael Paquier
On Sun, Sep 10, 2017 at 3:28 PM, Amit Kapila wrote: > I think here we should first agree on what we want to do. Based on > Tom's comment, I was thinking of changing comments in btree/hash part > and additionally for hash indexes, I can see if we can pass >

Re: [HACKERS] WIP: Separate log file for extension

2017-09-10 Thread Magnus Hagander
On Fri, Aug 25, 2017 at 12:12 AM, Antonin Houska wrote: > Attached is a draft patch to allow extension to write log messages to a > separate file. It introduces a concept of a "log stream". The extension's > shared library gets its stream assigned by calling this function from

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

2017-09-10 Thread Pavel Stehule
2017-09-08 23:09 GMT+02:00 Tom Lane : > Pavel Stehule writes: > > personally I prefer syntax without FOR keyword - because following > keyword > > must be reserved keyword > > > SET x = .., y = .. SELECT ... ; > > Nope. Most of the statement-starting

Re: [HACKERS] pgbench more operators & functions

2017-09-10 Thread Fabien COELHO
Here is a v13. No code changes, but TAP tests added to maintain pgbench coverage to green. Summary of patch contents: [...] 1. there are no any problem with compilation, patching 2. all tests passed 3. doc is ok I'll mark this patch as ready for commiter Ok. Thanks for the reviews. --

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Amit Kapila
On Sun, Sep 10, 2017 at 11:52 AM, Michael Paquier wrote: > On Sun, Sep 10, 2017 at 3:15 PM, Amit Kapila wrote: >> On Sat, Sep 9, 2017 at 9:00 PM, Tom Lane wrote: >>> Michael Paquier writes:

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Michael Paquier
On Sun, Sep 10, 2017 at 3:15 PM, Amit Kapila wrote: > On Sat, Sep 9, 2017 at 9:00 PM, Tom Lane wrote: >> Michael Paquier writes: >>> On Fri, Sep 8, 2017 at 5:24 AM, Tom Lane wrote: In short, this

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Amit Kapila
On Sat, Sep 9, 2017 at 9:00 PM, Tom Lane wrote: > Michael Paquier writes: >> On Fri, Sep 8, 2017 at 5:24 AM, Tom Lane wrote: >>> In short, this patch needs a significant rewrite, and more analysis than >>> you've done so far on

Re: [HACKERS] Setting pd_lower in GIN metapage

2017-09-10 Thread Amit Kapila
On Fri, Sep 8, 2017 at 1:54 AM, Tom Lane wrote: > Michael Paquier writes: >> On Thu, Sep 7, 2017 at 2:40 PM, Amit Langote >> wrote: >>> On 2017/09/07 13:09, Michael Paquier wrote: pd_lower should remain at 0 on

Re: [HACKERS] pgbench more operators & functions

2017-09-10 Thread Pavel Stehule
Hi 2017-09-09 11:02 GMT+02:00 Fabien COELHO : > > Hello Pavel, > > Here is a v13. No code changes, but TAP tests added to maintain pgbench > coverage to green. > > > Summary of patch contents: > > This patch extends pgbench expressions syntax while keeping compatibility >