Re: [HACKERS] KNN-GiST with recheck

2015-05-15 Thread Alexander Korotkov
On Fri, May 15, 2015 at 2:49 PM, Alexander Korotkov aekorot...@gmail.com wrote: On Fri, May 15, 2015 at 2:48 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05/15/2015 11:31 AM, Alexander Korotkov wrote: On Fri, May 15, 2015 at 2:30 AM, Heikki Linnakangas hlinn...@iki.fi wrote: On 05

Re: [HACKERS] WIP: Enhanced ALTER OPERATOR

2015-05-18 Thread Alexander Korotkov
possible side effects with cached query plans. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] KNN-GiST with recheck

2015-05-14 Thread Alexander Korotkov
On Wed, May 13, 2015 at 10:17 PM, Alexander Korotkov aekorot...@gmail.com wrote: One quick comment: It would be good to avoid the extra comparisons of the distances, when the index doesn't return any lossy items. As the patch stands, it adds one extra copyDistances() call and a cmp_distances

Re: [HACKERS] KNN-GiST with recheck

2015-04-17 Thread Alexander Korotkov
On Wed, Feb 25, 2015 at 12:15 PM, Alexander Korotkov aekorot...@gmail.com wrote: Hi! On Tue, Feb 24, 2015 at 5:39 PM, Tomas Vondra tomas.von...@2ndquadrant.com wrote: On 17.2.2015 14:21, Alexander Korotkov wrote: On Sun, Feb 15, 2015 at 2:08 PM, Alexander Korotkov aekorot...@gmail.com

Re: [HACKERS] Why no jsonb_exists_path()?

2015-06-10 Thread Alexander Korotkov
be interpreted in very different semantics. Checking keys only at top level, any level, sequence starting from top level ... etc. '{key1: value1, key2: value2, key3: value3}' '{key1:{ key2: {key3: value}}}' '{key1: value1} '[{key1: value1}, {key2: value2}, {key3: value3}]' -- Alexander Korotkov Postgres

Re: [HACKERS] WIP: Enhanced ALTER OPERATOR

2015-05-29 Thread Alexander Korotkov
On Thu, May 28, 2015 at 6:43 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: Could we address both this problems by denying changing existing commutators and negator? ISTM that setting absent commutator and negator is quite enough for ALTER

Re: [HACKERS] PGCon hacker lounge

2015-05-27 Thread Alexander Korotkov
room and nobody there. Didn't try to visit it anytime after. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Enhanced ALTER OPERATOR

2015-05-28 Thread Alexander Korotkov
don't exist before. But it's rather uncommon to unset or change commutator or negator. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Rework access method interface

2015-08-24 Thread Alexander Korotkov
On Mon, Aug 24, 2015 at 5:15 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: On Mon, Aug 10, 2015 at 7:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Hm. So one way or the other we're going to end up violating relational theory somewhere. OK, I

Re: [HACKERS] [PATCH] Microvacuum for gist.

2015-07-30 Thread Alexander Korotkov
)(so-curPageData 0)(so-curPageData == so-nPageData)) { -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

[HACKERS] 64-bit XIDs again

2015-07-30 Thread Alexander Korotkov
XIDs. We can use free bits in t_infomask2 to distinguish old and new formats. Any thoughts? Do you think 64-bit XIDs worth it? -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] 64-bit XIDs again

2015-07-30 Thread Alexander Korotkov
On Thu, Jul 30, 2015 at 5:24 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/30/2015 04:26 PM, Alexander Korotkov wrote: Also, I think it's possible to migrate to 64-bit XIDs without breaking pg_upgrade. Old tuples can be leaved with 32-bit XIDs while new tuples would be created with 64

Re: [HACKERS] 64-bit XIDs again

2015-07-31 Thread Alexander Korotkov
above: #1 and #2, and take one free bit from t_infomask2 for format indication. Probably I'm missing something, but I think keeping on-disk compatibility should be somehow possible. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Patch for ginCombineData

2015-08-05 Thread Alexander Korotkov
should have maintenance_work_mem 1gb and some very frequent entry so that it's posting list exceeds 1 gb itself. These circumstances shouldn't be very rare in modern systems. I think it could be backpatched. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian

Re: [HACKERS] [PATCH] Microvacuum for gist.

2015-08-03 Thread Alexander Korotkov
couple of notes from me: 1) I think gistvacuumpage() and gistkillitems() need function-level comments. 2) ItemIdIsDead() can be used in index scan like it's done in _bt_checkkeys(). -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] 64-bit XIDs again

2015-07-31 Thread Alexander Korotkov
tuples as (blockNumber; offset). And we can't remove these references without vacuum. Thus, we would have to invent something like multipage HOT in order to move tuples between pages. And that seems to be a complicated kludge. -- Alexander Korotkov Postgres Professional: http

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-08-14 Thread Alexander Korotkov
event information in PGPROC. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Alexander Korotkov
On Mon, Aug 10, 2015 at 6:36 PM, Petr Jelinek p...@2ndquadrant.com wrote: On 2015-08-10 16:58, Alexander Korotkov wrote: That should work, thanks! Also we can have SQL-visible functions to get amsupport and amstrategies and use them in the regression tests. SQL-visible functions would

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Alexander Korotkov
On Mon, Aug 10, 2015 at 5:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: On Mon, Aug 10, 2015 at 1:12 PM, Petr Jelinek p...@2ndquadrant.com wrote: I don't understand this, there is already AmRoutine in RelationData, why the need

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Alexander Korotkov
On Mon, Aug 10, 2015 at 6:47 PM, Tom Lane t...@sss.pgh.pa.us wrote: Petr Jelinek p...@2ndquadrant.com writes: On 2015-08-10 16:58, Alexander Korotkov wrote: That should work, thanks! Also we can have SQL-visible functions to get amsupport and amstrategies and use them in the regression

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Alexander Korotkov
On Mon, Aug 10, 2015 at 1:12 PM, Petr Jelinek p...@2ndquadrant.com wrote: On 2015-08-09 23:56, Alexander Korotkov wrote: Hacker, some time before I proposed patches implementing CREATE ACCESS METHOD. http://www.postgresql.org/message-id/capphfdsxwzmojm6dx+tjnpyk27kt4o7ri6x_4oswcbyu1rm

Re: [HACKERS] Proposal for CSN based snapshots

2015-07-27 Thread Alexander Korotkov
for now. We could also have 32-bit CSNs. However, that would doubles our troubles with wraparound: we will have 2 counters that could wraparound. That could return us to thoughts about 64-bit XIDs. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Selectivity estimation for intarray with @@

2015-07-21 Thread Alexander Korotkov
On Tue, Jul 21, 2015 at 6:49 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/21/2015 03:44 PM, Alexander Korotkov wrote: While Uriy is on vacation, I've revised this patch a bit. I whacked this around quite a bit, and I think it's in a committable state now. But if you could run

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-07-22 Thread Alexander Korotkov
On Wed, Jul 22, 2015 at 8:48 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Mon, Jul 20, 2015 at 9:18 PM, Alexander Korotkov a.korot...@postgrespro.ru wrote: attached patch allows pg_rewind to work when target timeline was switched. Actually, this patch fixes TODO from pg_rewind

Re: [HACKERS] Selectivity estimation for intarray with @@

2015-07-21 Thread Alexander Korotkov
: it should be int[]. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company intarray_sel-3.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-21 Thread Alexander Korotkov
On Tue, Jul 21, 2015 at 7:20 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/21/2015 04:14 PM, Alexander Korotkov wrote: On Tue, Jul 21, 2015 at 3:52 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/21/2015 02:56 PM, Alexander Korotkov wrote: Probably, but currently we

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-17 Thread Alexander Korotkov
with different options for user? -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Proposal for CSN based snapshots

2015-07-24 Thread Alexander Korotkov
can pick up this work from last community version of this patch. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

[HACKERS] Use pg_rewind when target timeline was switched

2015-07-20 Thread Alexander Korotkov
in function interfaces instead of specifying TLI directly. Thus, SimpleXLogPageRead() can easily start reading XLOGs from next timeline when current timeline ends. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] pg_trgm version 1.2

2015-07-20 Thread Alexander Korotkov
On Wed, Jul 15, 2015 at 12:31 AM, Jeff Janes jeff.ja...@gmail.com wrote: On Tue, Jul 7, 2015 at 6:33 AM, Alexander Korotkov a.korot...@postgrespro.ru wrote: See Tom Lane's comment about downgrade scripts. I think just remove it is a right solution. The new patch removes the downgrade

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-21 Thread Alexander Korotkov
leave 100 as default fillfactor, but provide an option. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-21 Thread Alexander Korotkov
for both GiST and GIN? -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-21 Thread Alexander Korotkov
On Tue, Jul 21, 2015 at 3:52 PM, Heikki Linnakangas hlinn...@iki.fi wrote: On 07/21/2015 02:56 PM, Alexander Korotkov wrote: Probably, but currently we are in quite unlogical situation. We have default fillfactor = 90 for GiST where it has no use cases at all and effectively is just a waste

Re: [HACKERS] Selectivity estimation for intarray with @@

2015-07-21 Thread Alexander Korotkov
be in [10;100]. But it's hard to fit such assumptions into our current regression tests infrastructure. I haven't gone through the C code. I also did some coding style and comments modifications. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] clearing opfuncid vs. parallel query

2015-10-23 Thread Alexander Korotkov
nb. > > > Maybe I should publish this code? > > > > Please do. > Tom Lane and Robert Haas are very unhappy with a python. Is there any > reason? > Requirement of python with pycparser as build dependency is a serious cataclysm. For instance, how many buildfarms will

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-10-29 Thread Alexander Korotkov
On Thu, Sep 24, 2015 at 6:36 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Sep 24, 2015 at 6:32 PM, Andres Freund <and...@anarazel.de> wrote: > >> On 2015-09-15 20:16:10 +0300, YUriy Zhuravlev wrote: >> > We will be tested. >> >>

Re: [HACKERS] Some questions about the array.

2015-11-11 Thread Alexander Korotkov
On Mon, Nov 9, 2015 at 8:23 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: > 2015-11-09 17:55 GMT+01:00 Alexander Korotkov <a.korot...@postgrespro.ru>: > >> On Mon, Nov 9, 2015 at 4:53 PM, Pavel Stehule <pavel.steh...@gmail.com> >> wrote: >> >

Re: [HACKERS] Some questions about the array.

2015-11-09 Thread Alexander Korotkov
Assuming array[~n] has a current meaning, could we give a try to new syntax which doesn't have current meaning? Not yet sure what exactly it could be... -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Rework access method interface

2015-11-03 Thread Alexander Korotkov
ew ones. So basically, I see zero value in exposing CREATE/ > ALTER OP CLASS's internal working representation to the verifiers. > I'm OK with validating opclass directly by system catalog, i.e. looping over SearchSysCacheList results. Teodor was telling me something similar personally. I

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-10-30 Thread Alexander Korotkov
On Thu, Oct 29, 2015 at 8:18 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Sep 24, 2015 at 6:36 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Thu, Sep 24, 2015 at 6:32 PM, Andres Freund <and...@anarazel.de> >&g

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-10-30 Thread Alexander Korotkov
Hi! On Fri, Oct 30, 2015 at 5:12 PM, Andres Freund <and...@anarazel.de> wrote: > On 2015-10-30 16:28:22 +0300, Alexander Korotkov wrote: > > pinunpin-cas-original-fix.patch is just original patch by Andres Freund > > with fixed bug which causes hang. > > Performance c

Re: [HACKERS] Summary of Vienna sharding summit, new TODO item

2015-11-07 Thread Alexander Korotkov
ble to > > external sharding solutions as well. > > > > Is this acceptable? > > Added to TODO. Great, thank you, Bruce! -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Access method extendability

2015-11-02 Thread Alexander Korotkov
fied. GenericXLogFinish swaps the data between page copy and page itself. That allow us to avoid critical section in used code. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company generic-xlog.4.patch.gz Description: GNU Zip compressed data

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-10-14 Thread Alexander Korotkov
ferent WAL fork position. > I am marking this patch as ready for committer. It would be cool in > the future to use the recovery test suite to have more advanced > scenarios tested, but it seems a shame to block this patch because of > that. > Thanks a lot. Now patch looks much better

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-10-14 Thread Alexander Korotkov
timelines. 2. Make additional checks for distinguish different timelines with the same numbers. 3. Allow rewind when target and source are on the same timelines. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] PoC: Partial sort

2015-10-16 Thread Alexander Korotkov
to to whisk dust. Rebased version of patch is attached. This patch isn't passing regression tests because of plan changes. I'm not yet sure about those changes: why they happens and are they really regression? Since I'm not very familiar with planning of INSERT ON CONFLICT and RLS, any help is apprec

Re: [HACKERS] PoC: Partial sort

2015-10-20 Thread Alexander Korotkov
On Fri, Oct 16, 2015 at 7:11 PM, Alexander Korotkov <aekorot...@gmail.com> wrote: > On Sun, Jun 7, 2015 at 11:01 PM, Peter Geoghegan <p...@heroku.com> wrote: > >> On Sun, Jun 7, 2015 at 8:10 AM, Andreas Karlsson <andr...@proxel.se> >> wrote: >> > A

Re: [HACKERS] point_ops for GiST

2015-10-12 Thread Alexander Korotkov
-in geometric types. In short: once we implement it for built-in geometric types, you can ask PostGIS team to do the same for their geometry/geography. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] point_ops for GiST

2015-10-12 Thread Alexander Korotkov
> those macros. > In my opinion it would be cool remove FP macros. I see absolutely no sense in them. But since it break compatibility it would be quite hard though. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] point_ops for GiST

2015-10-12 Thread Alexander Korotkov
ot;Consistent" method of GiST influences only search and can't lead to corrupt indexes. However, "same" method can lead to corrupt indexes. However, this is not the reason to not backpatch the changes and preserve buggy behaviour; this is the reason to recommend reindexing to users

Re: [HACKERS] Some questions about the array.

2015-10-09 Thread Alexander Korotkov
for me. When updating non-empty array its boundaries isn't extending. If one update non-empty array out of its boundaries then he get an error "ERROR: array subscript out of range". If we extrapolate this logic to empty arrays then we this error should be thrown on any update of empty array. Despite this, we allow any update of empty array. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-10 Thread Alexander Korotkov
On Fri, Jul 10, 2015 at 4:54 AM, Michael Paquier michael.paqu...@gmail.com wrote: On Thu, Jul 9, 2015 at 10:33 PM, Alexander Korotkov wrote: [...] + /* Caclculate max data size on page according to fillfactor */ s/Caclculate/Calculate When creating a simple gin index, I am seeing

Re: [HACKERS] pg_trgm version 1.2

2015-07-07 Thread Alexander Korotkov
On Tue, Jun 30, 2015 at 11:28 PM, Jeff Janes jeff.ja...@gmail.com wrote: On Tue, Jun 30, 2015 at 2:46 AM, Alexander Korotkov a.korot...@postgrespro.ru wrote: On Sun, Jun 28, 2015 at 1:17 AM, Jeff Janes jeff.ja...@gmail.com wrote: This patch implements version 1.2 of contrib module pg_trgm

Re: [HACKERS] Performance improvement for joins where outer side is unique

2015-07-07 Thread Alexander Korotkov
46 lines). Hunk #3 succeeded at 1466 (offset 46 lines). Hunk #4 succeeded at 1497 (offset 46 lines). patching file src/test/regress/sql/join.sql Hunk #1 succeeded at 1344 (offset 37 lines). -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Fillfactor for GIN indexes

2015-07-09 Thread Alexander Korotkov
too. Sounds reasonable. Now it works like btree. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company gin_fillfactor_6.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Cube extension kNN support

2015-07-09 Thread Alexander Korotkov
in the patch. Did forget to include it? -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-07-10 Thread Alexander Korotkov
. With this statistics user can identify system bottlenecks again without sampling. Number #2 will be provided as a separate patch. Number #1 require different concurrency model. ldus will extract it from waits monitoring patch shortly. -- Alexander Korotkov Postgres Professional: http

Re: [HACKERS] WIP: Rework access method interface

2015-08-27 Thread Alexander Korotkov
On Wed, Aug 26, 2015 at 7:20 PM, Alexander Korotkov a.korot...@postgrespro.ru wrote: On Wed, Aug 26, 2015 at 6:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: OK. So, as we mentioned before, if we need to expose something of am parameters

Re: [HACKERS] WIP: Rework access method interface

2015-08-26 Thread Alexander Korotkov
On Wed, Aug 26, 2015 at 6:50 PM, Tom Lane t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru writes: OK. So, as we mentioned before, if we need to expose something of am parameters at SQL-level then we need to write special functions which would call amhandler

Re: [HACKERS] WIP: Rework access method interface

2015-08-26 Thread Alexander Korotkov
ratio doesn't look very good. Agree. Teach syscache about inheritance would be overengeneering for this problem. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Horizontal scalability/sharding

2015-08-31 Thread Alexander Korotkov
ld rely only on ourselves. That is disappointing. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Access method extendability

2015-08-31 Thread Alexander Korotkov
GenericXLogAbort(). In the case of abort initial state of pages will be reverted. Generic xlog takes care about critical section, unlogged relation, setting lsn, making buffer dirty. User code is just simple and clear. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian

Re: [HACKERS] Commitfest remaining "Needs Review" items

2015-08-31 Thread Alexander Korotkov
On Mon, Aug 31, 2015 at 4:31 PM, Andres Freund <and...@anarazel.de> wrote: > On 2015-08-31 16:22:54 +0300, Alexander Korotkov wrote: > > Is it correct to switch 2015-09 commitfest to inprogress now? > > Yea, isn't it only starting the 15th? AFICS, on the last developer m

Re: [HACKERS] Commitfest remaining "Needs Review" items

2015-08-31 Thread Alexander Korotkov
n? > > Yeah, switched. Is it correct to switch 2015-09 commitfest to inprogress now? I thought we should still accept patches to 2015-09 since it's 2015-08-31 now. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] [PROPOSAL] Effective storage of duplicates in B-tree index.

2015-09-01 Thread Alexander Korotkov
, you have to do exclusive lock on one page of posting tree. One can say that concurrency would became worse because index would become smaller and number of pages would became smaller too. Since number of pages would be smaller, backends are more likely concur for the same page. But this argument can be user against any compression and for any bloat. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-09-07 Thread Alexander Korotkov
On Thu, Aug 20, 2015 at 9:57 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Jul 22, 2015 at 4:28 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Wed, Jul 22, 2015 at 8:48 AM, Michael Paquier < >> michael.paqu...@gmail.co

Re: [HACKERS] WIP: Access method extendability

2015-09-07 Thread Alexander Korotkov
n the same order GenericXLogRegister was called. Patches was rebased against latest version of am interface rework patch. http://www.postgresql.org/message-id/CAPpHfduGY=KZSBPZN5+USTXev-9M2PAUp3Yi=syfdo2n244...@mail.gmail.com -- Alexander Korotkov Postgres Professional: http://www.postgre

Re: [HACKERS] WIP: Rework access method interface

2015-09-07 Thread Alexander Korotkov
On Mon, Sep 7, 2015 at 10:02 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > On 2015-09-07 20:56, Alexander Korotkov wrote: > >> On Mon, Sep 7, 2015 at 9:17 PM, Petr Jelinek <p...@2ndquadrant.com >> >> However I don't like the naming differences between valid

Re: [HACKERS] Waits monitoring

2015-09-07 Thread Alexander Korotkov
y. Anyway, I think attracting more attention to this problem is good. It would be very nice if Simon or Andres give review of this. [4] - http://www.postgresql.org/message-id/CAPpHfdtdF8LyR0zBA_tzAwYq00GFZyVbh_XfFAABRQQ=mbn...@mail.gmail.com [5] - http://www.postgresql.org/message-id/55c3306b.5010...@postgrespro.ru -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Rework access method interface

2015-09-07 Thread Alexander Korotkov
On Mon, Sep 7, 2015 at 9:17 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > On 2015-09-04 16:26, Alexander Korotkov wrote: > >> >> Attached patch is implementing this. It doesn't pretend to be fully >> correct implementation, but it should be enough for proof the co

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-09-08 Thread Alexander Korotkov
On Tue, Sep 8, 2015 at 10:28 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Sep 8, 2015 at 1:14 AM, Alexander Korotkov wrote: > > On Thu, Aug 20, 2015 at 9:57 AM, Michael Paquier wrote: > >> The code above looks correct to me when scanning the WAL his

Re: [HACKERS] Waits monitoring

2015-09-09 Thread Alexander Korotkov
bjections here. And the same time [3] can be > > significantly simplified and improved on top of [1] and [2]. > > Great - let's try to deal with [1] first, then. > > Does anyone wish to object to me committing that part? > No objections from me. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-09-09 Thread Alexander Korotkov
On Wed, Sep 9, 2015 at 9:01 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > > > On Wed, Sep 9, 2015 at 3:27 AM, Alexander Korotkov > <a.korot...@postgrespro.ru> wrote: > >> On Tue, Sep 8, 2015 at 10:28 AM, Michael Paquier >> <michael.paqu...@g

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-09-14 Thread Alexander Korotkov
On Mon, Sep 14, 2015 at 2:12 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 2:25 PM, Alexander Korotkov <aekorot...@gmail.com> > wrote: > >> On Sat, Sep 12, 2015 at 2:05 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >&

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-09-14 Thread Alexander Korotkov
On Mon, Sep 14, 2015 at 2:25 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 3:02 PM, Alexander Korotkov <aekorot...@gmail.com> > wrote: > >> On Sat, Sep 12, 2015 at 3:24 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote:

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-09-16 Thread Alexander Korotkov
On Thu, Sep 10, 2015 at 8:33 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Sep 9, 2015 at 7:13 PM, Alexander Korotkov wrote: > > On Wed, Sep 9, 2015 at 9:01 AM, Michael Paquier wrote: > >> The code building the target history file is a d

Re: [HACKERS] statistics for array types

2015-09-16 Thread Alexander Korotkov
rong value from slot 3. > Hmm, I think we should store cutoff_freq / nonnull_cnt as minfreq when we collect no MCEs. Moreover, I think we should store it even when num_mcelem >= track_len and we haven't cut MCEs we find. In this case we can get more precise estimation for rare element usi

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-09-16 Thread Alexander Korotkov
On Mon, Sep 14, 2015 at 3:03 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Sep 14, 2015 at 5:32 AM, Alexander Korotkov > <aekorot...@gmail.com> wrote: > > In order to build the consensus we need the roadmap for waits monitoring. > > Would single byte in P

[HACKERS] LW_SHARED_MASK macro

2015-09-17 Thread Alexander Korotkov
swaiters %u waiters %u rOK %d", MyProcPid, where, MainLWLockNames[id], !!(state & LW_VAL_EXCLUSIVE), state & LW_SHARED_MASK, !!(state & LW_FLAG_HAS_WAITERS), pg_atomic_read_u32(>nwaiters), !!(state & LW_FLAG_RELEASE_OK; Should it be ((uint32) ((1 << 24)-1)) ins

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-09-14 Thread Alexander Korotkov
ake sense to include > information about backend processes in this variable as pg_stat_activity > just displays information of backend processes. > I'm not objecting that we should track only backends information in pg_stat_activity. I think we should have also some other way of tracking

Re: [HACKERS] RFC: replace pg_stat_activity.waiting with something more descriptive

2015-09-14 Thread Alexander Korotkov
On Sat, Sep 12, 2015 at 3:24 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Aug 14, 2015 at 7:23 PM, Alexander Korotkov <aekorot...@gmail.com> > wrote: > > > > On Thu, Aug 6, 2015 at 1:01 PM, Ildus Kurbangaliev < > i.kurbangal...@postgrespro.r

Re: [HACKERS] WIP: Rework access method interface

2015-09-20 Thread Alexander Korotkov
On Sun, Sep 20, 2015 at 5:02 PM, Petr Jelinek <p...@2ndquadrant.com> wrote: > On 2015-09-18 14:58, Alexander Korotkov wrote: > >> On Wed, Sep 16, 2015 at 8:44 PM, Teodor Sigaev <teo...@sigaev.ru >> <mailto:teo...@sigaev.ru>> wrote: >> >>

Re: [HACKERS] WIP: Rework access method interface

2015-09-20 Thread Alexander Korotkov
On Sun, Sep 20, 2015 at 5:18 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Petr Jelinek <p...@2ndquadrant.com> writes: > > On 2015-09-18 14:58, Alexander Korotkov wrote: > >> After, further personal discussion with Teodor, we decided that > >> amvalidate is

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-09-24 Thread Alexander Korotkov
we're running benchmarks on it. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Alexander Korotkov
. > > Yes. Also, for a major change like this, it would be a good thing if > the documentation got a review from a native English speaker. I will > volunteer to handle it if someone else does the first draft. > Great! I'll write this documentation. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-09-18 Thread Alexander Korotkov
On Wed, Sep 16, 2015 at 7:47 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Thu, Sep 10, 2015 at 8:33 AM, Michael Paquier < > michael.paqu...@gmail.com> wrote: > >> On Wed, Sep 9, 2015 at 7:13 PM, Alexander Korotkov wrote: > >

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-12-08 Thread Alexander Korotkov
On Tue, Dec 8, 2015 at 1:04 PM, Andres Freund <and...@anarazel.de> wrote: > On 2015-12-08 12:53:49 +0300, Alexander Korotkov wrote: > > ​This is why atomic increment *could be* cheaper than loop over CAS and, > it > > worth having experiments. ​Another idea is that we c

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-12-09 Thread Alexander Korotkov
On Tue, Dec 8, 2015 at 6:00 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Tue, Dec 8, 2015 at 3:56 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: >> >> ​Agree. This patch need to be carefully verified. Current experiments >> just

[HACKERS] Proposal: custom compression methods

2015-12-13 Thread Alexander Korotkov
ni...@gmail.com> who started work on this patch and sent me draft of proposal in Russian. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2015-12-11 Thread Alexander Korotkov
On Thu, Dec 10, 2015 at 9:26 AM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Wed, Dec 9, 2015 at 2:17 PM, Alexander Korotkov < > a.korot...@postgrespro.ru> wrote: > >> On Tue, Dec 8, 2015 at 6:00 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote

[HACKERS] Isolation of table creation

2015-12-11 Thread Alexander Korotkov
. # select * from tmp; i --- (0 rows) # insert into tmp values (2); INSERT 0 1 # select * from tmp; i --- 2 (1 row) # commit; COMMIT Is it a bug? -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Optimizer questions

2016-01-05 Thread Alexander Korotkov
should make this better, or at least make it practical to make it > better. > Hmm... Besides costing it would be nice to postpone calculation of expensive tlist functions after LIMIT. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] statistics for array types

2015-12-18 Thread Alexander Korotkov
On Wed, Sep 16, 2015 at 8:01 PM, Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > On Mon, Aug 24, 2015 at 8:26 PM, Jeff Janes <jeff.ja...@gmail.com> wrote: > >> On Thu, Aug 20, 2015 at 6:00 PM, Tomas Vondra < >> tomas.von...@2ndquadrant.com> wrote: &g

Re: [HACKERS] Commit fest status for 2015-11

2015-12-24 Thread Alexander Korotkov
d with Feedback: 22. > > Total: 103. > > Many thanks to Michael for doing the CF management work this time! > ​+1 ​Michael, thank you for the great job. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Patch: pg_trgm: gin index scan performance for similarity search

2015-12-24 Thread Alexander Korotkov
we use this upper bound. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2015-12-19 Thread Alexander Korotkov
tch in commitfest: > https://commitfest.postgresql.org/8/448/ ​Great. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] Use pg_rewind when target timeline was switched

2015-12-01 Thread Alexander Korotkov
. > ​However, we can add some explicit statements​ about new pg_rewind capabilities. Please, check attached patch for those statements. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company pg-rewind-target-switch-7.patch Description: Binary dat

Re: [HACKERS] Why we don't have checksums on clog files

2016-06-07 Thread Alexander Korotkov
ages. For data pages we have to reinitialize database cluster to enable checksums. I think we can also require reinitialization to enable checksums of SLRU pages. Thus, major problem would be that number of items fitting to page would depend on whether checksums are enabled. However, it sho

Re: [HACKERS] [PATCH] Refactoring of LWLock tranches

2016-01-29 Thread Alexander Korotkov
good for me. It compiles without warnings, passes regression tests. I also did small testing of replication slots in order to check that it works correctly. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

Re: [HACKERS] [PATCH] Refactoring of LWLock tranches

2016-01-29 Thread Alexander Korotkov
ropping old API I don't think it's useful to have LWLocks without having shared memory. There is another thing I'd like extensions to be able to do. It would be nice if extensions could use dynamic shared memory instead of static. Then extensions could use shared memory without being in shared_preload_libraries. But if extension register DSM, then there is no way to tell other backends to use it for that extension. Also DSM would be deallocated when all backends detached from it. This it out of scope for this patch though. -- Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company

<    2   3   4   5   6   7   8   9   10   11   >