[HACKERS] [PATCH] SortSupport for macaddr type

2016-08-26 Thread Brandur
d an entry into the current commitfest as suggested by the Postgres Wiki and follow up here with a link. Thanks, and if anyone has feedback or other thoughts, let me know! Brandur [1] https://www.postgresql.org/message-id/CAM3SWZR4avsTwwNVUzRNbHk8v36W-QBqpoKg=ogkwwy0dkt...@mail.gmail

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2016-08-26 Thread Brandur
8v36W-QBqpoKg=ogkwwy0dkt...@mail.gmail.com On Fri, Aug 26, 2016 at 10:44:22AM -0700, Brandur wrote: > Hello, > > I've attached a patch to add SortSupport for Postgres' macaddr which has the > effect of improving the performance of sorting operations for the type. The > strategy

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2017-02-28 Thread Brandur Leach
een generating a new OID value with the `unused_oids` script, but pretty much every time I rebase I collide with someone else's addition and need to find a new one. Is it better for me to pick an OID in an exotic range for my final patch, or that a committer just finds a new one (if nece

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2017-03-31 Thread Brandur Leach
Hello, Thank you Peter for the assist here and great sleuthing in the disassembly, and thanks Teodor for committing! Neha pointed out (thanks as well) a couple typos upthread that I hadn't gotten around to fixing. I've attached a new three line patch to sort those out. Brandur On W

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2017-02-05 Thread Brandur Leach
fications after > a pgindent run. Could you try to run pgindent on mac.c > before sending an updated patch? Good call! I've run the new version through pgindent. Let me know if you have any further feedback and/or suggestions. Thanks! Brandur On Wed, Sep 14, 2016 at 3:14 AM,

Re: [HACKERS] [PATCH] SortSupport for macaddr type

2017-02-07 Thread Brandur Leach
And as a short follow up, I've moved the patch to the current commit fest: https://commitfest.postgresql.org/13/743/ On Sun, Feb 5, 2017 at 1:56 PM, Brandur Leach wrote: > Hi Julien, > > Thank you for taking the time to do this review, and my > apologies for the very delayed