Re: [HACKERS] Windowing Function Patch Review -> Standard Conformance

2008-11-09 Thread David Rowley
Hitoshi Harada wrote: > I'm glad to hear that. Actually thanks to git it is quite easy for me > to merge my own repository with the HEAD. It tells me which lines are > new coming and which lines I modified are newer than else in CVS. This > is my first project where I use git (and I am not guru of

Re: [HACKERS] Windowing Function Patch Review -> Standard Conformance

2008-11-08 Thread David Rowley
Hitoshi Harada Wrote: > > although attached is the whole (split) patch. I'm having some trouble getting these patches to patch cleanly. I think it's because of this that I can't get postgres to compile after applying the patch. It errors out at tuptoaster.c some constants seem to be missing from

[HACKERS] Windowing Function Patch Review -> Standard Conformance

2008-11-04 Thread David Rowley
I wrote: > All, > > This is my first patch review for PostgreSQL. I did submit a patch last > commit fest (Boyer-Moore) so I feel I should review one this commit fest. > I'm quite new to PostgreSQL so please don't rely on me totally. I'll do my > best. Heikki is also reviewing this patch which mak

Re: [HACKERS] Windowing Function Patch Review -> Performance Comparison.

2008-11-04 Thread David Rowley
Hitoshi Harada wrote: > >> > Test 3 and 5 did not seem to make use of an index to get a sorted > list > >> of > >> > results. I disabled enable_seqscan but the planner still failed to > >> choose > >> > index_scan. Is there any reason for this? Perhaps I'm missing > something. > >> > Hitoshi, can y

Re: [HACKERS] Windowing Function Patch Review -> Performance Comparison.

2008-11-02 Thread David Rowley
e included your tests too. I understand that people will probably use this method as sometimes there is little choice to get the performance that is required. Hitoshi Harada Wrote: > 2008/11/2 David Rowley <[EMAIL PROTECTED]>: > > Obervations: > > > > Test 3 and 5 did not

[HACKERS] Windowing Function Patch Review -> Performance Comparison.

2008-11-01 Thread David Rowley
All, This is my first patch review for PostgreSQL. I did submit a patch last commit fest (Boyer-Moore) so I feel I should review one this commit fest. I'm quite new to PostgreSQL so please don't rely on me totally. I'll do my best. Heikki is also reviewing this patch which makes me feel better. M

Re: [HACKERS] TABLE command

2008-10-30 Thread David Rowley
Peter Eisentraut Wrote: > If I read this right, SQL would allow writing > > TABLE foo; Interesting; I managed to find it in the spec: 4) The TABLE is equivalent to the ( SELECT * FROM ) So going by that would the patch also have to support something like: WITH a AS (SELECT * FROM b) TABL

Re: [HACKERS] Window Functions: v07 APIs and buffering strateties

2008-10-27 Thread David Rowley
Hitoshi Harada Wrote: > As I promised, version 7 of the window functions is now released. At > the same time, git repository branch comes back to master. > > git: http://git.postgresql.org/?p=~davidfetter/window_functions/.git > patch: http://umitanuki.net/pgsql/window_functions.patch.20081028.gz

Re: [HACKERS] Window Functions patch v06

2008-10-13 Thread David Rowley
Hitoshi Harada wrote: >I made up my mind to scratch former window functions and redesigned >completely new execution model, based on the discussion with Heikki. >Attached is the v06 against HEAD today. >http://umitanuki.net/pgsql/wfv06/design.html First off, fantastic work! In my eyes this and WI

Re: [PATCHES] [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-09-08 Thread David Rowley
Heikki Linnakangas wrote: > David Rowley wrote: > Thanks for all the reviews and suggestions. > David, could you re-run the performance tests you ran earlier? I'm > curious to know what impact switching to the simpler loop for 1-byte > pattern had. Sure: http://ww

[HACKERS] TODO item: Allow substring/replace() to get/set bit values

2008-09-07 Thread David Rowley
I was just searching though the TODO list to try and find a quick one that could be ticked off. Under functions there is "Allow substring/replace() to get/set bit values". Does anyone have any more information about this?

Re: [PATCHES] [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-09-07 Thread David Rowley
Tom Lane Wrote: > "David Rowley" <[EMAIL PROTECTED]> writes: > > I've made the discussed changes. Also updated the benchmark results. > > http://www.unixbeast.com/~fat/8.3_test_v1.3.xls > Applied with revisions; mostly cosmetic except for one point. I &

Re: [PATCHES] [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-09-06 Thread David Rowley
<<>> Tom Lane wrote: > I wrote: > > I looked this over a bit and was immediately confused by one thing: > > the introductory comment says that the skip table size ought to be based > > on the length of the haystack, which makes sense to me, but the code is > > actually initializing it on the basis

Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-08-31 Thread David Rowley
f there is anything that I've overlooked. David. -Original Message----- From: David Rowley [mailto:[EMAIL PROTECTED] Sent: 31 August 2008 00:21 To: 'pgsql-hackers@postgresql.org' Subject: TODO item: Implement Boyer-Moore searching (First time hacker) Refere

[HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker)

2008-08-30 Thread David Rowley
My apologies if this is a duplicate. I think the attachment size was too big. Reference: Bruce Momjian writes: -> http://archives.postgresql.org/pgsql-committers/2007-09/msg00402.php Other references: Boyer Moore?? -> http://www.cs.utexas.edu/users/moore/best-ideas/string-searching/fs

<    5   6   7   8   9   10