version is attached.
The regression test for reindexdb is added as well.
Pushed.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
left. So I'm thinking that maybe we should pick up
small, self-contained and useful part from the patch and focus on that.
If we try to commit every features that the patch provides, we might get
nothing at least in 9.5, I'm afraid.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list
could probably even get away with just documenting the risk and
having people turn off the compression *completely* if they care about it,
but if we can do it at a table level, that's obviously a lot better.
+1
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On Wed, Apr 15, 2015 at 11:55 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Apr 15, 2015 at 11:10 AM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Apr 15, 2015 at 12:00 AM, Magnus Hagander mag...@hagander.net
wrote:
On Tue, Apr 14, 2015 at 4:50 PM, Heikki Linnakangas hlinn
On Wed, Apr 8, 2015 at 10:53 PM, Sawada Masahiko sawada.m...@gmail.com wrote:
On Wed, Apr 8, 2015 at 1:09 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Apr 8, 2015 at 1:57 AM, Sawada Masahiko sawada.m...@gmail.com
wrote:
On Wed, Apr 8, 2015 at 1:11 AM, FabrÃzio de Royes Mello
On Thu, Apr 9, 2015 at 12:33 AM, Jim Nasby jim.na...@bluetreble.com wrote:
On 4/8/15 7:04 AM, Fujii Masao wrote:
I'm thinking to apply the attached patch.
But does anyone want to keep supporting the option? Why?
Nuke it.
There seem no objections, so just pushed.
Regards,
--
Fujii Masao
On Tue, Apr 7, 2015 at 11:59 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Apr 6, 2015 at 9:10 PM, Fujii Masao masao.fu...@gmail.com wrote:
I'm not familiar with native language support (sorry), but don't we need to
add the shortcut of gettext into every calls of pg_log
On Mon, Apr 6, 2015 at 10:01 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Mon, Apr 6, 2015 at 5:33 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Apr 6, 2015 at 1:41 PM, Michael Paquier wrote:
I guess that you are working on a patch? If not, you
differently; normally the pipeline would be
aborted as a whole.
Make sense.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
., () is not
added after WITH clause. Did we reach the consensus about this syntax?
The last email from Robert just makes me think that () should be added
into the syntax.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
Hi,
While reviewing the REINDEX VERBOSE patch, I felt inclined to remove FORCE
option support from REINDEX command. It has been marked obsolete since
very old version 7.4. I think that it's no longer worth keeping supporting it.
Thought?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers
to implement it as a separate patch
because it's very different from log message problem.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Apr 6, 2015 at 11:40 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
Hi all,
I just spotted that PQmakeEmptyPGresult is named PQmakeEmptyPGResult
in one place (not Result, but result) in the docs.
A patch is attached.
Pushed. Thanks!
Regards,
--
Fujii Masao
--
Sent via
be called.
(4)
ISTM that set_pglocale_pgservice() needs to be called, but not in pg_rewind.
(5)
printf() is used to output an error in some files, e.g., timeline.c and
parsexlog.c. These printf() should be replaced with pg_log or pg_fatal?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers
On Fri, Apr 3, 2015 at 2:30 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 12:56 PM, Fujii Masao wrote:
The first patch looks good to me basically. But I have one comment:
shouldn't we expose pg_malloc_extended as a global function like
we did pg_malloc? Some
On Fri, Apr 3, 2015 at 8:37 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Apr 3, 2015 at 6:35 PM, Fujii Masao wrote:
Regarding the second patch, you added the checks of the return value of
XLogReaderAllocate(). But it seems half-baked. XLogReaderAllocate() still
uses palloc
On Thu, Feb 12, 2015 at 4:02 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Feb 11, 2015 at 2:13 AM, Robert Haas robertmh...@gmail.com wrote:
On Mon, Feb 9, 2015 at 7:02 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Feb 9, 2015 at 7:58 PM, Fujii Masao masao.fu
On Tue, Mar 10, 2015 at 5:29 PM, Kyotaro HORIGUCHI
horiguchi.kyot...@lab.ntt.co.jp wrote:
Hi, the attached is the v5 patch.
- Do feGetCurrentTimestamp() only when necessary.
- Rebased to current master
At Mon, 2 Mar 2015 20:21:36 +0900, Fujii Masao masao.fu...@gmail.com wrote
If checkpoint_completion_target is 1 and wal_keep_segments is 0,
it can become 4 * checkpoint_segments + 1.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Mar 19, 2015 at 1:43 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Mar 19, 2015 at 12:40 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Mar 19, 2015 at 12:23 PM, Fujii Masao masao.fu...@gmail.com wrote:
Are you planning to update the patch so that it's
On Fri, Mar 6, 2015 at 1:07 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Mar 6, 2015 at 12:44 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Mar 5, 2015 at 9:49 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Mar 5, 2015 at 7:10 PM, Fujii Masao wrote
On Sat, Mar 14, 2015 at 8:39 AM, Tomas Vondra
tomas.von...@2ndquadrant.com wrote:
Hi there,
with gcc 4.8.3, I'm getting this warning in xloginsert.c:
Thanks for the report! I fixed this problem at the commit cd6c45c.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql
,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Mar 9, 2015 at 9:08 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Mar 9, 2015 at 4:29 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Mar 5, 2015 at 10:08 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Mar 5, 2015 at 9:14 PM, Syed, Rahila rahila.s
in XLogRecordImageHeader
rather than block header.
Thanks for updating the patch! Attached is the refactored version of the patch.
Regards,
--
Fujii Masao
*** a/contrib/pg_xlogdump/pg_xlogdump.c
--- b/contrib/pg_xlogdump/pg_xlogdump.c
***
*** 359,376 XLogDumpCountRecord(XLogDumpConfig
.
Yes. I pushed the fix. Thanks!
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
format even after
committing this patch.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Dec 18, 2014 at 6:43 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Tue, Dec 16, 2014 at 3:51 AM, Simon Riggs si...@2ndquadrant.com wrote:
Currently, WALReceiver writes and fsyncs data it receives. Clearly,
while we are waiting for an fsync we aren't doing any other useful
work
extensible than simply having VACOPT_VERBOSE.
With the patch, VACUUM ANALYZE VERBOSE doesn't emit any verbose message.
Why did you remove that functionality?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http
On Thu, Mar 5, 2015 at 9:49 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Mar 5, 2015 at 7:10 PM, Fujii Masao wrote:
With the patch, VACUUM ANALYZE VERBOSE doesn't emit any verbose message.
Why did you remove that functionality?
Oops. Sorry about that. In gram.y
On Thu, Mar 5, 2015 at 1:59 AM, Marco Nenciarini
marco.nenciar...@2ndquadrant.it wrote:
Hi Fujii,
Il 03/03/15 11:48, Fujii Masao ha scritto:
On Tue, Mar 3, 2015 at 12:36 AM, Marco Nenciarini
marco.nenciar...@2ndquadrant.it wrote:
Il 02/03/15 14:21, Fujii Masao ha scritto:
On Thu, Feb 12
wal_keep_segments to accept MB/GB, as discussed
already)
+1
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
them into a block header (instead of
block image header) seems a waste of bytes in WAL. So I concur with Michael.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Mar 4, 2015 at 10:31 AM, Peter Geoghegan p...@heroku.com wrote:
SnapBuildCommitTxn() has what I gather is an obsolete reference to
SnapshotNow(). Attached patch corrects this.
Pushed. Thanks!
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On Tue, Mar 3, 2015 at 12:36 AM, Marco Nenciarini
marco.nenciar...@2ndquadrant.it wrote:
Il 02/03/15 14:21, Fujii Masao ha scritto:
On Thu, Feb 12, 2015 at 10:50 PM, Marco Nenciarini
marco.nenciar...@2ndquadrant.it wrote:
Hi,
I've attached an updated version of the patch.
basebackup.c:1565
.
intmax_wal_size = 8;/* 128 MB */
It's better to update the above code in xlog.c. That's not essential, though.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
the current design, especially that
every files basically need to be read to check whether they have been modified
since last backup even when *no* modification happens since last backup?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Mon, Mar 2, 2015 at 8:37 PM, Heikki Linnakangas hlinn...@iki.fi wrote:
On 03/02/2015 11:53 AM, Fujii Masao wrote:
On Sat, Feb 28, 2015 at 5:00 AM, Josh Berkus j...@agliodbs.com wrote:
On 11/10/2014 10:54 AM, Magnus Hagander wrote:
On Mon, Nov 10, 2014 at 7:48 PM, Heikki Linnakangas
retries and standby delay in
mainstream. Is there some reason we still need pg_standby?
Yes, it's not easy to perform fast failover without pg_standby for now.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription
mark_done,
+ int standby_message_timeout, int64 *last_status)
Maybe it's time to refactor this ugly coding (i.e., currently many arguments
need to be given to each functions. Looks ugly)...
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers
, but we can just add new flag field if we prefer
the extensibility and readability of the code.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
. The standby emit the following
error messages.
LOG: invalid block_id 255 at 0/3B0
LOG: record with invalid length at 0/30017F0
LOG: invalid block_id 255 at 0/3001878
LOG: record with invalid length at 0/30027D0
LOG: record with invalid length at 0/3002E58
...
Regards,
--
Fujii Masao
to converse from MB, GB etc?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote:
On 2/18/15 10:25 AM, David Steele wrote:
On 2/18/15 6:11 AM, Fujii Masao wrote:
The pg_audit doesn't log BIND parameter values when prepared statement is
used.
Seems this is an oversight of the patch
On Thu, Feb 26, 2015 at 1:40 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Fujii Masao wrote:
On Tue, Feb 24, 2015 at 1:29 AM, David Steele da...@pgmasters.net wrote:
1) Follow Oracle's as session option and only log each statement type
against an object the first time it happens
On Wed, Jan 14, 2015 at 11:04 AM, Ali Akbar the.ap...@gmail.com wrote:
2014-12-18 19:35 GMT+07:00 Fujii Masao masao.fu...@gmail.com:
On Mon, Dec 15, 2014 at 2:38 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
I was thinking something like this, added just after that para
On Fri, Feb 20, 2015 at 9:33 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Feb 20, 2015 at 9:12 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Tue, Feb 10, 2015 at 10:32 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Feb 9, 2015 at 8:29 PM, Fujii Masao masao.fu
WAL records when I set up replication and enabled wal_compression.
LOG: record with invalid length at 0/3B0
LOG: record with invalid length at 0/3000518
LOG: Invalid block length in record 0/30005A0
LOG: Invalid block length in record 0/3000D60
...
Regards,
--
Fujii Masao
--
Sent via
On Tue, Feb 10, 2015 at 10:32 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Feb 9, 2015 at 8:29 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Sun, Feb 8, 2015 at 2:54 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Feb 6, 2015 at 4:58 PM, Fujii Masao wrote
, probably we should remove them at first
and find out another idea to fix the problem you pointed. ISTM that it's not so
difficult to remove them. Thought? Do you have any numbers which can prove
that such frequent gettimeofday() has only ignorable impact on the performance?
Regards,
--
Fujii Masao
think
this is problematic.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
only (9.3, 9.4 and master look correct, earlier
releases don't have pg_receivexlog)
Are you planning to back-patch the fix to 9.2?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
. It can throw out the time counting stuff in the loop we are
talking about and that of XLogWalRcvSendHSFeedback and
XLogWalRcvSendReply, but it might be a bit too large for the
gain.
Yes, sounds overkill.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On Sun, Feb 8, 2015 at 2:54 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Feb 6, 2015 at 4:58 PM, Fujii Masao wrote:
- * Wait for more WAL to arrive. Time out after 5
seconds,
- * like when polling the archive, to react to a trigger
.
MemoryContextAllocExtended() was added, so isn't it time to replace palloc()
with MemoryContextAllocExtended(CurrentMemoryContext, MCXT_ALLOC_NO_OOM)
in allocate_recordbuf()?
Regards,
--
Fujii Masao
*** a/src/backend/access/transam/xlogreader.c
--- b/src/backend/access/transam/xlogreader.c
On Fri, Feb 6, 2015 at 3:42 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
Fujii Masao wrote:
I wrote
This is an inspiration from lz4 APIs. Wouldn't it be buggy for a
compression algorithm to return a size of 0 bytes as compressed or
decompressed length btw? We could as well make
*/
+is_compressed = true;
+}
You can refactor XLogCompressBackupBlock() and move all the
above code to it for more simplicity.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org
On Fri, Feb 6, 2015 at 3:22 PM, Kyotaro HORIGUCHI
horiguchi.kyot...@lab.ntt.co.jp wrote:
Sorry, I misunderstood that.
At Wed, 4 Feb 2015 19:22:39 +0900, Fujii Masao masao.fu...@gmail.com
wrote in
cahgqgwgudgcmnhzinkd37i+jijdkruecrea1ncrs1mmte3r...@mail.gmail.com
On Wed, Feb 4, 2015
in postgresql.conf rather than
recovery.conf? I'd like to change the value of this parameter without
restarting the server.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
On Tue, Jan 6, 2015 at 11:09 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Mon, Jan 5, 2015 at 10:29 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Sun, Dec 28, 2014 at 10:57 PM, Michael Paquier wrote:
The patch 1 cannot be applied to the master successfully because of
recent change
On Thu, Feb 5, 2015 at 10:20 AM, Kyotaro HORIGUCHI
horiguchi.kyot...@lab.ntt.co.jp wrote:
Hello,
At Wed, 4 Feb 2015 19:22:39 +0900, Fujii Masao masao.fu...@gmail.com wrote
in cahgqgwgudgcmnhzinkd37i+jijdkruecrea1ncrs1mmte3r...@mail.gmail.com
On Wed, Feb 4, 2015 at 4:58 PM, Kyotaro HORIGUCHI
has the same typo. Fixed both. Thanks!
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
mentioned in the previous mail. But
the current master still has this problem.
Seems walreceiver has the same problem. No?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
platforms.
This problem exists even now because pg_usleep is used, but the sleep
time is just 5 seconds, so it's not so bad. But the patch allows a user to
set large sleep time. Shouldn't we use WaitLatch or split the pg_usleep
like recoveryPausesHere() does?
Regards,
--
Fujii Masao
--
Sent
On Mon, Jan 5, 2015 at 6:22 PM, Andres Freund and...@2ndquadrant.com wrote:
On 2015-01-05 16:22:56 +0900, Fujii Masao wrote:
On Sun, Jan 4, 2015 at 5:47 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2015-01-03 16:03:36 +0100, Andres Freund wrote:
pg_basebackup really
changed heavily
remember from Fujii Masao this same thread that
showed a performance improvement for WAL compression:
http://www.postgresql.org/message-id/CAHGQGwGqG8e9YN0fNCUZqTTT=hnr7ly516kft5ffqf4pp1q...@mail.gmail.com
Why are we not seeing the 33% compression and 15% performance
improvement he saw
bottleneck especially in synchronous replication cases.
FPW compression can be useful for those cases, for example.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Sun, Dec 28, 2014 at 10:57 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Dec 26, 2014 at 4:16 PM, Michael Paquier michael.paqu...@gmail.com
wrote:
On Fri, Dec 26, 2014 at 3:24 PM, Fujii Masao masao.fu...@gmail.com
wrote:
pglz_compress() and pglz_decompress() still use
errhidecontext(bool hide_ctx)
Here in function header, function name should be
errhidecontext.
Fixed. Thanks!
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql
On Sun, Jan 4, 2015 at 5:47 AM, Andres Freund and...@2ndquadrant.com wrote:
On 2015-01-03 16:03:36 +0100, Andres Freund wrote:
On 2014-12-31 16:32:19 +0100, Andres Freund wrote:
On 2014-12-05 16:18:02 +0900, Fujii Masao wrote:
On Fri, Dec 5, 2014 at 9:28 AM, Andres Freund
On Thu, Dec 4, 2014 at 12:08 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Dec 3, 2014 at 11:54 PM, Alvaro Herrera
alvhe...@2ndquadrant.com wrote:
Pushed with some extra cosmetic tweaks.
I got the following assertion failure when I executed
pg_xact_commit_timestamp()
in the standby
avoid that. Thought?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Dec 19, 2014 at 12:19 AM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Thu, Dec 18, 2014 at 5:27 PM, Fujii Masao masao.fu...@gmail.com wrote:
Thanks!
Thanks for your input.
+else
+memcpy(compression_scratch, page, page_len);
I don't think
compression patch which we're talking about in other thread. Right?
DecodeXLogRecord() seems also a backend-only, so we should treat it
in the same way as you proposed? Or pg_rewind uses that?
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Wed, Dec 24, 2014 at 10:41 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Wed, Dec 24, 2014 at 10:16 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Dec 24, 2014 at 9:42 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
Wouldn't it be better to declare it as a static
, with
+ * last free bit used to check if block is
+ * compressed */
At least to me, defining something like the following seems more easy to
read.
uint16hole_offset:15,
is_compressed:1
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers
On Thu, Dec 18, 2014 at 12:52 PM, Etsuro Fujita
fujita.ets...@lab.ntt.co.jp wrote:
Hi,
The attached patch just removes one bad-looking blank line in the
comments at the top of a function in explain.c.
Applied.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers
that it reads and replays the WAL data?
Current walreceiver. But if walwriter is responsible for fsyncing WAL data,
probably walwriter should do that. Because the startup process should not replay
the WAL data which has not been fsync'd yet.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing
?
What happens when WAL streaming is terminated and the startup process starts to
read the WAL file from the archive? After reading the WAL file from the archive,
probably we would need to change .ready files of every older WAL files to .done.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers
) seems less important in
this case because most processes need the buffer for WAL compression,
though.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
the regression output files, until I
realized why that was a bad idea. Add a comment about that.
Applied.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
no way to squelch in the server logfile, I think
checking for the table is the right answer.
Fair enough. I will come up with checking for table before vacuum
approach.
+1 for this approach.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
On Mon, Dec 15, 2014 at 12:25 PM, Andrew Gierth
and...@tao11.riddles.org.uk wrote:
Fujii == Fujii Masao masao.fu...@gmail.com writes:
Fujii Pushed.
Bug found:
regression=# select count(*) from generate_series(1::numeric,10) v,
generate_series(1,v) w;
count
---
0
(1 row
in that context.
/para
/warning
I'm OK with this.
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 28, 2014 at 9:07 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Wed, Nov 26, 2014 at 4:05 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 8:17 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 3:40 AM, Andres Freund
tests of this patch are FPW off + 0 bytes. Patches as well as
results are attached.
I think that neither pg_control nor xl_parameter_change need to have the info
about WAL compression because each backup block has that entry.
Will review the remaining part later.
Regards,
--
Fujii Masao
,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
.
This would let room for another mode: 'record', to completely compress
a record. For now though, I think that a simple on/off switch would be
fine for this patch. Let's keep things simple.
+1
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org
catcache
45 catcache 44 catcache 7 catcache 6 catcache 7 catcache 6 catcache 7
catcache 6 catcache 7 catcache 6 catcache 7 catcache 6 catcache 7
catcache 6 catcache 7 catcache 6 catcache 7 catcache 6 snapshot 2608
relcache 16384
Regards,
--
Fujii Masao
--
Sent via pgsql-hackers mailing list (pgsql
On Thu, Dec 4, 2014 at 12:58 PM, Simon Riggs si...@2ndquadrant.com wrote:
On 4 December 2014 at 03:08, Fujii Masao masao.fu...@gmail.com wrote:
#1. set up and start the master and standby servers with
track_commit_timestamp disabled
#2. enable track_commit_timestamp in the master and restart
On Fri, Nov 28, 2014 at 3:43 AM, Noah Misch n...@leadboat.com wrote:
On Fri, Nov 28, 2014 at 03:11:06AM +0900, Fujii Masao wrote:
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
Sure. I'll first issue git revert 9f80f48, then apply the attached
patch.
Since libpq
On Wed, Nov 26, 2014 at 4:05 PM, Michael Paquier
michael.paqu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 8:17 PM, Fujii Masao masao.fu...@gmail.com wrote:
On Fri, Aug 15, 2014 at 3:40 AM, Andres Freund and...@2ndquadrant.com
wrote:
On 2014-08-14 14:37:22 -0400, Robert Haas wrote:
On Thu
On Thu, Nov 27, 2014 at 9:32 PM, Mats Erik Andersson b...@gisladisker.se
wrote:
Hello there,
the text response of pg_isready is hard coded in English.
These short snippets really ought to be localized as well.
Thanks for the patch! Committed.
Regards,
--
Fujii Masao
--
Sent via pgsql
On Wed, Nov 19, 2014 at 3:24 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Will Leinweber w...@heroku.com writes:
On Tue, Nov 18, 2014 at 9:54 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Fujii Masao masao.fu...@gmail.com writes:
Is there any reason why \watch must ignore \pset null setting?
Hmmm
On Thu, Nov 27, 2014 at 11:58 PM, Peter Eisentraut pete...@gmx.net wrote:
Surely that's not a value that we expect users to be able to edit. Is
pg_config_manual.h just abused as a place that's included everywhere?
(I suggest utils/guc.h as a better place.)
+1
Regards,
--
Fujii Masao
On Thu, Nov 27, 2014 at 12:38 PM, Noah Misch n...@leadboat.com wrote:
On Tue, Nov 25, 2014 at 09:53:10PM +0900, Fujii Masao wrote:
On Tue, Nov 25, 2014 at 12:37 PM, Noah Misch n...@leadboat.com wrote:
On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote:
(3) PQhost() cannot return
On Wed, Nov 26, 2014 at 5:15 AM, Simon Riggs si...@2ndquadrant.com wrote:
On 25 November 2014 at 14:06, Fujii Masao masao.fu...@gmail.com wrote:
On Thu, Nov 20, 2014 at 5:35 AM, Simon Riggs si...@2ndquadrant.com wrote:
On 19 November 2014 16:41, Fujii Masao masao.fu...@gmail.com wrote:
On Wed
On Tue, Nov 25, 2014 at 12:37 PM, Noah Misch n...@leadboat.com wrote:
On Wed, Jan 22, 2014 at 11:48:26PM +0900, Fujii Masao wrote:
(3) PQhost() cannot return the hostaddr.
We can fix the problem (3) by changing PQhost() so that it also
returns the hostaddr. But this change might break
by, for example, comparing the result of
pg_last_committed_xact() in the master and that of
pg_last_xact_replay_timestamp()
in the standby. Because pg_last_xact_replay_timestamp() can return even
the timestamp of aborted transaction, but pg_last_committed_xact()
cannot. Right?
Regards,
--
Fujii
401 - 500 of 2751 matches
Mail list logo
