Re: [HACKERS] WIP: Covering + unique indexes.

2016-12-01 Thread Haribabu Kommi
On Sat, Nov 19, 2016 at 8:38 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 10/4/16 10:47 AM, Anastasia Lubennikova wrote: > > 03.10.2016 15:29, Anastasia Lubennikova: > >> 03.10.2016 05:22, Michael Paquier: > >>> On Tue, Sep 27, 2016 at 12:17 AM, Anastasia Lubennikova > >>>

Re: [HACKERS] Fast Default WIP patch for discussion

2016-12-01 Thread Haribabu Kommi
On Sat, Oct 29, 2016 at 2:28 AM, Serge Rielau wrote: > Time for me to dig into that then. > Closed in 2016-11 commitfest with "returned with feedback" status. Please feel free to update the status once you submit the updated patch. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] PassDownLimitBound for ForeignScan/CustomScan [take-2]

2016-12-01 Thread Haribabu Kommi
On Thu, Nov 10, 2016 at 10:59 AM, Kouhei Kaigai wrote: > > On Tue, Nov 8, 2016 at 6:54 AM, Jeevan Chalke > > wrote: > > > 1. ps_numTuples is declared as long, however offset and count members > in > > > LimitState struct and bound member in

Re: [HACKERS] Add support for restrictive RLS policies

2016-12-01 Thread Haribabu Kommi
On Fri, Dec 2, 2016 at 2:09 AM, Stephen Frost wrote: > Dean, > > * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > > On 1 December 2016 at 14:38, Stephen Frost wrote: > > > * Dean Rasheed (dean.a.rash...@gmail.com) wrote: > > >> In

Re: [HACKERS] postgres_fdw super user checks

2016-12-01 Thread Haribabu Kommi
On Tue, Oct 18, 2016 at 10:38 AM, Michael Paquier wrote: > On Mon, Oct 17, 2016 at 10:51 PM, Robert Haas > wrote: > > On Mon, Oct 17, 2016 at 2:18 AM, Michael Paquier > > wrote: > >> On Mon, Oct 17, 2016 at 3:33 AM,

Re: [HACKERS] Rename max_parallel_degree?

2016-12-01 Thread Haribabu Kommi
On Thu, Oct 27, 2016 at 3:38 AM, Robert Haas wrote: > On Mon, Oct 24, 2016 at 4:04 PM, Peter Eisentraut > wrote: > > On 10/12/16 7:58 PM, Robert Haas wrote: > >> I don't think it's wrong that the handling is done there, though. The > >>

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2016-12-01 Thread Haribabu Kommi
On Tue, Nov 15, 2016 at 5:58 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Sat, Nov 12, 2016 at 10:12 PM, Pavan Deolasee <pavan.deola...@gmail.com > > wrote: > >> >> >> On Tue, Nov 8, 2016 at 9:13 AM, Haribabu Kommi <kommi

Re: [HACKERS] pg_recvlogical --endpos

2016-12-01 Thread Haribabu Kommi
On Wed, Nov 30, 2016 at 4:26 PM, Okano, Naoki wrote: > > On Wednesday, November 30, 2016 10:34 AM Craig Ringer wrote: > >On 30 November 2016 at 09:18, Okano, Naoki > > > wrote: > >> > >> On November 29, 2016 at 5:03 PM Craig

Re: [HACKERS] Stopping logical replication protocol

2016-12-01 Thread Haribabu Kommi
On Fri, Nov 4, 2016 at 12:44 AM, Craig Ringer wrote: > On 21 October 2016 at 19:38, Vladimir Gordiychuk wrote: > > Craig, Andres what do you thinks about previous message? > > I haven't had a chance to look further to be honest. > > Since a downstream

Re: [HACKERS] btree_gin and btree_gist for enums

2016-12-01 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 11:31 AM, Andrew Dunstan wrote: > I won't have time to fix this before the end of the Commitfest The patch is marked as "returned with feedback" in 2016-11 commitfest. Please free to submit an updated patch to the next commitfest. Regards, Hari

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-29 Thread Haribabu Kommi
Hi All, The commitfest status summary after four weeks of progress: Needs review: 48 Waiting on author: 25 Ready for Commiter: 12 Commited: 36 Moved to next CF: 15 Rejected: 5 Returned with feedback: 6 TOTAL: 147 Overall progress of completion - 42% week-1 progress of completion - 9% week-2

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-29 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 9:46 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > > It could be because of some un-initialised variable, which is > initialized appropriately by default on your machine but not on my > machine. I first applied your pg_hba_rules... patch, ran regression. >

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-29 Thread Haribabu Kommi
On Sat, Nov 26, 2016 at 4:48 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > Currently the casting is supported from macaddr to macaddr8, but not the > > other way. This is because, not all 8 byte MAC addresses can b

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-24 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 12:53 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > On Wed, Nov 23, 2016 at 1:42 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > >> The precedent of int4/int8/float4/float8 is that SQL d

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-22 Thread Haribabu Kommi
On Wed, Nov 23, 2016 at 1:42 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > Any suggestions for the name to be used for the new datatype the can > > work for both 48 and 64 bit MAC addresses? > > The pre

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-22 Thread Haribabu Kommi
Hi All, The commitfest status summary after three weeks of progress: Needs review: 59 Waiting on author: 28 Ready for Commiter: 16 Commited: 35 Moved to next CF: 0 Rejected: 5 Returned with feedback: 4 TOTAL: 147 Overall progress of completion - 29% week-1 progress of completion - 9% week-2

Re: [HACKERS] sequence data type

2016-11-22 Thread Haribabu Kommi
Hi Vik and Vinayak, This is a gentle reminder. you both are assigned as reviewer's to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you

Re: [HACKERS] identity columns

2016-11-22 Thread Haribabu Kommi
Hi Vitaly, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet on the new patch in this commitfest. Please share your review about the patch. This will help us in smoother operation of commitfest. Please

Re: [HACKERS] raw output from copy

2016-11-22 Thread Haribabu Kommi
Hi, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your review.

Re: [HACKERS] Renaming of pg_xlog and pg_clog

2016-11-22 Thread Haribabu Kommi
Hi Craig, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your review.

Re: [HACKERS] patch proposal

2016-11-22 Thread Haribabu Kommi
Hi Abhijit, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your review about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your

Re: [HACKERS] GiST support for UUIDs

2016-11-22 Thread Haribabu Kommi
On Wed, Nov 2, 2016 at 3:49 AM, Adam Brusselback wrote: > So I apologize in advance if I didn't follow the processes exactly, I was > going to attempt to review this to move it along, but ran into issues > applying the patch cleanly to master. I fixed the issues I was

Re: [HACKERS] Proposal : For Auto-Prewarm.

2016-11-21 Thread Haribabu Kommi
Hi Ashutosh, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Please share your views about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already shared your

Re: [HACKERS] PATCH: Batch/pipelining support for libpq

2016-11-21 Thread Haribabu Kommi
On Fri, Nov 18, 2016 at 7:18 PM, Craig Ringer wrote: > The latest is what's attached upthread and what's in the git repo also > referenced upthread. > > I haven't been able to update in response to more recent review due to > other development commitments. At this point I

Re: [HACKERS] PoC: Partial sort

2016-11-21 Thread Haribabu Kommi
Hi Peter, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet in this commitfest on the latest patch posted by the author. If you don't have any comments on the patch, please move the patch into "ready for

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-11-21 Thread Haribabu Kommi
Hi Vinayak, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. If you have any more review comments / performance results regarding the approach of the patch, please share it. Otherwise, you can mark the patch as "Ready for committer" for

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-21 Thread Haribabu Kommi
On Tue, Nov 22, 2016 at 5:33 AM, Robert Haas wrote: > On Sat, Nov 19, 2016 at 2:54 PM, Tom Lane wrote: > > Stephen Frost writes: > >> Let's create a new data type for this which supports old and new types, > >> add what casts make

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-17 Thread Haribabu Kommi
On Thu, Nov 17, 2016 at 10:13 PM, Ashutosh Bapat < ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Nov 16, 2016 at 4:40 PM, Ashutosh Bapat > wrote: > > make check run with this patch shows server crashes. regression.out > > attached. I have run make check after

Re: [HACKERS] [PATCH] Better logging of COPY queries if log_statement='all'

2016-11-16 Thread Haribabu Kommi
Hi Dmitry, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. some people are against to the

Re: [HACKERS] Fun fact about autovacuum and orphan temp tables

2016-11-16 Thread Haribabu Kommi
Hi Dilip, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Michael had sent an updated patch

Re: [HACKERS] Improve OOM handling in pg_locale.c

2016-11-16 Thread Haribabu Kommi
Hi Mithun, This is a gentle reminder. you assigned as reviewer to the current patch in the 11-2016 commitfest. But you haven't shared your review yet. Can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Please Ignore if you already

Re: [HACKERS] pg_dump / copy bugs with "big lines" ?

2016-11-16 Thread Haribabu Kommi
Hi Tomas and Gerdan, This is a gentle reminder. you both are assigned as reviewers to the current patch in the 11-2016 commitfest. But you haven't shared any reviews yet, can you please try to share your views about the patch. This will help us in smoother operation of commitfest. Please Ignore

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-16 Thread Haribabu Kommi
Hi All, The commitfest status summary after one week of progress: Needs review: 76 Waiting on author: 16 Ready for Commiter: 16 Commited: 32 Moved to next CF: 0 Rejected: 4 Returned with feedback: 3 TOTAL: 147 Overall progress of completion - 26%. week-1 progress of completion - 9%. week-2

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2016-11-14 Thread Haribabu Kommi
On Sat, Nov 12, 2016 at 10:12 PM, Pavan Deolasee <pavan.deola...@gmail.com> wrote: > > > On Tue, Nov 8, 2016 at 9:13 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > >> >> Thanks for the patch. This shows a very good performance improvement.

Re: [HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-10 Thread Haribabu Kommi
On Fri, Nov 11, 2016 at 6:15 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: > > [ copy_to_view_3.patch ] > > Pushed with cosmetic adjustments. > Thank you. Regards, Hari Babu Fujitsu Australia

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-09 Thread Haribabu Kommi
On Fri, Nov 4, 2016 at 11:09 AM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Tue, Oct 25, 2016 at 11:40 PM, Peter Eisentraut < > peter.eisentr...@2ndquadrant.com> wrote: > >> On 10/25/16 1:38 AM, Haribabu Kommi wrote: >> > Here I attache

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-09 Thread Haribabu Kommi
On Mon, Nov 7, 2016 at 3:36 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Nov 7, 2016 at 12:36 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > The added regression test fails for the cases where the server is loaded > > with > >

Re: [HACKERS] commitfest 2016-11 status summary

2016-11-08 Thread Haribabu Kommi
Hi All, The commitfest status summary after one week of progress: Needs review: 78 Waiting on author: 16 Ready for Commiter: 19 Commited: 28 Moved to next CF: 0 Rejected: 3 Returned with feedback: 3 TOTAL: 147 Overall progress of completion - 23%. week-1 progress of completion - 9%. There

Re: [HACKERS] Patch: Write Amplification Reduction Method (WARM)

2016-11-07 Thread Haribabu Kommi
Thanks for the patch. This shows a very good performance improvement. I started reviewing the patch, during this process and I ran the regression test on the WARM patch. I observed a failure in create_index test. This may be a bug in code or expected that needs to be corrected. Regards, Hari

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-11-06 Thread Haribabu Kommi
On Fri, Nov 4, 2016 at 6:33 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 6/7/16 2:43 PM, Peter Eisentraut wrote: > > On 6/7/16 1:19 AM, Haribabu Kommi wrote: > >> How about the following case, Do we treat them as same or different? > >>

Re: [HACKERS] pg_hba_file_settings view patch

2016-11-06 Thread Haribabu Kommi
On Fri, Oct 28, 2016 at 4:55 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Fri, Oct 28, 2016 at 4:17 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > >> Greg Stark wrote: >> >> > The fundamental problem is that the pga_hba.c

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-06 Thread Haribabu Kommi
On Mon, Nov 7, 2016 at 8:40 AM, Shay Rojansky wrote: > > 1. Does everyone agrees that renaming the existing datatype without >> > changing the OID? >> > >> > >> > As I said before, Npgsql for one loads data types by name, not by OID. >> > So this would definitely cause

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-03 Thread Haribabu Kommi
On Thu, Nov 3, 2016 at 5:23 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Thu, Nov 3, 2016 at 9:57 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > Thanks for your suggestion. Yes, I agree that adding a hint is good. > > Updated patch is attached

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-11-03 Thread Haribabu Kommi
On Tue, Oct 25, 2016 at 11:40 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 10/25/16 1:38 AM, Haribabu Kommi wrote: > > Here I attached the first version of patch that supports both EUI-48 and > > EUI-64 type > > Mac addresses with a sin

Re: [HACKERS] Add radiustimeout parameter for RADIUS HBA

2016-11-03 Thread Haribabu Kommi
On Mon, Oct 24, 2016 at 2:03 PM, Samuel D. Leslie wrote: > Hello everyone, > > I’d like to submit the attached patch for feedback from the PostgreSQL > community and potential future inclusion in the codebase. The patch adds a > new parameter to the RADIUS authentication method

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-02 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 8:05 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Tue, Nov 1, 2016 at 12:40 PM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > COPY command is treated as an UTILITY command, During the query > > processing, the rules are n

[HACKERS] commitfest 2016-11 status summary

2016-11-01 Thread Haribabu Kommi
Hi All, The 2016-11 commitfest is officially started. Please add any further development patches into 2017-01 commitfest. The current status summary is: Needs review: 98 Waiting on author: 9 Ready for Commiter: 18 Commited: 19 Moved to next CF: 0 Rejected: 0 Returned with feedback: 3 TOTAL: 147

Re: [HACKERS] commit fest manager for CF 2016-11?

2016-11-01 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 11:19 PM, Michael Paquier wrote: > On Tue, Nov 1, 2016 at 4:53 PM, Michael Paquier > wrote: > > On Tue, Nov 1, 2016 at 12:20 PM, Thomas Munro > > wrote: > >> On Tue, Nov 1, 2016 at 4:15

[HACKERS] Re: [BUGS] BUG #14350: VIEW with INSTEAD OF INSERT TRIGGER and COPY. Missing feature or working as designed.

2016-11-01 Thread Haribabu Kommi
On Tue, Nov 1, 2016 at 3:54 PM, Dilip Kumar <dilipbal...@gmail.com> wrote: > On Tue, Oct 4, 2016 at 1:07 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > I think currently there is no handling of INSTEAD of triggers in the copy > > functionality. &g

[HACKERS] ECPG BUlk insert support using arrays

2016-10-31 Thread Haribabu Kommi
Hi All, I didn't find any relevant thread about the discussion of Bulk insert support in ECPG using arrays. Oracle supports the same and details are available in [1]. I see some performance benefits in supporting the same in ECPG also. Does any one worked on this area before? Are there any

Re: [HACKERS] commit fest manager for CF 2016-11?

2016-10-31 Thread Haribabu Kommi
On Mon, Oct 31, 2016 at 4:31 PM, Michael Paquier wrote: > On Mon, Oct 31, 2016 at 1:49 PM, Peter Eisentraut > wrote: > > Commit fest CF 2016-11 is supposed to start in about a day. I don't > > think a commit fest manager was chosen

Re: [HACKERS] pg_hba_file_settings view patch

2016-10-27 Thread Haribabu Kommi
On Fri, Oct 28, 2016 at 4:17 AM, Alvaro Herrera wrote: > Greg Stark wrote: > > > The fundamental problem is that the pga_hba.conf file has some bits of > > complex structure that aren't easily captured by linear arrays. The > > problem I struggled with most was the

Re: [HACKERS] pg_hba_file_settings view patch

2016-10-25 Thread Haribabu Kommi
On Mon, Oct 3, 2016 at 3:51 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Sep 5, 2016 at 4:09 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > On Sun, Sep 4, 2016 at 1:44 AM, Simon Riggs <si...@2ndquadrant.com> > wrote: > >>

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-10-24 Thread Haribabu Kommi
On Tue, Oct 18, 2016 at 1:51 AM, Shay Rojansky wrote: > The current macaddr datatype needs to be kept for some time by renaming >> it without changing OID and use the newer one for further usage. >> > > From the point of view of a driver maintainer... Npgsql looks up data > types

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-10-18 Thread Haribabu Kommi
On Wed, Oct 19, 2016 at 5:11 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Sep 29, 2016 at 1:45 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > > Currently, The SQL stats is a fixed size counter to track the all the > ALTER > > cases as

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-10-16 Thread Haribabu Kommi
On Thu, Oct 13, 2016 at 4:10 PM, Vitaly Burovoy wrote: > On 10/12/16, Tom Lane wrote: > >>> but we're > >>> not breaking on-disk compatibility of existing macaddr columns. > > Can I ask why? It will not be a varlen (typstorage will not be >

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-10-16 Thread Haribabu Kommi
On Fri, Oct 14, 2016 at 7:48 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > > On 2016/10/12 12:21, Haribabu Kommi wrote: > > I tried changing the pg_stat_sql into row mode and ran the regress suite > to > add different type of SQL commands to the view and ran

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-10-16 Thread Haribabu Kommi
On Wed, Oct 12, 2016 at 4:06 PM, vinayak wrote: > > > Thank you for the patch. > > Test: Commands with uppercase and lowercase > > If the tag='select' then it returns the 0 rows but count is actually > increment by 1. > > tag='select' vs tag='SELECT' > >

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-10-12 Thread Haribabu Kommi
On Thu, Oct 13, 2016 at 7:59 AM, Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> Vitaly Burovoy writes: > >>> P.S.: I still think it is a good idea to change storage format, > > >> I'm not sure which part

[HACKERS] Change of extension name to new name

2016-10-12 Thread Haribabu Kommi
Hi All, As we are planning to change an extension name from one name to another name because of additional features that are added into this extension, so the name is not matching, so we decided to change the name, but it is causing problem to the already existing installations with old extension

Re: [HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-10-12 Thread Haribabu Kommi
On Thu, Oct 13, 2016 at 7:31 AM, Vitaly Burovoy <vitaly.buro...@gmail.com> wrote: > Haribabu Kommi, why have you read enough about EUI-64? > Your function "macaddr64_trunc" sets 4 lower bytes as 0 whereas > (according to the Wikipedia, but I can look for a standard) 3

[HACKERS] macaddr 64 bit (EUI-64) datatype support

2016-10-12 Thread Haribabu Kommi
There was bug that is raised in [1] related to storing EUI-64 mac address in PostgreSQL MAC address datatype. As the current macaddr datatype stores only 48 bit MAC address only, and now a days people are adopting to EUI-64 format of MAC address. So it better to add the support in PostgreSQL.

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-10-11 Thread Haribabu Kommi
On Thu, Sep 29, 2016 at 3:45 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > > > On Thu, Sep 22, 2016 at 3:05 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > >> Peter Eisentraut wrote: >> >> > How about having the tag not be

Re: [HACKERS] Notice lock waits

2016-09-29 Thread Haribabu Kommi
On Fri, Sep 30, 2016 at 3:00 AM, Jeff Janes <jeff.ja...@gmail.com> wrote: > On Wed, Sep 28, 2016 at 11:57 PM, Haribabu Kommi <kommi.harib...@gmail.com > > wrote: >> >> >> Providing the details of lock wait to the client is good. I fell this >> mes

Re: [HACKERS] "Re: Question about grant create on database and pg_dump/pg_dumpall

2016-09-29 Thread Haribabu Kommi
On Mon, Sep 26, 2016 at 2:29 PM, Rafia Sabih <rafia.sa...@enterprisedb.com> wrote: > On Tue, Jul 5, 2016 at 06:39 AM, Haribabu Kommi > kommi(dot)haribabu(at)gmail(dot)com wrote: > > Still i feel the GRANT statements should be present, as the create > database statement > i

Re: [HACKERS] Notice lock waits

2016-09-29 Thread Haribabu Kommi
On Sat, Aug 6, 2016 at 3:00 AM, Jeff Janes wrote: > One time too many, I ran some minor change using psql on a production > server and was wondering why it was taking so much longer than it did > on the test server. Only to discover, after messing around with > opening new

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-09-28 Thread Haribabu Kommi
On Thu, Sep 22, 2016 at 3:05 AM, Alvaro Herrera wrote: > Peter Eisentraut wrote: > > > How about having the tag not be a column name but a row entry. So you'd > > do something like > > > > SELECT * FROM pg_stat_sql WHERE tag = 'ALTER VIEW'; > > > > That way, we don't

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-09-20 Thread Haribabu Kommi
On Thu, Sep 15, 2016 at 6:01 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Sep 2, 2016 at 2:33 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > On Wed, Aug 31, 2016 at 3:19 AM, Alvaro Herrera < > alvhe...@2ndquadrant.com> > > wrote: >

Re: [HACKERS] gettimeofday is at the end of its usefulness?

2016-09-13 Thread Haribabu Kommi
On Thu, Aug 25, 2016 at 3:12 PM, Haribabu Kommi <kommi.harib...@gmail.com> wrote: > On Thu, Jun 9, 2016 at 12:56 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > > Thom Brown <t...@linux.com> writes: > >> On 15 May 2014 at 19:56, Bruce Momjian <br...@momjian.us&g

Re: [HACKERS] An extra error for client disconnection on Windows

2016-09-08 Thread Haribabu Kommi
On Thu, Jun 2, 2016 at 6:51 PM, Kyotaro HORIGUCHI < horiguchi.kyot...@lab.ntt.co.jp> wrote: > Hello. > > After a process termination without PQfinish() of a client, > server emits the following log message not seen on Linux boxes. > > > LOG: could not receive data from client: An existing

Re: [HACKERS] Truncating/vacuuming relations on full tablespaces

2016-09-08 Thread Haribabu Kommi
On Mon, Jun 20, 2016 at 9:28 PM, Asif Naeem wrote: > Thank you for useful suggestions. PFA patch, I have tried to cover all the > points mentioned. > >> >> Patch needs rebase, it is failing to apply on latest master. And also there are some pending comment fix from Robert.

Re: [HACKERS] [sqlsmith] Failed assertion in joinrels.c

2016-09-06 Thread Haribabu Kommi
On Fri, Aug 26, 2016 at 7:11 PM, Dilip Kumar wrote: > I have changed this in attached patch.. > I reviewed and tested the patch. The changes are fine. This patch provides better error message compared to earlier. Marked the patch as "Ready for committer" in commit-fest.

Re: [HACKERS] System load consideration before spawning parallel workers

2016-09-05 Thread Haribabu Kommi
On Fri, Sep 2, 2016 at 3:01 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 8/16/16 3:39 AM, Haribabu Kommi wrote: > > Yes, we need to consider many parameters as a system load, not just only > > the CPU. Here I attached a POC patch that im

Re: [HACKERS] pg_hba_file_settings view patch

2016-09-05 Thread Haribabu Kommi
On Sun, Sep 4, 2016 at 1:44 AM, Simon Riggs <si...@2ndquadrant.com> wrote: > On 15 August 2016 at 12:17, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: > > > comments? > > This looks like a good feature contribution, thanks. > > At present the pat

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-09-02 Thread Haribabu Kommi
On Wed, Aug 31, 2016 at 3:19 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > >> Apart from the above, here are the following list of command tags that >> are generated in the code, I took only the first word of the command tag >> j

[HACKERS] ecpg -? option doesn't work in windows

2016-08-29 Thread Haribabu Kommi
ecpg option --help alternative -? doesn't work in windows. In windows, the PG provided getopt_long function is used for reading the provided options. The getopt_long function returns '?' for invalid characters also but it sets optopt option to 0 in case if the character itself is a '?'. But this

Re: [HACKERS] gettimeofday is at the end of its usefulness?

2016-08-24 Thread Haribabu Kommi
On Thu, Jun 9, 2016 at 12:56 AM, Tom Lane wrote: > Thom Brown writes: >> On 15 May 2014 at 19:56, Bruce Momjian wrote: >>> On Tue, May 13, 2014 at 06:58:11PM -0400, Tom Lane wrote: A recent question from Tim Kane prompted me to measure

Re: [HACKERS] pg_stat_lwlock wait time view

2016-08-24 Thread Haribabu Kommi
On Thu, Aug 25, 2016 at 6:57 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Aug 24, 2016 at 4:23 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> >> Based on the performance impact with the additional timing calculations, >> we can decide the

[HACKERS] pg_stat_lwlock wait time view

2016-08-24 Thread Haribabu Kommi
There was some discussion earlier in adding pg_stat_lwlock view in [1]. The main objections which I observed for that patch was showing LWLOCK information to the user that don't understand what this lock used for and etc. Currently as part of wait_event information in pg_stat_activity the LWLOCK

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-08-24 Thread Haribabu Kommi
On Tue, Aug 23, 2016 at 3:59 AM, Andres Freund wrote: >> Haribabu's categorization >> scheme seems to need some work, but the idea of categorizing >> statements by type and counting executions per type seems very >> reasonable. > > I'd consider instead using something like

Re: [HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-08-21 Thread Haribabu Kommi
On Sun, Aug 21, 2016 at 1:17 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Haribabu Kommi <kommi.harib...@gmail.com> writes: >> This is a new statistics view that is used to provide the number of >> SQL operations that are >> happened on a particular inte

Re: [HACKERS] Any need of GRANT/REVOKE CREATE TABLE | POLICY | ETC

2016-08-20 Thread Haribabu Kommi
On Tue, Aug 2, 2016 at 3:25 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Jul 19, 2016 at 2:59 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> During the discussion of supporting multi tenancy with the help of >> row level security, because of

[HACKERS] New SQL counter statistics view (pg_stat_sql)

2016-08-20 Thread Haribabu Kommi
This is a new statistics view that is used to provide the number of SQL operations that are happened on a particular interval of time. This view is useful for the system to find out the pattern of the operations that are happening in the instance during particular interval of time. Following is

Re: [HACKERS] System load consideration before spawning parallel workers

2016-08-16 Thread Haribabu Kommi
On Fri, Aug 5, 2016 at 9:46 AM, Jim Nasby <jim.na...@bluetreble.com> wrote: > On 8/1/16 1:08 AM, Haribabu Kommi wrote: >> >> There are some utilities and functions that are available to calculate the >> current system load, based on the available resources and system lo

[HACKERS] pg_hba_file_settings view patch

2016-08-15 Thread Haribabu Kommi
Hi All, While working on pg_hba_lookup function that can be used to lookup for an client authentication that can be matched for given input parameters, Tom raised some concrete use case issues in the following mail [1]. In this same thread, he raised some advantages of having a view similar like

Re: [HACKERS] System load consideration before spawning parallel workers

2016-08-01 Thread Haribabu Kommi
On Fri, Jul 29, 2016 at 8:48 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Jul 29, 2016 at 11:26 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: >> we observed that spawning the specified number of parallel workers for >> every query that satisfie

[HACKERS] System load consideration before spawning parallel workers

2016-07-28 Thread Haribabu Kommi
we observed that spawning the specified number of parallel workers for every query that satisfies for parallelism is sometimes leading to performance drop compared to improvement during the peak system load with other processes. Adding more processes to the system is leading to more context

[HACKERS] Any need of GRANT/REVOKE CREATE TABLE | POLICY | ETC

2016-07-19 Thread Haribabu Kommi
Hi All, During the discussion of supporting multi tenancy with the help of row level security, because of some problems of executing any policy that was created by an unprivileged user [1]. To avoid that problem, If we have some kind of new mechanism to GRANT/REVOKE only CREATE POLICY from all

Re: [HACKERS] Unable to test parallel aggregate/joins in Postgres beta 2

2016-07-14 Thread Haribabu Kommi
On Thu, Jul 14, 2016 at 11:16 PM, Madusudanan.B.N wrote: > > 3) Is there any kind of toggle to enable parallel aggregate/join feature ? > I am able to generate parallel plan, The parallel plan may be costly in your query compared to other scans, because of which it is

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-07-10 Thread Haribabu Kommi
On Sat, Apr 9, 2016 at 6:36 AM, Tom Lane wrote: > > More generally, I'm not convinced about the use-case for this patch. > What problem is it supposed to help in dealing with, exactly? Not syntax > errors in the hba file, evidently, since it doesn't make any attempt to >

Re: [HACKERS] What happens if tuple queue is full

2016-07-05 Thread Haribabu Kommi
On Wed, Jul 6, 2016 at 10:57 AM, Tatsuo Ishii wrote: > Hi, > > Does anybody know what will happen if tuple queue is full, which is > used by the parallel leader and workers? In my understanding memory > used for the queue is a dynamic shared memory and it could be full. The

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-07-03 Thread Haribabu Kommi
On Wed, Jun 29, 2016 at 6:31 AM, Markus Wanner wrote: >> I added another character array of 256 member into inet_struct as a last >> member >> to store the zone id. > > I haven't looked at the patch in detail, but zeroing or memcpy'ing those > 256 bytes seems like overkill to

Re: [HACKERS] WIP: Data at rest encryption

2016-06-13 Thread Haribabu Kommi
On Sun, Jun 12, 2016 at 5:13 PM, Ants Aasma <ants.aa...@gmail.com> wrote: > On Fri, Jun 10, 2016 at 5:23 AM, Haribabu Kommi > <kommi.harib...@gmail.com> wrote: > >> 2. Instead of depending on a contrib module for the encryption, how >> about integrating pgcryp

Re: [HACKERS] WIP: Data at rest encryption

2016-06-09 Thread Haribabu Kommi
On Tue, Jun 7, 2016 at 11:56 PM, Ants Aasma wrote: > Hi all, > > I have been working on data-at-rest encryption support for PostgreSQL. > In my experience this is a common request that customers make. The > short of the feature is that all PostgreSQL data files are encrypted

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-06-06 Thread Haribabu Kommi
On Sat, Jun 4, 2016 at 1:50 PM, Tom Lane wrote: > Robert Haas writes: >> Yeah, but what if somebody doesn't want to store scopes? > > [ shrug... ] We can invent a "strip_scope()" sort of function, > analogous to the weight-stripping function for

Re: [HACKERS] IPv6 link-local addresses and init data type

2016-05-30 Thread Haribabu Kommi
On Tue, May 31, 2016 at 9:35 AM, Tom Dunstan wrote: > >> On 31 May 2016, at 2:07 AM, Tom Lane wrote: >> >> The impression I have is that scopes are not very well standardized --- >> eg, OS X reports things like "fe80::1%lo0" not just "%0". If we could >> get

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-21 Thread Haribabu Kommi
On Tue, Mar 22, 2016 at 2:19 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Mon, Mar 21, 2016 at 6:16 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Mon, Mar 14, 2016 at 4:51 PM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: >&

[HACKERS] Re: [HACKERS] Re: [HACKERS] Re: [HACKERS] Windows service is not starting so there’s message in log: FATAL: "could not create shared memory segment “Global/PostgreSQL.851401618”: Permission

2016-03-21 Thread Haribabu Kommi
On Mon, Mar 14, 2016 at 4:51 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Fri, Mar 11, 2016 at 5:21 PM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Fri, Mar 11, 2016 at 12:00 AM, Amit Kapila <amit.kapil...@gmail.com> >> wrote: &g

Re: [HACKERS] pam auth - add rhost item

2016-03-21 Thread Haribabu Kommi
On Wed, Mar 16, 2016 at 10:46 PM, Grzegorz Sampolski wrote: > Hi. > Can be, but as you mentioned OS resolver can be configured to not use > dns at all. So much more appropriate will be pam_try_hostname if we want > to be more accurately. > But for me pamusedns, pam_use_hostname

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-03-21 Thread Haribabu Kommi
On Mon, Mar 21, 2016 at 2:00 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Haribabu Kommi wrote: > >> > Check. >> > >> > +} lookup_hba_line_context; >> > ^ but why TAB here? >> >> corrected. I am not sure why pg_indent is

<    1   2   3   4   5   6   >