Re: I: [HACKERS] About Our CLUSTER implementation is pessimal patch

2010-02-09 Thread Josh Kupershmidt
On Tue, Feb 9, 2010 at 5:49 AM, Leonardo F m_li...@yahoo.it wrote: Not even a comment? As I said, performance results on my system were very good Hi Leonardo, Perhaps you could supply a .sql file containing a testcase illustrating the performance benefits you tested with your patch -- as

[HACKERS] patch: Distinguish between unique indexes and unique constraints

2010-04-17 Thread Josh Kupershmidt
Addressing TODO item Distinguish between unique indexes and unique constraints in \d+ for psql, and picking up from thread: http://archives.postgresql.org/message-id/8780.1271187...@sss.pgh.pa.us Attached is a simple patch which clarifies unique constraints with UNIQUE CONSTRAINT in psql's \d+

Re: [HACKERS] patch: Distinguish between unique indexes and unique constraints

2010-04-18 Thread Josh Kupershmidt
On Sun, Apr 18, 2010 at 11:41 AM, Robert Haas robertmh...@gmail.com wrote: Josh - you may want to add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open Added, thanks! Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-14 Thread Josh Kupershmidt
On Sun, Dec 11, 2011 at 9:52 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Hi guys,  I have added the '-n' option to pg_archivecleanup which performs a dry-run and outputs the names of the files to be removed to stdout (making possible to pass the list via pipe to another

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-15 Thread Josh Kupershmidt
On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: My actual intention was to have the filename as output of the command, in order to easily pipe it to another script. Hence my first choice was to use the stdout channel, considering also that

Re: [HACKERS] disable prompting by default in createuser

2012-01-15 Thread Josh Kupershmidt
On Thu, Dec 22, 2011 at 2:26 PM, Peter Eisentraut pete...@gmx.net wrote: On lör, 2011-11-26 at 01:28 +0200, Peter Eisentraut wrote: I propose that we change createuser so that it does not prompt for anything by default.  We can arrange options so that you can get prompts for whatever is

Re: [HACKERS] Psql names completion.

2012-01-26 Thread Josh Kupershmidt
On Mon, Jan 23, 2012 at 5:28 PM, Dominik Bylica dominik2c...@gmail.com wrote: Hello. It's probably not the right place to write, but I guess you are there to take care of it. When I was creating a trigger with command like: create trigger asdf before update on beginninOfTheNameOfMyTable...

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-01-27 Thread Josh Kupershmidt
On Fri, Jan 27, 2012 at 9:47 AM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 15, 2012 at 5:05 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jan 15, 2012 at 3:02 PM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: My actual intention was to have the filename

Re: [HACKERS] Dry-run mode for pg_archivecleanup

2012-02-01 Thread Josh Kupershmidt
On Tue, Jan 31, 2012 at 10:29 AM, Gabriele Bartolini gabriele.bartol...@2ndquadrant.it wrote: Here is my final version which embeds comments from Josh. I have also added debug information to be printed in case '-d' is given. Looks fine; will mark Ready For Committer. Josh -- Sent via

Re: [HACKERS] disable prompting by default in createuser

2012-02-05 Thread Josh Kupershmidt
On Wed, Feb 1, 2012 at 1:13 PM, Peter Eisentraut pete...@gmx.net wrote: On sön, 2012-01-15 at 18:14 -0500, Josh Kupershmidt wrote: I see this patch includes a small change to dropuser, to make the 'username' argument mandatory if --interactive is not set, for symmetry with createuser's new

[HACKERS] misleading error message from connectMaintenanceDatabase()

2012-02-27 Thread Josh Kupershmidt
I noticed a misleading error message recently while using createdb. Try: test=# CREATE ROLE dummy NOLOGIN; Now, attempt to use createdb as that role. Here's 9.1.1: $ createdb -Udummy testdb createdb: could not connect to database postgres: FATAL: role dummy is not permitted to log in And here

Re: [HACKERS] vacuumlo issue

2012-03-20 Thread Josh Kupershmidt
On Tue, Mar 20, 2012 at 7:53 AM, Tom Lane t...@sss.pgh.pa.us wrote: I'm not entirely convinced that that was a good idea.  However, so far as vacuumlo is concerned, the only reason this is a problem is that vacuumlo goes out of its way to do all the large-object deletions in a single

Re: [HACKERS] Default mode for shutdown

2010-12-16 Thread Josh Kupershmidt
On Wed, Dec 15, 2010 at 10:11 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: It occurs to me that we may need a new mode, which disconnects sessions that are not in a transaction (or as soon as they are) but leaves in-progress transactions alone; this could be the new default.  Of

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Josh Kupershmidt
On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se wrote: Hi Josh, Here is my review of this patch for the commitfest. Review of https://commitfest.postgresql.org/action/patch_view?id=439 Thanks a lot for the review! Contents and Purpose This patch

Re: [HACKERS] psql: Add \dL to show languages

2011-01-16 Thread Josh Kupershmidt
On Sun, Jan 16, 2011 at 8:52 PM, Robert Haas robertmh...@gmail.com wrote: On Sun, Jan 16, 2011 at 7:04 AM, Magnus Hagander mag...@hagander.net wrote: I do not like the use of parentheses in the usage description list (procedural) languages. Why not have it simply as list procedural languages?

Re: [HACKERS] psql: Add \dL to show languages

2011-01-17 Thread Josh Kupershmidt
. If others feel the same way, I'd be happy to rip those columns out. Few more comments below: On Mon, Jan 17, 2011 at 3:51 PM, Andreas Karlsson andr...@proxel.se wrote: On Sun, 2011-01-16 at 22:32 -0500, Josh Kupershmidt wrote: On Sat, Jan 15, 2011 at 8:26 PM, Andreas Karlsson andr...@proxel.se

Re: [HACKERS] psql: Add \dL to show languages

2011-01-18 Thread Josh Kupershmidt
On Tue, Jan 18, 2011 at 1:35 PM, Andreas Karlsson andr...@proxel.se wrote: Hi Josh, Nope, I do not have any better ideas than DO Blocks?. Everything looks good with the exception one bug now. \dL foo * QUERY ** SELECT l.lanname AS Name,      

Re: [HACKERS] psql: Add \dL to show languages

2011-01-19 Thread Josh Kupershmidt
On Wed, Jan 19, 2011 at 9:09 PM, Robert Haas robertmh...@gmail.com wrote: This patch doesn't seem terribly consistent to me - we show the name of the call handler and the name of the validator, but for the inline handler we just indicate whether there is one or not.  That seems like something

Re: [HACKERS] Suggestion for --truncate-tables to pg_restore

2012-11-20 Thread Josh Kupershmidt
Hi Karl, I signed on to review this patch for the current CF. Most of the background for the patch seems to be in the message below, so I'm going to respond to this one first. On Fri, Sep 21, 2012 at 8:54 AM, Karl O. Pinc k...@meme.com wrote: On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote: I've

Re: [HACKERS] Suggestion for --truncate-tables to pg_restore

2012-11-23 Thread Josh Kupershmidt
On Wed, Nov 21, 2012 at 5:48 AM, Karl O. Pinc k...@meme.com wrote: On Fri, Sep 21, 2012 at 8:54 AM, Karl O. Pinc k...@meme.com wrote: On 09/20/2012 12:24:49 PM, Karl O. Pinc wrote: OT: After looking at the code I found a number of conflicting option combinations are not tested for or

Re: [HACKERS] Suggestion for --truncate-tables to pg_restore

2012-11-26 Thread Josh Kupershmidt
On Mon, Nov 26, 2012 at 3:42 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Nov 26, 2012 at 4:51 PM, Karl O. Pinc k...@meme.com wrote: P.S. An outstanding question regards --truncate-tables is whether it should drop indexes before truncate and re-create them after restore. Sounds like

Re: [HACKERS] Suggestion for --truncate-tables to pg_restore

2012-12-04 Thread Josh Kupershmidt
Sorry for the delay in following up here. On Mon, Nov 26, 2012 at 8:30 PM, Karl O. Pinc k...@meme.com wrote: On 11/26/2012 08:45:08 PM, Josh Kupershmidt wrote: On Mon, Nov 26, 2012 at 3:42 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Nov 26, 2012 at 4:51 PM, Karl O. Pinc k

[HACKERS] allowing multiple PQclear() calls

2012-12-10 Thread Josh Kupershmidt
The documentation for PQclear() doesn't say whether it is safe to call PQclear() more than once on the same PGresult pointer. In fact, it is not safe, but apparently only because of this last step: /* Free the PGresult structure itself */ free(res); The other members of PGresult which may

Re: [HACKERS] allowing multiple PQclear() calls

2012-12-11 Thread Josh Kupershmidt
On Tue, Dec 11, 2012 at 5:18 AM, Boszormenyi Zoltan z...@cybertec.at wrote: 2012-12-11 12:45 keltezéssel, Simon Riggs írta: On 11 December 2012 10:39, Marko Kreen mark...@gmail.com wrote: On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com wrote: Would it be crazy to add

Re: [HACKERS] Strange errors from 9.2.1 and 9.2.2 (I hope I'm missing something obvious)

2012-12-11 Thread Josh Kupershmidt
On Tue, Dec 11, 2012 at 6:01 PM, David Gould da...@sonic.net wrote: I'm sure I've had a stroke or something in the middle of the night and just didn't notice, but I'm able to reproduce the following on three different hosts on both 9.2.1 and 9.2.2. As far as I know the only difference between

Re: [HACKERS] Multiple --table options for other commands

2012-12-11 Thread Josh Kupershmidt
, arguments and we're free to change this. Any thoughts? Agreed with Robert that this change should be reasonable in a major version (i.e. 9.3). On 12/10/2012 09:23:03 PM, Karl O. Pinc wrote: On 10/30/2012 10:14:19 PM, Josh Kupershmidt wrote: I went ahead and cooked up a patch to allow pg_restore

Re: [HACKERS] Multiple --table options for other commands

2012-12-12 Thread Josh Kupershmidt
On Wed, Dec 12, 2012 at 8:14 AM, Karl O. Pinc k...@meme.com wrote: On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote: On Tue, Dec 11, 2012 at 11:46 AM, Karl O. Pinc k...@meme.com wrote: I believe you need ellipses behind --table in the syntax summaries of the command reference docs. Hrm, I

Re: [HACKERS] Multiple --table options for other commands

2012-12-13 Thread Josh Kupershmidt
On Thu, Dec 13, 2012 at 6:05 AM, Karl O. Pinc k...@meme.com wrote: On 12/13/2012 12:35:14 AM, Karl O. Pinc wrote: On 12/12/2012 11:04:53 PM, Josh Kupershmidt wrote: On Wed, Dec 12, 2012 at 8:14 AM, Karl O. Pinc k...@meme.com wrote: On 12/11/2012 10:25:43 PM, Josh Kupershmidt wrote

Re: [HACKERS] Multiple --table options for other commands

2012-12-13 Thread Josh Kupershmidt
On Thu, Dec 13, 2012 at 7:24 PM, Karl O. Pinc k...@meme.com wrote: The problem is that the pg man pages would then have a syntax different from all the other man pages in the system, which all have ... outside of square braces. See man cat, e.g. FWIW, `man cat` on my OS X machine has

Re: [HACKERS] Multiple --table options for other commands

2012-12-13 Thread Josh Kupershmidt
On Thu, Dec 13, 2012 at 9:03 PM, Karl O. Pinc k...@meme.com wrote: My brain seems to have turned itself on. I went and (re)read the docbook manual and was able to come up with this, which works: arg choice=plain rep=repeatarg choice=opt group choice=plain arg

Re: [HACKERS] Patch for checking file parameters to psql before password prompt

2012-12-18 Thread Josh Kupershmidt
On Sun, Dec 2, 2012 at 4:37 AM, Alastair Turner b...@ctrlf5.co.za wrote: Patch for the changes discussed in http://archives.postgresql.org/pgsql-hackers/2010-10/msg00919.php attached (eventually ...) In summary: If the input file (-f) doesn't exist or the ouput or log files (-o and -l) can't

[HACKERS] discarding duplicate indexes

2012-12-19 Thread Josh Kupershmidt
I recently came across a scenario like this (tested on git head): CREATE TABLE test (id int); CREATE INDEX test_idx1 ON test (id); CREATE INDEX test_idx2 ON test (id); CREATE TABLE test_copycat (LIKE test INCLUDING ALL); \d test_copycat Why do we end up with only one index on

Re: [HACKERS] discarding duplicate indexes

2012-12-20 Thread Josh Kupershmidt
On Thu, Dec 20, 2012 at 1:26 AM, Gavin Flower gavinflo...@archidevsys.co.nz wrote: On 20/12/12 14:57, Josh Kupershmidt wrote: CREATE TABLE test (id int); CREATE INDEX test_idx1 ON test (id); CREATE INDEX test_idx2 ON test (id); I initially misread your example code, but after I realised my

[HACKERS] bad examples in pg_dump README

2013-01-03 Thread Josh Kupershmidt
The ./src/bin/pg_dump README contains several inoperable examples. First, this suggestion: | or to list tables: | | pg_restore backup-file --table | less seems bogus, i.e. the --table option requires an argument specifing which table to restore, and does not list tables. Next, this

Re: [HACKERS] bad examples in pg_dump README

2013-01-05 Thread Josh Kupershmidt
On Sat, Jan 5, 2013 at 7:34 AM, Magnus Hagander mag...@hagander.net wrote: On Fri, Jan 4, 2013 at 3:36 AM, Josh Kupershmidt schmi...@gmail.com wrote: Do we need to keep it at all, really? Certainly the introductory part is covered in the main documentation already... Pretty much. (I did find

Re: [HACKERS] bad examples in pg_dump README

2013-01-08 Thread Josh Kupershmidt
On Mon, Jan 7, 2013 at 8:12 PM, Peter Eisentraut pete...@gmx.net wrote: On Sat, 2013-01-05 at 15:34 +0100, Magnus Hagander wrote: On Fri, Jan 4, 2013 at 3:36 AM, Josh Kupershmidt schmi...@gmail.com wrote: I propose slimming down the pg_dump README, keeping intact the introductory notes

Re: [HACKERS] string escaping in tutorial/syscat.source

2013-01-15 Thread Josh Kupershmidt
On Tue, Jan 15, 2013 at 6:35 PM, Jeff Janes jeff.ja...@gmail.com wrote: Do you propose back-patching this? You could argue that this is a bug in 9.1 and 9.2. Before that, they generate deprecation warnings, but do not give the wrong answer. I think that backpatching to 9.1 would be

[HACKERS] fixing pg_ctl with relative paths

2013-01-22 Thread Josh Kupershmidt
There have been some complaints[1][2] in the past about pg_ctl not playing nice with relative path specifications for the datadir. Here's a concise illustration: $ mkdir /tmp/mydata/ initdb /tmp/mydata/ $ cd /tmp/ $ pg_ctl -D ./mydata/ start $ cd / $ pg_ctl -D /tmp/mydata/ restart IMO

Re: [HACKERS] autocomplete - SELECT fx

2012-07-05 Thread Josh Kupershmidt
On Mon, Jul 2, 2012 at 1:13 AM, Pavel Stehule pavel.steh...@gmail.com wrote: I tested Peter's patch and it works well. I liked it as well. But I'm not sure what should happen with the patch now. It seems like it'd be commit-ready with just a tweak or two to the query as I noted in my last mail,

Re: [HACKERS] autocomplete - SELECT fx

2012-07-10 Thread Josh Kupershmidt
On Sat, Jul 7, 2012 at 5:43 PM, Noah Misch n...@leadboat.com wrote: I like the patch, as far as it goes. It's the natural addition to the completions we already offer; compare the simplistic completion after WHERE. Like Pavel and Robert, I think a delightful implementation of tab completion

Re: [HACKERS] [PATCH] psql \n shortcut for set search_path =

2012-07-10 Thread Josh Kupershmidt
On Tue, Jul 10, 2012 at 2:09 AM, Colin 't Hart co...@sharpheart.org wrote: Attached please find a trivial patch for psql which adds a \n meta command as a shortcut for typing set search_path =. I think the use-case is a bit narrow: saving a few characters typing on a command not everyone uses

Re: [HACKERS] pg_reorg in core?

2012-09-20 Thread Josh Kupershmidt
On Thu, Sep 20, 2012 at 7:05 PM, Michael Paquier michael.paqu...@gmail.com wrote: Hi all, During the last PGCon, I heard that some community members would be interested in having pg_reorg directly in core. I'm actually not crazy about this idea, at least not given the current state of

Re: [HACKERS] pg_reorg in core?

2012-09-20 Thread Josh Kupershmidt
On Thu, Sep 20, 2012 at 8:33 PM, Michael Paquier michael.paqu...@gmail.com wrote: On Fri, Sep 21, 2012 at 12:07 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Thu, Sep 20, 2012 at 7:05 PM, Michael Paquier michael.paqu...@gmail.com wrote: What could be also great is to move the project

[HACKERS] string escaping in tutorial/syscat.source

2012-10-14 Thread Josh Kupershmidt
Hi all, It seems the queries in ./src/tutorial/syscat.source use string escaping with the assumption that standard_conforming_strings is off, and thus give wrong results with modern versions. A simple fix is attached. Josh syscat.source_escaping.diff Description: Binary data -- Sent via

[HACKERS] Multiple --table options for other commands

2012-10-28 Thread Josh Kupershmidt
Hi all, I see there's already a TODO for allowing pg_restore to accept multiple --table arguments[1], but would folks support adding this capability to various other commands which currently accept only a single --table argument, such as clusterdb, vacuumdb, and reindexdb? Looking at pg_dump, it

Re: [HACKERS] Multiple --table options for other commands

2012-10-30 Thread Josh Kupershmidt
On Sun, Oct 28, 2012 at 4:30 PM, Josh Kupershmidt schmi...@gmail.com wrote: I see there's already a TODO for allowing pg_restore to accept multiple --table arguments[1], but would folks support adding this capability to various other commands which currently accept only a single --table

[HACKERS] psql: tab completions for 'WITH'

2012-04-03 Thread Josh Kupershmidt
Hi all, I noticed psql's tab-completion for 'WITH' is a bit overeager. If you try to tab-complete commands like: ALTER ROLE jsmith WITH [TAB] COPY tbl FROM 'filename' WITH [TAB] you'll get 'RECURSIVE' unhelpfully filled in. I think 'RECURSIVE' should only be suggested if 'WITH' is the first

Re: [HACKERS] psql: tab completions for 'WITH'

2012-04-10 Thread Josh Kupershmidt
On Tue, Apr 10, 2012 at 10:38 AM, Peter Eisentraut pete...@gmx.net wrote: On tis, 2012-04-03 at 22:34 -0700, Josh Kupershmidt wrote: I noticed psql's tab-completion for 'WITH' is a bit overeager. If you try to tab-complete commands like:   ALTER ROLE jsmith WITH [TAB]   COPY tbl FROM

Re: [HACKERS] Last gasp

2012-04-11 Thread Josh Kupershmidt
On Wed, Apr 11, 2012 at 8:59 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: On 11 April 2012 15:35, Magnus Hagander mag...@hagander.net wrote: For example, Thom (and others) could collect a number of typo fixes in their own repo and then just ask for a merge.The advantage over just staging

[HACKERS] psql: server version check for \dO

2012-05-09 Thread Josh Kupershmidt
Hi all, I think psql's \dO command is missing the server version check which similar commands such as \dx use. Right now \dO errors out with: test=# \dO ERROR: relation pg_catalog.pg_collation does not exist when talking to servers older than 9.1, which don't have pg_collation. Simple patch

Re: [HACKERS] Draft release notes complete

2012-05-10 Thread Josh Kupershmidt
On Wed, May 9, 2012 at 8:11 PM, Bruce Momjian br...@momjian.us wrote: I have completed my draft of the 9.2 release notes, and committed it to git.  I am waiting for our development docs to build, but after 40 minutes, I am still waiting: This bit: Previously supplied years and year masks of

[HACKERS] pg_restore logging inconsistency

2012-05-30 Thread Josh Kupershmidt
Hi all, Bosco Rama recently complained[1] about not seeing a message printed by pg_restore for each LO to be restored. The culprit seems to be the different level passed to ahlog() for this status message: pg_backup_archiver.c: ahlog(AH, 2, restoring large object with OID %u\n, oid);

Re: [HACKERS] [BUGS] Tab completion of function arguments not working in all cases

2012-06-17 Thread Josh Kupershmidt
[Hope it's OK if I move this thread to -hackers, as part of CF review.] On Sat, Jun 9, 2012 at 2:40 AM, Dean Rasheed dean.a.rash...@gmail.com wrote: Hi, I noticed this while testing 9.2, but it seems to go back to at least 8.3. Tab completion of function arguments doesn't work if the function

Re: [HACKERS] [BUGS] Tab completion of function arguments not working in all cases

2012-06-18 Thread Josh Kupershmidt
On Mon, Jun 18, 2012 at 3:56 AM, Dean Rasheed dean.a.rash...@gmail.com wrote: On 18 June 2012 04:21, Josh Kupershmidt schmi...@gmail.com wrote: As a side note unrelated to this patch, I also dislike how function name tab-completions will not fill in the opening parenthesis, which makes

Re: [HACKERS] patch: autocomplete for functions

2012-06-18 Thread Josh Kupershmidt
On Sun, Feb 19, 2012 at 12:10 PM, Pavel Stehule pavel.steh...@gmail.com wrote: Hello I found so this extremely simple patch should be useful. It helps for pattern SELECT fx(); There was thread about it. Hi Pavel, I signed up to be reviewer for this patch, and finally got around to taking a

Re: [HACKERS] patch: autocomplete for functions

2012-06-18 Thread Josh Kupershmidt
On Mon, Mar 19, 2012 at 1:01 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: I'm rather of the contrary opinion -- surely if we're going to complete function names, we should only complete those that are in schemas in the path; similarly for column names. I think it makes sense to only

Re: [HACKERS] return values of backend sub-main functions

2012-06-19 Thread Josh Kupershmidt
On Tue, Jun 19, 2012 at 4:31 AM, Peter Eisentraut pete...@gmx.net wrote: On ons, 2012-01-18 at 21:21 +0200, Peter Eisentraut wrote: On lör, 2012-01-07 at 16:41 -0500, Tom Lane wrote: Peter Eisentraut pete...@gmx.net writes: I suggest that we change PostgresMain(), PostmasterMain(),

[HACKERS] pg_signal_backend() asymmetry

2012-06-27 Thread Josh Kupershmidt
Hi all, I have one nitpick related to the recent changes for pg_cancel_backend() and pg_terminate_backend(). If you use these functions as an unprivileged user, and try to signal a nonexistent PID, you get: ERROR: must be superuser or have the same role to cancel queries running in other

Re: [HACKERS] pg_signal_backend() asymmetry

2012-06-28 Thread Josh Kupershmidt
On Thu, Jun 28, 2012 at 6:48 AM, Noah Misch n...@leadboat.com wrote: On Thu, Jun 28, 2012 at 01:36:49AM -0700, Daniel Farina wrote: On Wed, Jun 27, 2012 at 5:38 PM, Josh Kupershmidt schmi...@gmail.com wrote: I have one nitpick related to the recent changes for pg_cancel_backend

Re: [HACKERS] Posix Shared Mem patch

2012-07-03 Thread Josh Kupershmidt
On Tue, Jul 3, 2012 at 6:57 AM, Robert Haas robertmh...@gmail.com wrote: Here's a patch that attempts to begin the work of adjusting the documentation for this brave new world.  I am guessing that there may be other places in the documentation that also require updating, and this page probably

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-05-28 Thread Josh Kupershmidt
On Fri, Mar 11, 2011 at 8:54 AM, Bruce Momjian br...@momjian.us wrote: I have added it to the next commit fest. Hi Torello, I have volunteered (more accurately, Greg Smith volunteered me :-) to be a reviewer for this patch. I know you're a bit new here, so I thought I'd outline where this patch

[HACKERS] psql: missing tab completions for COMMENT ON

2011-05-28 Thread Josh Kupershmidt
Hi all, psql's auto-complete support for COMMENT ON was missing support for a few object types: 1.) EXTENSION and PROCEDURAL LANGUAGE are now auto-complete candidates for COMMENT ON [TAB]. Lists of extensions and procedural languages should also be filled in when a user types COMMENT ON

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-05-29 Thread Josh Kupershmidt
On Sun, May 29, 2011 at 5:04 AM, Noah Misch n...@leadboat.com wrote: What risks arise from unconditionally allowing these calls for the same user's backends?  `pg_cancel_backend' ought to be safe enough; the user always has access to the standard cancellation protocol, making the SQL interface

Re: [HACKERS] Any idea for serializing INSERTING SERIAL column?

2011-05-31 Thread Josh Kupershmidt
On Tue, May 31, 2011 at 8:08 PM, Tatsuo Ishii is...@postgresql.org wrote: [snip] In summary, 1) LOCK table foo cannot be used because of conflict with autovacuum 2) LOCK sequence just doesn't work 3) SELECT 1 FROM LOCK sequece fails after XID wraparound If you have other idea to serialize

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-06-01 Thread Josh Kupershmidt
On Wed, Jun 1, 2011 at 5:55 PM, Noah Misch n...@leadboat.com wrote: On Sun, May 29, 2011 at 10:56:02AM -0400, Josh Kupershmidt wrote: Looking around, I see there were real problems[1] with sending SIGTERM to individual backends back in 2005 or so, and pg_terminate_backend() was only deemed

Re: [HACKERS] Review: psql include file using relative path

2011-06-05 Thread Josh Kupershmidt
On Sun, Jun 5, 2011 at 10:21 AM, Gurjeet Singh singh.gurj...@gmail.com wrote: On Sat, May 21, 2011 at 11:59 AM, Josh Kupershmidt schmi...@gmail.com wrote: Tweaks applied, but omitted the C variable names as I don't think that adds much value. Your rewordings are fine, but the the article

Re: [HACKERS] Review: psql include file using relative path

2011-06-06 Thread Josh Kupershmidt
On Sun, Jun 5, 2011 at 8:16 PM, Gurjeet Singh singh.gurj...@gmail.com wrote: Attached an updated patch. If you find it ready for committer, please mark it so in the commitfest app. I can't find anything further to nitpick with this patch, and have marked it Ready For Committer in the CF.

Re: [HACKERS] smallserial / serial2

2011-06-09 Thread Josh Kupershmidt
On Wed, Jun 8, 2011 at 6:36 PM, Brar Piening b...@gmx.de wrote: I tried to look at everything and cover everthing but please consider that this is my first review so please have a second look at it! I took a look at this as well, and I didn't encounter any problems either. The patch is

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Josh Kupershmidt
On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure mmonc...@gmail.com wrote: I did a quick review and test of your patch.  It didn't quite apply cleanly due to recent non-related describe.c changes -- updated patch attached. Thanks for looking at this. Your updated patch looks good to me.

Re: [HACKERS] psql describe.c cleanup

2011-06-14 Thread Josh Kupershmidt
On Tue, Jun 14, 2011 at 3:25 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: pgindent moves strings back to the left when it thinks they fit within 80 columns.  Yes, that seems pretty screwy. I am losing track of the ways in which pgindent has managed to mangle our source code :-/ Josh

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-06-19 Thread Josh Kupershmidt
On Sun, Jun 19, 2011 at 3:25 AM, Kohei KaiGai kai...@kaigai.gr.jp wrote: 2011/6/18 Josh Kupershmidt schmi...@gmail.com: I think the v5 patch should be marked as 'Ready for Committer' I think we still need to handle my Still TODO concerns noted upthread. I don't have a lot of time this weekend

Re: [HACKERS] smallserial / serial2

2011-06-22 Thread Josh Kupershmidt
On Tue, Jun 21, 2011 at 10:58 PM, Robert Haas robertmh...@gmail.com wrote: Committed the main patch, and your regression tests. Hmph, looks like buildfarm members koi and jaguar are failing make check now: http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=koidt=2011-06-22%2008%3A06%3A00 due

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-07-02 Thread Josh Kupershmidt
On Wed, Jun 29, 2011 at 12:15 PM, Merlin Moncure mmonc...@gmail.com wrote: Patch applies clean, does what it is supposed to do, and matches other conventions in describe.c  Passing to committer.   pg_comments may be a better way to go, but that is a problem for another day... Thanks for the

[HACKERS] plpgsql extension install nitpick

2011-07-02 Thread Josh Kupershmidt
Hi all, I noticed that the plpgsql extension gets installed with an extension comment of 'PL/pgSQL procedural language', which comes from plpgsql.control. That seems fine and dandy, but take a look at the following query (modified from psql's \dL query): SELECT l.lanname AS Name,

Re: [HACKERS] plpgsql extension install nitpick

2011-07-02 Thread Josh Kupershmidt
On Sat, Jul 2, 2011 at 11:22 PM, Tom Lane t...@sss.pgh.pa.us wrote: Josh Kupershmidt schmi...@gmail.com writes: [ plpgsql's comment is now attached to the extension, not the PL itself ] So, basically, I would like to have that comment show up for the first query. I imagine this could be fixed

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-07-08 Thread Josh Kupershmidt
On Thu, Jul 7, 2011 at 10:00 PM, Robert Haas robertmh...@gmail.com wrote: [review of original, small patch to add another type to \dd's output] I am inclined to say that we should reject this patch as it stands. That's totally OK - that original patch was of marginal use given the larger

[HACKERS] patch: pg_comments system view

2011-07-15 Thread Josh Kupershmidt
On Fri, Jul 15, 2011 at 4:48 PM, Josh Berkus j...@agliodbs.com wrote: I am unable to figure out the status of the pg_comments patch from this thread.  What's going on with it? I don't blame you :-) I think this thread got so confusing because two separate topics were intertwined. (I'm going to

Re: [HACKERS] patch: pg_comments system view

2011-07-15 Thread Josh Kupershmidt
On Fri, Jul 15, 2011 at 7:01 PM, Josh Berkus j...@agliodbs.com wrote: On 7/15/11 3:54 PM, Josh Kupershmidt wrote: So that's where the pg_comments patch stands, at least AIUI. Clear as mud yet? :) Sounds like returned with feedback to me. Yeah, that's fine for this CF (though I do welcome any

[HACKERS] psql: bogus descriptions displayed by \d+

2011-07-16 Thread Josh Kupershmidt
Hi all, The psql output for \d+ on indexes, sequences, and views is rather bogus. Examples below from the SQL at bottom. So, if you look at \d+ newtbl, the right-most column named Description should display any comments attached to newtbl's columns. You should see bcol column comment as the

Re: [HACKERS] psql: bogus descriptions displayed by \d+

2011-07-17 Thread Josh Kupershmidt
On Sat, Jul 16, 2011 at 12:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: After a bit of review of the archives, the somebody was me: http://git.postgresql.org/gitweb/?p=postgresql.gita=commitdiffh=b7d67954456f15762c04e5269b64adc88dcd0860 and this thread was the discussion about it:

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-07-18 Thread Josh Kupershmidt
On Sun, Jul 17, 2011 at 11:25 PM, Robert Haas robertmh...@gmail.com wrote: On Sat, Jul 2, 2011 at 8:37 PM, Josh Kupershmidt schmi...@gmail.com wrote: On Sun, Jun 19, 2011 at 11:59 AM, Josh Kupershmidt schmi...@gmail.com wrote: It seems funny to have is_system = true unconditionally for any

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-07-20 Thread Josh Kupershmidt
[Resending with gzip'ed patch this time, I think the last attempt got eaten.] On Mon, Jul 18, 2011 at 11:15 PM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 18, 2011 at 10:57 PM, Josh Kupershmidt schmi...@gmail.com wrote: 1.) For now, I'm just ignoring the issue of visibility checks; I

Re: [HACKERS] psql: bogus descriptions displayed by \d+

2011-07-21 Thread Josh Kupershmidt
On Sun, Jul 17, 2011 at 10:54 AM, Josh Kupershmidt schmi...@gmail.com wrote: On Sat, Jul 16, 2011 at 12:49 PM, Tom Lane t...@sss.pgh.pa.us wrote: After a bit of review of the archives, the somebody was me: http://git.postgresql.org/gitweb/?p=postgresql.gita=commitdiffh

Re: [HACKERS] psql: bogus descriptions displayed by \d+

2011-07-25 Thread Josh Kupershmidt
On Fri, Jul 22, 2011 at 12:44 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jul 21, 2011 at 9:17 PM, Josh Kupershmidt schmi...@gmail.com wrote: Here's a small patch against branch 8.4 to mention support for COMMENT ON index_name.column_name. I am not in favor of this - because we'd

Re: [HACKERS] psql: bogus descriptions displayed by \d+

2011-07-26 Thread Josh Kupershmidt
On Tue, Jul 26, 2011 at 9:53 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 25, 2011 at 10:29 PM, Josh Kupershmidt schmi...@gmail.com wrote: I think this is basically the right approach but I found what you did here a bit wordy, so I simplified it, committed it, and back-patched

Re: [HACKERS] psql: bogus descriptions displayed by \d+

2011-07-27 Thread Josh Kupershmidt
On Wed, Jul 27, 2011 at 5:19 PM, Peter Eisentraut pete...@gmx.net wrote: On tis, 2011-07-26 at 09:53 -0400, Robert Haas wrote: On Mon, Jul 25, 2011 at 10:29 PM, Josh Kupershmidt schmi...@gmail.com wrote: That seems like a good way to document this; patch for master updated. I avoided

Re: [HACKERS] psql: display of object comments

2011-08-04 Thread Josh Kupershmidt
On Thu, Aug 4, 2011 at 12:26 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jul 26, 2011 at 8:38 PM, Josh Kupershmidt schmi...@gmail.com wrote: [new patch] I've committed the portion of this that displays comments on languages and casts. Thanks! For domains and conversions, I am

Re: [HACKERS] vacuumlo patch

2011-08-06 Thread Josh Kupershmidt
On Tue, Jul 26, 2011 at 12:18 PM, Timothy D. F. Lewis elatl...@gmail.com wrote: I'm not sure what David did for me so as per Roberts suggestion I have added this patch to the commit fest. I'm hoping I have not put this patch in more than one workflow. Hi Tim, I would be willing to review this

Re: [HACKERS] vacuumlo patch

2011-08-07 Thread Josh Kupershmidt
On Sun, Aug 7, 2011 at 12:41 AM, Tim elatl...@gmail.com wrote: Hi Josh, Thanks for help. Attached is a patch including changes suggested in your comments. Excerpts from Josh's message On Sat, Aug 6, 2011 at 9:57 PM:  1. It wasn't clear to me whether you're OK with Aron's suggested tweak,

Re: [HACKERS] vacuumlo patch

2011-08-07 Thread Josh Kupershmidt
On Sun, Aug 7, 2011 at 3:54 AM, Tim elatl...@gmail.com wrote: Excerpts from Josh's message On Sun, Aug 7, 2011 at 2:36 AM: could we figure out what that limit should be based on max_locks_per_transaction? It would be nice to implement via -l max instead of making users do it manually or

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Josh Kupershmidt
On Mon, Aug 8, 2011 at 4:34 PM, Robert Haas robertmh...@gmail.com wrote: OK, I've now committed most of this, with some additions to the documentation.  Remaining bits attached. Looks good, thanks. I am a bit confused as to why we have both \det and \dE.  They seem redundant.  Shouldn't we

Re: [HACKERS] psql: display of object comments

2011-08-08 Thread Josh Kupershmidt
On Mon, Aug 8, 2011 at 6:01 PM, Josh Kupershmidt schmi...@gmail.com wrote: (i.e. add Options column to \dE+ if we keep that one). Oh nevermind, Options is displayed by \d+ foreign_table_name. Josh -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] mb_regress.sh gripes

2011-08-18 Thread Josh Kupershmidt
Hi all, A few gripes about mb_regress.sh: 1. No exit code is specified, so even if there are differences between results/ and expected/ the script will still return 0. 2. The 'dropdb' command is used to wipe out the utf8 database before the run. This generates an error message like: dropdb:

[HACKERS] dropdb and dropuser: IF EXISTS

2011-08-25 Thread Josh Kupershmidt
I noticed a few places where it would be handy if dropdb took a flag like --if-exists which would basically just add in the 'IF EXISTS' clause to the DROP DATABASE statement. For example, scripts like find_static or mbregress.sh use dropdb createdb, but they generate noisy errors from dropdb when

Re: [HACKERS] dropdb and dropuser: IF EXISTS

2011-08-29 Thread Josh Kupershmidt
On Fri, Aug 26, 2011 at 10:42 PM, Robert Haas robertmh...@gmail.com wrote: +1 for --if-exists, but -X isn't doing a lot for me, especially since we've used -X for other purposes in other commands.  I'd just skip having a short form for this one. Fine by me. Updated patch attached. Josh diff

Re: [HACKERS] dropdb and dropuser: IF EXISTS

2011-08-30 Thread Josh Kupershmidt
On Tue, Aug 30, 2011 at 11:14 AM, Robert Haas robertmh...@gmail.com wrote: Committed with some edits.  I stole the documentation language from the DROP DATABASE and DROP USER pages and just copied it over, instead of saying the same thing in different words.  And I rearranged the options

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-02-19 Thread Josh Kupershmidt
On Wed, Jan 23, 2013 at 12:06 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2013/1/14 Tom Lane t...@sss.pgh.pa.us: Well, fine, but then it should fix both of them and remove minimal_error_message altogether. I would however suggest eyeballing what happens when you try \ef nosuchfunction

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-03-04 Thread Josh Kupershmidt
On Wed, Feb 27, 2013 at 12:09 PM, Stephen Frost sfr...@snowman.net wrote: * Pavel Stehule (pavel.steh...@gmail.com) wrote: I don't agree so it works well - you cannot use short type names is significant issue This is for psql. In what use-case do you see that being a serious limitation? I

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-03-04 Thread Josh Kupershmidt
On Mon, Mar 4, 2013 at 11:39 AM, Stephen Frost sfr...@snowman.net wrote: Josh, * Josh Kupershmidt (schmi...@gmail.com) wrote: I still think this patch is an improvement over the status quo, and is committable as-is. Yes, the patch doesn't address the existing ugliness

Re: [HACKERS] bugfix: --echo-hidden is not supported by \sf statements

2013-03-04 Thread Josh Kupershmidt
On Mon, Mar 4, 2013 at 11:54 AM, Stephen Frost sfr...@snowman.net wrote: Yeah, no, I don't think we should go in this direction. The whole TraceQuery thing is entirely redundant to what's already there and which should have been used from the beginning. This would be adding on to that

  1   2   >