On 2/6/07, Tom Lane [EMAIL PROTECTED] wrote:
Marko Kreen [EMAIL PROTECTED] writes:
Attached is a patch for uniqueindent-0.2 that removes the
buggy checks and makes functions STRICT IMMUTABLE.
Not sure where you should send that, but it's not here.
I did Cc: the maintainer.
--
marko
On 3/6/07, Neil Conway [EMAIL PROTECTED] wrote:
On Tue, 2007-03-06 at 00:18 -0500, Tom Lane wrote:
Perhaps they provide a compatibility hack that you didn't spot?
Quite possibly. Anyone have any suggestions?
Python guys discuss the situation here:
http://www.python.org/dev/peps/pep-0353/
On 3/7/07, Hannu Krosing [EMAIL PROTECTED] wrote:
Do any of you know about a way to READ PAGE ONLY IF IN CACHE in *nix
systems ?
Supposedly you could mmap() a file and then do mincore() on the
area to see which pages are cached.
But you were talking about postgres cache before, there it
On 3/27/07, Bruce Momjian [EMAIL PROTECTED] wrote:
I removed the advertising clause from all the BSD-copyrighted files from
Berkeley, namely all but */blf.*.
Their upstream is OpenBSD that still has same license.
NetBSD and FreeBSD have even worse versions with ssleay
license.
I think I need
On 4/4/09, Tom Lane t...@sss.pgh.pa.us wrote:
Peter Eisentraut pete...@gmx.net writes:
I have recently fixed the configure script to recognize Python 3.0. But
note that building and running PL/Python with Python 3.0 does not
actually work. It looks like several symbols have been
On 4/11/09, Tom Lane t...@sss.pgh.pa.us wrote:
It gets worse though: I have seldom seen such a badly designed piece of
syntax as the Unicode string syntax --- see
http://developer.postgresql.org/pgdocs/postgres/sql-syntax-lexical.html#SQL-SYNTAX-STRINGS-UESCAPE
You scan the string, and
On 4/14/09, Peter Eisentraut pete...@gmx.net wrote:
On Saturday 11 April 2009 00:54:25 Tom Lane wrote:
It gets worse though: I have seldom seen such a badly designed piece of
syntax as the Unicode string syntax --- see
On 4/14/09, Peter Eisentraut pete...@gmx.net wrote:
On Tuesday 14 April 2009 14:38:38 Marko Kreen wrote:
I think the problem is that they should not act like E'' strings, but they
should act like plain '' strings - they should follow stdstr setting.
That way existing tools that may
On 4/14/09, Tom Lane t...@sss.pgh.pa.us wrote:
Peter Eisentraut pete...@gmx.net writes:
On Tuesday 14 April 2009 18:54:33 Tom Lane wrote:
The other proposal that seemed
attractive to me was a decode-like function:
uescape('foo\00e9bar')
uescape('foo\00e9bar', '\')
This was
On 4/15/09, Greg Stark st...@enterprisedb.com wrote:
On Wed, Apr 15, 2009 at 6:23 PM, Tom Lane t...@sss.pgh.pa.us wrote:
Wouldn't we just then say that U'' strings are always standard-
conforming?
That's exactly what's causing the problem --- they are, but there
is lots of software
On 4/15/09, Tom Lane t...@sss.pgh.pa.us wrote:
Marko Kreen mark...@gmail.com writes:
Whats wrong with requiring U to conform with stdstr=off quoting rules?
The sole and only excuse for that misbegotten syntax is to be exactly
SQL spec compliant --- otherwise we might as well pick something
On 4/15/09, Tom Lane t...@sss.pgh.pa.us wrote:
Marko Kreen mark...@gmail.com writes:
As both this and the doubling-\\ way would mean we should have usable
alternative in case of stdstr=off also, so in the end we have agreed
to accept \u also?
Given Martijn's complaint about more-than-16
On 4/16/09, Sam Mason s...@samason.me.uk wrote:
On Wed, Apr 15, 2009 at 11:19:42PM +0300, Marko Kreen wrote:
On 4/15/09, Tom Lane t...@sss.pgh.pa.us wrote:
Given Martijn's complaint about more-than-16-bit code points, I think
the \u proposal is not mature enough to go into 8.4. We
On 4/16/09, Sam Mason s...@samason.me.uk wrote:
On Thu, Apr 16, 2009 at 02:47:20PM +0300, Marko Kreen wrote:
On 4/16/09, Sam Mason s...@samason.me.uk wrote:
Microsoft have also gone this way in C#, named code points are not
supported however.
And it handles also non-BMP codepoints
On 4/16/09, Tom Lane t...@sss.pgh.pa.us wrote:
Sam Mason s...@samason.me.uk writes:
I'd never heard of UTF-16 surrogate pairs before this discussion and
hence didn't realise that it's valid to have a surrogate pair in place
of a single code point. The docs say that D800 DF02 corresponds
Seems I'm bad at communicating in english, so here is C variant of
my proposal to bring \u escaping into extended strings. Reasons:
- More people are familiar with \u escaping, as it's standard
in Java/C#/Python, probably more..
- U strings will not work when stdstr=off.
Syntax:
\u
On 4/16/09, Sam Mason s...@samason.me.uk wrote:
On Thu, Apr 16, 2009 at 08:48:58PM +0300, Marko Kreen wrote:
Seems I'm bad at communicating in english,
I hope you're not saying this because of my misunderstandings!
so here is C variant of
my proposal to bring \u escaping
On 4/16/09, Marko Kreen mark...@gmail.com wrote:
It's up to UTF8 validator whether to consider non-characters as error.
I checked, and it did not work well, as addunicode() did not set
the saw_high_bit variable.when outputting UTF8. Attached patch fixes it.
Currently is would be NOP
On 4/17/09, Kevin Grittner kevin.gritt...@wicourts.gov wrote:
Andrew Dunstan and...@dunslane.net wrote:
ISTM that one of the uses of this is to say store the character
that corresponds to this Unicode code point in whatever the database
encoding is
I would think you're right. As long
On 4/18/09, Tom Lane t...@sss.pgh.pa.us wrote:
Kevin Grittner kevin.gritt...@wicourts.gov writes:
Andrew Dunstan and...@dunslane.net wrote:
ISTM that one of the uses of this is to say store the character
that corresponds to this Unicode code point in whatever the database
encoding is
On 4/18/09, Tom Lane t...@sss.pgh.pa.us wrote:
Sam Mason s...@samason.me.uk writes:
On Fri, Apr 17, 2009 at 07:01:47PM +0200, Martijn van Oosterhout wrote:
On Fri, Apr 17, 2009 at 07:07:31PM +0300, Marko Kreen wrote:
Btw, is there any good reason why we don't reject \000, \x00
in text
On 6/1/09, Markus Wanner mar...@bluegap.ch wrote:
a newish conversion with cvs2git is available to check here:
git://www.bluegap.ch/
(it's not incremental and will only stay for a few days)
+1 for the idea of replacing CVS usernames with full names.
The knowledge about CVS usernames
On 6/2/09, Marko Kreen mark...@gmail.com wrote:
On 6/1/09, Markus Wanner mar...@bluegap.ch wrote:
a newish conversion with cvs2git is available to check here:
git://www.bluegap.ch/
(it's not incremental and will only stay for a few days)
Btw this conversion seems broken
On 6/2/09, Markus Wanner mar...@bluegap.ch wrote:
Quoting Marko Kreen mark...@gmail.com:
I don't care half as much about the keyword expansion stuff - that's
doomed to disappear anyway.
But this is one aspect we need to get right for the conversion.
What's your definition
On 6/2/09, Markus Wanner mar...@bluegap.ch wrote:
Quoting Marko Kreen mark...@gmail.com:
Btw this conversion seems broken as it contains random merge commits.
Well, that's a feature, not a bug ;-)
When a commit adds a file to the master *and* then to the branch as well,
cvs2git
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
Jeremy Kerr j...@ozlabs.org writes:
The following patch changes psecure_write to be more like psecure_read -
it only alters the signal mask if the connection is over SSL. It's only
an RFC, as I'm not entirely sure about the reasoning behind
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
Jeremy Kerr j...@ozlabs.org writes:
The consideration is that the application fails completely on server
disconnect (because it gets SIGPIPE'd). This was long ago deemed
unacceptable, and we aren't likely to change our opinion on that.
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
Marko Kreen mark...@gmail.com writes:
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
We've had problems before with userland headers not being in sync
with what the kernel knows.
Well, we could just test in configure perhaps?
The single
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
Aidan Van Dyk ai...@highrise.ca writes:
* Markus Wanner mar...@bluegap.ch [090602 10:23]:
You consider it a mess, I consider it a better and more valid
representation of the mess that CVS is.
So much better that it makes the history as
On 6/2/09, Markus Wanner mar...@bluegap.ch wrote:
[academic nitpicking]
Sorry, not going there. Just look at the state of VCS systems
that have prioritized academic issues insead of practicality...
(arch/darcs/monotone/etc..)
So please turn the merge logic off. If this cannot be turned off,
On 6/2/09, Markus Wanner mar...@bluegap.ch wrote:
Quoting Marko Kreen mark...@gmail.com:
And what silly side effects are you talking about?
I'm talking about spurious file duplicates popping up after a rename and a
merge, see my example in this thread.
The example was not actual case
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
[ it's way past time for a new subject thread ]
Marko Kreen mark...@gmail.com writes:
They cannot be same commits in GIT as the resulting tree is different.
This brings up something that I've been wondering about: my limited
exposure to git
On 6/2/09, Tom Lane t...@sss.pgh.pa.us wrote:
Alvaro Herrera alvhe...@commandprompt.com writes:
Hmm, but is there a way to create those clones from a single local
database?
(I like the monotone model much better. This mixing of working copies
and databases as if they were a single
On 6/2/09, Alvaro Herrera alvhe...@commandprompt.com wrote:
Mark Mielke wrote:
I am curious about why an end user would really care? CVS and SVN both
kept local workspace directories containing metadata. If anything, I
find GIT the least intrusive of these three, as the .git is only in
On 6/3/09, Greg Stark st...@enterprisedb.com wrote:
On Wed, Jun 3, 2009 at 1:19 PM, Andres Freund and...@anarazel.de wrote:
git log --no-merges hides the actual merge commits if that is what you
want.
Ooh! Life seems so much sweeter now!
Given that we don't have to see them then I'm
On 6/3/09, Magnus Hagander mag...@hagander.net wrote:
Robert Haas wrote:
On Wed, Jun 3, 2009 at 10:13 AM, Magnus Hagander mag...@hagander.net
wrote:
I'm not sure whether we should mark the old branches getting merges
down or the new branches getting merged up. I suspect I'm missing
On 6/3/09, Aidan Van Dyk ai...@highrise.ca wrote:
* Marko Kreen mark...@gmail.com [090603 10:26]:
Thats true, but it's not representable in VCS, unless you use cherry-pick,
which is just UI around patch transport. But considering separate
local trees (with can optionally contain local
On 6/3/09, Aidan Van Dyk ai...@highrise.ca wrote:
* Marko Kreen mark...@gmail.com [090603 11:12]:
Well, thats good to know, but this also seems to mean it's rather bad
tool for back-patching, as you risk including random unwanted commits
too that happened in the HEAD meantime. But also
On 6/10/09, Jeremy Kerr j...@ozlabs.org wrote:
+ int optval;
+ if (!setsockopt(conn-sock,
SOL_SOCKET, SO_NOSIGPIPE,
+ (char *)optval,
sizeof(optval)))
On 6/18/09, Simon Riggs si...@2ndquadrant.com wrote:
On Tue, 2009-06-16 at 10:23 -0400, Tom Lane wrote:
Speaking of which, what about some performance numbers? Like Heikki,
I'm quite suspicious of whether there is any real-world gain to be had
from this approach.
It has been lore
On 6/19/09, Andrew Dunstan and...@dunslane.net wrote:
Kevin Grittner wrote:
8.3.7
real0m24.249s
real0m24.054s
real0m24.361s
8.4rc1
real0m33.503s
real0m34.198s
real0m33.931s
Ugh. This looks like a poster child case for a benchfarm ...
Is there any
On Thu, Dec 29, 2011 at 03:12:50PM -0300, Alvaro Herrera wrote:
Excerpts from Marko Kreen's message of jue dic 29 15:04:49 -0300 2011:
3) Have a way to format aclitem into something
that can used to create GRANT statement easily. Eg:
pg_get_privilege_info(
IN priv
Hello,
I tried to generalize a function that creates partitions
for a table and found out it's impossible to do it for grants.
Basically, what I want is a child table that takes it's grants
from parent table. IMHO quite reasonable request. But I don't
see a way to do it in pl/pgsql. (Writing
On Thu, Dec 29, 2011 at 11:11:22PM -0300, Alvaro Herrera wrote:
Excerpts from Marko Kreen's message of jue dic 29 15:22:49 -0300 2011:
On Thu, Dec 29, 2011 at 03:12:50PM -0300, Alvaro Herrera wrote:
Excerpts from Marko Kreen's message of jue dic 29 15:04:49 -0300 2011:
3) Have a way
On Mon, Jan 02, 2012 at 12:31:13PM +0100, Dimitri Fontaine wrote:
Marko Kreen mark...@gmail.com writes:
I tried to generalize a function that creates partitions
for a table and found out it's impossible to do it for grants.
Basically, what I want is a child table that takes it's grants
On Tue, Jan 17, 2012 at 05:53:33PM +0900, Kyotaro HORIGUCHI wrote:
Hello, This is revised and rebased version of the patch.
a. Old term `Add Tuple Function' is changed to 'Store
Handler'. The reason why not `storage' is simply length of the
symbols.
b. I couldn't find the place to
On Sat, Jan 21, 2012 at 1:52 PM, Marc Mamin m.ma...@intershop.de wrote:
c. Refine error handling of dblink.c. I think it preserves the
previous behavior for column number mismatch and type
conversion exception.
Hello,
I don't know if this cover following issue.
I just mention it
On Sun, Jan 22, 2012 at 11:47 PM, Mikko Tiihonen
mikko.tiiho...@nitorcreations.com wrote:
* introduced a new GUC variable array_output copying the current
bytea_output type, with values full (old value) and
smallfixed (new default)
* added documentation for the new GUC variable
If this
On Mon, Jan 23, 2012 at 5:34 PM, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 23, 2012 at 9:36 AM, Florian Weimer fwei...@bfk.de wrote:
* Robert Haas:
In this particular case, I knew that the change was coming and could
push updated Java and Perl client libraries well before the
On Mon, Jan 23, 2012 at 11:20:52AM -0500, Tom Lane wrote:
Robert Haas robertmh...@gmail.com writes:
On Mon, Jan 23, 2012 at 9:59 AM, Marko Kreen mark...@gmail.com wrote:
Now that I think about it, same applies to bytea_output?
Probably so. But I think we need not introduce quite so many
On Mon, Jan 23, 2012 at 11:06 PM, Robert Haas robertmh...@gmail.com wrote:
On Mon, Jan 23, 2012 at 11:15 AM, Noah Misch n...@leadboat.com wrote:
As I said upthread, and you appeared to agree, the protocol is independent of
individual data type send/recv formats. Even if we were already adding
On Tue, Jan 24, 2012 at 09:33:52PM -0500, Robert Haas wrote:
Furthermore, while we haven't settled the question of exactly what a
good negotiation facility would look like, we seem to agree that a GUC
isn't it. I think that means this isn't going to happen for 9.2, so
we should mark this
On Wed, Jan 25, 2012 at 10:23:14AM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
On Tue, Jan 24, 2012 at 09:33:52PM -0500, Robert Haas wrote:
Furthermore, while we haven't settled the question of exactly what a
good negotiation facility would look like, we seem to agree
On Wed, Jan 25, 2012 at 11:40:28AM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
On Wed, Jan 25, 2012 at 10:23:14AM -0500, Tom Lane wrote:
Huh? How can that work? If we decide to change the representation of
some other well known type, say numeric, how do we decide whether
On Wed, Jan 25, 2012 at 12:58:15PM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
On Wed, Jan 25, 2012 at 11:40:28AM -0500, Tom Lane wrote:
Then why bother with the bit in the format code? If you've already done
some other negotiation to establish what datatype formats you
On Wed, Jan 25, 2012 at 12:54:00PM -0600, Merlin Moncure wrote:
On Wed, Jan 25, 2012 at 11:24 AM, Marko Kreen mark...@gmail.com wrote:
I specifically want to avoid any sort of per-connection
negotation, except the max format version supported,
because it will mess up multiplexed usage
On Wed, Jan 25, 2012 at 01:43:03PM -0600, Merlin Moncure wrote:
On Wed, Jan 25, 2012 at 1:24 PM, Marko Kreen mark...@gmail.com wrote:
On Wed, Jan 25, 2012 at 12:54:00PM -0600, Merlin Moncure wrote:
On Wed, Jan 25, 2012 at 11:24 AM, Marko Kreen mark...@gmail.com wrote:
I specifically want
On Wed, Jan 25, 2012 at 02:50:09PM -0600, Merlin Moncure wrote:
On Wed, Jan 25, 2012 at 2:29 PM, Marko Kreen mark...@gmail.com wrote:
well, I see the following cases:
1) Vserver Vapplication: server downgrades wire formats to
applications version
2) Vapplication Vlibpq Vserver: since
On Fri, Jan 27, 2012 at 05:57:01PM +0900, Kyotaro HORIGUCHI wrote:
Hello, This is a new version of the patch formerly known as
'alternative storage for libpq'.
- Changed the concept to 'Alternative Row Processor' from
'Storage handler'. Symbol names are also changed.
- Callback function
On Fri, Jan 27, 2012 at 09:35:04AM -0600, Merlin Moncure wrote:
On Fri, Jan 27, 2012 at 2:57 AM, Kyotaro HORIGUCHI
- The meaning of PGresAttValue is changed. The field 'value' now
contains a value withOUT terminating zero. This change seems to
have no effect on any other portion within
On Mon, Jan 30, 2012 at 06:06:57PM +0900, Kyotaro HORIGUCHI wrote:
The gain of performance is more than expected. Measure script now
does query via dblink ten times for stability of measuring, so
the figures become about ten times longer than the previous ones.
sec
On Tue, Jan 31, 2012 at 4:59 AM, Kyotaro HORIGUCHI
horiguchi.kyot...@oss.ntt.co.jp wrote:
This is fixed version of dblink.c for row processor.
i'll re-send the properly fixed patch for dblink.c later.
- malloc error in initStoreInfo throws ERRCODE_OUT_OF_MEMORY. (new error)
- storeHandler()
On Wed, Feb 1, 2012 at 10:32 AM, Kyotaro HORIGUCHI
horiguchi.kyot...@oss.ntt.co.jp wrote:
Another thing: if realloc() fails, the old pointer stays valid.
So it needs to be assigned to temp variable first, before
overwriting old pointer.
mmm. I've misunderstood of the realloc.. I'll fix there
freePGconn() does not free sslcompression. Fix.
Found with valgrind.
--
marko
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 5add143..4605e49 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -2803,6 +2803,8 @@
On Tue, Jan 31, 2012 at 8:56 PM, Robert Haas robertmh...@gmail.com wrote:
2012/1/29 Kohei KaiGai kai...@kaigai.gr.jp:
Remote SQL: DECLARE pgsql_fdw_cursor_0 SCROLL CURSOR FOR SELECT
a, b FROM public.t1 WHERE (a 2)
(3 rows)
Shouldn't we be using protocol-level cursors rather than
On Thu, Feb 02, 2012 at 04:51:37PM +0900, Kyotaro HORIGUCHI wrote:
Hello, This is new version of dblink.c
- Memory is properly freed when realloc returns NULL in storeHandler().
- The bug that free() in finishStoreInfo() will be fed with
garbage pointer when malloc for sinfo-valbuflen
On Fri, Feb 03, 2012 at 01:15:30PM +0100, Christian Ullrich wrote:
* Peter Eisentraut wrote:
I noticed ecpglib still uses PQconnectdb() with a craftily assembled
connection string. Here is a patch to use PQconnectdbParams() instead.
+ const char *conn_keywords[6];
+ const char
On Tue, Feb 07, 2012 at 07:25:14PM +0900, Shigeru Hanada wrote:
(2012/02/02 23:30), Marko Kreen wrote:
On Thu, Feb 02, 2012 at 04:51:37PM +0900, Kyotaro HORIGUCHI wrote:
Hello, This is new version of dblink.c
- Memory is properly freed when realloc returns NULL in storeHandler
On Wed, Feb 08, 2012 at 02:44:13PM +0900, Shigeru Hanada wrote:
(2012/02/07 23:44), Marko Kreen wrote:
On Tue, Feb 07, 2012 at 07:25:14PM +0900, Shigeru Hanada wrote:
- What is the right (or recommended) way to prevent from throwing
exceptoin in row-processor callback function? When author
On Tue, Feb 07, 2012 at 04:44:09PM +0200, Marko Kreen wrote:
Although it seems we could allow exceptions, at least when we are
speaking of Postgres backend, as the connection and result are
internally consistent state when the handler is called, and the
partial PGresult is stored under PGconn
On Tue, Feb 14, 2012 at 05:59:06PM -0500, Tom Lane wrote:
Bruce Momjian br...@momjian.us writes:
On Mon, Feb 13, 2012 at 08:28:03PM -0500, Tom Lane wrote:
+1, I was about to suggest the same thing. Running any of these tests
for a fixed number of iterations will result in drastic
On Thu, Feb 16, 2012 at 02:24:19PM +0900, Kyotaro HORIGUCHI wrote:
As far as I see, on an out-of-memory in getAnotherTuple() makes
conn-result-resultStatus = PGRES_FATAL_ERROR and
qpParseInputp[23]() skips succeeding 'D' messages consequently.
When exception raised within row processor,
On Thu, Feb 16, 2012 at 05:49:34PM +0900, Kyotaro HORIGUCHI wrote:
I added the function PQskipRemainingResult() and use it in
dblink. This reduces the number of executing try-catch block from
the number of rows to one per query in dblink.
This implementation is wrong - you must not simply
On Fri, Feb 17, 2012 at 10:54 AM, Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Robert Haas robertmh...@gmail.com writes:
Wait, we already have ALTER TRIGGER bob ON ANY COMMAND SET DISABLED;
Eh, so what happens then if someone sets a command trigger on ALTER TRIGGER?
We should remove
On Fri, Feb 17, 2012 at 4:04 PM, Dimitri Fontaine
dimi...@2ndquadrant.fr wrote:
Marko Kreen mark...@gmail.com writes:
Btw, we already have a GUC for triggers: session_replication_role,
how will the command triggers follow that?
Note that the replica here in my mind would have been an Hot
Demos/tests of the new API:
https://github.com/markokr/libpq-rowproc-demos
Comments resulting from that:
- PQsetRowProcessorErrMsg() should take const char*
- callback API should be (void *, PGresult *, PQrowValue*)
or void* at the end, but not in the middle
I have not looked yet what
On Sun, Feb 19, 2012 at 1:55 AM, Tom Lane t...@sss.pgh.pa.us wrote:
Dimitri Fontaine dimi...@2ndquadrant.fr writes:
Tom Lane t...@sss.pgh.pa.us writes:
Yeah ... if you *don't* know the difference between a DFA and an NFA,
you're likely to find yourself in over your head. Having said that,
On Tue, Feb 21, 2012 at 02:11:35PM +0900, Kyotaro HORIGUCHI wrote:
I don't have any attachment to PQskipRemainingResults(), but I
think that some formal method to skip until Command-Complete('C')
without breaking session is necessary because current libpq does
so.
We have such function:
On Tue, Feb 21, 2012 at 11:42 AM, Kyotaro HORIGUCHI
horiguchi.kyot...@oss.ntt.co.jp wrote:
Also, as row handler is on connection, then changing it's
behavior is connection context, not result.
OK, current implement copying the pointer to the row processor
from PGconn to PGresult and
On Tue, Feb 21, 2012 at 12:13 PM, Kyotaro HORIGUCHI
horiguchi.kyot...@oss.ntt.co.jp wrote:
- PQskipResult(conn, true) makes all consequent PQgetResult()'s
to skip all the rows.
Well, Is this right?
Yes, call getResult() until it returns NULL.
If this is right, row processor should stay
On Wed, Feb 22, 2012 at 12:27:57AM +0900, Kyotaro HORIGUCHI wrote:
fe-exec.c
- PQskipResult() is added instead of PGskipRemainigResults().
It must free the PGresults that PQgetResult() returns.
Also, please fix 2 issues mentined here:
On Thu, Feb 23, 2012 at 07:14:03PM +0900, Kyotaro HORIGUCHI wrote:
Hello, this is new version of the patch.
Looks good.
By the way, I would like to ask you one question. What is the
reason why void* should be head or tail of the parameter list?
Aesthetical reasons:
1) PGresult and
On Fri, Feb 24, 2012 at 07:53:14PM +0900, Kyotaro HORIGUCHI wrote:
Hello, this is new version of the patch.
By the way, I would like to ask you one question. What is the
reason why void* should be head or tail of the parameter list?
Aesthetical reasons:
I got it. Thank you.
On Fri, Feb 24, 2012 at 02:11:45PM +0200, Marko Kreen wrote:
On Fri, Feb 24, 2012 at 07:53:14PM +0900, Kyotaro HORIGUCHI wrote:
- I have no idea how to do test for protocol 2...
I have a urge to test with rm fe-protocol2.c...
Now I tested with 7.3.21 and the non-error case works fine
On Fri, Feb 24, 2012 at 4:26 PM, Merlin Moncure mmonc...@gmail.com wrote:
On Fri, Feb 24, 2012 at 7:52 AM, Marko Kreen mark...@gmail.com wrote:
So could we like, uh, not do it and simply drop the V2 code?
I think it's plausible that very old client libraries could connect to
a modern server
On Tue, Feb 14, 2012 at 01:39:06AM +0200, Marko Kreen wrote:
I tried imaging some sort of getFoo() style API for fetching in-flight
row data, but I always ended up with rewrite libpq step, so I feel
it's not productive to go there.
Instead I added simple feature: rowProcessor can return '2
On Fri, Feb 24, 2012 at 11:46:19AM -0500, Tom Lane wrote:
As for taking it out of libpq, I would vote against doing that as long
as we have pg_dump support for pre-7.4 servers. Now, I think it would
be entirely reasonable to kill pg_dump's support for pre-7.3 servers,
because that would
On Fri, Feb 24, 2012 at 05:46:16PM +0200, Marko Kreen wrote:
- rename to PQrecvRow() and additionally provide PQgetRow()
I tried it and it seems to work as API - there is valid behaviour
for both sync and async connections.
Sync connection - PQgetRow() waits for data from network
On Mon, Feb 27, 2012 at 05:20:30PM +0900, Kyotaro HORIGUCHI wrote:
Hello,
On OOM, the old result is freed to have higher chance that
constructing new result succeeds. But if we want to transport
error message, we need to keep old PGresult around. Thus
two separate paths.
Ok, I
On Tue, Feb 28, 2012 at 05:04:44PM +0900, Kyotaro HORIGUCHI wrote:
There is still one EOF in v3 getAnotherTuple() -
pqGetInt(tupnfields), please turn that one also to
protocolerror.
pqGetInt() returns EOF only when it wants additional reading from
network if the parameter `bytes' is
On Tue, Mar 06, 2012 at 11:13:45AM +0900, Kyotaro HORIGUCHI wrote:
But it's broken in V3 protocol - getAnotherTuple() will be called
only if the packet is fully read. If the packet contents do not
agree with packet header, it's protocol error. Only valid EOF
return in V3
Commit b5282aa893:
Revise sinval code to remove no-longer-used tuple TID from inval messages.
dropped ItemPointer from callbacks and replaced it with hashValue.
There seems to be 2 ways that new backend code calculates it:
- hashoid(oid), which seems to assume too much?
-
On Tue, Mar 06, 2012 at 11:10:38AM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
So my question is that after doing generic SearchSysCache() like:
tup = SearchSysCache(USERMAPPINGUSERSERVER,
ObjectIdGetDatum(user_mapping-userid),
ObjectIdGetDatum
On Tue, Mar 06, 2012 at 04:27:11PM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
On Tue, Mar 06, 2012 at 11:10:38AM -0500, Tom Lane wrote:
Why would you need to know that? The reason the calculation function
is static is that there's no apparent need to expose
On Wed, Mar 07, 2012 at 11:16:06AM -0500, Tom Lane wrote:
Marko Kreen mark...@gmail.com writes:
On Tue, Mar 06, 2012 at 04:27:11PM -0500, Tom Lane wrote:
Or you could do like setrefs.c does, and assume you know how to
calculate the hash value for an OID-keyed cache.
Ok, the hashoid
On Fri, Mar 09, 2012 at 05:28:20PM -0500, Andrew Dunstan wrote:
Buildfarm member mussel (OS X 10.7.3, llvm-gcc 4.2.1, x86_64)seems
to be getting consistent warnings when running the pgcrypto
regression tests, that look like this:
WARNING: detected write past chunk end in ExprContext
On Thu, Mar 15, 2012 at 11:29:31PM +0200, Alex wrote:
https://github.com/a1exsh/postgres/commits/uri
The point of the patch is to have one string with all connection options,
in standard format, yes? So why does not this work:
db = PQconnectdb(postgres://localhost);
?
--
marko
--
Sent
On Tue, Dec 11, 2012 at 6:59 AM, Josh Kupershmidt schmi...@gmail.com wrote:
Would it be crazy to add an already_freed flag to the pg_result
struct which PQclear() would set, or some equivalent safety mechanism,
to avoid this hassle for users?
Such mechanism already exist - you just need to set
When there is 'ssl=on' then postmaster calls SSL_CTX_new(),
which asks for random number, thus requiring initialization
of randomness pool (RAND_poll). After that all forked backends
think pool is already initialized. Thus they proceed with same
fixed state they got from postmaster.
Output is
On Fri, Dec 21, 2012 at 10:27 PM, Noah Misch n...@leadboat.com wrote:
This should have gone to secur...@postgresql.org, instead.
It went and this could have been patched in 9.2.2 but they did not care.
On Fri, Dec 21, 2012 at 06:05:10PM +0200, Marko Kreen wrote:
When there is 'ssl
401 - 500 of 655 matches
Mail list logo
