On Sat, Mar 4, 2017 at 1:46 PM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 3/3/17 13:58, Petr Jelinek wrote:
>> On 23/02/17 08:24, Masahiko Sawada wrote:
>>> Attached updated version patches. Please review these.
>>>
>>
>> T
On Sat, Apr 8, 2017 at 1:09 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Sat, Apr 8, 2017 at 3:37 AM, Andres Freund <and...@anarazel.de> wrote:
>> Hi,
>>
>> When I started writing this, there were the following reamining CF
>> items, minus bug
lpgsql extra_checks
> - Winner of the "most opaque CF title" award
> - hasn't received a whole lot of review
> - don't think we're even close to having design agreement
>
> Generic type subscripting
> - still some review back and forth
> - probably should be punted
>
On Fri, Apr 7, 2017 at 1:23 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> At Thu, 6 Apr 2017 18:42:37 +0200, Petr Jelinek
> <petr.jeli...@2ndquadrant.com> wrote in
> <8c7afb37-be73-c6bd-80bc-e87522f04...@2ndquadrant.com>
>> On 06/04/17 16:44, M
Hi all,
Attached fixes a typo in publicationcmd.c file.
s/om/on/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_publicationcmds_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers
On Wed, Mar 29, 2017 at 11:14 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Wed, Mar 22, 2017 at 2:49 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> On Thu, Mar 16, 2017 at 2:37 PM, Vinayak Pokale
>> <pokale_vinayak...@lab.ntt.co.jp> wrot
On Tue, Apr 18, 2017 at 12:24 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hi,
>
> Thank you for the revised version.
>
> At Mon, 17 Apr 2017 23:29:28 +0900, Masahiko Sawada <sawada.m...@gmail.com>
> wrote in <CAD21AoA+yFJTbw0PCw-ttmh9TsTygM3=
On Tue, Apr 18, 2017 at 6:40 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> At Tue, 18 Apr 2017 14:58:50 +0900, Masahiko Sawada <sawada.m...@gmail.com>
> wrote in <cad21aobqsjugx0lcdrjedlb-yx2evglmdt8nz4zr_xpxrbm...@mail.gmail.com>
>> On Tue, Apr 18
there will be a lot of peoples who
want to use logical synchronous replication but this is a big
restriction for such user. I think we should document it or deal with
it.
Thought?
[1]
https://www.postgresql.org/docs/devel/static/logicaldecoding-synchronous.html
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH
s
>> to
>> Recheck Mid-Beta" section so that we can hear more opinions.
>
> I'm reading that some people want to report NULL priority, some people want to
> report a constant 1 priority, and nobody wants the current behavior. Is that
> an accurate summary?
Yes, I think that's correct.
FWIW the reason of current behavior is that it would be useful for the
user who is willing to switch from ANY to FIRST. They can know which
standbys will become sync or potential.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Mon, Apr 24, 2017 at 4:41 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello,
>
> At Sun, 23 Apr 2017 00:51:52 +0900, Masahiko Sawada <sawada.m...@gmail.com>
> wrote in <CAD21AoApBU+nz7FYaWX6gjyB9r6WWrTujbL4rrZiocHLc=p...@mail.gmail.com>
>&
On Tue, Apr 25, 2017 at 1:42 AM, Petr Jelinek
<petr.jeli...@2ndquadrant.com> wrote:
> On 24/04/17 17:52, Masahiko Sawada wrote:
>> On Mon, Apr 24, 2017 at 4:41 PM, Kyotaro HORIGUCHI
>> <horiguchi.kyot...@lab.ntt.co.jp> wrote:
>> + /*
>> + * Remove entrie
On Tue, Apr 25, 2017 at 12:56 AM, Fujii Masao <masao.fu...@gmail.com> wrote:
> On Mon, Apr 24, 2017 at 9:02 AM, Noah Misch <n...@leadboat.com> wrote:
>> On Thu, Apr 20, 2017 at 11:34:34PM -0700, Noah Misch wrote:
>>> On Fri, Apr 21, 2017 at 01:20:05PM +0900, Masah
On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> Hello,
>
> At Mon, 24 Apr 2017 11:18:32 +0900, Masahiko Sawada <sawada.m...@gmail.com>
> wrote in <cad21aobu8mzdgx-stj3u+qkaej5rpnouotw4kfexc4xddnf...@mail.gmail.co
scale factor the primary key index creation takes a long
time even if we're going to use other types of indexes. With this
option, the initialization time is reduced and you can create indexes
as you want.
Feedback is very welcome. I'll add this patch to the next CF.
Regards,
--
Masahiko Sawada
t we
can do that using psql -f. So an alternative ways is having a flexible
style option for example --custom-initialize = { [load, create_pkey,
create_fkey, vacuum], ... }. That would solve this in a better way.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Sof
On Wed, Aug 2, 2017 at 11:40 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Tue, Jul 4, 2017 at 10:13 PM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> scanned_tuples variable in LVRelStats is introduced by commit b4b6923e
>> but it seems to me that it
On Wed, Aug 2, 2017 at 10:25 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Tue, Aug 1, 2017 at 9:49 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
>> I'd like to propose a new option -I for pgbench command which skips
>> the creating primary keys after init
; to me. I'm going to play with it a bit more and, barring issues, will
> push them tomorrow morning.
>
Thank you for the patches, Michael-san! It looks good to me too.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
>> default behavior should change to quorum and I am still of that opinion.
>
> This item appears under "decisions to recheck mid-beta". If anyone is going
> to push for a change here, now is the time.
It has been 1 week since the previous mail. I though that there were
others arg
On Fri, Aug 4, 2017 at 3:01 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Thu, Aug 3, 2017 at 1:10 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
>> So we can remove scanned_tuples from LVRelStats struct and change the
>> variable name num_tuples to scanned_tup
ll patch fixes these issues.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
code_improvement_for_btree.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subs
On Wed, Aug 16, 2017 at 4:38 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 8/9/17 20:22, Masahiko Sawada wrote:
>> There is a type of logical replication message 'Y' for data types, but
>> it's not documented in section 52.9. Logical Replication Message
;>> ISTM that it should always use INT8.
>>
>>
>> Hmm, I think it's a valid point. Should we allow users to specify like
>> the above thing in the custom initialization feature as well?
>
>
> I would be in favor of having an option to do a tpc-b conforming schema
On Fri, Aug 11, 2017 at 1:40 AM, Josh Berkus <j...@berkus.org> wrote:
> On 08/09/2017 10:49 PM, Michael Paquier wrote:
>> On Fri, Aug 4, 2017 at 8:19 AM, Masahiko Sawada <sawada.m...@gmail.com>
>> wrote:
>>> On Fri, Jul 28, 2017 at 2:24 PM, Noah Misch <n
On Thu, Jun 22, 2017 at 12:03 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Fri, May 19, 2017 at 11:12 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> On Wed, May 17, 2017 at 1:30 AM, Robert Haas <robertmh...@gmail.com> wrote:
>>> On Sa
On Tue, Aug 15, 2017 at 11:14 AM, Alvaro Herrera
<alvhe...@2ndquadrant.com> wrote:
> Michael Paquier wrote:
>> On Tue, Aug 15, 2017 at 10:27 AM, Masahiko Sawada <sawada.m...@gmail.com>
>> wrote:
>> > Currently vacuum verbose outputs vacuum logs as foll
On Tue, Aug 15, 2017 at 2:53 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 8/14/17 08:32, Masahiko Sawada wrote:
>> While reading source code, I found a typo in sequence.c file. Attached
>> patch for fixing it.
>>
>> s/localy/locally/
ch and will add to commit fest.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
vacuum_more_explicit_relname.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
asoning about what
> might (not) have happened.
>
> Or at least make the filtering optional.
>
I'd vote for having both and making one optional (perhaps filtering?).
Both are useful to me for the debugging and study purpose.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
paths in tqual.c.
*/
Maybe we can get rid of the second "because" in the first sentence?
Attached patch.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/r
On Wed, Aug 9, 2017 at 11:23 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Mon, Aug 7, 2017 at 1:44 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
>> On Sat, Aug 5, 2017 at 3:29 AM, Peter Geoghegan <p...@bowt.ie> wrote:
>>> On Fri, Aug 4, 2017 at
a patch to fix this inconsistency, parked
> in next CF. I am not arguing for this change as a bug fix, but as an
> improvement for PG11.
>
> Thoughts?
Thank you for the patch. Regarding to creating the backup history file
on stanbys, is there any difference from the patch posted on
On Thu, Aug 10, 2017 at 4:50 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Thu, Aug 10, 2017 at 9:45 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> Thank you for the patch. Regarding to creating the backup history file
>> on stanbys, is there
On Sun, Aug 13, 2017 at 12:28 PM, Alvaro Herrera
<alvhe...@2ndquadrant.com> wrote:
> Alvaro Herrera wrote:
>> Masahiko Sawada wrote:
>> > Hi all,
>> >
>> > In snapbuild.c file, there is a comment as follows.
>> >
>> >* NB:
.
>
> Remove the "no-primary-keys" from the long option array as it has
> disappeared. You might consider make "custom-initialize" take the 'I' short
> option.
>
> Ranting unrelated to this patch: the automatic aid type switching based on
> scale is a ba
Hi,
While reading source code, I found a typo in sequence.c file. Attached
patch for fixing it.
s/localy/locally/g
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_sequence_c.patch
Description: Binary data
--
Sent via pgsql
On Thu, Aug 17, 2017 at 3:52 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 6/20/17 22:20, Masahiko Sawada wrote:
>> Hi,
>>
>> In J.2. Tool Sets section of documentation, there is a link to DocBook
>> XSL Stylesheets but that link seems no lon
On Wed, Aug 16, 2017 at 4:37 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Wed, Aug 16, 2017 at 4:24 PM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> FWIW, in my opinion if tte current behavior of 'N(a,b)' could confuse
>> users and we want to br
On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 8/8/17 05:58, Masahiko Sawada wrote:
>> Are you planning to work on remaining patches 0005 and 0006 that
>> improve the subscription codes in PG11 cycle? If not, I will take
ory file for backups taken at recovery as well.
> 2) Archive it if archive_mode = always.
> 3) Wait for both the segment of the stop point and the backup history
> files to be archived before returning back to the caller of
> pg_stop_backup.
>
> It would be nice to get all that addressed
On Wed, Jul 12, 2017 at 11:19 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Sat, Jul 8, 2017 at 5:19 AM, Petr Jelinek
> <petr.jeli...@2ndquadrant.com> wrote:
>> Hi,
>>
>> I have done some review of subscription handling (well self-review) and
>>
On Mon, Jul 10, 2017 at 10:01 PM, Heikki Linnakangas <hlinn...@iki.fi> wrote:
> On 07/10/2017 01:27 PM, Masahiko Sawada wrote:
>>
>> This commit seems be cause of the documentation compilation error. I
>> think is missing.
>>
>> ...
>>
>> Attac
ory is
> zeroed, and the value of InvalidTransactionId is 0.
>
> If the memory was not 0 for whatever reason, VACUUM would not behave as
> expected.
>
>
> See attached patch.
>
Thank you for the patch. This change makes sense to me.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORP
On Fri, Jul 7, 2017 at 9:09 PM, Magnus Hagander <mag...@hagander.net> wrote:
> On Fri, Jul 7, 2017 at 8:31 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>>
>> Hi,
>>
>> While reading source code, I found that the header comment of
>> st
On Mon, Jul 10, 2017 at 11:56 AM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Sat, Jul 8, 2017 at 12:50 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> On Fri, Jul 7, 2017 at 3:48 PM, Michael Paquier
>> <michael.paqu...@gmail.com> wrote:
9:E: end tag for "SECT3" omitted, but OMITTAG NO
was specified
osx:libpq.sgml:891:3: start tag was here
make: *** [postgres.xml] Error 1
make: Leaving directory `/home/masahiko/pgsql/source/postgresql/doc/src/sgml'
Attached small patch fixes this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRA
t being
> correctly synchronized.
>
> 0003 - Splits the schizophrenic SetSubscriptionRelState function into
> two which don't try to do broken upsert and report proper errors instead.
>
> 0004 - Solves the issue which Masahiko Sawada reported [2] about ALTER
> SUBSCRIPTION handling of workers
On Wed, Jul 12, 2017 at 5:06 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Tue, Jul 11, 2017 at 9:28 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> Attached updated version patch. Please review it.
>
> Cool, thanks.
Thank you for reviewin
Hi,
Attached patch for $subject.
s/reporing/reporting/g
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_info_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Tue, Jul 18, 2017 at 1:28 PM, Stephen Frost <sfr...@snowman.net> wrote:
> Masahiko, Michael,
>
> * Masahiko Sawada (sawada.m...@gmail.com) wrote:
>> > This is beginning to shape.
>>
>> Sorry, I missed lots of typo in the last patch. All comments from you
&
t; {HEAP_XMIN_COMMITTED,HEAP_XMIN_INVALID,HEAP_XMAX_INVALID,HEAP_XMIN_FROZEN}
>>> (1 row)
>>
>> Seems like a good idea to me.
>>
>
> +1, it'll be really helpful.
>
+1.
When I investigated data corruption incident I also wrote a plpgsql
function for the same pur
ves 160 lines of
> code.
>
Thank you for the patch. Is this an item for PG11?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscriptio
pt at merging some functions which removes 160 lines of
>>> code.
>>
>>
>> Thank you for the patch. Is this an item for PG11?
>
>
> Yes, as it is submitted to CF 2017-09.
>
Thank!
It is already registered to next CF. I missed it, sorry.
Regards,
--
Masahiko Sawada
hes. Or we can fix the docs of back
branches and fix the code only in PG10. I expect that the user who
wrote a backup script has done enough functional test and dealt with
this issue somehow, but since the current doc clearly says that
pg_stop_backup() waits for all WAL to be archived we have to make
On Sat, Jul 22, 2017 at 8:04 AM, Stephen Frost <sfr...@snowman.net> wrote:
> Masahiko, all,
>
> * Masahiko Sawada (sawada.m...@gmail.com) wrote:
>> On Tue, Jul 18, 2017 at 1:28 PM, Stephen Frost <sfr...@snowman.net> wrote:
>> > Masahiko, Michael,
>> >
old.
>
> I hate to reply to myself, but I wanted to add: in any case, the case
> I'm trying to avoid is the case where the FSM *never* gets vacuumed.
> That's bad. But it may not be the phenomenon you're experiencing in
> your tests.
>
I think the frequently vacuuming the FSM du
On Thu, Jul 27, 2017 at 5:48 PM, Sokolov Yura
<funny.fal...@postgrespro.ru> wrote:
> On 2017-07-27 11:30, Masahiko Sawada wrote:
>>
>> On Tue, Jul 25, 2017 at 2:27 AM, Claudio Freire <klaussfre...@gmail.com>
>> wrote:
>>>
>>> On Mon, Jul 24, 2017
omments, so I think the new
> parameter also needs this. Attached is a simple patch to fix
> this.
>
Good point. Similarly, dynamic_shared_memory_type and event_source are
required restarting to change but are not mentioned in
postgresql.conf.sample. Should we add a comment as well?
Regards,
without atomicity means that some parts of data can be lost
>> without simple
>> way to detect and fix that.
>
> OK, thanks for weighing in.
>
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Wed, Jul 26, 2017 at 10:29 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Mon, Jun 19, 2017 at 4:30 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>>> I think that either of the options you suggested now would be better.
>>> We'll need t
On Thu, Jul 27, 2017 at 10:28 AM, Robert Haas <robertmh...@gmail.com> wrote:
> On Fri, Apr 7, 2017 at 10:56 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> Vinayak, why did you marked this patch as "Move to next CF"? AFAIU
>> there is not discussion
have used all space available and then substantially increased
> the size of the relation (leading to vacuum on the table running for
> longer).
Yeah, the parallel vacuum of a particular table might help this issue
unless disk I/O is bottle-neck. I'm planning work on that.
Regards,
--
Mas
P_RECORED means by? I could not find such XLOG info value.
Does it mean XLOG_BACKUP_END?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your sub
Hi,
Attached patch for $subject.
s/entires/entries/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_aclchk_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
On Thu, Jun 29, 2017 at 10:30 PM, Magnus Hagander <mag...@hagander.net> wrote:
> On Thu, Jun 22, 2017 at 6:22 PM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>>
>> On Thu, Jun 22, 2017 at 10:36 PM, Magnus Hagander <mag...@hagander.net>
>> wrote:
>&
mit | subpublications
-+--+--++---+-+---+-
13164 | hoge_sub | 10 | t | dbname=postgres
port=5550 | hoge_sub| off | {one_pub}
(1 row)
=# drop subscription hoge_sub ;
DROP SUBSCRIPTION
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND
On Fri, Jun 30, 2017 at 11:02 PM, Robert Haas <robertmh...@gmail.com> wrote:
> On Wed, Jun 28, 2017 at 5:11 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> Attached patch for $subject.
>> A period is missing at the end of sentence.
>
> Seems
ou for committing the patch!
>
> Maybe we can start new threads for the other parts of the patch and
> maybe split the patch up a bit.
Yeah, let's discuss about reworking the locking and management on new thread.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
N
On Sat, Jul 1, 2017 at 4:55 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 6/30/17 03:58, Masahiko Sawada wrote:
>> Attached patch for $subject.
>>
>> s/entires/entries/
>
> fixed
>
Thanks.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAP
On Wed, Jun 28, 2017 at 2:13 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Wed, Jun 28, 2017 at 1:47 AM, Petr Jelinek
> <petr.jeli...@2ndquadrant.com> wrote:
>>
>> On 27/06/17 10:51, Masahiko Sawada wrote:
>>> On Mon, Jun 26, 2017 at 12:12 PM,
lstats->scanned_tuples = num_tuples;
vacrelstats->tuples_deleted = tups_vacuumed;
vacrelstats->new_dead_tuples = nkeep;
Attached small path fixes this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_vacuumlazy.patch
Descripti
On Thu, Jun 29, 2017 at 10:49 AM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Thu, Jun 29, 2017 at 10:28 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> While reading source codes I found the following comment in xlog.c.
>>
>> /*
>>
hould be a bitwise OR instead of AND. Now this line
>> cleans all bits in t_infomask which later will be copied directly in tuple.
>
> I think you're right.
>
I also think that's right. Should we back-patch it down to 9.3?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHON
On Wed, Jul 5, 2017 at 4:57 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Wed, Jul 5, 2017 at 10:19 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> I feel that since we cannot switch the WAL forcibly on the standby
>> server we need to find a
Hi,
While reading source code, I found that the header comment of
streamutil.c is not correct. I guess pg_receivelog is a mistake of
pg_receivexlog and it's an oversight when changing xlog to wal.
Attached patch fixes this.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
On Fri, Jul 7, 2017 at 4:21 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Fri, Jul 7, 2017 at 4:06 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
>> I agree with this idea. I've tried to make it wait for archiving but
>> it seems to me that there a
On Sun, Jul 2, 2017 at 4:39 PM, Michael Paquier
<michael.paqu...@gmail.com> wrote:
> On Sat, Jul 1, 2017 at 3:59 AM, Stephen Frost <sfr...@snowman.net> wrote:
>> * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
>>> On 6/30/17 04:08, Masahiko Sawada wrote
On Wed, Apr 26, 2017 at 12:35 PM, Petr Jelinek
<petr.jeli...@2ndquadrant.com> wrote:
> On 26/04/17 01:01, Fujii Masao wrote:
>> On Mon, Apr 24, 2017 at 7:57 PM, Kyotaro HORIGUCHI
>> <horiguchi.kyot...@lab.ntt.co.jp> wrote:
>>> Hello,
>>>
>>&g
Hi,
Attached patch for $subject.
s/accomodate/accommodate/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_subscriptioncmd_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers
secondary option and hot_standby
> should be default.
>
The idea of changing the default value seems good to me but I'm not
sure it's good idea to change the default value now under the
circumstances where we're focus on stabilization.
Also we should update the document as well.
Regards,
--
Masahik
HI,
Attached patch for $subject.
s/strigs/strings/
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
fix_typo_in_worker_c.patch
Description: Binary data
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make
e that lacks
>> critical functionality.
>>
>> regards, tom lane
>
> I attached the patch which also update manual as the mention of sawada-san.
>
Thank you for updating the patch. Also maybe we can update line in
PostgresNode.pm where hot_standby is set to
On Thu, Apr 27, 2017 at 1:58 PM, Huong Dangminh
<huo-dangm...@ys.jp.nec.com> wrote:
>> On Thu, Apr 27, 2017 at 11:48 AM, Masahiko Sawada <sawada.m...@gmail.com>
>> wrote:
>> > Thank you for updating the patch. Also maybe we can update line in
>> >
srch(
+ (void *) itemptr,
+ (void *)
&(vacrelstats->dead_tuples.dt_segments->last_dead_tuple),
+ vacrelstats->dead_tuples.last_seg + 1,
+ sizeof(DeadTuplesSegment));
+
I think that we can change the above to;
+ /* Searc
sactions wait only for
>> + replies from the requested number of faster standbys in all the listed
>> + standbys, i.e., such slow standby doesn't block the transactions.
>>
>
> Can we do few modifications like:
> improve those latencies --> reduce those late
On Fri, Apr 28, 2017 at 5:26 PM, Kyotaro HORIGUCHI
<horiguchi.kyot...@lab.ntt.co.jp> wrote:
> At Fri, 28 Apr 2017 10:20:48 +0900, Masahiko Sawada <sawada.m...@gmail.com>
> wrote in
up the hash table when we're done with all tables (just to
+* release the bit of memory).
+*/
+ else if (!table_states && last_start_times)
+ {
Isn't it better to use != NIL instead as follows?
else if (table_state != NIL && last_start_times)
Regards,
t makes sense to me. Since NOCONNECT option changes some default
values including ENABLED to false I think we should apply it also when
NOCONNECT is specified?
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
quot;;
>>
>> This is a minor point though.
After some thoughts I agree to remain it in the perl code.
>
> Thanks, I attached the update patch.
So it looks good to me.
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
ng item in release note, oldestxmin is also
reported by VACUUM VERBOSE and autovacuum , which is introduced by
commit 9eb344faf54a849898d9be012ddfa8204cfeb57c (author is Simon).
* Have VACUUM VERBOSE report the number of skipped frozen pages
(Masahiko Sawada)
Could we add this item to the rele
d on
here[1]. I guess reviewing that patch is almost done.
[1]
https://www.postgresql.org/message-id/CAHGQGwELzJrA4SDA4TsJGds4X-ykTOP%2By5hecsoQmQqzZf8T7A%40mail.gmail.com
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hacker
ver crash. I'll add it.
> On Fri, Jul 28, 2017 at 3:07 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>>
>> On Mon, Jul 24, 2017 at 4:22 PM, <sc...@deltaex.com> wrote:
>> > The following bug has been logged on the website:
>> >
>> > Bug
On Fri, Jul 28, 2017 at 1:13 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Thu, Jul 27, 2017 at 9:31 AM, Masahiko Sawada <sawada.m...@gmail.com>
> wrote:
>> On Wed, Jul 26, 2017 at 10:29 PM, Robert Haas <robertmh...@gmail.com> wrote:
>>> On Mon, J
On Thu, Aug 3, 2017 at 11:31 PM, Tom Lane <t...@sss.pgh.pa.us> wrote:
> Masahiko Sawada <sawada.m...@gmail.com> writes:
>> If we want to create other tables and load data to them as we want we
>> can do that using psql -f. So an alternative ways is having a flexible
On Mon, Aug 7, 2017 at 10:22 PM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 8/7/17 00:27, Masahiko Sawada wrote:
>>>> However, even with this patch there is still an issue that NOTICE
>>>> messages "removed subscription for table publ
On Mon, Aug 7, 2017 at 1:44 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote:
> On Sat, Aug 5, 2017 at 3:29 AM, Peter Geoghegan <p...@bowt.ie> wrote:
>> On Fri, Aug 4, 2017 at 11:12 AM, Alvaro Herrera
>> <alvhe...@2ndquadrant.com> wrote:
>>> Interesti
arded systems do before we choose what
> we want to do.
[1] https://research.google.com/archive/spanner.html
[2]
https://www.microsoft.com/en-us/research/wp-content/uploads/2016/02/samehe-clocksi.srds2013.pdf
[3] https://arxiv.org/pdf/1704.01355.pdf
Regards,
--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Tue, Aug 1, 2017 at 6:23 AM, Peter Eisentraut
<peter.eisentr...@2ndquadrant.com> wrote:
> On 7/13/17 03:22, Masahiko Sawada wrote:
>> Hi,
>>
>> Attached patch for $subject.
>>
>> s/reporing/reporting/g
>
> fixed
Thank you!
Regards,
--
M
bt transactions. That process periodically checks if there is
unresolved transaction on shared memory and tries to resolve it
according commit log. If we change it so that the backend process can
communicate with the resolver process via SetLatch the resolver
process is better to be implemente
401 - 500 of 730 matches
Mail list logo
