Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-29 Thread Masahiko Sawada
y > v - vacuum > > I think it is mostly okay, but it is the last time to think about it. Using > "d" for cleanup (drop) would mean finding another letter for filling in > data... maybe "g" for data generation? "c" may have been chosen for "create >

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-08-31 Thread Masahiko Sawada
think we should set T_RangeVar to rangevar.type in autovacuum_do_vac_analyze function. Also, there is a small typo in dedupe_vacuum_relations_v2.patch. + /* if already procesed or not equal, skip */ + if (list_member_int(duplicates, i) || rela

[HACKERS] Re: [BUGS] 10.0: Logical replication doesn't execute BEFORE UPDATE OF trigger

2017-10-09 Thread Masahiko Sawada
ueries would have been > executed on one instance. > > Actual result > - > > Replication fails, log contains: > > ``` > [3227] ERROR: duplicate key value violates unique constraint "test_pkey" > [3227] DETAIL: Key (k)=(k1) already exists. > [3176] L

[HACKERS] Fix a typo in execReplication.c

2017-10-09 Thread Masahiko Sawada
Hi, Attached a patch for $subject. ISTM these are mistakes of copy-and-paste. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_comment_in_execReplication_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] Issues with logical replication

2017-10-03 Thread Masahiko Sawada
>>> worker.c:736 >> >> We have locked the same tuple in RelationFindReplTupleByIndex() just >> before this gets called and didn't get the same error. I guess we do >> something wrong with snapshots. Will need to investigate more. >> > > Okay, so it's not

Re: [HACKERS] Fix a typo in execReplication.c

2017-10-11 Thread Masahiko Sawada
On Thu, Oct 12, 2017 at 5:02 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Oct 9, 2017 at 10:59 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Attached a patch for $subject. ISTM these are mistakes of copy-and-paste. > > Committed, but isn't

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-09-27 Thread Masahiko Sawada
On Tue, Sep 26, 2017 at 9:50 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Sep 26, 2017 at 5:06 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Based on the review comment from Robert, I'm planning to do the big >> change to the architecture o

Re: [HACKERS] Slow synchronous logical replication

2017-10-11 Thread Masahiko Sawada
t least your use case. We send at least the begin and commit data to all subscriptions and then wait for the reply from them but can we skip to wait them, for example, when the walsender actually didn't send any data modified by the transaction? Regards, -- Masahiko Sawada NIPPON TELEGRAPH A

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-10-18 Thread Masahiko Sawada
t's wait and see. > > > The patch needs a rebase in the documentation because of the xml-ilization > of the sgml doc. > Thank you for the notification! Attached rebased patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench

[HACKERS] Fix a typo in libpq/auth.c

2017-10-19 Thread Masahiko Sawada
Hi, Attached a patch for $subject. s/RAIDUS/RADIUS/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_auth_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-19 Thread Masahiko Sawada
On Tue, Sep 5, 2017 at 3:41 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Thank you for the opinions. > > At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada <sawada.m...@gmail.com> > wrote in

Re: [HACKERS] Block level parallel vacuum WIP

2017-10-23 Thread Masahiko Sawada
On Mon, Oct 23, 2017 at 10:43 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/10/22 5:25, Thomas Munro wrote: >> On Sun, Oct 22, 2017 at 5:09 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> On Tue, Sep 19, 2017 at 3:31 AM, Masahiko Sawada <

[HACKERS] ginInsertCleanup called from vacuum could still miss tuples to be deleted

2017-11-13 Thread Masahiko Sawada
GE_BLKNO, ExclusiveLock)) return; workMemory = work_mem; } Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_ginInsertCleanup.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-11-05 Thread Masahiko Sawada
On Sat, Nov 4, 2017 at 7:04 AM, Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Wed, Nov 1, 2017 at 5:55 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov >> <a.korot...@postgrespro.ru>

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-11-06 Thread Masahiko Sawada
On Mon, Oct 30, 2017 at 3:17 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> Since

Re: [HACKERS] Explicit relation name in VACUUM VERBOSE log

2017-11-01 Thread Masahiko Sawada
more generic solution for other log messages. But especially for VACUUM VERBOSE log, since the log messages could be very long when the table has multiple indices this patch would be useful for users. Since the previous patch conflicts with current HEAD, attached the updated patch. Regards, -- Masah

[HACKERS] Fix a typo in dsm_impl.c

2017-11-06 Thread Masahiko Sawada
Hi, Attached the patch for $subject. s/reamin/remain/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_dsm_impl_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Remove duplicate setting in test/recovery/Makefile

2017-11-07 Thread Masahiko Sawada
Hi, I found that EXTRA_INSTALL is doubly set at both top and bottom of the src/test/recovery/Makefile. Is it necessary? Attached patch fixes this. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center remove_duplicate_setting.patch Description

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
contrib/bloom/Makefile b/contrib/bloom/Makefile index 13bd397..c1566d4 100644 --- a/contrib/bloom/Makefile +++ b/contrib/bloom/Makefile @@ -20,5 +20,7 @@ include $(top_builddir)/src/Makefile.global include $(top_srcdir)/contrib/contrib-global.mk endif +check: wal-check + wal-check: temp-install $(prove_check) Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Fix a typo in dsm_impl.c

2017-11-07 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 6:36 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Nov 6, 2017 at 11:22 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Attached the patch for $subject. > > Committed. > Thank you! Regards, -- Masahiko Sawada NIPPON TE

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 11:20 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 1:58 AM, Alexander Korotkov > <a.korot...@postgrespro.ru> wrote: >> On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada <sawada.m...@gmail.com> >> w

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-11-08 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 5:41 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Nov 6, 2017 at 4:42 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: >>>> I suggest that a good thing to do more or less immediately, regardless >>>> of when this patch

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-10-30 Thread Masahiko Sawada
On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Since the previous patch conflicts with current HEAD, I attached the >> updated patch for next CF.

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-10-30 Thread Masahiko Sawada
On Mon, Oct 30, 2017 at 5:48 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Thu, Oct 26, 2017 at 7:41 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> Because I don't want to break the current user semantics. that is, >> currently

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-10-26 Thread Masahiko Sawada
On Fri, Sep 8, 2017 at 4:32 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Sep 8, 2017 at 7:24 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wro

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-10-30 Thread Masahiko Sawada
If we insert a tuple on the new master server to a block that has been truncated on the old master, the WAL apply on the new standby will fail? I guess there are such corner cases causing failures of WAL replay after switch-over. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORP

Re: [HACKERS] Deadlock in ALTER SUBSCRIPTION REFRESH PUBLICATION

2017-10-31 Thread Masahiko Sawada
> postmaster.c:4029 > #22 0x007fd398 in ServerLoop () at postmaster.c:1753 > #23 0x007fc92f in PostmasterMain (argc=3, argv=0x244d6e0) at > postmaster.c:1361 > #24 0x00734f08 in main (argc=3, argv=0x244d6e0) at main.c:228 > > > > The reason of this deadlo

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-10-31 Thread Masahiko Sawada
On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Tue, Oct 31, 2017 at 5:16 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> On Mon, Oct 30, 2017 at 10:16 PM, Robert Haas <robertmh...@gmail.com> >> w

Re: [HACKERS] More stats about skipped vacuums

2017-10-20 Thread Masahiko Sawada
gt; This seems enough to find the cause of a table bloat. The same > discussion could be applied to analyze but it might be the > another issue. > > There may be a better way to indicate the vacuum soundness. Any > opinions and suggestions are welcome. > > I'm going to make a patch to do

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-10-26 Thread Masahiko Sawada
On Thu, Oct 26, 2017 at 2:36 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Oct 25, 2017 at 3:15 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> Foreign Transaction Resolver >> == >> I introduc

<    3   4   5   6   7   8