Re: [HACKERS] Re: pg_stat_statements normalisation without invasive changes to the parser (was: Next steps on pg_stat_statements normalisation)

2012-03-19 Thread Peter Geoghegan
interesting things.  Just a thought ... I think that that is a good idea. However, I am not a Perl hacker, though this is the second time that that has left me at a disadvantage when working on Postgres, so I think it's probably time to learn a certain amount. -- Peter Geoghegan       http://www

Re: [HACKERS] Error trying to compile a simple C trigger

2012-03-20 Thread Peter Geoghegan
/tupdesc.h -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED

2010-12-12 Thread Peter Geoghegan
, this refinement of Simon's proposal would probably entail adding an additional column to pg_constraint. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED

2010-12-13 Thread Peter Geoghegan
. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ALTER TABLE ... ADD FOREIGN KEY ... NOT ENFORCED

2010-12-13 Thread Peter Geoghegan
. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Segfault related to pg_authid when running initdb from git master

2010-12-14 Thread Peter Geoghegan
. The trouble seems occur here, at line 1224 of initdb.c: for (line = pg_authid_setup; *line != NULL; line++) PG_CMD_PUTS(*line); After I see the segmentation fault in stderr, gdb reports that initdb has received SIGPIPE. Hope that helps. -- Regards, Peter Geoghegan -- Sent via

Re: [HACKERS] Segfault related to pg_authid when running initdb from git master

2010-12-15 Thread Peter Geoghegan
breakpoint 1, 0x00577360 in main () (gdb) n Single stepping until exit from function main, which has no line number information. Program received signal SIGSEGV, Segmentation fault. 0x0047615b in _bt_preprocess_keys () Hope that helps. -- Regards, Peter Geoghegan -- Sent via

Re: [HACKERS] Segfault related to pg_authid when running initdb from git master

2010-12-15 Thread Peter Geoghegan
On 15 December 2010 16:26, Robert Haas robertmh...@gmail.com wrote: On Wed, Dec 15, 2010 at 6:07 AM, Peter Geoghegan peter.geoghega...@gmail.com wrote: On 15 December 2010 01:35, Robert Haas robertmh...@gmail.com wrote: I am suspicious of the fact that you are invoking initdb as ./initdb

Re: [HACKERS] Segfault related to pg_authid when running initdb from git master

2010-12-15 Thread Peter Geoghegan
were new, they were somehow linked with one or more older, release object files. Thanks. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Segfault related to pg_authid when running initdb from git master

2010-12-15 Thread Peter Geoghegan
. Thanks for the tip. I guess it simply didn't occur to me to make distclean because I made the rather questionable assumption that it's only necessary when there are weird linking issues. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] C++ keywords in headers (was Re: [GENERAL] #include funcapi.h)

2010-12-27 Thread Peter Geoghegan
nullptr static_assert Perhaps we should add -std=c++0x to the g++ command in cpluspluscheck.sh . Since C++0x is “almost 100-percent compatible with the existing Standard C++” according to no less an authority than Bjarne Stroustrup, this seems sensible. -- Regards, Peter Geoghegan -- Sent via

Re: [HACKERS] C++ keywords in headers (was Re: [GENERAL] #include funcapi.h)

2010-12-27 Thread Peter Geoghegan
, they might well be using C++0x. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] writable CTEs

2010-12-27 Thread Peter Geoghegan
after WITH queries in the docs at certain select places? I could write a documentation patch. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] writable CTEs

2010-12-27 Thread Peter Geoghegan
, because the term WITH query may not be exactly equivalent to the term CTE - WITH queries are comprised of one or more CTEs, plus a main query. Or are they? Comments? -- Regards, Peter Geoghegan diff --git a/doc/src/sgml/queries.sgml b/doc/src/sgml/queries.sgml index f6e081e..45df052 100644 --- a/doc

Re: [HACKERS] writable CTEs

2010-12-28 Thread Peter Geoghegan
. Attached is a new patch written with this consideration in mind. It also has an acronym.sgml entry for CTE, which was absent from my earlier patch. I think David actually agreed that I was right to have doubts. -- Regards, Peter Geoghegan diff --git a/doc/src/sgml/acronyms.sgml b/doc/src/sgml

Re: [HACKERS] writable CTEs

2010-12-28 Thread Peter Geoghegan
, but the fact that I never hear the term in conversation probably has something to do with that too. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] writable CTEs

2010-12-28 Thread Peter Geoghegan
WITH Queries to WITH Queries (Common Table Expressions) because CTEs are the defining characteristic of WITH queries, and, as I've said, the term common table expression has mindshare in a way that WITH query clearly doesn't. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] C++ keywords in headers (was Re: [GENERAL] #include funcapi.h)

2011-01-02 Thread Peter Geoghegan
that there is likely to be an expectation that the same compiler that is used to build pg should be able to include pg headers in C++ TUs. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] writable CTEs

2011-01-05 Thread Peter Geoghegan
Hello, I have added my common table expressions docpatch to the 2011-01 commitfest: https://commitfest.postgresql.org/action/patch_view?id=476 I think that we need to get this resolved. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Determining client_encoding from client locale

2011-01-17 Thread Peter Geoghegan
tend to be much of a problem in practice because pg_dump will have the dump SET client_encoding as appropriate from the DB encoding. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] REVIEW: writable CTEs - doc patch

2011-01-19 Thread Peter Geoghegan
I think that a major goal of the DocBook format is that it separates content from presentation, so whatever tool is used to render that content as HTML for .org isn't necessarily publicly available. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers

[HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2012-11-14 Thread Peter Geoghegan
://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=82e429794b348cd80c1d1b011e21ffac98bc6e88 [3] http://pgeoghegan.blogspot.com/2012/06/towards-14000-write-transactions-on-my.html [4] http://blog.2ndquadrant.com/intel_ssds_lifetime_and_the_32/ -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2012-11-15 Thread Peter Geoghegan
at least addressed this concern, but that just didn't work as well as this. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2012-11-15 Thread Peter Geoghegan
that that can make an appreciable difference when following this method. I'd suggest that a value of 5 be used there. I think we should just change that, since everyone will just use the default anyway (or, the more cautious ones will use a higher value than the default, if anything). -- Peter

Re: [HACKERS] Hash id in pg_stat_statements

2012-11-15 Thread Peter Geoghegan
statistics just doesn't appreciably alter things here, I feel. The number of discrete queries that an application will execute in a week just isn't that different from the number that it will ever execute, I suspect. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-11-15 Thread Peter Geoghegan
to be logically impossible. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-11-15 Thread Peter Geoghegan
. I can see the concern though, and I suppose that given the alternative is to add a heuristic, simply using a flag may be the best way to proceed. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-11-15 Thread Peter Geoghegan
of the array by the maximum length. I guess the fact that you didn't spot it made me overconfident. :-) -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-11-15 Thread Peter Geoghegan
immediately occurs to me, though. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-11-15 Thread Peter Geoghegan
. The alternative might just be to add a new constant to the TupSortStatus enum. That might be more logical. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Index only scans wiki page

2012-11-15 Thread Peter Geoghegan
On 13 November 2012 01:25, Peter Geoghegan pe...@2ndquadrant.com wrote: Attached is a piece I wrote on the feature. That might form the basis of a new wiki page. Since no one else moved on this, I've completely replaced the existing page with the contents of the user-orientated document I

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2012-11-15 Thread Peter Geoghegan
than following my advice here. I suspect my tools - in particular, pgbench - just isn't sophisticated enough to evaluate the effectiveness of any particular model. I might have used something like Tsung, which modes workloads stochastically, instead. However, I just didn't have the time. -- Peter

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2012-11-19 Thread Peter Geoghegan
I've added this to the open commitfest. I think that a formal review is probably required here. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-11-25 Thread Peter Geoghegan
; // actually calls copy constructor - equivalent to MyClass foo(5); foo = 4; // This calls copy assignment operator -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] MySQL search query is not executing in Postgres DB

2012-11-25 Thread Peter Geoghegan
. So yes, C++ distinguishes between explicit, assignment, and implicit casting in a way that is, in broad strokes, at least as sophisticated as PostgreSQL. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Materialized views WIP patch

2012-11-26 Thread Peter Geoghegan
disregard everything or even anything else in pursuit of simplicity; just that needing a Ph.D is Postgresology, as you once put it, to do something routine to many is really hard to defend. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Materialized views WIP patch

2012-11-26 Thread Peter Geoghegan
need to overload the word snapshot? I'd just as soon invent a new word as use the Oracle one, since I don't think the term snapshot is widely recognised as referring to anything other than snapshot isolation. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] enhanced error fields

2012-12-10 Thread Peter Geoghegan
). -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [PATCH 02/14] Add support for a generic wal reading facility dubbed XLogReader

2012-12-11 Thread Peter Geoghegan
that seems like a very insignificant size. Perhaps people who live in countries with less bandwidth care about these things more. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Use gcc built-in atomic inc/dec in lock.c

2012-12-12 Thread Peter Geoghegan
to wonder if there is any evidence that this *is* actually helpful to performance. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] logical changeset generation v3 - git repository

2012-12-12 Thread Peter Geoghegan
On 9 December 2012 19:14, Andres Freund and...@2ndquadrant.com wrote: I pushed a new version which - is rebased ontop of master - is based ontop of the new xlogreader (biggest part) - is base ontop of the new binaryheap.h - some fixes - some more comments I decided to take another look at

Re: [HACKERS] [PERFORM] encouraging index-only scans

2012-12-13 Thread Peter Geoghegan
relallvisible/relpages, instead of an arbitrary constant, to estimate how many heap page fetches can be avoided during an index-only scan. Have I missed some nuance? -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2012-12-21 Thread Peter Geoghegan
/ memNowUsed, ! memtupsize), ! memtupsize * 2); I also added a brief note within tuplestore.c to the effect that the two buffer sizing strategies are not in sync. Thoughts? -- Peter

Re: [HACKERS] enhanced error fields

2012-12-21 Thread Peter Geoghegan
?? Well, I don't think we *usually* need to log *any* verbose fields. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2012-12-28 Thread Peter Geoghegan
). I think you probably should have created a PG_STAT_STATEMENTS_COLS_V1_1 macro, since that version of the module is now legacy, like *V1_0 is in HEAD. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
be done about that - you need to specify the information somewhere, and it makes sense to do it at that point. The field names are frequently expanded in the error message presented to the user anyway. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
://archives.postgresql.org/message-id/caeylb_um9z8vitjckaogg2shab1n-71doznhj2pjm2ls96q...@mail.gmail.com -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
hazardous - it breaks any kind of encapsulation that might have existed. If one person slightly refactors their code, it could break the code of another person who has never even met or talked to the first. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
routine_name is exposed for error handling purposes. Correct me if I'm mistaken, but I don't believe that ANSI SQL has anything to say about any of these error fields. You've just lifted the names of the fields from various information_schema catalogs, which is hardly the same thing. -- Peter Geoghegan

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
the function is a really bad idea, and that we should not facilitate it. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
, and I agree that it's very useful for some fields (if you can actually have a reasonable set of guarantees about where each becomes available). I just don't think that it's worth including fields like routine_name within ErrorData, and in fact it may be harmful to do so. -- Peter Geoghegan http

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
suggesting that the two are not comparable. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] enhanced error fields

2012-12-28 Thread Peter Geoghegan
a function_name field, and it was idiomatic to change the behaviour of an exception handler on the basis of the field's value, that would be equivalent. Obviously that is not the case. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] Rewriter hook

2012-12-28 Thread Peter Geoghegan
on. You can get the post-parse-analyze tree by registering a post_parse_analyze_hook (like pg_stat_statements), and the same tree *after* rule expansion by registering a planner_hook. It isn't obvious what you're missing that a hook into the rewriter would get you. -- Peter Geoghegan http

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
to a TRIGGER_NAME seems incorrect. If you think that there should be a trigger name within CONTEXT, there might be a case to be made for that, but I would prefer to have that reviewed separately. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
ERRCODE_CHECK_VIOLATION errors will lack a schema name and table name (and even then, only sometimes). Pavel originally included a constraint_schema field, because he figured that the way constraints are catalogued necessitated such a field. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
it reliably with the schema_name + table_name, though I'm not strongly encouraging that you do. So I guess we disagree on that, though I'm not *that* strongly opposed to adding back in a constraint_schema field if the extra code is deemed worth it. Does anyone else have an opinion? Tom? -- Peter

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
actually has three pg_class oid columns; conrelid, conindid and confrelid. That is all. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
will not care about any ambiguity, and even if they do, they could easily misunderstand the exact rules. The right thing to do is not have multiple constraints with the same name in flight within the same place that do different things. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
pointless without a CONSTRAINT_NAME field. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
. This whole lookup table idea presupposes that there'll only ever be one error message per constraint in the entire application. That usually isn't true for all sorts of reasons, in my experience. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2012-12-29 Thread Peter Geoghegan
sensible. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
. I don't know what to say to that. Sometimes, when deciding how to address problems like this, it's possible to arrive at slightly surprising answers by process of elimination. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] pg_stat_statements: calls under-estimation propagation

2012-12-29 Thread Peter Geoghegan
in the third-party utility building time-series data from snapshots. I currently put the probability of a collision within pg_stat_statements as 1% in the event of a pg_stat_statements.max of 10,000. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] enhanced error fields

2012-12-29 Thread Peter Geoghegan
going to insist that I hack a bunch of mechanism into this patch so that the user can unambiguously identify each constraint object, I'll do that. However, that's more code, and more complexity, that will have to be documented, for just next to no practical benefit that I can see. -- Peter

Re: [HACKERS] buffer assertion tripping under repeat pgbench load

2012-12-29 Thread Peter Geoghegan
to worry about, though). http://people.planetpostgresql.org/andrew/index.php?/archives/301-Finding-the-origin-of-problems-with-git-bisect.html If you try and do a binary search through many commits *manually*, for a bug that is this hard to reproduce, well, that's no fun. -- Peter Geoghegan http

Re: [HACKERS] enhanced error fields

2013-01-04 Thread Peter Geoghegan
about how reliably the values can be used. I think that that should be fine. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] enhanced error fields

2013-01-04 Thread Peter Geoghegan
a look upthread. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] enhanced error fields

2013-01-05 Thread Peter Geoghegan
that, assuming nothing changes. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Cascading replication: should we detect/prevent cycles?

2013-01-05 Thread Peter Geoghegan
to justify. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [PATCH 1/2] Provide a common malloc wrappers and palloc et al. emulation for frontend'ish environs

2013-01-09 Thread Peter Geoghegan
to the patchset itself). -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] enhanced error fields

2013-01-13 Thread Peter Geoghegan
available. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Timing events WIP v1

2013-01-14 Thread Peter Geoghegan
structure, facilitating machine reading and aggregation. [1] Original RFC e-mail: http://www.postgresql.org/message-id/509300f7.5000...@2ndquadrant.com -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] Parallel query execution

2013-01-15 Thread Peter Geoghegan
/caeylb_vezpkdx54vex3x30oy_uoth89xoejjw6aucjjiujs...@mail.gmail.com -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] tuplesort memory usage: grow_memtuples

2013-01-17 Thread Peter Geoghegan
On 17 January 2013 18:22, Tom Lane t...@sss.pgh.pa.us wrote: Applied with some changes: Thank you. That feedback is useful. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2013-01-20 Thread Peter Geoghegan
easily viewable within a browser on this occasion. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Doc patch making firm recommendation for setting the value of commit_delay

2013-01-21 Thread Peter Geoghegan
), but it might have been XFS. I don't recall. The operating system was Debian Lenny. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Prepared statements fail after schema changes with surprising error

2013-01-21 Thread Peter Geoghegan
, two physically distinct namespaces with the same nspname) between executions of the prepared query? -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] enhanced error fields

2013-01-26 Thread Peter Geoghegan
it. As I've said, the vast majority of the value likely to be delivered by this patch comes from the constraint_name field. That's the really compelling one, to my mind. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] enhanced error fields

2013-01-27 Thread Peter Geoghegan
On 27 January 2013 18:57, Tom Lane t...@sss.pgh.pa.us wrote: Peter Geoghegan peter.geoghega...@gmail.com writes: I think we may be talking at cross purposes here. Guarantee may have been too strong a word, or the wrong word entirely. All that I really want here is for there to be a coding

Re: [HACKERS] Re: Doc patch making firm recommendation for setting the value of commit_delay

2013-01-27 Thread Peter Geoghegan
isn't particularly relevant. I have also increased the default time that pg_test_fsync runs - I think that the kind of variability commonly seen in its output, that you yourself have reported, justifies doing so in passing. -- Regards, Peter Geoghegan commit_delay_doc.2013_01_28.patch Description

Re: [HACKERS] Re: Doc patch making firm recommendation for setting the value of commit_delay

2013-01-27 Thread Peter Geoghegan
, the cost of setting it too low could be quite high now, because the absolute values (and not just how different wal_sync_methods compare) is now important. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Re: Doc patch making firm recommendation for setting the value of commit_delay

2013-01-27 Thread Peter Geoghegan
that I no longer have that data. Of course, I could fairly easily recreate it, but I don't think I'll have time tomorrow. Is it important? Are you interested in both the insert and tpc-b cases? -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] enhanced error fields

2013-01-28 Thread Peter Geoghegan
not be a sensible approach. Perhaps I'm mistaken, but I can't imagine that it would be terribly useful to anyone (including Pavel) to have a GET DIAGNOSTICS style ROUTINE_NAME. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Hm, table constraints aren't so unique as all that

2013-01-28 Thread Peter Geoghegan
the case for fixing this, but I don't feel that it's particularly important that constraints be uniquely identifiable from the proposed new errdata fields. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] enhanced error fields

2013-01-29 Thread Peter Geoghegan
the feature means bloating up errdata). -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] embedded list v2

2012-07-04 Thread Peter Geoghegan
(0002-Remove-usage-of-lib-dllist.h-and-replace-it-by-the-n.patch) soon. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] enhanced error fields

2012-07-06 Thread Peter Geoghegan
essential to have that right away, but it's something to consider. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services eelog.2012_07_07.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] enhanced error fields

2012-07-10 Thread Peter Geoghegan
would hope that it was a well-defined subset. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] enhanced error fields

2012-07-10 Thread Peter Geoghegan
files include that new header. That said, it's not as if I feel strongly about it. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] enhanced error fields

2012-07-10 Thread Peter Geoghegan
this. Still, it ought to be possible, if not entirely straightforward, to use a pre-declaration all the same. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Closing out the June commitfest

2012-07-15 Thread Peter Geoghegan
commitments. I expect to be able to spend more time on review this week. I think that I stand a good chance of seeing at least one of those three committed. Hopefully the passing of the nominal deadline will help to focus things. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] pgbench--new transaction type

2012-07-15 Thread Peter Geoghegan
as rejected in the commitfest app? Why? It would be nice if this information was automatically posted as a comment. Surely if a patch is rejected, there should be at least a one-line explanation. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Checkpointer split has broken things dramatically (was Re: DELETE vs TRUNCATE explanation)

2012-07-17 Thread Peter Geoghegan
phase of a checkpoint, especially if an I/O scheduler like deadline is used. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] 9.2 release schedule

2012-07-21 Thread Peter Geoghegan
an earlier release date than that. Can we finish the 9.2 release notes? -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Peter Geoghegan
instead? -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] embedded list v2

2012-07-23 Thread Peter Geoghegan
On 5 July 2012 02:49, Peter Geoghegan pe...@2ndquadrant.com wrote: On 28 June 2012 19:20, Andres Freund and...@2ndquadrant.com wrote: 0001-Add-embedded-list-interface.patch Looks good now? I have a few gripes. We are passed the nominal deadline. Had you planned on getting back to me

Re: [HACKERS] enhanced error fields

2012-07-23 Thread Peter Geoghegan
Returned with Feedback. I agree that that's the right thing to do at this point. -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Peter Geoghegan
); I'm sorry, I don't follow you here. What is ffs() ? -- Peter Geoghegan http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] sortsupport for text

2012-07-23 Thread Peter Geoghegan
On 23 July 2012 16:36, Robert Haas robertmh...@gmail.com wrote: On Mon, Jul 23, 2012 at 11:34 AM, Peter Geoghegan pe...@2ndquadrant.com wrote: tss-buflen = 1 ffs(len1); I'm sorry, I don't follow you here. What is ffs() ? Sorry, fls, not ffs. I always get those mixed up. See src/port

<    1   2   3   4   5   6   7   8   9   10   >