Re: [HACKERS] Back branches vs. gcc 4.8.0

2013-04-05 Thread Peter Geoghegan
. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Back branches vs. gcc 4.8.0

2013-04-05 Thread Peter Geoghegan
style flexible arrays, so this may be the least-worst option. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 9.3 Beta1 status report

2013-04-20 Thread Peter Geoghegan
, never in a released version. * Improve grouping of sessions waiting for commit_delay (Peter Geoghegan) I think this should be under General Performance. It's definitely a performance feature. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

[HACKERS] Redundancy in comment within lock.c

2013-04-25 Thread Peter Geoghegan
Silly typo report. Line 3774 of lmgr's lock.c says: * Re-acquire a lock belonging to a transaction that was prepared, when * when starting up into hot standby mode. This has been the case since the original hot standby commit. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list

Re: [HACKERS] pg_controldata gobbledygook

2013-04-25 Thread Peter Geoghegan
affected in a similar way. So I'd be sure to document it clearly, and to perhaps preserve the old label names to avoid breaking scripts. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref

Re: [HACKERS] XLogFlush invoked about twice as many times after 9.2 group commit enhancement

2013-05-07 Thread Peter Geoghegan
on an exclusive lock on WALWriteLock within XLogFlush would always hurt throughput, when in fact it can considerably help throughput, as demonstrated by 9.3's commit_delay implementation. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

[HACKERS] local_preload_libraries logspam

2013-05-07 Thread Peter Geoghegan
level, as sometimes happens in the EXEC_BACKEND case (granted, this is just so that there is behavior equivalent to the !EXEC_BACKEND case for shared_preload_libraries). -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] local_preload_libraries logspam

2013-05-07 Thread Peter Geoghegan
seems like one of the first things you need to know about. Hence, I'd vote for DEBUG1. +1 to DEBUG1. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] XLogFlush invoked about twice as many times after 9.2 group commit enhancement

2013-05-07 Thread Peter Geoghegan
and the increased number of XLogFlush() calls are because of the new group commit behavior. The cost of a WAL write + flush is more effectively amortized, and so XLogFlush() calls becomes cheaper. I'm not prepared to make any predictions as to exactly how they might relate. -- Peter Geoghegan

Re: [HACKERS] XLogFlush invoked about twice as much after 9.2 group commit enhancement

2013-05-07 Thread Peter Geoghegan
the cost of an fsync, the more useful it is to amortize that cost among concurrently committing transactions. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal to add --single-row to psql

2013-05-13 Thread Peter Geoghegan
many of the details that you are likely to care about but are inconsequential to the semantics of the query. For example, you couldn't tell from the post-parse analysis tree if the query text was originally select all, the, columns from table or select * from table. -- Peter Geoghegan -- Sent

[HACKERS] Better handling of archive_command problems

2013-05-13 Thread Peter Geoghegan
about approaches to mitigating the problems that arise when an archive_command continually fails, and the DBA must manually clean up the mess? -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] local_preload_libraries logspam

2013-05-13 Thread Peter Geoghegan
of EXEC_BACKEND. -- Peter Geoghegan load_level.2013_05_13.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Slicing TOAST

2013-05-14 Thread Peter Geoghegan
is that the archetypal beginner project is to add some feature to psql. Well, psql is fairly feature complete these days, so finding something to do there that's likely to be accepted is probably not that easy. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Parallel Sort

2013-05-15 Thread Peter Geoghegan
comparators (even considerably more expensive than bttextcmp) for pass-by-reference Datums (where the memory locality advantage of quicksort doesn't really help so much) makes timsort much more compelling. That's why it's used for Python lists. -- Peter Geoghegan -- Sent via pgsql-hackers

Re: [HACKERS] Parallel Sort

2013-05-15 Thread Peter Geoghegan
On Wed, May 15, 2013 at 11:32 AM, Peter Geoghegan p...@heroku.com wrote: I think that this effort could justify itself independently of any attempt to introduce parallelism to in-memory sorting. I abandoned a patch to introduce timsort to Postgres, because I knew that there was no principled

Re: [HACKERS] Better handling of archive_command problems

2013-05-15 Thread Peter Geoghegan
cycle. That'd certainly be better, but I can't see a way of doing it without adding a whole bunch of mechanism to some important codepaths, like within XLogWrite(), which would be quite a hard sell. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Better handling of archive_command problems

2013-05-16 Thread Peter Geoghegan
? -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Better handling of archive_command problems

2013-05-16 Thread Peter Geoghegan
. This is unfortunate, because there is plenty of evidence that archive_command issues cause serious user pain all the time. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Vacuum, Freeze and Analyze: the big picture

2013-06-03 Thread Peter Geoghegan
various measures that make that very unlikely. It might also have something to do with our check for pre-sorted input [1], but I'm still skeptical. [1] http://www.postgresql.org/message-id/caeylb_xn4-6f1ofsf2qduf24ddcvhbqidt7jppdl_rit1zb...@mail.gmail.com -- Peter Geoghegan -- Sent via pgsql

Re: [HACKERS] Vacuum, Freeze and Analyze: the big picture

2013-06-03 Thread Peter Geoghegan
of this threshold. Am I mistaken? https://www.kernel.org/doc/Documentation/sysctl/vm.txt -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] local_preload_libraries logspam

2013-06-03 Thread Peter Geoghegan
On Mon, May 13, 2013 at 3:22 PM, Peter Geoghegan p...@heroku.com wrote: Attached patch renders all loaded library... messages DEBUG1, regardless of whether local_preload_libraries or shared_preload_libraries is involved, and regardless of EXEC_BACKEND. Can someone take a look at this, please

Re: [HACKERS] local_preload_libraries logspam

2013-06-04 Thread Peter Geoghegan
On Tue, Jun 4, 2013 at 5:46 AM, Andres Freund and...@2ndquadrant.com wrote: I don't really see a point in delaying it towards 9.4. Me neither, obviously. It's not as if someone was willing to speak in defense of the current behavior. -- Peter Geoghegan -- Sent via pgsql-hackers mailing

Re: [HACKERS] Proposal: plpgsql - for in array statement

2010-09-28 Thread Peter Geoghegan
, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Git downed?

2010-09-29 Thread Peter Geoghegan
It looks that way to me too. .Oh wait, it works now. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] ISN patch that applies cleanly with git apply

2010-10-02 Thread Peter Geoghegan
clearly explaining how that will work though - so far, it's really just been described in very broad strokes. If a regression test cannot be produced in time, is that likely to be a deal-breaker for getting this committed? -- Regards, Peter Geoghegan diff --git a/contrib/isn/ISBN.h b/contrib/isn

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-03 Thread Peter Geoghegan
continue to do our level best to hyphenate correctly for the user, but it's important to understand that we cannot guarantee correct hyphenation over time. Perhaps Jan Otto can weigh in here. -- Regards, Peter Geoghegan diff --git a/contrib/isn/ISBN.h b/contrib/isn/ISBN.h index d8d5ccd..6e6d95b 100644

Re: [HACKERS] pgadmin

2010-10-03 Thread Peter Geoghegan
This is the sort of question that is far better suited to the pgsql-gene...@postgresql.org mailing list or the pgadmin-supp...@postgresql.org mailing list, but the answer is that you should use the copy sql command: http://www.postgresql.org/docs/current/static/sql-copy.html -- Regards, Peter

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-12 Thread Peter Geoghegan
the listing of all the 628,000 assigned publisher codes that is only available in book form at a cost of €558? How might I verify the correctness of the new ISBN_range, preferably without spending €558?:-) -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-13 Thread Peter Geoghegan
, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-18 Thread Peter Geoghegan
, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-18 Thread Peter Geoghegan
country code of 979. Prior versions of the patch will outright reject these correct ISBN-13s, so I think that is a good idea. Hm, maybe just the addition of 979 is ok to back-port.  Comments? If you're not going to backport everything, I think that that's reasonable. -- Regards, Peter Geoghegan

Re: [HACKERS] ISN patch that applies cleanly with git apply

2010-10-20 Thread Peter Geoghegan
I have committed the patch and the text proposed above. Can I take it that there is no need for a formal review, where I answer various questions per http://wiki.postgresql.org/wiki/Reviewing_a_Patch? -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Integer input functions for date and timestamp

2010-10-22 Thread Peter Geoghegan
offering would need to include a variant for 'timestamp with time zone'. What's wrong with to_timestamp() and to_date()? Sure, your functions might be marginally faster, but I don't think that it's likely to be a very performance sensitive area. -- Regards, Peter Geoghegan -- Sent via pgsql

Re: [HACKERS] Large C files

2011-09-06 Thread Peter Geoghegan
was thinking about splitting up plpython.c, but it's not even on that list. ;-) IIRC the obesity of that file is something that Jan Urbański intends to fix, or is at least concerned about. Perhaps you should compare notes. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] Large C files

2011-09-06 Thread Peter Geoghegan
On 7 September 2011 00:13, Peter Geoghegan pe...@2ndquadrant.com wrote: * Within TUs, we unshadow a previously shadowed variable, so we link to a global variable rather than one local to the original/other new file. Unlikely to be a problem. Here's what I get when I compile xlog.c in the usual

Re: [HACKERS] Large C files

2011-09-06 Thread Peter Geoghegan
writing or fixing a bit of code at a time, which we're all used to, if the compiler doesn't tell you about it, your chances of catching the problem before a bug manifests itself are close to zero. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Large C files

2011-09-08 Thread Peter Geoghegan
the superfluous xlog headers are included). Does that seem reasonable? Is there interest in developing this idea further? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services nm-diff.sh Description: Bourne shell script -- Sent via pgsql-hackers

Re: [HACKERS] Large C files

2011-09-09 Thread Peter Geoghegan
of a previous pgrminclude campaign in July 2006 that It took us two weeks to mostly recover, but we were still dealing with some fallout in December. I think that makes the case for adding this tool or some refinement as a complement to pgrminclude in src/tools fairly compelling. -- Peter Geoghegan

Re: [HACKERS] Double sorting split patch

2011-09-17 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Double sorting split patch

2011-09-18 Thread Peter Geoghegan
the dependency, can we trust the developers/steering committee of the JIT (Okay, so I'm really thinking about LLVM here), and so on. That's just off the top of my head. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

[HACKERS] Inlining comparators as a performance optimisation

2011-09-19 Thread Peter Geoghegan
. Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services diff --git a/src/backend/utils/sort/tuplesort.c b/src/backend/utils/sort/tuplesort.c index 3505236..c5ac708 100644 --- a/src/backend/utils/sort/tuplesort.c +++ b/src

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-09-20 Thread Peter Geoghegan
approaching the isolated macro Vs qsort() function pointer benchmark, that's a *big* win. Sorting integers and floats is very common and important. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services inline_compar_test.tar.gz Description

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-09-21 Thread Peter Geoghegan
On 21 September 2011 01:48, karave...@mail.bg wrote: All -O2 version show 42% speedup with inlined qsort. -O0 showed 25% speedup. Thanks. Looks like the figures I posted last night were fairly conservative. Does anyone else care to report results? -- Peter Geoghegan       http://www

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-09-21 Thread Peter Geoghegan
On 21 September 2011 07:51, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: On 21.09.2011 02:53, Peter Geoghegan wrote: C stdlib quick-sort time elapsed: 2.092451 seconds Inline quick-sort time elapsed: 1.587651 seconds Does *that* look attractive to you? Not really

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-09-21 Thread Peter Geoghegan
implementation over my OS vendor's c std lib qsort(), using an isolated test-case, that does not have anything to do with that impedance mismatch. I'm not sure why you doubt that the same thing is happening within tuplesort. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] memory barriers (was: Yes, WaitLatch is vulnerable to weak-memory-ordering bugs)

2011-09-22 Thread Peter Geoghegan
is not accurate: http://msdn.microsoft.com/en-us/library/f20w0x5e(v=vs.71).aspx Besides, if it's not supported, why bother mentioning it? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Large C files

2011-09-23 Thread Peter Geoghegan
in that script on a less-than-geologic time scale. Fair point. I'm a little busy with other things right now, but I'll revisit it soon. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Large C files

2011-09-24 Thread Peter Geoghegan
-automated fashion, there'd be some other open source tool already available for us to use. As far as I know, there isn't. As we work around pgrminclude's bugs, its benefits become increasingly small and hard to quantify. If we're not going to use it, it should be removed from the tree. -- Peter

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-09-26 Thread Peter Geoghegan
should be using constants from fmgroids.h though. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] [OT?] Time-zone database down [was: Re: timezone buglet?]

2011-10-07 Thread Peter Geoghegan
conclusive to me... -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [v9.2] Fix Leaky View Problem

2011-10-10 Thread Peter Geoghegan
the perspective of code maintenance, because it had also been a tough work for me to track the depth field in this patch. Would you consider putting the depth field directly into a generic superclass node, such as the Expr node? Perhaps that approach would be neater. -- Peter Geoghegan       http://www

Re: [HACKERS] Large C files

2011-10-14 Thread Peter Geoghegan
that the #includes are redundant within Postgres, we cannot be sure that they are redundant in third party code. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] psql expanded auto

2011-11-04 Thread Peter Geoghegan
On 17 December 2010 22:12, Peter Eisentraut pete...@gmx.net wrote: I have often found myself wanting that psql automatically switch between normal and \x mode depending on the width of the output.  Would others find this useful? +1 Sounds like a very good idea. -- Peter Geoghegan

Re: [HACKERS] [PATCH] optional cleaning queries stored in pg_stat_statements

2011-11-05 Thread Peter Geoghegan
of the parser as new problems came to light. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] [PATCH] optional cleaning queries stored in pg_stat_statements

2011-11-06 Thread Peter Geoghegan
to commit the patch with that infrastructure, because the adjunct adds quite a lot of value to the patch, there is no need to have that be a blocker. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers

Re: [HACKERS] const correctness

2011-11-09 Thread Peter Geoghegan
, not a deficiency. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Core Extensions relocation

2011-11-14 Thread Peter Geoghegan
codes ISBN prefixes for the purposes of sanitising ISBNs, even though their assignment is actually controlled by a decentralised body of regional authorities. I'd vote for kicking it out of contrib. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] Core Extensions relocation

2011-11-15 Thread Peter Geoghegan
it, we give users a false sense of security about doing the right thing, when they're very probably not. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-15 Thread Peter Geoghegan
. The difference is that it's possible to imagine a scenario under which I could recommend using any one of those modules, despite their flaws. I could not contrive a reason for using contrib/isn. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-15 Thread Peter Geoghegan
of it. I think that that's more important than any additional test coverage it may bring. There's only a fairly marginal benefit at the expense of a bad user experience for anyone who should use isn. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-15 Thread Peter Geoghegan
that separates each part of the ISBN would be lost, but it is actually not visible on large ISBN websites, presumably because it's a tar-pit of a problem. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-15 Thread Peter Geoghegan
that someone can do in that situation is to write their own patch to contrib/isn. They'd then have to wait for that patch to be accepted if they didn't want to fork, which is a very bad situation indeed. This already happened once. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-16 Thread Peter Geoghegan
-understood way rather than less limited in a way that is unpredictable or difficult to reason about. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] ISN was: Core Extensions relocation

2011-11-17 Thread Peter Geoghegan
for the compacted representation). If I had a lot of time to work on fixing contrib/isn, I still wouldn't, because the correct thing to do is to produce your own domain. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-18 Thread Peter Geoghegan
we have now. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-19 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-19 Thread Peter Geoghegan
On 20 November 2011 03:29, Peter Geoghegan pe...@2ndquadrant.com wrote: ./configure CFLAGS=-fno-inline -fno-inline-small-functions (I could have disabled more -02 optimisations, but this proved sufficient to make my point) I'll isolate this further to tuplesort.c soon, which ought to be a lot

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-20 Thread Peter Geoghegan
. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-22 Thread Peter Geoghegan
look out for, as it might be tricky to remember the exact circumstances under which the optimisation kicks in by the time we're done here. I haven't had as much time as I'd like to polish this patch, or to get clearer answers. I expect to spend more time on it over the weekend. -- Peter

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-24 Thread Peter Geoghegan
lessons learned from comparetup_heap. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services processor : 0 vendor_id : GenuineIntel cpu family : 6 model : 15 model name : Intel(R) Core(TM)2 Duo CPU E6750

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-26 Thread Peter Geoghegan
in the hundreds of megabytes on a high-end server. I don't have immediate access to one, but I'm working that out. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services From 92185762297ba9819eb7f1b208db03663d9fdfa8 Mon Sep 17 00:00:00 2001

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-27 Thread Peter Geoghegan
consider multiple scanKeys (we have to at least consider them even if we know in advance from the nScankeys variable that there'll never be multiple scanKeys). Again, if the cardinality was higher, we'd probably see Not inlined do better here. -- Peter Geoghegan       http://www.2ndQuadrant.com

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-11-29 Thread Peter Geoghegan
a paradigm shifting one, and it makes parallelising qsort itself for further improvements quite a lot less attractive - there's too many other sources of overhead. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-01 Thread Peter Geoghegan
be really noticeable for plans with a sort node as their root node, but that isn't exactly a rare occurrence, particularly among large, expensive sorts. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services From

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-01 Thread Peter Geoghegan
be possible to be penny wise and pound foolish here though. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-02 Thread Peter Geoghegan
, rather than 1860.332ms. Not exactly a subtle difference. Assuming that those figures are representative of the gains to be had by a generic mechanism that does not inline/specialize across number of scanKeys, are you sure that that's worthwhile? -- Peter Geoghegan       http://www.2ndQuadrant.com

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-04 Thread Peter Geoghegan
in results_server.ods . You'll see very similar figures to results_server.ods for HEAD and for my patch, as you'd expect. I think the results speak for themselves. I maintain that we should use specialisations - that's where most of the benefit is to be found. -- Peter Geoghegan       http://www.2ndQuadrant.com

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-05 Thread Peter Geoghegan
concludes, whatever happens? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services results_server_w_heikki.ods Description: application/vnd.oasis.opendocument.spreadsheet -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-06 Thread Peter Geoghegan
other optimisations that my patch had? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] pg_stat_statements with query tree based normalization

2011-12-06 Thread Peter Geoghegan
that attempts to exercise them all is going to add other costs that dwarf the additional overhead and further muddy the waters. I intend to work through the known issues with this patch in the next couple of days. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-07 Thread Peter Geoghegan
when you look at sorting in isolation, but it's just that there's been a number of other significant wins in my patch, and of course there is overhead from a number of other areas, so perhaps it's easy to lose sight of that. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] Inlining comparators as a performance optimisation

2011-12-07 Thread Peter Geoghegan
to justify my position. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] static or dynamic libpgport

2011-12-09 Thread Peter Geoghegan
in particular (though I don't think that they have a beef with static libraries generally) - maybe they took a cue from Redhat there? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] pg_stat_statements with query tree based normalization

2011-12-10 Thread Peter Geoghegan
there were disclaimers about. I'm aware of some further bugs in the patch that Greg posted regarding the synchronisation of executor and planner plugins, so please bear with me while I squash them. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training

Re: [HACKERS] pg_dump --exclude-table-data

2011-12-14 Thread Peter Geoghegan
it as-is. Extremely minor problem noted: There are two spaces at the start of one sentence in your SGML doc updates. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] pg_dump --exclude-table-data

2011-12-14 Thread Peter Geoghegan
or worse, that standard includes being obsessed with white space. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] CommitFest 2011-11 Update

2011-12-16 Thread Peter Geoghegan
. I'll work on it tomorrow. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Replication timeout units

2011-12-20 Thread Peter Geoghegan
disables. +1 from me. That's very confusing. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] spam (http://wiki.openssi.org/go/PostgreSQL_on_OpenSSI_enabled_Knoppix)

2011-02-11 Thread Peter Geoghegan
I think that Acai berry supplements are used as part of various pyramid schemes. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Re: [COMMITTERS] pgsql: Fix blatantly uninitialized variable in recent commit.

2011-02-17 Thread Peter Geoghegan
. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Correctly producing array literals for prepared statements

2011-02-22 Thread Peter Geoghegan
all corner cases are covered, or at least enough of them to produce a net gain in usefulness? There may well be additional subtleties that have not occurred to me. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Correctly producing array literals for prepared statements

2011-02-23 Thread Peter Geoghegan
looking at you) so that might make it difficult or impossible. Yes, that question is addressed here: http://pqxx.org/development/libpqxx/wiki/BinaryTransfers . -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your

Re: [HACKERS] Correctly producing array literals for prepared statements

2011-02-23 Thread Peter Geoghegan
a general purpose drop-in replacement for PQescapeStringConn(). It might be just as misguided. -- Regards, Peter Geoghegan #include sstream #include iostream #include string #include vector #include deque #include list #include set #include pqxx/pqxx using namespace std; using namespace pqxx; struct

Re: [HACKERS] Why pfree(NULL) breaks execution?

2011-03-04 Thread Peter Geoghegan
particularly strongly about what pfree() should do one way or the other, but that isn't so; free(NULL) works on all platforms, and is required to by the standard. -- Regards, Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] pl/python tracebacks v2

2011-03-20 Thread Peter Geoghegan
of frustration about the lack of tracebacks available when writing pl/python. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Explain Nodes

2011-04-28 Thread Peter Geoghegan
The code for all nodes is in src/backend/executor. I think that you will find it useful to look at the big switch statements in ExecInitNode() and friends in execProcnode.c . -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services

[HACKERS] Process wakeups when idle and power consumption

2011-05-05 Thread Peter Geoghegan
, such as wal_writer_delay, and that suggestion could well be a bit woolly. It might be an enum value that represented various levels of concern that would default to something like 'conservative' (i.e. the current values). Thoughts? -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] Process wakeups when idle and power consumption

2011-05-05 Thread Peter Geoghegan
for signals that we expect call SetLatch() anyway, as in this case. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training and Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Process wakeups when idle and power consumption

2011-05-06 Thread Peter Geoghegan
/pgsql-hackers/2010-12/msg00401.php Fujii Masao suggests removing wal_sender_delay in that thread, and replacing it with a generic default. That does work well with my suggestion to unify these sorts of timeouts under a single GUC. -- Peter Geoghegan       http://www.2ndQuadrant.com/ PostgreSQL

<    1   2   3   4   5   6   7   8   9   10   >