Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Petr Jelinek
On 2015-09-29 13:44, Fujii Masao wrote: On Tue, Sep 29, 2015 at 12:05 PM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: Petr Jelinek wrote: On 2015-09-02 16:14, Fujii Masao wrote: On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas <robertmh...@gmail.com> wrote: On Mon, Aug 3, 2015

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-29 Thread Petr Jelinek
On 2015-09-29 05:05, Alvaro Herrera wrote: Petr Jelinek wrote: On 2015-09-02 16:14, Fujii Masao wrote: On Wed, Aug 5, 2015 at 2:16 AM, Robert Haas <robertmh...@gmail.com> wrote: On Mon, Aug 3, 2015 at 10:31 AM, Fujii Masao <masao.fu...@gmail.com> wrote: track_commit_timestamp t

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-28 Thread Petr Jelinek
Is someone updating the patch? Sorry, missed your reply. The "sesssion" is typo and it actually affects several variables around the replication origin, so I attached separate patch (which should be applied first) which fixes the typo everywhere. I reworded the comment, hopeful

Re: [HACKERS] WIP: Rework access method interface

2015-09-26 Thread Petr Jelinek
mvalidate* functions that the am defines. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postg

Re: [HACKERS] WIP: Rework access method interface

2015-09-25 Thread Petr Jelinek
this the documentation has to be updated. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] WIP: Rework access method interface

2015-09-20 Thread Petr Jelinek
sed function called amvalidate which will call all those C interfaces that are supported by current version (I agree that those interfaces like amvalidateopclass should accept just Oid). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Trainin

Re: [HACKERS] WIP: Rework access method interface

2015-09-20 Thread Petr Jelinek
On 2015-09-20 16:17, Alexander Korotkov wrote: On Sun, Sep 20, 2015 at 5:02 PM, Petr Jelinek <p...@2ndquadrant.com Hmm, we might want these functons in any case (although I think just one function which would return all am params would be better). But why is it not evident? We

Re: [HACKERS] creating extension including dependencies

2015-09-20 Thread Petr Jelinek
On 2015-09-18 04:52, Petr Jelinek wrote: On 2015-09-17 17:31, Jeff Janes wrote: If I fail to specify CASCADE and get an ERROR, I think there should be a HINT which suggests the use of CASCADE. create extension earthdistance ; ERROR: required extension "cube" is not installed

Re: [HACKERS] creating extension including dependencies

2015-09-17 Thread Petr Jelinek
rd CASCADE. Hmm, it already does? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/

Re: [HACKERS] Sequence Access Method WIP

2015-09-16 Thread Petr Jelinek
On 2015-09-16 13:21, Thom Brown wrote: On 28 July 2015 at 19:51, Petr Jelinek <p...@2ndquadrant.com <mailto:p...@2ndquadrant.com>> wrote: On 2015-07-28 20:11, Heikki Linnakangas wrote: Petr, is this enough feedback on this patch for thi

Re: [HACKERS] a funnel by any other name

2015-09-16 Thread Petr Jelinek
additional info saying if tuples are being partitioned or duplicated. In any case, let's not name any of the nodes as "Replicate". -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers maili

Re: [HACKERS] creating extension including dependencies

2015-09-15 Thread Petr Jelinek
l free to discard them if you think they are not adapted, the patch attached applies on top of Petr's patch. And /log/ is missing in src/test/modules/extensions/.gitignore. Ah sorry, I based it on my branch which didn't contain your changes. Merged. -- Petr Jelinek http

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-09-15 Thread Petr Jelinek
is, so here it is. It just removes the on start check for track_commit_timestamp being same in config and control file. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services From 49533f556d8120564ed81dc67acfcc03d2894166 Mon Se

Re: [HACKERS] WIP: Rework access method interface

2015-09-14 Thread Petr Jelinek
. The next AM type will need to add code for different AM types but that's mostly it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to

Re: [HACKERS] Horizontal scalability/sharding

2015-09-08 Thread Petr Jelinek
n issues that need solving in this area for FDWs, sharding and parallel query. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] WIP: Access method extendability

2015-09-07 Thread Petr Jelinek
methods need to be schema qualified? -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] WIP: Rework access method interface

2015-09-07 Thread Petr Jelinek
don't like the naming differences between validate_opclass and amvalidate. If you expect that the current amvalidate will only be used for opclass validation then it should be renamed accordingly. Also GetIndexAmRoutine should check the return type of the amhandler. -- Petr Jelinek

Re: [HACKERS] creating extension including dependencies

2015-09-07 Thread Petr Jelinek
On 2015-09-07 21:28, Petr Jelinek wrote: On 2015-09-07 21:09, Alvaro Herrera wrote: Andres Freund wrote: On 2015-09-07 20:56:50 +0200, Petr Jelinek wrote: Yes that sounds cleaner. Just as a side note, List is a Node and does have copy support (and we pass List as DefElem->arg from gra

Re: [HACKERS] creating extension including dependencies

2015-09-07 Thread Petr Jelinek
aint there was that it changes order of errors you get in situation when the schema is not the same as the one in control file and it also does not exist. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-

Re: [HACKERS] WIP: Rework access method interface

2015-09-07 Thread Petr Jelinek
On 2015-09-07 20:56, Alexander Korotkov wrote: On Mon, Sep 7, 2015 at 9:17 PM, Petr Jelinek <p...@2ndquadrant.com However I don't like the naming differences between validate_opclass and amvalidate. If you expect that the current amvalidate will only be used for opclass validat

Re: [HACKERS] creating extension including dependencies

2015-09-07 Thread Petr Jelinek
On 2015-09-07 21:09, Alvaro Herrera wrote: Andres Freund wrote: On 2015-09-07 20:56:50 +0200, Petr Jelinek wrote: Yes that sounds cleaner. Just as a side note, List is a Node and does have copy support (and we pass List as DefElem->arg from gram.y in several places). I know - but the l

Re: [HACKERS] checkpointer continuous flushing

2015-09-06 Thread Petr Jelinek
the struct typedefs at the top of the C file and don't mix them with function definitions (I am talking about the TableSpaceCheckpointStatus and TableSpaceCountEntry). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent

Re: [HACKERS] track_commit_timestamp and COMMIT PREPARED

2015-09-05 Thread Petr Jelinek
It includes advancement of replication origin as well. I didn't feel like doing refactor of commit code this late in 9.5 cycle though, so I went with the code duplication + note in xact.c. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Suppo

Re: [HACKERS] Freeze avoidance of very large table.

2015-09-04 Thread Petr Jelinek
On 2015-09-04 02:11, Bruce Momjian wrote: On Thu, Sep 3, 2015 at 11:37:09PM +0200, Petr Jelinek wrote: I don't understand. I'm just proposing that the source code for the extension to live in src/extensions/, and have the shared library installed by toplevel make install; I'm not suggesting

Re: [HACKERS] Freeze avoidance of very large table.

2015-09-03 Thread Petr Jelinek
ension is installed automatically. For that, you still need a superuser to run CREATE EXTENSION. +! for this -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@post

Re: [HACKERS] Horizontal scalability/sharding

2015-09-03 Thread Petr Jelinek
On 2015-09-02 19:57, Josh Berkus wrote: > On 09/01/2015 04:14 PM, Petr Jelinek wrote: >> On 2015-09-02 00:09, Josh Berkus wrote: >>> Not really, the mechanism is different and the behavior is different. >>> One critical deficiency in using binary syncrep is that y

Re: [HACKERS] Horizontal scalability/sharding

2015-09-01 Thread Petr Jelinek
rk bandwidth. > > In what way is the total network bandwitdh used in the system different > for shard copying than for sync replication? > Again, when shards are distributed over multiple DCs (or actually even multiple racks) the bandwidth and latency of local copy will be much better t

Re: [HACKERS] WIP: Rework access method interface

2015-08-31 Thread Petr Jelinek
g this new method. This function can be used in regression tests. Should I try to implement such new access method function, say 'amvalidate'? Makes sense to me to do that, should be probably optional though. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] Test code is worth the space

2015-08-15 Thread Petr Jelinek
commutator for operator ( example build output https://travis-ci.org/decibel/postgres/jobs/75692377 ). I didn't yet investigate what's causing this. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Petr Jelinek
, but that would make this patch more invasive. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Petr Jelinek
On 2015-08-10 17:47, Tom Lane wrote: Petr Jelinek p...@2ndquadrant.com writes: On 2015-08-10 16:58, Alexander Korotkov wrote: That should work, thanks! Also we can have SQL-visible functions to get amsupport and amstrategies and use them in the regression tests. SQL-visible functions would

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Petr Jelinek
some additional SQL). However I am not sure if using catalog as some sort of cache for function output is a good idea in general. IMHO it would be better to just have those options as part of CREATE and ALTER DDL for INDEX ACCESS METHODS if we store them in pg_am. -- Petr Jelinek

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Petr Jelinek
On 2015-08-10 16:58, Alexander Korotkov wrote: On Mon, Aug 10, 2015 at 5:48 PM, Tom Lane t...@sss.pgh.pa.us mailto:t...@sss.pgh.pa.us wrote: Alexander Korotkov a.korot...@postgrespro.ru mailto:a.korot...@postgrespro.ru writes: On Mon, Aug 10, 2015 at 1:12 PM, Petr Jelinek p

Re: [HACKERS] WIP: Rework access method interface

2015-08-10 Thread Petr Jelinek
, it appears not so easy to hide amsupport into AmRoutine, because it's needed for relcache. As a temporary solution it's duplicated in RelationData. I don't understand this, there is already AmRoutine in RelationData, why the need for additional field for just amsupport? -- Petr Jelinek

Re: [HACKERS] Bug? Small samples in TABLESAMPLE SYSTEM returns zero rows

2015-08-06 Thread Petr Jelinek
. There is a blog post on 2ndQ blog page which tries to describe the sampling methods visually, not sure if it's more obvious from that or not. It's somewhat broken on planet though (only title there). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support

Re: [HACKERS] Bug? Small samples in TABLESAMPLE SYSTEM returns zero rows

2015-08-06 Thread Petr Jelinek
page, the rest is API docs. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] Freeze avoidance of very large table.

2015-08-05 Thread Petr Jelinek
property, they provide namespacing so not everything has to be in pg_catalog which already has about gazilion functions. It's nice to have stuff you don't need for day to day operations separate but still available (which is why src/extensions is better than contrib). -- Petr Jelinek

Re: [HACKERS] [DOCS] max_worker_processes on the standby

2015-08-05 Thread Petr Jelinek
the the SQL interface will complain if called on the slave So +0.5 from me towards following master and removing the error message -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql

Re: [HACKERS] creating extension including dependencies

2015-07-31 Thread Petr Jelinek
On 2015-07-31 03:03, Michael Paquier wrote: On Thu, Jul 30, 2015 at 10:58 PM, Petr Jelinek wrote: On 2015-07-27 15:18, Michael Paquier wrote: Something also has not been discussed yet: what to do with new_version and old_version (the options of CreateExtensionStmt)? As of now if those options

Re: [HACKERS] creating extension including dependencies

2015-07-30 Thread Petr Jelinek
On 2015-07-27 15:18, Michael Paquier wrote: On Sun, Jul 26, 2015 at 1:01 AM, Petr Jelinek wrote: Yes that's what I meant by the change of checking order in the explanation above. I did that because I thought code would be more complicated otherwise, but apparently I was stupid

Re: [HACKERS] 64-bit XIDs again

2015-07-30 Thread Petr Jelinek
will have free space that can't be used by new tuples since the system is now in different epoch. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Sequence Access Method WIP

2015-07-28 Thread Petr Jelinek
on this in the current CF. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] creating extension including dependencies

2015-07-25 Thread Petr Jelinek
On 2015-07-25 14:37, Michael Paquier wrote: On Sat, Jul 25, 2015 at 12:59 AM, Petr Jelinek p...@2ndquadrant.com wrote: On 2015-07-22 07:12, Michael Paquier wrote: On Tue, Jul 21, 2015 at 11:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Petr Jelinek p...@2ndquadrant.com writes: ... My main

Re: [HACKERS] creating extension including dependencies

2015-07-24 Thread Petr Jelinek
On 2015-07-22 07:12, Michael Paquier wrote: On Tue, Jul 21, 2015 at 11:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Petr Jelinek p...@2ndquadrant.com writes: ... My main question is if we are ok with SCHEMA having different behavior with CASCADE vs without CASCADE. I went originally

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-24 Thread Petr Jelinek
On 2015-07-25 00:36, Tom Lane wrote: I wrote: Petr Jelinek p...@2ndquadrant.com writes: The only major difference that I see so far and I'd like you to incorporate that into your patch is that I renamed the SampleScanCost to SampleScanGetRelSize because that reflects much better the use

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-23 Thread Petr Jelinek
because that reflects much better the use of it, it isn't really used for costing, but for getting the pages and tuples of the baserel. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-23 Thread Petr Jelinek
On 2015-07-24 01:26, Petr Jelinek wrote: On 2015-07-24 00:39, Tom Lane wrote: I wrote: OK, so InitSampleScan for a function called at ExecInitSampleScan time (which we might as well make optional), and then we'll use BeginSampleScan for the function that gets the parameters. The restart

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-21 Thread Petr Jelinek
that BeginSampleScan() needs can be obtained directly from ss_currentRelation I guess, but it's somewhat strange to pass semi-initialized SampleScanState to the BeginSampleScan(). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent

Re: [HACKERS] creating extension including dependencies

2015-07-21 Thread Petr Jelinek
will go to their own schema no matter what user specifies in the command so I guess it's ok to just document that this is the behavior of CASCADE. As you say if somebody wants control over each individual extension they can't use CASCADE anyway. -- Petr Jelinek http://www

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-20 Thread Petr Jelinek
be enabled for it. Umm, we were actually doing syncscan as well before. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-20 Thread Petr Jelinek
On 2015-07-20 12:18, Petr Jelinek wrote: On 2015-07-19 22:56, Tom Lane wrote: * You might have expected me to move the tsmseqscan and tsmpagemode flags into the TsmRoutine struct, but instead this API puts equivalent flags into the SampleScanState struct. The reason for that is that it lets

Re: [HACKERS] creating extension including dependencies

2015-07-20 Thread Petr Jelinek
On 2015-07-19 17:16, Michael Paquier wrote: On Sat, Jul 18, 2015 at 8:00 AM, Petr Jelinek p...@2ndquadrant.com wrote: On 2015-07-15 06:07, Michael Paquier wrote: On Fri, Jul 10, 2015 at 11:28 PM, Tom Lane t...@sss.pgh.pa.us wrote: Andres Freund and...@anarazel.de writes: On July 10, 2015

Re: [HACKERS] pg_resetsysid

2015-07-18 Thread Petr Jelinek
On 2015-07-18 02:29, Peter Eisentraut wrote: On 6/14/15 11:29 AM, Petr Jelinek wrote: 0002 - Adds pg_resetsysid utility which changes the system id to newly generated one. 0003 - Adds -s option to pg_resetxlog to change the system id to the one specified - this is separate from the other one

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-17 Thread Petr Jelinek
On 2015-07-16 17:08, Tom Lane wrote: Petr Jelinek p...@2ndquadrant.com writes: On 2015-07-16 15:59, Tom Lane wrote: I'm not clear on whether sequence AMs would need explicit catalog representation, or could be folded down to just a single SQL function with special signature as I suggested

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-16 Thread Petr Jelinek
much at the moment, but if we ever get serious about supporting index AM extensions, I think we ought to consider doing that. +1 I think this is very relevant to the proposed sequence am patch as well. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-16 Thread Petr Jelinek
an issue. That is unless you'd like to combine the linear probing and bernoulli of course, but I don't see any benefit in doing that. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-16 Thread Petr Jelinek
that usable values are fractional or integral, they'll get sane behavior with different supplied seeds almost always producing different samples. Sounds reasonable. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent

Re: [HACKERS] TABLESAMPLE patch is really in pretty sad shape

2015-07-16 Thread Petr Jelinek
On 2015-07-16 15:59, Tom Lane wrote: Alvaro Herrera alvhe...@2ndquadrant.com writes: Petr Jelinek wrote: On 2015-07-13 00:36, Tom Lane wrote: PS: now that I've written this rant, I wonder why we don't redesign the index AM API along the same lines. It probably doesn't matter much

Re: [HACKERS] TABLESAMPLE doesn't actually satisfy the SQL spec, does it?

2015-07-16 Thread Petr Jelinek
On 2015-07-16 16:22, Tom Lane wrote: Petr Jelinek p...@2ndquadrant.com writes: On 2015-07-12 18:02, Tom Lane wrote: A possible way around this problem is to redefine the sampling rule so that it is not history-dependent but depends only on the tuple TIDs. For instance, one could hash the TID

Re: [HACKERS] creating extension including dependencies

2015-07-09 Thread Petr Jelinek
On 2015-07-07 15:41, Andres Freund wrote: On 2015-07-07 22:36:29 +0900, Fujii Masao wrote: On Mon, Jun 15, 2015 at 7:50 AM, Petr Jelinek p...@2ndquadrant.com wrote: Hi, I am getting tired installing manually required extensions manually. I was wondering if we might want to add option

Re: [HACKERS] [BUGS] BUG #13126: table constraint loses its comment

2015-07-07 Thread Petr Jelinek
On 2015-07-04 13:45, Michael Paquier wrote: On Fri, Jul 3, 2015 at 11:59 PM, Petr Jelinek wrote: Well for indexes you don't really need to add the new AT command, as IndexStmt has char *idxcomment which it will automatically uses as comment if not NULL. While I am not huge fan

Re: [HACKERS] [BUGS] BUG #13126: table constraint loses its comment

2015-07-03 Thread Petr Jelinek
On 2015-07-03 15:50, Michael Paquier wrote: On Thu, Jul 2, 2015 at 11:16 PM, Petr Jelinek p...@2ndquadrant.com wrote: I was going through the code and have few comments: - Why do you change the return value of TryReuseIndex? Can't we use reuse the same OidIsValid(stmt-oldNode) check

Re: [HACKERS] [BUGS] BUG #13126: table constraint loses its comment

2015-07-02 Thread Petr Jelinek
that except for moving some of the nesting out to another function. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] Dereferenced pointer in tablesample.c

2015-06-30 Thread Petr Jelinek
the above I would just remove the if statement here - it's not present in any other code that does ExecInitExpr/ExecEvalExpr either. It's most likely relic of the code that didn't treat the repeatable separately and just put it into args List. Patch attached. -- Petr Jelinek http

Re: [HACKERS] Tab completion for TABLESAMPLE

2015-06-19 Thread Petr Jelinek
On 2015-06-19 09:08, Brendan Jurd wrote: On Sun, 14 Jun 2015 at 20:44 Petr Jelinek p...@2ndquadrant.com mailto:p...@2ndquadrant.com wrote: looks like I omitted psql tab completion from the TABLESAMPLE patch. The attached patch adds it. Hi Petr, I'm doing an initial review

Re: [HACKERS] Inheritance planner CPU and memory usage change since 9.3.2

2015-06-18 Thread Petr Jelinek
On 2015-06-18 22:04, Tom Lane wrote: By the by, the tablesample additions to range_table_mutator are obviously broken. Bah, typos. Attached patch corrects them. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff

Re: [HACKERS] Inheritance planner CPU and memory usage change since 9.3.2

2015-06-18 Thread Petr Jelinek
On 2015-06-19 00:38, Petr Jelinek wrote: On 2015-06-18 22:04, Tom Lane wrote: By the by, the tablesample additions to range_table_mutator are obviously broken. Bah, typos. Attached patch corrects them. Actually it should probably look more like this, sorry. -- Petr Jelinek

Re: [HACKERS] Inheritance planner CPU and memory usage change since 9.3.2

2015-06-18 Thread Petr Jelinek
On 2015-06-19 01:04, Petr Jelinek wrote: On 2015-06-19 00:38, Petr Jelinek wrote: On 2015-06-18 22:04, Tom Lane wrote: By the by, the tablesample additions to range_table_mutator are obviously broken. Bah, typos. Attached patch corrects them. Actually it should probably look more like

Re: [HACKERS] Sequence Access Method WIP

2015-06-17 Thread Petr Jelinek
issue here. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] 9.5 release notes

2015-06-14 Thread Petr Jelinek
On 2015-06-14 03:02, Bruce Momjian wrote: On Sat, Jun 13, 2015 at 05:47:59AM -0300, Alvaro Herrera wrote: Petr Jelinek wrote: Hi, + listitem + para +Add typeJSONB/ functions functionjsonb_set()/ and +functionjsonb_pretty/ (Dmitry Dolgov, Andrew Dunstan

[HACKERS] Tab completion for TABLESAMPLE

2015-06-14 Thread Petr Jelinek
Hi, looks like I omitted psql tab completion from the TABLESAMPLE patch. The attached patch adds it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c

[HACKERS] pg_resetsysid

2015-06-14 Thread Petr Jelinek
.anarazel.de -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services From f587fd47c9e43f5c08cf840978ff21b64f39d24d Mon Sep 17 00:00:00 2001 From: Petr Jelinek pjmo...@pjmodos.net Date: Sun, 14 Jun 2015 16:23:39 +0200 Subject: [PATCH 4

Re: [HACKERS] On columnar storage

2015-06-14 Thread Petr Jelinek
purpose (see indexes). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

[HACKERS] creating extension including dependencies

2015-06-14 Thread Petr Jelinek
that implements this. I call it prototype mainly because the syntax (CREATE EXTENSION ... RECURSIVE) could be improved, I originally wanted to do something like INCLUDING DEPENDENCIES but that need news (unreserved) keyword and I don't think it's worth it, plus it's wordy. -- Petr Jelinek

Re: [HACKERS] 9.5 release notes

2015-06-12 Thread Petr Jelinek
of the review. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] jsonb - path

2015-06-10 Thread Petr Jelinek
... Proceeding from that, I'm rather inclined to say that the answer is to rename the operator rather than remove it, and that's what I'm going to do unless there's a groundswell that says no. +1 for renaming -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] [CORE] Restore-reliability mode

2015-06-08 Thread Petr Jelinek
it over to other machines, etc. We should be lowering the barrier to user based testing as much as possible and doing alpha with packages is exactly how we do that. IMHO the only real discussion here is if current 9.5 is ready for user testing and FWIW I thin it is. -- Petr Jelinek

Re: [HACKERS] Further issues with jsonb semantics, documentation

2015-06-05 Thread Petr Jelinek
: {a: 2}}' - '/c/a'; and we will again silently do nothing. That's going to cause bugs in applications using this. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Order of columns in query is important?!

2015-05-26 Thread Petr Jelinek
the tuple again). If this was the case, changing column order would lead to performance increase, not decrease as reported. My guess would be same as Amits, it's most likely the additional projection step. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7

[HACKERS] Compiler warning about overflow in xlog.c

2015-05-23 Thread Petr Jelinek
with the .partial suffix but the code should still be fixed which is what attached one-line patch does. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services xlog-overflow-fix.diff Description: binary/octet-stream -- Sent via pgsql-hackers

Re: [HACKERS] jsonb_set: update or upsert default?

2015-05-23 Thread Petr Jelinek
); jsonb_set -- {baz: 1, foo: bar} (1 row) If I use empty jsonb object it does not work anymore: # select jsonb_set('{}', '{foo}', 'bar', true); jsonb_set --- {} (1 row) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development

Re: [HACKERS] jsonb concatenate operator's semantics seem questionable

2015-05-19 Thread Petr Jelinek
for precedents. Given the above I would vote to just provide the function and leave out the || operator for now. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] RFC: Non-user-resettable SET SESSION AUTHORISATION

2015-05-19 Thread Petr Jelinek
that idea is quite sound. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] jsonb concatenate operator's semantics seem questionable

2015-05-17 Thread Petr Jelinek
described by Peter. So there is definitely point for both, at this time we just support only one of them, that's all. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Sequence Access Method WIP

2015-05-13 Thread Petr Jelinek
at later time. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Sequence Access Method WIP

2015-05-13 Thread Petr Jelinek
is something that we agreed on several months ago so there was plenty of time to revisit that decision.) -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Triaging the remaining open commitfest items

2015-05-13 Thread Petr Jelinek
said he won't have time for this one before freeze so I guess it can be pushed to 9.6. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] feature freeze and beta schedule

2015-05-01 Thread Petr Jelinek
but other than that the infrastructure part is definitely committable. The current approach is really good. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] INSERT ... ON CONFLICT UPDATE/IGNORE 4.0

2015-05-01 Thread Petr Jelinek
towards what Robert says. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Petr Jelinek
On 01/05/15 15:01, Bruce Momjian wrote: On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related to this. Can you show me the commit? 865f14a2d31af23a05bbf2df04c274629c5d5c4d -- Petr Jelinek

Re: [HACKERS] proposal: disallow operator = and use it for named parameters

2015-05-01 Thread Petr Jelinek
On 01/05/15 15:17, Bruce Momjian wrote: On Fri, May 1, 2015 at 03:13:28PM +0200, Petr Jelinek wrote: On 01/05/15 15:01, Bruce Momjian wrote: On Fri, May 1, 2015 at 05:25:53AM +0200, Pavel Stehule wrote: It is done Uh, I am not sure why you say that as I don't see any commit related

Re: [HACKERS] Replication identifiers, take 4

2015-04-29 Thread Petr Jelinek
in the origin.h rather than in the origin.c as the DoNotReplicateId macro uses UINT16_MAX and is also used in xact.c. I think correct fix is using PG_UINT16_MAX. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql

Re: [HACKERS] alternative compression algorithms?

2015-04-29 Thread Petr Jelinek
the pglz_decompress is still called every time. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] mogrify and indent features for jsonb

2015-04-29 Thread Petr Jelinek
On 27/04/15 18:46, Petr Jelinek wrote: On 18/04/15 20:35, Dmitry Dolgov wrote: Sorry for late reply. Here is a slightly improved version of the patch with the new `h_atoi` function, I hope this implementation will be more appropriate. It's better, but a) I don't like the name of the function

Re: [HACKERS] INSERT ... ON CONFLICT syntax issues

2015-04-28 Thread Petr Jelinek
On 28/04/15 16:44, Andres Freund wrote: On 2015-04-28 10:40:10 -0400, Stephen Frost wrote: * Andres Freund (and...@anarazel.de) wrote: On 2015-04-28 16:36:28 +0200, Petr Jelinek wrote: I am also very sure that every time I'll write this statement I will have to look into manual for the names

Re: [HACKERS] mogrify and indent features for jsonb

2015-04-27 Thread Petr Jelinek
. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] INSERT ... ON CONFLICT syntax issues

2015-04-26 Thread Petr Jelinek
) or ON CONFLICT [WITH] (foo) both seem acceptable. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org

Re: [HACKERS] Replication identifiers, take 4

2015-04-24 Thread Petr Jelinek
only be called if a origin was setup with + * replident_session_setup(). I also think the replident_checkpoint file should be renamed to replorigin_checkpoint. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via

Re: [HACKERS] Freeze avoidance of very large table.

2015-04-23 Thread Petr Jelinek
(and potentially other info) inline for each tuple but have some info in header only for tuples that need it. That might have bad performance side effects of course, but there are definitely some potential ways of doing things differently which we could explore. -- Petr Jelinek http://www

Re: [HACKERS] Reducing tuple overhead

2015-04-23 Thread Petr Jelinek
it. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

<    3   4   5   6   7   8   9   10   11   12   >