om heap using malloc outside critical section. The size of the
memory block is 4 * BkpBlock header + 4 * BLCKSZ.
Thank you,
On Mon, Aug 18, 2014 at 10:40 PM, Robert Haas wrote:
> On Thu, Jul 3, 2014 at 3:58 PM, Rahila Syed
> wrote:
> > Updated version of patches are attached.
>
Freund
> wrote:
> > On 2014-08-18 13:06:15 -0400, Robert Haas wrote:
> >> On Mon, Aug 18, 2014 at 7:19 AM, Rahila Syed
> wrote:
> >> >>According to the measurement result, the amount of WAL generated in
> >> >>"Multiple Blocks in one run&quo
1.25
pglz 1.14 1.16
This shows compression ratios of both the scenarios Multiple blocks and
single block are nearly same for this benchmark.
Thank you,
Rahila Syed
y guc. There's the 'full_page_writes' guc and I see little
>reaason to deviate from its name.
Yes. This will be renamed to full_page_compression according to suggestions
earlier in the discussion.
Thank you,
Rahila Syed
On Fri, Jul 11, 2014 at 12:00 PM, And
ne in the patch does not involve reporting OOM error in case
of failure. IIUC, this eliminates the probability of PANIC in critical
section. So, I think keeping this allocation in critical section should be
fine. Am I missing something?
Thank you,
Rahila Syed
On Mon, Jul 7, 2014 at 4:43 PM
Thank you for review comments.
>There are still numerous formatting changes required, e.g. spaces around
>"=" and correct formatting of comments. And "git diff --check" still has
>a few whitespace problems. I won't point these out one by one, but maybe
>you should run pgindent
I will do this.
>C
Hello,
The patch on compilation gives following error,
mcxt.c: In function ‘MemoryContextAllowInCriticalSection’:
mcxt.c:322: error: ‘struct MemoryContextData’ has no member named
‘allowInCriticalSection’
The member in MemoryContextData is defined as 'allowInCritSection' while
the MemoryContextA
Hello ,
>I have a few preliminary comments about your patch
Thank you for review comments.
>the patch creates src/common/lz4/.travis.yml, which it shouldn't.
Agree. I will remove it.
>Shouldn't this use palloc?
palloc() is disallowed in critical sections and we are already in CS while
executing
. Higher four bits can be used to indicate state of compression i.e
off,lz4,snappy,pglz.
The flag can be extended to incorporate more compression algorithms added
in future if any.
What is your opinion on this?
Thank you,
Rahila Syed
On Tue, May 27, 2014 at 9:27 AM, Rahila Syed
wrote:
> He
, 2014 at 8:04 PM, Fujii Masao wrote:
> On Tue, May 27, 2014 at 12:57 PM, Rahila Syed
> wrote:
> > Hello All,
> >
> > 0001-CompressBackupBlock_snappy_lz4_pglz extends patch on compression of
> > full page writes to include LZ4 and Snappy . Changes include making
Hello All,
0001-CompressBackupBlock_snappy_lz4_pglz extends patch on compression of
full page writes to include LZ4 and Snappy . Changes include making
"compress_backup_block" GUC from boolean to enum. Value of the GUC can be
OFF, pglz, snappy or lz4 which can be used to turn off compression or
101 - 111 of 111 matches
Mail list logo
