Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-03 Thread Robert Haas
On Jan 3, 2010, at 12:31 PM, Tom Lane t...@sss.pgh.pa.us wrote: In practice the reasonable engineering alternatives may just be to do what KaiGai's patch does, or to do nothing. In that case I think a good argument can be made for the latter. Nobody has ever complained about this from the

Re: [HACKERS] pg_migrator issues

2010-01-03 Thread Robert Haas
Bruce, Sorry for not having replied sooner... On Sun, Jan 3, 2010 at 5:43 PM, Bruce Momjian br...@momjian.us wrote: 1)  Right now pg_migrator preserves relfilenodes for TOAST files because this is required for proper migration.  Now that we have shown that strategically-placed global

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-03 Thread Robert Haas
On Sun, Jan 3, 2010 at 10:17 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Robert Haas robertmh...@gmail.com wrote: I have reviewed this patch and I think it looks pretty good.  A couple of minor nits: - There are needless whitespace changes in the definition of struct Counters

Re: [HACKERS] PATCH: Add hstore_to_json()

2010-01-03 Thread Robert Haas
On Sun, Jan 3, 2010 at 11:00 AM, Andrew Dunstan and...@dunslane.net wrote: Hitoshi Harada wrote: 2010/1/3 Andrew Dunstan and...@dunslane.net: Hitoshi Harada wrote: A question: Isn't there no possibility that we have our own implementation to handle JSON (i.e. no use of external libraries)?

Re: [HACKERS] pg_read_file() and non-ascii input file

2010-01-03 Thread Robert Haas
On Sun, Jan 3, 2010 at 9:10 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Robert Haas robertmh...@gmail.com wrote: If we want to keep backward compatibility, the issue can be fixed by adding pg_verifymbstr() to the function. I don't feel good about changing the return type

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-03 Thread Robert Haas
2010/1/3 KaiGai Kohei kai...@ak.jp.nec.com: (2010/01/04 4:06), Robert Haas wrote: On Jan 3, 2010, at 12:31 PM, Tom Lane t...@sss.pgh.pa.us wrote: In practice the reasonable engineering alternatives may just be to do what KaiGai's patch does, or to do nothing. In that case I think a good

Re: [HACKERS] New VACUUM FULL

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 3:04 AM, Simon Riggs si...@2ndquadrant.com wrote: This is a more cautious approach. Completely removing VFI in this release is a big risk that we need not take; we have little to gain from doing so and putting it back again will be harder. I am always keen to push

Re: [HACKERS] [BUG?] strange behavior in ALTER TABLE ... RENAME TO on inherited columns

2010-01-04 Thread Robert Haas
On Sun, Jan 3, 2010 at 11:18 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: 2010/1/3 KaiGai Kohei kai...@ak.jp.nec.com:  if (number_of_attribute_origin(myrelid, oldattname) 1)      ereport(ERROR, ...); Am I missing something? That sounds about right to me

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 1:39 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Hmm, I see this needs to be rebased over Tom's latest changes, but the conflict I got was in syscache.h, rather than syscache.c.  Not sure if that's what you were going

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 10:42 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Robert Haas escribió: Hmm, I see this needs to be rebased over Tom's latest changes, but the conflict I got was in syscache.h, rather than syscache.c.  Not sure if that's what you were going for or if there's

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 1:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: My only objection to that is that if we're going to add attoptions also, I'd like to get this committed first before I start working on that, and we're running short on time.  If you

Re: [HACKERS] pg_migrator issues

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 2:11 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: 2)  Right now pg_migrator renames old tablespaces to .old, which fails if the tablespaces are on mount points.  I have already received a report of such a failure. I thought it was impossible to

Re: I: [HACKERS] TODO: Allow substring/replace() to get/set bit values

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 5:17 AM, Leonardo F m_li...@yahoo.it wrote: Re-reading the docs it looks like the only thing missing is get/set_bit for bit string. Substring is already implemented for bit string, and I don't really know if replace is useful at all. (sorry if the other mail came

Re: [HACKERS] New VACUUM FULL

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 11:57 AM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-01-04 at 10:31 -0500, Robert Haas wrote: On Mon, Jan 4, 2010 at 3:04 AM, Simon Riggs si...@2ndquadrant.com wrote: This is a more cautious approach. Completely removing VFI in this release is a big risk

Re: [HACKERS] pg_migrator issues

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 2:52 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jan 4, 2010 at 2:11 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: 2) ?Right now pg_migrator renames old tablespaces to .old, which fails if the tablespaces are on mount

Re: [HACKERS] New VACUUM FULL

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 3:51 PM, Simon Riggs si...@2ndquadrant.com wrote: On Mon, 2010-01-04 at 12:05 -0800, Josh Berkus wrote: What I should have said, in addition: VFI will be kept as a non-default option, in case it is required. We will document that use of VFI will not work correctly

Re: [HACKERS] pg_migrator issues

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 3:33 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jan 4, 2010 at 2:52 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: On Mon, Jan 4, 2010 at 2:11 PM, Bruce Momjian br...@momjian.us wrote: Alvaro Herrera wrote: 2) ?Right now

Re: [HACKERS] pg_migrator issues

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 4:53 PM, Bruce Momjian br...@momjian.us wrote: Robert Haas wrote: What doesn't work if we just don't rename the tablespace at all? ?And can't we put some smarts into the backend to handle that thing? Well, when you restore the old dump's schema into the new

Re: [HACKERS] KNNGiST for knn-search (WIP)

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 5:33 PM, Paul Ramsey pram...@cleverelephant.ca wrote: I'm sure whatever conclusion -hackers comes to in the end will be the best for pgsql, and I'll be supportive. But until then, let me note from the PostGIS point-of-view: sure would be great to get this in for 8.5 :)

Re: [HACKERS] Red-black tree for GIN

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 8:12 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Robert Haas escribió: I did a quick read-through of this, and one question that immediately occurred to me is that rbtree.c says that it is adopted from http://algolist.manual.ru/ds/rbtree.php.  But I'm not sure

Re: [HACKERS] ECPG DESCRIBE [OUTPUT] support

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 1:51 PM, Boszormenyi Zoltan z...@cybertec.at wrote: new patch is attached. Modified according to the new DB2 / Sybase compatible SQLDA structure. ECPGdescribe() has an int compat parameter, because: - the (struct prepared_statement *)-stmt -compat is not set, and - it's

Re: [HACKERS] New VACUUM FULL

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 8:35 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jan 4, 2010 at 3:51 PM, Simon Riggs si...@2ndquadrant.com wrote: Changes required to remove it are at least these places * most of vacuum.c * visibility checks * heap tuple

Re: [HACKERS] Verifying variable names in pgbench

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 10:00 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: We can remove the complexity if we give up showing the command (arg0) in error messages. Shall we remove it? Simplified patch attached. Here is the

[HACKERS] Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane t...@postgresql.org wrote: Log Message: --- Remove too-smart-for-its-own-good optimization of not overwriting the output files when they haven't changed.  This confuses make because the build fails to update the file timestamps, and so it keeps

Re: [HACKERS] Verifying variable names in pgbench

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 10:44 PM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Robert Haas robertmh...@gmail.com wrote: What is currently done for other, similar error messages? Current error messages are:  for commands: context: out of memory  for others  : Couldn't allocate

[HACKERS] Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 10:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane t...@postgresql.org wrote: Log Message: --- Remove too-smart-for-its-own-good optimization of not overwriting the output files when

[HACKERS] Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 10:53 PM, Greg Stark gsst...@mit.edu wrote: On Tue, Jan 5, 2010 at 3:42 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 4, 2010 at 9:34 PM, Tom Lane t...@postgresql.org wrote: Log Message: --- Remove too-smart-for-its-own-good optimization

[HACKERS] Re: [COMMITTERS] pgsql: Remove too-smart-for-its-own-good optimization of not overwriting

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 11:03 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I think you're dismissing the idea too cavalierly.  If A generates B, A is inevitably changed frequently, but the changes to A affect B only rarely, this is a good trick. The only

Re: [HACKERS] quoting psql varible as identifier

2010-01-04 Thread Robert Haas
On Mon, Jan 4, 2010 at 2:51 PM, Pavel Stehule pavel.steh...@gmail.com wrote: 2010/1/4 Tom Lane t...@sss.pgh.pa.us: Pavel Stehule pavel.steh...@gmail.com writes: I have one question. If I understand well, the function fmtId isn't multibyte safe? So why is possible to use it in pg_dump?

Re: [HACKERS] PATCH: Add hstore_to_json()

2010-01-04 Thread Robert Haas
On Sun, Jan 3, 2010 at 1:51 PM, David E. Wheeler da...@kineticode.com wrote: On Jan 3, 2010, at 8:00 AM, Andrew Dunstan wrote: I think the minimal functionality I'd want is:   convert record to JSON   convert JSON to record With caveats as to dealing with nested structures (can a record be

Re: [HACKERS] execute sql commands in core

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 12:56 AM, black light blacklight1...@gmail.com wrote: Hi, I want to add some hard-wired extra authentication codes in my PG. The only problem is how to access tables to get/change information from core (auth.c)? I have changed the SPI functions to use them but it was

Re: [HACKERS] Thoughts on statistics for continuously advancing columns

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 7:49 AM, Chetan Suttraway chetan.suttra...@enterprisedb.com wrote: if we can treat this case as similar to that of merging of histograms in case of joins involving 2 tables and generating the histograms for the cartesian (result) node, ...which you can't, because it's

Re: I: [HACKERS] TODO: Allow substring/replace() to get/set bit values

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 3:58 AM, Leonardo F m_li...@yahoo.it wrote: You might want to search the archives (or the wiki history, or the CVS history if it's been there since before we moved the TODO list to the wiki) for discussion of why that item was added to the TODO in the first place. I

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-05 Thread Robert Haas
On Mon, Jan 4, 2010 at 1:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: My only objection to that is that if we're going to add attoptions also, I'd like to get this committed first before I start working on that, and we're running short on time.  If you

Re: I: [HACKERS] TODO: Allow substring/replace() to get/set bit values

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 10:45 AM, Leonardo F m_li...@yahoo.it wrote: As you say, there's really no point in changing the internal representation, and if you don't find replace() useful either, then why are you even working on this at all? I would like a get_bit / set_bit for bit strings, as I

Re: [HACKERS] pg_migrator issues

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 11:06 AM, Alvaro Herrera alvhe...@commandprompt.com wrote: Tom Lane wrote: Bruce Momjian br...@momjian.us writes: I liked the idea, but I listed it as item #2 and no one else said they liked it.  The only complexity I can see with the idea is that doing an upgrade

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 12:24 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Tom Lane wrote: Log Message: --- Get rid of the need for manual maintenance of the initial contents of pg_attribute, by having genbki.pl derive the information from the various catalog header files.

Re: [HACKERS] Stats for inheritance trees

2010-01-05 Thread Robert Haas
On Tue, Dec 29, 2009 at 9:12 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yep.  It would also lower the barrier to future innovations of that type, which would be a good thing, IMO.  Unfortunately we'd likely need to continue to support the existing syntax

Re: [HACKERS] Re: [COMMITTERS] pgsql: Get rid of the need for manual maintenance of the initial

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 12:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Is there by any chance some other, conflicting Catalog.pm on that machine? Even if there is, shouldn't the use of perl -I ensure our version gets loaded? I would certainly think so

Re: [HACKERS] Stats for inheritance trees

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 1:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Another option would be to call it inherits_ndistinct, or something like that, which seems a little more readable, but not great: I don't think there's going to be any getting around

Re: [HACKERS] Stats for inheritance trees

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 1:09 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Jan 5, 2010 at 1:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Another option would be to call it inherits_ndistinct, or something like that, which seems a little more

Re: [HACKERS] Stats for inheritance trees

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 1:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: It's probably also worth noting that the reason I used DISTINCT originally is because it's already a keyword. True. It occurs to me that the pg_stats view already exposes n_distinct

Re: [HACKERS] true serializability and predicate locking

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 2:14 PM, Jeff Davis pg...@j-davis.com wrote: I have a question regarding true serializability and predicate locking. There's some context on the wiki page: http://wiki.postgresql.org/wiki/Serializable under the heading Predicate Locking. If you have the following

Re: [HACKERS] Stats for inheritance trees

2010-01-05 Thread Robert Haas
On Tue, Dec 29, 2009 at 9:12 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yep.  It would also lower the barrier to future innovations of that type, which would be a good thing, IMO.  Unfortunately we'd likely need to continue to support the existing syntax

Re: [HACKERS] Writeable CTEs

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 4:20 PM, Josh Berkus j...@agliodbs.com wrote: On 1/5/10 9:45 AM, Marko Tiikkaja wrote: On 2010-01-05 19:21 +0200, Greg Stark wrote: with t as (delete from foo returning *) select * from t where x=? applications will almost certainly expect the number to match the

Re: [HACKERS] Auto-extending table partitions?

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 8:00 PM, u235sentinel u235senti...@gmail.com wrote: http://www.postgresql.org/docs/8.4/static/ddl-partitioning.html Is there a way to automatically extend table partitions?  I'm curious if / when a table is getting full if there is a way for postgres to create

Re: [HACKERS] xpath improvement suggestion

2010-01-05 Thread Robert Haas
On Tue, Jan 5, 2010 at 6:09 PM, Arie Bikker a...@abikker.nl wrote: Hi all, Well I had  to burn some midnight oil trying to figure out why a construct like SELECT xpath('name()','a/'); doesn't give the expected result. Kept getting an empty array:  xpath - {} instead of the

[HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
The fastgetattr() attempts to make provision for the case where isnull is a NULL pointer, but it doesn't seem to work. I tried it and got: relcache.c:494: error: invalid use of void expression relcache.c:494: error: invalid use of void expression relcache.c:494: warning: left-hand operand of

Re: [pgsql-www] [HACKERS] tribble.postgresql.org - planned maintenance downtime

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 9:42 AM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: all services should be up now and again sorry for the delays... No, thank you for maintaining this for the rest of us! ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Status of plperl inter-sp calling

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 9:46 AM, Tom Lane t...@sss.pgh.pa.us wrote: Tim Bunce tim.bu...@pobox.com writes: For my own benefit, being a PostgreSQL novice, could you expand a little? For example, given two stored procedures, A and V, where V is marked VOLATILE and both are plperl. How would having

Re: [HACKERS] patch - per-tablespace random_page_cost/seq_page_cost

2010-01-06 Thread Robert Haas
On Tue, Jan 5, 2010 at 10:17 AM, Robert Haas robertmh...@gmail.com wrote: On Mon, Jan 4, 2010 at 1:48 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: My only objection to that is that if we're going to add attoptions also, I'd like to get this committed first

Re: [HACKERS] Auto-extending table partitions?

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 12:06 PM, David Fetter da...@fetter.org wrote: On Tue, Jan 05, 2010 at 08:50:25PM -0700, u235sentinel wrote: Robert Haas wrote: Getting full? ...Robert Ok.  Bad analogy.  We have the tables setup to write data according to the month it was loaded.  We have

Re: [HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 9:43 AM, Robert Haas robertmh...@gmail.com wrote: The fastgetattr() attempts to make provision for the case where isnull is a NULL pointer, but it doesn't seem to work.  I tried it and got: relcache.c:494: error: invalid use of void expression relcache.c:494: error

Re: [HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 1:05 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: The fastgetattr() attempts to make provision for the case where isnull is a NULL pointer, but it doesn't seem to work.  I tried it and got: relcache.c:494: error: invalid use of void

Re: [HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 1:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Spoke with Bruce on IM and we think the best option is to just remove the NULL tests.  Since it's been this way for 11 years, presumably nobody is trying to use it with a NULL fourth

Re: [HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 1:38 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Well, that comment is a bit misleading too, since a pointer with a NULL value might work but a literal NULL certainly doesn't. I think (bool *) NULL would work.  What your compiler

Re: [HACKERS] fastgetattr isNull

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 1:16 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Spoke with Bruce on IM and we think the best option is to just remove the NULL tests.  Since it's been this way for 11 years, presumably nobody is trying to use it with a NULL fourth

Re: I: [HACKERS] TODO: Allow substring/replace() to get/set bit values

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 1:21 PM, Leonardo F m_li...@yahoo.it wrote: To sum up: 1) a new function, get_bit, that calls substring 2) a new function, overlay, that replaces bits (starting at a certain position) 3) a new function, set_bit, that calls overlay That seems reasonable to me.  

[HACKERS] unresolved bugs

2010-01-06 Thread Robert Haas
Over the past few months, I've been attempting to keep tracks of which postings on pgsql-bugs have not gotten a response and to respond to those where I have a clue what the issue might be. However, there are a few that I don't really have an idea about which look like they might be real bugs...

Re: [HACKERS] unresolved bugs

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 4:00 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Robert Haas escribió: Over the past few months, I've been attempting to keep tracks of which postings on pgsql-bugs have not gotten a response and to respond to those where I have a clue what the issue might

Re: [HACKERS] unresolved bugs

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 4:10 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: Robert Haas wrote: On Wed, Jan 6, 2010 at 4:00 PM, Alvaro Herrera alvhe...@commandprompt.com wrote: Robert Haas escribió: Over the past few months, I've been attempting to keep tracks of which postings

Re: [HACKERS] Serializable Isolation without blocking

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 4:29 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: And use git so you can keep merging up to CVS HEAD easily. Regarding this, I was thinking that it would make sense to use a repository on git.postgresql.org

Re: [HACKERS] Cancelling idle in transaction state

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 4:37 PM, Joachim Wieland j...@mcknight.de wrote: On Fri, Jan 1, 2010 at 10:45 PM, Simon Riggs si...@2ndquadrant.com wrote: CancelRequest's behaviour currently equates to SIGINT, so processCancelRequest() can only use SIGINT if SIGINT's behaviour remains same. I would

Re: [HACKERS] unresolved bugs

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 6:09 PM, Andrew Dunstan and...@dunslane.net wrote: Alvaro Herrera wrote: Robert Haas escribió: On Wed, Jan 6, 2010 at 4:10 PM, Stefan Kaltenbrunner ste...@kaltenbrunner.cc wrote: hmm maybe I should resurrect the bugzilla testbed again :) If we're going to use a bug

[HACKERS] Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 6:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: I wrote: With this patch, a CLOBBER_CACHE_ALWAYS build starts falling apart all over the place :-(.  Looks like you blew the memory management somehow; it appears to be using a previously pfree'd pointer: Actually, there were

Re: [HACKERS] Serializable Isolation without blocking

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 5:04 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Robert Haas robertmh...@gmail.com wrote: I think you should have users/kgrittner/postgres.git rather than serializable.git.  serializable sounds more like the branch name. Hmmm  On a multi-year project

Re: [HACKERS] Testing with concurrent sessions

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 4:52 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: David E. Wheeler da...@kineticode.com wrote: Last I heard, Andrew was willing to require Test::More for testing, so that a Perl script could handle multiple psql connections (perhaps forked) and output test

Re: [HACKERS] Testing with concurrent sessions

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 8:40 PM, Andrew Dunstan and...@dunslane.net wrote: Doing this without DBI is going to be ten times harder than doing it with DBI.  Are we really sure that's not a viable option? In the buildfarm? Yes, I think so. The philosophy of the buildfarm is that it should do what

Re: [HACKERS] Testing with concurrent sessions

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 9:26 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: It just seems crazy to me to try to test anything without proper language bindings.  Opening a psql session and parsing the results seems extraordinarily painful.  I wonder if it would

[HACKERS] Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 6:11 PM, Tom Lane t...@sss.pgh.pa.us wrote: 3. Invoking tablespace_reloptions while switched into CacheMemoryContext.  This isn't a crasher, but it strikes me as a bad idea because if reloptions.c happens to leak anything, that'll represent a permanent (session-lifespan)

[HACKERS] Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 10:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: What tools do we have for identifying memory leaks? User complaints :-( YGTBFKM. It seems like we should have a tool that dumps out every memory context in the system

Re: [HACKERS] Testing with concurrent sessions

2010-01-06 Thread Robert Haas
On Wed, Jan 6, 2010 at 10:00 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: For basic regression tests, yeah, we'd probably like to keep that Perl-free. OK.  Is parallel psql the only reasonable option? It seems so, assuming you're willing to concede that it is a reasonable option in

[HACKERS] memory context debugging

2010-01-07 Thread Robert Haas
On Wed, Jan 6, 2010 at 11:14 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Wed, Jan 6, 2010 at 10:13 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: What tools do we have for identifying memory leaks? User complaints

Re: [HACKERS] Buffer statistics for pg_stat_statements

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 3:31 AM, Takahiro Itagaki itagaki.takah...@oss.ntt.co.jp wrote: Tom Lane t...@sss.pgh.pa.us wrote: I don't necessarily know what the right thing to do with the new ones is, but I am pretty sure that pg_indent will revert any changes you make to the existing ones.

Re: [HACKERS] Patch: Allow substring/replace() to get/set bit values

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 7:02 AM, Leonardo F m_li...@yahoo.it wrote: attached a patch that adds the following functions for bit string: Thanks! Please add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open The next CommitFest starts January 15th. ...Robert -- Sent

Re: [HACKERS] PostgreSQL 8.5 Open Items

2010-01-07 Thread Robert Haas
On Fri, Dec 25, 2009 at 3:09 PM, Robert Haas robertmh...@gmail.com wrote: I'm not sure whether we ever posted this schedule anywhere official - if so, I can't find it - but my understanding is that we have consensus on the release schedule described here: http://archives.postgresql.org/pgsql

Re: [HACKERS] PostgreSQL 8.5 Open Items

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 10:50 AM, Magnus Hagander mag...@hagander.net wrote: On Thu, Jan 7, 2010 at 16:47, Robert Haas robertmh...@gmail.com wrote: On Fri, Dec 25, 2009 at 3:09 PM, Robert Haas robertmh...@gmail.com wrote: I'm not sure whether we ever posted this schedule anywhere official

Re: [HACKERS] Patch: Allow substring/replace() to get/set bit values

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 11:05 AM, Leonardo F m_li...@yahoo.it wrote: Thanks!  Please add your patch here: https://commitfest.postgresql.org/action/commitfest_view/open Ok; but what about what I said about the difference between bit/string substring? That affects overlay behaviour for

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Wed, Jan 6, 2010 at 3:03 AM, Heikki Linnakangas heikki.linnakan...@enterprisedb.com wrote: Fujii Masao wrote: I've done that in my git branch. Could you push that git branch to a public place? Ahh, sorry, forgot that again. It's there now, at

Re: [HACKERS] Testing with concurrent sessions

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 11:46 AM, Andrew Dunstan and...@dunslane.net wrote: Using DBI/DBD::Pg would raise another issue - what version of libpq would it be using? Not the one in the build being tested, that's for sure. If you really want to use Perl then either a Pure Perl DBI driver (which Greg

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
2010/1/7 Magnus Hagander mag...@hagander.net: 2010/1/7 Devrim GÜNDÜZ dev...@gunduz.org: On Thu, 2010-01-07 at 11:55 -0500, Robert Haas wrote: Personally, I would rather have a release without SR in June or July than a release with SR in August or September. June, yes. July, frankly

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 12:24 PM, Tom Lane t...@sss.pgh.pa.us wrote: Magnus Hagander mag...@hagander.net writes: We made the mistake last time to delay the release significantly for a single feature. It turned out said feature didn't make it *anyway*. Let's not repeat that mistake. Yeah,

Re: [HACKERS] Application name patch - v3

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 10:33 AM, Guillaume Lelarge guilla...@lelarge.info wrote: Le 04/01/2010 22:36, Guillaume Lelarge a écrit : Le 29/12/2009 14:12, Guillaume Lelarge a écrit : Le 29/12/2009 00:03, Guillaume Lelarge a écrit : Le 28/12/2009 22:59, Tom Lane a écrit : Guillaume Lelarge

Re: [HACKERS] Small locking bugs in hs

2010-01-07 Thread Robert Haas
On Sun, Dec 27, 2009 at 2:12 PM, Andres Freund and...@anarazel.de wrote: While unlikely to cause issues two new LWLockAcquire calls use the wrong locking mode. Patch attached. Does it make sense to add this to the 2010-01 CommitFest so we don't lose track of it? ...Robert -- Sent via

Re: [HACKERS] tsvector extraction patch

2010-01-07 Thread Robert Haas
On Fri, Jul 3, 2009 at 3:01 AM, Hans-Juergen Schoenig -- PostgreSQL postg...@cybertec.at wrote: Hans-Juergen Schoenig -- PostgreSQL wrote: hello, this patch has not made it through yesterday, so i am trying to send it again. i made a small patch which i found useful for my personal tasks.

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 1:21 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I like Andres' suggestion upthread of setting a deadline and determining to bounce the patch if it's not committed by that date. If it turns out we have to bounce it, that stinks, but I

Re: [HACKERS] Listen / Notify - what to do when the queue is full

2010-01-07 Thread Robert Haas
On Wed, Dec 9, 2009 at 5:43 AM, Joachim Wieland j...@mcknight.de wrote: Hi, On Mon, Dec 7, 2009 at 5:38 AM, Greg Smith g...@2ndquadrant.com wrote: JI'm going to mark this one returned with feedback, and I do hope that work continues on this patch so it's early in the queue for the final

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 2:00 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: That may well be so, but adding another one is not going to improve the situation even a little bit.  I don't think what you're saying weakens in the slightest the argument that I

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 1:53 PM, Bruce Momjian br...@momjian.us wrote: Tom Lane wrote: Robert Haas robertmh...@gmail.com writes: I like Andres' suggestion upthread of setting a deadline and determining to bounce the patch if it's not committed by that date. If it turns out we have to bounce

Re: [HACKERS] Serializable Isolation without blocking

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 2:40 PM, Greg Stark gsst...@mit.edu wrote: On Thu, Jan 7, 2010 at 11:08 AM, Markus Wanner mar...@bluegap.ch wrote: Row level locks are very fine grained, but those are spilled to disk in its current implementation. So those are an even worse fit for the needs of SIREAD.

Re: [HACKERS] true serializability and predicate locking

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 3:43 PM, Kevin Grittner kevin.gritt...@wicourts.gov wrote: Albe Laurenz laurenz.a...@wien.gv.at wrote: Kevin Grittner wrote: Another interesting thing which crossed my mind (and I should probably add a section for such things in the wiki) is that, given the overhead and

Re: [HACKERS] Streaming replication and postmaster signaling

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 3:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I am tempted to say we should clamp down and go into damage control mode sooner rather than later. The more I see of the HS patch, the more I think the same.  But my proposal

Re: [HACKERS] PostgreSQL 8.5 Open Items

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 4:03 PM, Bruce Momjian br...@momjian.us wrote: Josh Berkus wrote: Bruce, Have you looked at this?  Are there no other Open Items? I have 2k emails that I need to go through to see what I have kept as open.  I am working on pg_migrator stuff at the moment. I am

Re: [HACKERS] PostgreSQL 8.5 Open Items

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 5:41 PM, Bruce Momjian br...@momjian.us wrote: It's my mailbox --- it is my time to decide when to look at it, or not. Absolutely. There is nothing private about its contents. Understood. You can do whatever you want with the release schedule. I should be so lucky.

[HACKERS] damage control mode

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 4:23 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: On Thu, Jan 7, 2010 at 3:36 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: I am tempted to say we should clamp down and go into damage control mode

Re: [HACKERS] Serializable implementation

2010-01-07 Thread Robert Haas
I'm torn between thinking it would be good to spell it that way and thinking that we should have serializable_isolation_implementation GUC (or something to that effect) which maps to an enumeration containing snapshot and ssi.  Opinions welcome, since I've put that GUC at the top of my

Re: [HACKERS] damage control mode

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 9:11 PM, Andrew Dunstan and...@dunslane.net wrote: This strikes me as quite premature. Heiki just said he expects to have SR committed next week. Getting it committed is not what I'm worried about. What I'm concerned about is Tom's statement that he believes that HS is

Re: [HACKERS] Stats for inheritance trees

2010-01-07 Thread Robert Haas
On Tue, Jan 5, 2010 at 4:45 PM, Robert Haas robertmh...@gmail.com wrote: On Tue, Dec 29, 2009 at 9:12 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: Yep.  It would also lower the barrier to future innovations of that type, which would be a good thing, IMO

Re: [HACKERS] damage control mode

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 10:20 PM, Tom Lane t...@sss.pgh.pa.us wrote: Robert Haas robertmh...@gmail.com writes: OK, we have a proposal on the table to bump some patches from this CommitFest to free up more committer resources, particularly Tom, to work on Hot Standby and Streaming Replication

Re: [HACKERS] damage control mode

2010-01-07 Thread Robert Haas
On Thu, Jan 7, 2010 at 10:51 PM, Tom Lane t...@sss.pgh.pa.us wrote: Fair enough ;-).  But I don't feel a need to make a decision now, either.  We can at least wait a week and see if Heikki gets SR committed. OK. ...Robert -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

<    2   3   4   5   6   7   8   9   10   11   >