Re: [HACKERS] pl/perl extension fails on Windows

2017-07-31 Thread Tom Lane
tput from configure, particularly the new lines about CFLAGS? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-30 Thread Tom Lane
Christoph Berg <m...@debian.org> writes: > Re: Tom Lane 2017-07-28 <3254.1501276...@sss.pgh.pa.us> >> Christoph Berg <m...@debian.org> writes: >>> The plperl segfault on Debian's kfreebsd port I reported back in 2013 >>> is also still present: >>

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-30 Thread Tom Lane
"Tels" <nospam-pg-ab...@bloodgate.com> writes: > On Sun, July 30, 2017 12:22 pm, Tom Lane wrote: >> Yeah, I looked into that. The closest candidate I can find is that >> perl 5.10.1 contains Test::More 0.92. However, it's not real clear >> to me exactly which

Re: [HACKERS] PostgreSQL not setting OpenSSL session id context?

2017-07-30 Thread Tom Lane
happening. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PostgreSQL not setting OpenSSL session id context?

2017-07-30 Thread Tom Lane
ly lightweight per-session state, but that ain't us. I think what you need to do is tell SslStream not to expect that PG servers will do session resumption. (I'm a bit astonished that that would be its default assumption in the first place, but whatever.) regards, tom l

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-30 Thread Tom Lane
Noah Misch <n...@leadboat.com> writes: > On Sun, Jul 30, 2017 at 12:05:10PM -0400, Tom Lane wrote: >> Well, OK, but I'd still like to tweak configure so that it records >> an absolute path for prove rather than just setting PROVE=prove. >> That way you'd at least be able

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-30 Thread Tom Lane
"Tels" <nospam-pg-ab...@bloodgate.com> writes: > On Sun, July 30, 2017 1:21 am, Tom Lane wrote: >>> So the question is, does anyone care? I wouldn't except that our >>> documentation appears to claim that we work with Perl "5.8 or later". > N

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-30 Thread Tom Lane
Noah Misch <n...@leadboat.com> writes: > On Sun, Jul 30, 2017 at 01:21:28AM -0400, Tom Lane wrote: >> I think it'd be a good idea to insist that "prove" be in >> the same directory we found "perl" in. > Nah; on my machines, I use /usr/bin/perl and

Re: [HACKERS] GSoC 2017: Foreign Key Arrays

2017-07-29 Thread Tom Lane
TINCT will use, ie the default for the data type. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-29 Thread Tom Lane
ea to insist that "prove" be in the same directory we found "perl" in. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-29 Thread Tom Lane
ecause we should only get to that function through ExecProcNode(). If somehow it's not redundant, please add a comment explaining why not. Some other minor cosmetic changes, mostly comment wordsmithing. I think this (and the previous one) are committable. regards, tom l

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-29 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-07-26 16:28:38 -0400, Tom Lane wrote: >> It's certainly possible that there are long-running loops not involving >> any ExecProcNode recursion at all, but that would be a bug independent >> of this issue. The CFI

Re: [HACKERS] Memory leak

2017-07-29 Thread Tom Lane
s attachments rather than pasting them into the text in-line. Poking at it a bit harder with valgrind, it seems that the vast majority of what it reports as leaks is caused by replace_token(). If we wanted to reduce memory wastage during initdb, that would be the place to work on. But I'm dubious that

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

2017-07-28 Thread Tom Lane
Daniel Gustafsson <dan...@yesql.se> writes: > On 27 Jul 2017, at 19:40, Tom Lane <t...@sss.pgh.pa.us> wrote: >> listTables and listDbRoleSettings print a custom message rather than >> an empty table for no matches (but in QUIET mode they just do the >> latter)

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-28 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: >> On 07/27/2017 11:58 PM, Tom Lane wrote: >>> I wonder if it'd be worth getting the buildfarm >>> to log the output of "perl -V" so we could get a clearer picture >>> of what's being teste

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-28 Thread Tom Lane
l, thanks. I hope people will set up some buildfarm machines with the formerly-broken configurations. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-28 Thread Tom Lane
=kfreebsd-amd64=10~beta2-1=1499947011=0 So it'd be interesting to know if it's any better with HEAD ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] map_partition_varattnos() and whole-row vars

2017-07-28 Thread Tom Lane
ole > mess.) I think the pain arises mostly from the decision to allow partitions to not all have identical rowtype. I would have lobbied against that choice if I'd been paying more attention at the start ... but I wasn't. regards, tom lane -- Sent via pgsql-ha

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-28 Thread Tom Lane
Ashutosh Sharma <ashu.coe...@gmail.com> writes: > On Fri, Jul 28, 2017 at 10:05 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Uh-huh. So the issue is indeed that they're injecting PERL_IMPLICIT_SYS >> via a command-line #define rather than putting it into perl's co

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-28 Thread Tom Lane
rl droppings.) regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-28 Thread Tom Lane
Ashutosh Sharma <ashu.coe...@gmail.com> writes: > On Fri, Jul 28, 2017 at 7:22 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Assuming that the Perl crew know what they're doing and this list is >> complete, I notice that not one of the symbols they show as relevant >&g

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-28 Thread Tom Lane
ersecting that with what we get from Perl's ccflags. But that would be a lot more complex, so I'd rather go with the simpler filter rule for now. (BTW, you never did tell us exactly what defines you're getting out of Perl's flags on the problem installation.) regards

Re: [HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-27 Thread Tom Lane
orth getting the buildfarm to log the output of "perl -V" so we could get a clearer picture of what's being tested. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] PL_stashcache, or, what's our minimum Perl version?

2017-07-27 Thread Tom Lane
stashcache is a macro, so we could make it compile with an "#ifdef PL_stashcache", but I'm pretty nervous about whether that would be breaking needed cleanup behavior. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] On Complex Source Code Reading Strategy

2017-07-27 Thread Tom Lane
're browsing in. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-27 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 07/27/2017 04:33 PM, Tom Lane wrote: >> So I was trying to figure a way to not include XSUB.h except in a very >> limited part of plperl, like ideally just the .xs files. It's looking >> like that would

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-27 Thread Tom Lane
define aTHX_ aTHX, #endif As best I can tell, that's absolute brain death on the part of the Perl crew; it means you can't write working calling code at all without including XSUB.h, or at least copying-and-pasting this bit out of it. regards, tom lane -- Sent

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-27 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Wed, Jul 26, 2017 at 2:41 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> The bigger issue is whether there's some failure case this would cause >> that I'm missing altogether. Thoughts? > I think dependencies are

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-27 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > What is the minimal set of extra defines required to sort out the > handshake fingerprint issue? Also, exactly what defines do you end up importing in your test build? regards, tom lane -- Sent via p

Re: [HACKERS] tab completion for "create user mapping for"

2017-07-27 Thread Tom Lane
G FOR". > Attached patch fixes that. Pushed, thanks. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql's \d and \dt are sending their complaints to different output files

2017-07-27 Thread Tom Lane
Daniel Gustafsson <dan...@yesql.se> writes: >> On 19 Jun 2017, at 17:32, Tom Lane <t...@sss.pgh.pa.us> wrote: >> So, if we're getting into enforcing consistency in describe.c, there's >> lots to do. > Addressed in attached patch, see list of

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-27 Thread Tom Lane
served, > SPI.obj : error LNK2019: unresolved external symbol PerlProc_setjmp > referenced in function do_plperl_return_next That's certainly a mess, but how come that wasn't happening before? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] expand_dbname in postgres_fdw

2017-07-27 Thread Tom Lane
nywhere, and for that matter "checked for extended formats" is a masterpiece of unhelpful obfuscation. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] asynchronous execution

2017-07-26 Thread Tom Lane
if you wanted both instrumentation and async support on the same node. But maybe those two couldn't be arms-length from each other anyway, in which case it might be fine as-is. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.or

Re: [HACKERS] pg_dump does not handle indirectly-granted permissions properly

2017-07-26 Thread Tom Lane
Stephen Frost <sfr...@snowman.net> writes: > * Tom Lane (t...@sss.pgh.pa.us) wrote: >> AFAICT, pg_dump has no notion that it needs to be careful about the order >> in which permissions are granted. I did > I'm afraid that's correct, though I believe that's always been

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-26 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-07-26 15:03:37 -0400, Tom Lane wrote: >> Hm, that seems kinda backwards to me; I was envisioning the checks >> moving to the callees not the callers. I think it'd end up being >> about the same number of occurren

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-26 Thread Tom Lane
ment call about where to put them. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] expand_dbname in postgres_fdw

2017-07-26 Thread Tom Lane
uld work. It says that you can specify (most of) the same fields that are allowed in a connection string, not that one of those fields might be taken to *be* a connection string. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-26 Thread Tom Lane
st say you might have to not use parallel restore with old dumps that contain self-revoke ACLs?) The bigger issue is whether there's some failure case this would cause that I'm missing altogether. Thoughts? regards, tom lane -- Sent via pgsql-hackers mailing list (pgs

Re: [HACKERS] pg_dump does not handle indirectly-granted permissions properly

2017-07-26 Thread Tom Lane
ous either. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-26 Thread Tom Lane
it for the next pg_upgrade or dump/restore). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] AlterUserStmt anmd RoleSpec rules in grammar.y

2017-07-26 Thread Tom Lane
did not change their results. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Testlib.pm vs msys

2017-07-26 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 07/26/2017 09:33 AM, Tom Lane wrote: >> It might be interesting to look into its copy of IPC::Run and see if >> the wait technology is different from later versions. > It's using 0.94 just like my Linux box. O

Re: [HACKERS] pg_upgrade failed with error - ERROR: column "a" in child table must be marked NOT NULL

2017-07-26 Thread Tom Lane
it's moot. Not sure what's involved there code-wise, though, nor whether we'd want to back-patch. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Testlib.pm vs msys

2017-07-26 Thread Tom Lane
around the problem without upsetting the > good work you've been doing in reducing TAP test times generally. I still find this pretty ugly :-(. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-26 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Tue, Jul 25, 2017 at 10:45 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Instead, I've prepared the attached draft patch, which addresses the >> problem by teaching pg_backup_archiver.c to process TOC entries in >

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-25 Thread Tom Lane
seems safer than just absorbing everything willy-nilly. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-25 Thread Tom Lane
ies that need to be broken. If somebody else wants to try drafting a patch like that, I won't stand in the way, but I don't wanna do so. Not clear where we want to go from here. Should we try to get this into next month's minor releases, or review it in September's commitfest and back-patch af

Re: [HACKERS] pg_dump does not handle indirectly-granted permissions properly

2017-07-25 Thread Tom Lane
s make more sense to me. Yeah, it makes more sense to me too, but nonetheless that's the result I get. I suspect there is an element of indeterminacy here. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

Re: [HACKERS] PostgreSQL 10 (latest beta) and older ICU

2017-07-25 Thread Tom Lane
ill anyone still care by then? (Concretely, my concern is that the alpha and beta testing that's happened so far hasn't covered pre-4.6 ICU at all. I'd be surprised if the incompatibility you found so far is the only one.) regards, tom lane -- Sent via pgsql-hacker

[HACKERS] pg_dump does not handle indirectly-granted permissions properly

2017-07-25 Thread Tom Lane
IZATION; That might be just chance, but my current bet is that Stephen broke it sometime in the v10 cycle --- especially since we haven't heard any complaints like this from the field. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@pos

Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade

2017-07-25 Thread Tom Lane
ots of undocumented behaviors in PG; if we tried to explain every one of them, the docs would become unusably bloated. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade

2017-07-25 Thread Tom Lane
to go do something with more tangible benefit, like see if we can make its REFRESH MATERIALIZED VIEW commands come out at the right time. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscript

Re: [HACKERS] Testlib.pm vs msys

2017-07-25 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 07/25/2017 11:25 AM, Tom Lane wrote: >> Oh. So when was the last time it worked? And why do the buildfarm >> archives contain apparently-successful log_stage entries for pg_ctl-check >> on jacana, up thro

Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade

2017-07-25 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Tue, Jul 25, 2017 at 10:31 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> pg_dump doesn't really support that scenario, and I don't feel any >> great need to make it do so. Per the comment in dumpProcLang: > Is thi

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-25 Thread Tom Lane
Robert Haas <robertmh...@gmail.com> writes: > On Tue, Jul 25, 2017 at 11:00 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Hm, I had the idea that we were already asking ExtUtils::Embed for that, >> but now I see we only inquire about LDFLAGS not CCFLAGS. Yes, this sounds

Re: [HACKERS] Testlib.pm vs msys

2017-07-25 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 07/25/2017 11:11 AM, Tom Lane wrote: >> What I'm on about is that jacana still succeeds entirely, more than half >> the time. If this is a handle-duplication problem, how could it ever >> succeed? >

Re: [HACKERS] Testlib.pm vs msys

2017-07-25 Thread Tom Lane
Andrew Dunstan <andrew.duns...@2ndquadrant.com> writes: > On 07/24/2017 09:33 PM, Tom Lane wrote: >> Seems like the TAP test should fail every time, if this is a full >> description. But maybe it's part of the answer, so it seems worth >> experimenting in this direct

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2017-07-25 Thread Tom Lane
Tomas Vondra <tomas.von...@2ndquadrant.com> writes: > On 7/25/17 12:55 AM, Tom Lane wrote: >> I think the planner basically assumes that reltuples is the live >> tuple count, so maybe we'd better change VACUUM to get in step. > Attached is a patch that (I think) does jus

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-25 Thread Tom Lane
e that to the problematic field(s). regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-25 Thread Tom Lane
d to be made aware of that. If that *isn't* the explanation, then we need to find out what is. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] estimation for join results cardinality is sometimes more than the product of the downstream nodes'

2017-07-25 Thread Tom Lane
er others based on nothing except estimation errors. I do not think we'd get a net benefit in plan quality. If we could do this earlier and adjust the join relation's overall cardinality estimate, it might be something to consider. regards, tom lane -- Sent via pgsql-hacke

Re: [HACKERS] pl/perl extension fails on Windows

2017-07-25 Thread Tom Lane
l and it is not > clear why perl is using those flags. Do you think we can do something > at our end to make it work or someone should check with Perl community > about it? It would be a good idea to find somebody who knows more about how these Perl distros are built.

Re: [HACKERS] Create language syntax is not proper in pg_dumpall and not working using pg_upgrade

2017-07-25 Thread Tom Lane
... but you didn't do that either. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [SQL] Postgresql “alter column type” creates an event which contains “temp_table_xxx”

2017-07-25 Thread Tom Lane
gh, so I wonder how exactly a logical decoding plugin is supposed to make sense of what it can see here. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] cache lookup failed error for partition key with custom opclass

2017-07-25 Thread Tom Lane
Rushabh Lathia <rushabh.lat...@gmail.com> writes: > On Mon, Jul 24, 2017 at 7:23 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Some looking around says that this *isn't* the only place that just >> blithely assumes that it will find an opfamily entry. But I agree >>

Re: [HACKERS] Testlib.pm vs msys

2017-07-24 Thread Tom Lane
g Microsoft's documentation suggests that maybe all we have to do is pass CreateProcessAsUser's bInheritHandles parameter as FALSE not TRUE in pg_ctl.c. It's not apparent to me that there are any handles we do need the CMD process to inherit. regards, tom lane -- Sent via

Re: [HACKERS] VACUUM and ANALYZE disagreeing on what reltuples means

2017-07-24 Thread Tom Lane
live > The question is - which of the reltuples definitions is the right one? > I've always assumed that "reltuples = live + dead" but perhaps not? I think the planner basically assumes that reltuples is the live tuple count, so maybe we'd better change VACUUM to get in step.

Re: Fwd: [HACKERS] Syncing sql extension versions with shared library versions

2017-07-24 Thread Tom Lane
Mat Arye <m...@timescaledb.com> writes: > On Mon, Jul 24, 2017 at 1:38 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> I'm not really sure why planner hooks would have anything to do with your >> exposed SQL API? > Sorry what I meant was i'd like to package differ

Re: [HACKERS] Buildfarm failure and dubious coding in predicate.c

2017-07-24 Thread Tom Lane
not found cases below, either. Will fix, unless you're already on it? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Issue with circular references in VIEW

2017-07-24 Thread Tom Lane
Gilles Darold <gilles.dar...@dalibo.com> writes: > Le 24/07/2017 à 19:19, Tom Lane a écrit : >> ... I'm inclined to think in terms of fixing it at that level >> rather than in pg_dump. It doesn't look like it would be hard to fix: >> both functions ultimately call

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-24 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-07-21 20:17:54 -0400, Tom Lane wrote: >>> I dislike having the miscadmin.h include in executor.h - but I don't >>> quite see a better alternative. >> I seriously, seriously, seriously dislike that. You

Re: [HACKERS] Issue with circular references in VIEW

2017-07-24 Thread Tom Lane
pg_dump. It doesn't look like it would be hard to fix: both functions ultimately call get_query_def(), it's just that one passes down a tuple descriptor for the view while the other currently doesn't. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-h

Re: [HACKERS] Change in "policy" on dump ordering?

2017-07-24 Thread Tom Lane
GRANTs from REVOKEs and putting only the latter at the end. I'm not quite convinced that that's a good idea but it certainly merits consideration. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] cache lookup failed error for partition key with custom opclass

2017-07-24 Thread Tom Lane
not checking for that isn't up to project standards. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Improve perfomance for index search ANY(ARRAY[]) condition with single item

2017-07-23 Thread Tom Lane
t know anything about ScalarArrayOpExpr, but there's a patch pending to improve that: https://commitfest.postgresql.org/14/1136/ You should probably build your revised patch as a follow-on to that one, else we're going to have merge conflicts. regards, tom lane -- Sent via

Re: [HACKERS] Improve perfomance for index search ANY(ARRAY[]) condition with single item

2017-07-23 Thread Tom Lane
array is coming from a parameter rather than an ARRAY[] construct. That is, you should be able to do this not only for ARRAY[x] but for any single-element constant array. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Testlib.pm vs msys

2017-07-23 Thread Tom Lane
EOF detection AFAICS. It's also hard to explain this way why it only fails some of the time. I think we need to look at what the recent changes were in this area and try to form a better theory of why it's started to fail here. regards, tom lane -- Sent via pgsql-

Re: [HACKERS] Buildfarm failure and dubious coding in predicate.c

2017-07-22 Thread Tom Lane
king that it was an optional optimization, and not something that is critical for correctness of several different callers. I'm going to go improve the comments. Meanwhile, it's still pretty unclear what happened yesterday on culicidae. regards, tom lane -- Sent via

Re: [HACKERS] Syncing sql extension versions with shared library versions

2017-07-22 Thread Tom Lane
eep backwards compatibility across versions, your users are probably going to think differently. The amount of practical freedom you'd gain here is probably not so much as you're hoping. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To m

Re: [HACKERS] segfault in HEAD when too many nested functions call

2017-07-21 Thread Tom Lane
Andres Freund <and...@anarazel.de> writes: > On 2017-07-18 16:53:43 -0400, Tom Lane wrote: >> BTW, I don't see why you really need to mess with anything except >> ExecProcNode? Surely the other cases such as MultiExecProcNode are >> not called often enough to just

Re: [HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > Tom Lane wrote: >> We could stabilize this test result by forcing lc_messages = C in >> the foreign server options. However, that would lose regression >> coverage of situations where the remote locale is different,

[HACKERS] Buildfarm failure and dubious coding in predicate.c

2017-07-21 Thread Tom Lane
d memory right here; but what we've got is not up to project standards IMO. I have some ideas about fixing this by enlisting the help of dynahash.c explicitly, rather than fooling with "scratch entries". But I haven't been able yet to write a design for that that doesn't have obvious bugs.

Re: [HACKERS] More optimization effort?

2017-07-21 Thread Tom Lane
, but it looks tedious and bulky. > I have, however, decided not to volunteer to be the one who works on > that project. Me either. Any one of these things would require a *lot* of work in order to have a coherent feature that provided useful behavior across a bunch of different datatypes.

Re: [HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
pecial variable, as we do for LASTOID for instance; but it doesn't look like that's actually been done yet. We should revisit this if that feature ever materializes. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make chan

[HACKERS] Locale dependency in new postgres_fdw test

2017-07-21 Thread Tom Lane
uld mask issues that the test case ought to find, too. Maybe set lc_messages = C in the options only for the duration of these new test cases? regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] [COMMITTERS] pgsql: Add a Gather executor node.

2017-07-21 Thread Tom Lane
, +1. Some of them have some documentation in them, which you'd need to make sure is duplicative or else copy it to an appropriate place. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: h

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-21 Thread Tom Lane
mpletely bulletproof before 9.6. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] More optimization effort?

2017-07-21 Thread Tom Lane
or-specific knowledge that doesn't exist in the system today. And as Craig noted, applying that knowledge would be expensive, even in cases where it failed to help. So, color me skeptical ... regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] PgFDW connection invalidation by ALTER SERVER/ALTER USER MAPPING

2017-07-20 Thread Tom Lane
iple sessions. I made some cosmetic updates to the code patch, as well. I think this is actually a bug fix, and should not wait for the next commitfest. regards, tom lane diff --git a/contrib/postgres_fdw/connection.c b/contrib/postgres_fdw/connection.c index 8c33dea..8eb47

Re: [HACKERS] <> join selectivity estimate question

2017-07-20 Thread Tom Lane
the <>, for instance "(a.b + b.y) <> a.c". I don't think it's especially interesting for the present purpose though, since we're going to end up with 1.0 selectivity in any case where examine_variable can't find stats. regards, tom lane -- Sent v

Re: [HACKERS] Increase Vacuum ring buffer.

2017-07-20 Thread Tom Lane
uld debate the exact constants. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_upgrade failed if view contain natural left join condition

2017-07-20 Thread Tom Lane
uot;ON FALSE". No, it's normal that an AND of no conditions degenerates to TRUE. It's like omitting a WHERE clause. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Increase Vacuum ring buffer.

2017-07-20 Thread Tom Lane
ection to a 16MB ring buffer for vacuum when it is coming out of a 1GB arena ... it just seems like a rather large fraction of 128MB to give to a background process, especially to each of several background processes. Maybe the fraction-of-shared-buffers shouldn't be one size fits all, but a

[HACKERS] Definitional questions for pg_sequences view

2017-07-20 Thread Tom Lane
e bothered to provide the view. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_upgrade failed if view contain natural left join condition

2017-07-20 Thread Tom Lane
.3. Although I have a feeling this might be a mistake in a back-patched bug fix, so that it'd depend on which 9.3.x you looked at. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pg_upgrade failed if view is based on sequence

2017-07-20 Thread Tom Lane
0. (If you want those values, you should now get them out of the pg_sequence catalog.) This should have been called out as a significant incompatibility in the v10 release notes, but I see that it's not listed in the right section. Will fix that ... regards, tom lan

Re: [HACKERS] [GENERAL] huge RAM use in multi-command ALTER of table heirarchy

2017-07-20 Thread Tom Lane
Greg Stark <st...@mit.edu> writes: > On 19 July 2017 at 00:26, Tom Lane <t...@sss.pgh.pa.us> wrote: >> It's probably a bit late in the v10 cycle to be taking any risks in >> this area, but I'd vote for ripping out RememberToFreeTupleDescAtEOX >> as soon as the v1

Re: [HACKERS] autovacuum can't keep up, bloat just continues to rise

2017-07-19 Thread Tom Lane
regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] psql's \r broken since e984ef5861d

2017-07-19 Thread Tom Lane
/9b4ea968-753f-4b5f-b46c-d7d3bf7c8f90%40manitou-mail.org regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

<    4   5   6   7   8   9   10   11   12   13   >