[HACKERS] [PATCH] Remove trailing spaces

2017-03-29 Thread Alexander Law
Hello, Please consider committing the attached patches to remove trailing spaces in strings in the source code. One patch is for localizable messages, and the other is just for consistency (less important). -- Alexander Lakhin Postgres Professional: http://www.postgrespro.com The Russian

[HACKERS] Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default

2016-12-15 Thread Alexander Law
Hello Alvaro, It's caused by the condition ... in the simple.xlink template (docbook/stylesheet/docbook-xsl/xhtml/inline.xsl). (This test executed for each xlink (~ 9 times)). Yes, it's inefficient but it doesn't affect build time (for me). You can try to apply the attached patch and

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-06-24 Thread Alexander Law
Hello Noah, Thanks for your work, your patch is definitely better. I agree that this approach much more generic. 23.06.2013 20:53, Noah Misch wrote: The attached revision fixes all above points. Would you look it over? The area was painfully light on comments, so I added some. I renamed

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-02-20 Thread Alexander Law
Hello, 15.02.2013 02:59, Noah Misch wrote: With your proposed change, the problem will resurface in an actual SQL_ASCII database. At the problem's root is write_console()'s assumption that messages are in the database encoding. pg_bind_textdomain_codeset() tries to make that so, but it only

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-02-13 Thread Alexander Law
Hello, Alexander Law exclus...@gmail.com writes: Please look at the following l10n bug: http://www.postgresql.org/message-id/502a26f1.6010...@gmail.com and the proposed patch. With your proposed change, the problem will resurface in an actual SQL_ASCII database. At the problem's root

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-01-29 Thread Alexander Law
30.01.2013 05:51, Noah Misch wrote: On Tue, Jan 29, 2013 at 09:54:04AM -0500, Tom Lane wrote: Alexander Law exclus...@gmail.com writes: Please look at the following l10n bug: http://www.postgresql.org/message-id/502a26f1.6010...@gmail.com and the proposed patch. That patch looks entirely

Re: [HACKERS] BUG #7493: Postmaster messages unreadable in a Windows console

2013-01-28 Thread Alexander Law
Hello, Thanks for fixing bug #6510! Please look at the following l10n bug: http://www.postgresql.org/message-id/502a26f1.6010...@gmail.com and the proposed patch. Best regards, Alexander From 1e2d5f712744d4731b665724703c0da4971ea41e Mon Sep 17 00:00:00 2001 From: Alexander Lakhin

Re: [HACKERS] BUG #6510: A simple prompt is displayed using wrong charset

2013-01-23 Thread Alexander Law
Hello, Please let me know if I can do something to get the bug fix (https://commitfest.postgresql.org/action/patch_view?id=902) committed. I would like to fix other bugs related to postgres localization, but I am not sure yet how to do it. Thanks in advance, Alexander 18.10.2012 19:46,

[HACKERS] Re: BUG #6742: pg_dump doesn't convert encoding of DB object names to OS encoding

2012-07-25 Thread Alexander Law
not the only one instance of the issue. For example, when I try to use vacuumdb, I get completely unreadable messages: http://oi48.tinypic.com/1c8j9.jpg (blue marks what is in Russian or English, all the other text is gibberish). Best regards, Alexander 18.07.2012 12:51, Alexander Law wrote