Re: [HACKERS] Different error messages executing CREATE TABLE or ALTER TABLE to create a column xmin
Hi Robert, On Thu, Jan 26, 2012 at 7:59 PM, Robert Haas robertmh...@gmail.com wrote: On Thu, Jan 26, 2012 at 1:13 PM, Vik Reykja vikrey...@gmail.com wrote: On Thu, Jan 26, 2012 at 18:47, Robert Haas robertmh...@gmail.com wrote: OK, committed with that further change. thank you for the fast fix and Vik for the base patch ;) Just a small nit to pick, though: Giuseppe Sucameli contributed to this patch but was not credited in the commit log. I didn't use any of his code, though. I agree, Robert didn't use any part of my patch, so there's no reason to credit me in the log. Regards. -- Giuseppe Sucameli -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
[HACKERS] Different error messages executing CREATE TABLE or ALTER TABLE to create a column xmin
Hi hackers, the attached patch fixes the problem I explained in pgsql-bugs (forwarded). It's a trivial problem, so no initial patch design was required. Hope to see my patch applied. Thanks for your work. Regards. -- Forwarded message -- From: Giuseppe Sucameli brush.ty...@gmail.com Date: Sun, Jan 22, 2012 at 2:22 PM Subject: Different error messages executing CREATE TABLE or ALTER TABLE to create a column xmin To: pgsql-b...@postgresql.org Hi all, trying to create a table with a column xmin I get the following error message: test= create table lx (xmin int); ERROR: column name xmin conflicts with a system column name Instead I get a different (and less understandable) error message if I try to add a column named xmin to an existent table: test= create table lx (i int); CREATE TABLE test= alter table lx add xmin int; ERROR: column xmin of relation lx already exists. The same problem occurs using xmax as column name. I'm on Ubuntu 11.04. Tried on both PostgreSQL 8.4.10 and 9.1.2 Regards. -- Giuseppe Sucameli -- Giuseppe Sucameli postgresql_syscol_message.diff Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
