[HACKERS] ginInsertCleanup called from vacuum could still miss tuples to be deleted

2017-11-13 Thread Masahiko Sawada
GE_BLKNO, ExclusiveLock)) return; workMemory = work_mem; } Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_ginInsertCleanup.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-11-08 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 5:41 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Nov 6, 2017 at 4:42 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: >>>> I suggest that a good thing to do more or less immediately, regardless >>>> of when this patch

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 11:20 AM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Wed, Nov 8, 2017 at 1:58 AM, Alexander Korotkov > <a.korot...@postgrespro.ru> wrote: >> On Tue, Nov 7, 2017 at 4:34 PM, Masahiko Sawada <sawada.m...@gmail.com> >> w

Re: [HACKERS] Fix a typo in dsm_impl.c

2017-11-07 Thread Masahiko Sawada
On Wed, Nov 8, 2017 at 6:36 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Nov 6, 2017 at 11:22 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Attached the patch for $subject. > > Committed. > Thank you! Regards, -- Masahiko Sawada NIPPON TE

[HACKERS] Remove duplicate setting in test/recovery/Makefile

2017-11-07 Thread Masahiko Sawada
Hi, I found that EXTRA_INSTALL is doubly set at both top and bottom of the src/test/recovery/Makefile. Is it necessary? Attached patch fixes this. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center remove_duplicate_setting.patch Description

Re: [HACKERS] Fix bloom WAL tap test

2017-11-07 Thread Masahiko Sawada
contrib/bloom/Makefile b/contrib/bloom/Makefile index 13bd397..c1566d4 100644 --- a/contrib/bloom/Makefile +++ b/contrib/bloom/Makefile @@ -20,5 +20,7 @@ include $(top_builddir)/src/Makefile.global include $(top_srcdir)/contrib/contrib-global.mk endif +check: wal-check + wal-check: temp-install $(prove_check) Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Fix a typo in dsm_impl.c

2017-11-06 Thread Masahiko Sawada
Hi, Attached the patch for $subject. s/reamin/remain/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_dsm_impl_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-11-06 Thread Masahiko Sawada
On Mon, Oct 30, 2017 at 3:17 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas <robertmh...@gmail.com> wrote: >> On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> Since

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-11-05 Thread Masahiko Sawada
On Sat, Nov 4, 2017 at 7:04 AM, Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Wed, Nov 1, 2017 at 5:55 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov >> <a.korot...@postgrespro.ru>

Re: [HACKERS] Explicit relation name in VACUUM VERBOSE log

2017-11-01 Thread Masahiko Sawada
more generic solution for other log messages. But especially for VACUUM VERBOSE log, since the log messages could be very long when the table has multiple indices this patch would be useful for users. Since the previous patch conflicts with current HEAD, attached the updated patch. Regards, -- Masah

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-10-31 Thread Masahiko Sawada
On Tue, Oct 31, 2017 at 6:17 PM, Alexander Korotkov <a.korot...@postgrespro.ru> wrote: > On Tue, Oct 31, 2017 at 5:16 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> On Mon, Oct 30, 2017 at 10:16 PM, Robert Haas <robertmh...@gmail.com> >> w

Re: [HACKERS] Deadlock in ALTER SUBSCRIPTION REFRESH PUBLICATION

2017-10-31 Thread Masahiko Sawada
> postmaster.c:4029 > #22 0x007fd398 in ServerLoop () at postmaster.c:1753 > #23 0x007fc92f in PostmasterMain (argc=3, argv=0x244d6e0) at > postmaster.c:1361 > #24 0x00734f08 in main (argc=3, argv=0x244d6e0) at main.c:228 > > > > The reason of this deadlo

Re: [HACKERS] WIP: long transactions on hot standby feedback replica / proof of concept

2017-10-30 Thread Masahiko Sawada
If we insert a tuple on the new master server to a block that has been truncated on the old master, the WAL apply on the new standby will fail? I guess there are such corner cases causing failures of WAL replay after switch-over. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORP

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-10-30 Thread Masahiko Sawada
On Mon, Oct 30, 2017 at 5:48 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Thu, Oct 26, 2017 at 7:41 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> Because I don't want to break the current user semantics. that is, >> currently

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-10-30 Thread Masahiko Sawada
On Fri, Oct 27, 2017 at 12:03 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Oct 26, 2017 at 12:36 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Since the previous patch conflicts with current HEAD, I attached the >> updated patch for next CF.

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-10-26 Thread Masahiko Sawada
On Thu, Oct 26, 2017 at 2:36 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Oct 25, 2017 at 3:15 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> >> Foreign Transaction Resolver >> == >> I introduc

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-10-26 Thread Masahiko Sawada
On Fri, Sep 8, 2017 at 4:32 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Fri, Sep 8, 2017 at 7:24 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wro

Re: [HACKERS] Block level parallel vacuum WIP

2017-10-23 Thread Masahiko Sawada
On Mon, Oct 23, 2017 at 10:43 AM, Amit Langote <langote_amit...@lab.ntt.co.jp> wrote: > On 2017/10/22 5:25, Thomas Munro wrote: >> On Sun, Oct 22, 2017 at 5:09 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> On Tue, Sep 19, 2017 at 3:31 AM, Masahiko Sawada <

Re: [HACKERS] More stats about skipped vacuums

2017-10-20 Thread Masahiko Sawada
gt; This seems enough to find the cause of a table bloat. The same > discussion could be applied to analyze but it might be the > another issue. > > There may be a better way to indicate the vacuum soundness. Any > opinions and suggestions are welcome. > > I'm going to make a patch to do

[HACKERS] Fix a typo in libpq/auth.c

2017-10-19 Thread Masahiko Sawada
Hi, Attached a patch for $subject. s/RAIDUS/RADIUS/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_typo_in_auth_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-10-19 Thread Masahiko Sawada
On Tue, Sep 5, 2017 at 3:41 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > Thank you for the opinions. > > At Tue, 29 Aug 2017 15:00:57 +0900, Masahiko Sawada <sawada.m...@gmail.com> > wrote in

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-10-18 Thread Masahiko Sawada
t's wait and see. > > > The patch needs a rebase in the documentation because of the xml-ilization > of the sgml doc. > Thank you for the notification! Attached rebased patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2017-10-17 Thread Masahiko Sawada
et, then > it'll show things like FROZEN, and hide COMMITTED|INVALID. Similar for other > combos. > FWIW, I agree with this direction. ISTM the showing the raw flags by default and having an option to show combined flags would be a right way. I sometimes wanted to have the same mechanism fo

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-10-16 Thread Masahiko Sawada
cleanup vacuum when aggressive vacuum, which is one of the situation that I really wanted to skip. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Fix a typo in execReplication.c

2017-10-13 Thread Masahiko Sawada
On Thu, Oct 12, 2017 at 11:30 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Oct 12, 2017 at 6:55 AM, Petr Jelinek > <petr.jeli...@2ndquadrant.com> wrote: >> Thanks for the patch, looks correct to me. > > Committed and back-patched to v10. > Thank y

Re: [HACKERS] Fix a typo in execReplication.c

2017-10-11 Thread Masahiko Sawada
On Thu, Oct 12, 2017 at 5:02 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Mon, Oct 9, 2017 at 10:59 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Attached a patch for $subject. ISTM these are mistakes of copy-and-paste. > > Committed, but isn't

Re: [HACKERS] Slow synchronous logical replication

2017-10-11 Thread Masahiko Sawada
t least your use case. We send at least the begin and commit data to all subscriptions and then wait for the reply from them but can we skip to wait them, for example, when the walsender actually didn't send any data modified by the transaction? Regards, -- Masahiko Sawada NIPPON TELEGRAPH A

[HACKERS] Re: [BUGS] 10.0: Logical replication doesn't execute BEFORE UPDATE OF trigger

2017-10-10 Thread Masahiko Sawada
On Tue, Oct 10, 2017 at 11:29 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Mon, Oct 9, 2017 at 11:13 PM, Aleksander Alekseev > <a.aleks...@postgrespro.ru> wrote: >> Hi hackers, >> >> I've found something that looks

[HACKERS] Fix a typo in execReplication.c

2017-10-09 Thread Masahiko Sawada
Hi, Attached a patch for $subject. ISTM these are mistakes of copy-and-paste. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center fix_comment_in_execReplication_c.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql

[HACKERS] Re: [BUGS] 10.0: Logical replication doesn't execute BEFORE UPDATE OF trigger

2017-10-09 Thread Masahiko Sawada
ueries would have been > executed on one instance. > > Actual result > - > > Replication fails, log contains: > > ``` > [3227] ERROR: duplicate key value violates unique constraint "test_pkey" > [3227] DETAIL: Key (k)=(k1) already exists. > [3176] L

Re: [HACKERS] Block level parallel vacuum WIP

2017-10-04 Thread Masahiko Sawada
On Tue, Sep 19, 2017 at 4:31 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Tue, Sep 19, 2017 at 3:33 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Fri, Sep 8, 2017 at 10:37 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >&

Re: [HACKERS] Issues with logical replication

2017-10-03 Thread Masahiko Sawada
>>> worker.c:736 >> >> We have locked the same tuple in RelationFindReplTupleByIndex() just >> before this gets called and didn't get the same error. I guess we do >> something wrong with snapshots. Will need to investigate more. >> > > Okay, so it's not

Re: [HACKERS] cache lookup errors for missing replication origins

2017-10-03 Thread Masahiko Sawada
s are included. The patch passes the regression test and I found no problems in this patch. I've marked it as Ready for Committer. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@pos

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-10-02 Thread Masahiko Sawada
On Sat, Sep 30, 2017 at 12:42 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Wed, Sep 27, 2017 at 11:15 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> I think that making a resolver process have connection caches to each >> foreign server for a

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-09-27 Thread Masahiko Sawada
On Wed, Sep 27, 2017 at 4:05 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Wed, Sep 27, 2017 at 12:11 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Tue, Sep 26, 2017 at 9:50 PM, Robert Haas <robertmh...@gmail.com> wrote: >&

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-09-27 Thread Masahiko Sawada
On Tue, Sep 26, 2017 at 9:50 PM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Sep 26, 2017 at 5:06 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Based on the review comment from Robert, I'm planning to do the big >> change to the architecture o

Re: [HACKERS] logical replication and statistics

2017-09-26 Thread Masahiko Sawada
On Tue, Sep 26, 2017 at 6:57 PM, Pavel Stehule <pavel.steh...@gmail.com> wrote: > > > 2017-09-26 11:56 GMT+02:00 Pavel Stehule <pavel.steh...@gmail.com>: >> >> >> >> 2017-09-26 11:51 GMT+02:00 Masahiko Sawada <sawada.m...@gmail.com>: >

Re: [HACKERS] logical replication and statistics

2017-09-26 Thread Masahiko Sawada
gt;> >> The main replication worker should still be running though. The output >> of pg_stat_replication should only be empty if there is nothing running. >> > > I did some inserts, updates, .. > > I can recheck it - it was done on 10 RC I guess CREATE SUBSCRIPTION fail

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2017-09-26 Thread Masahiko Sawada
eriodically, and tries to resolve in-doubt transactions. This patch still has the concern in the design and I'm planing to update the patch for the next commit fest. So I'll mark this as "Waiting on Author". Feedback and suggestion are very welcome. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Replication status in logical replication

2017-09-25 Thread Masahiko Sawada
> the server now is "streaming" and not "Catchup". > > And, I don't find any issues with code and patch to me is ready for > committer, marked the same in cf entry. > Thank you for the reviewing the patch! Regards, -- Masahiko Sawada NIPPON TELEGRAPH AN

Re: [HACKERS] Shaky coding for vacuuming partitioned relations

2017-09-25 Thread Masahiko Sawada
On Mon, Sep 25, 2017 at 8:22 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Mon, Sep 25, 2017 at 7:57 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> FWIW, the same thing can happen when specifying an invalid replication >> origin name to

Re: [HACKERS] logical replication and statistics

2017-09-25 Thread Masahiko Sawada
pty and no wal sender processes launch. The test_sub can start the replication by ALTER SUBSCRIPTION test_sub ENABLE. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] comments improvements

2017-09-25 Thread Masahiko Sawada
On Mon, Sep 25, 2017 at 5:36 AM, Erik Rijkers <e...@xs4all.nl> wrote: > comments improvements > For triggers.sql.20170924.diff file, you need to update expected/triggers.out file as well. -- Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Sof

Re: [HACKERS] Shaky coding for vacuuming partitioned relations

2017-09-25 Thread Masahiko Sawada
to find_all_inheritors should also use > ShareUpdateExclusiveLock, and the lock on top of RangeVarGetRelid() > needs to be reworked. > > Attached is a proposal of patch. FWIW, I agreed the approach of this patch, and found no problems in the patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-25 Thread Masahiko Sawada
On Fri, Sep 22, 2017 at 5:31 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Fri, 22 Sep 2017 17:21:04 +0900, Masahiko Sawada <sawada.m...@gmail.com> > wrote in <cad21aobn9ucgmduinx2ptu8upetohnr-a35abcqyznlfvwd...@mail.gmail.com> >> On Fri, Se

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-24 Thread Masahiko Sawada
On Sat, Sep 23, 2017 at 4:06 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/21/17 04:43, Masahiko Sawada wrote: >>> Once we got this patch, DROP SUBSCRIPTION is not transactional either >>> if dropping a replication slot or if th

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-22 Thread Masahiko Sawada
On Fri, Sep 22, 2017 at 4:16 PM, Kyotaro HORIGUCHI <horiguchi.kyot...@lab.ntt.co.jp> wrote: > At Fri, 22 Sep 2017 15:00:20 +0900, Masahiko Sawada <sawada.m...@gmail.com> > wrote in <cad21aod6zgb1w6ps1axj0ccab_chdyiitntedpmhkefgg13...@mail.gmail.com> >> On Tue, Se

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-09-22 Thread Masahiko Sawada
On Fri, Sep 22, 2017 at 3:46 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Sep 22, 2017 at 3:24 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> I have a question. Since WALInsertLockRelease seems not to call >> LWLockWaitForVa

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-09-22 Thread Masahiko Sawada
On Fri, Sep 22, 2017 at 3:00 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Fri, Sep 22, 2017 at 11:34 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> You're right. I updated the patch so that it exits do_pg_abort_backup >> if the state is NONE

Re: [HACKERS] GUC for cleanup indexes threshold.

2017-09-22 Thread Masahiko Sawada
te in > <CAH2-WzkhJhAXD+6DdBp7D8WYLfJ3D0m=AZbGsiw=usujtmu...@mail.gmail.com> >> On Wed, Apr 5, 2017 at 3:50 PM, Andres Freund <and...@anarazel.de> wrote: >> > Hi, >> > >> > On 2017-04-01 03:05:07 +0900, Masahiko Sawada wrote: >> >> On Fri, Mar

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-09-21 Thread Masahiko Sawada
l.com> wrote: > On Thu, Sep 21, 2017 at 5:56 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: >> On Thu, Sep 21, 2017 at 4:40 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >>> On Thu, Sep 21, 2017 at 2:25 PM, Michae

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-21 Thread Masahiko Sawada
On Sun, Sep 17, 2017 at 2:01 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Sat, Sep 16, 2017 at 9:52 PM, Peter Eisentraut > <peter.eisentr...@2ndquadrant.com> wrote: >> On 9/15/17 13:35, Arseny Sher wrote: >>> Peter Eisentraut <peter.eisentr...@2n

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-21 Thread Masahiko Sawada
l, code is simple and clean, it is > easy to invoke, easy to extend as well, which I'm planning to do once it > gets in. > > I switched the patch to "Ready for Committers". No doubt they will have > their own opinions about it. Let's wait and see. Thank you for the reviewing thi

Re: [HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-09-21 Thread Masahiko Sawada
On Thu, Sep 21, 2017 at 2:25 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Thu, Sep 21, 2017 at 1:07 AM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> The bug can happen in PostgreSQL 9.1 or higher that non-exclusive >> backup has been intro

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-20 Thread Masahiko Sawada
.*)" (memorization) in the data generation message check. > Thank you, fixed it. > Otherwise all is well for me. > Attached the updated version patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench_custom_initializatio

[HACKERS] Assertion failure when the non-exclusive pg_stop_backup aborted.

2017-09-20 Thread Masahiko Sawada
s. I changed do_pg_abort_backup() so that it decrements nonExclusiveBackups only if > 0. Feedback is very welcome. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/x

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-19 Thread Masahiko Sawada
t; appears once. I do not think that it is worth trying to check for the v > repetition, so I suggest to remove one from the first test. Repetition of ' > ' is checked with the second test. Agreed. > Maybe you could check that the data generation message is there. Added the check. Att

Re: [HACKERS] Creating backup history files for backups taken from standbys

2017-09-19 Thread Masahiko Sawada
On Tue, Sep 19, 2017 at 2:48 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Tue, Sep 19, 2017 at 8:33 AM, David Steele <da...@pgmasters.net> wrote: >> On 9/18/17 7:26 PM, Michael Paquier wrote: >>> On Tue, Sep 19, 2017 at 8:14 AM, David Steele <da...@pgma

Re: [HACKERS] Commits don't block for synchronous replication

2017-09-19 Thread Masahiko Sawada
es, so this report uses the same data > as the backend themselves, so that's a reliable source. In Postgres > 10, pg_stat_activity is also able to show to users what are the > backends waiting for a change to be flushed/applied on the standby > using the wait event called SyncRep. You c

Re: [HACKERS] Block level parallel vacuum WIP

2017-09-19 Thread Masahiko Sawada
On Tue, Sep 19, 2017 at 3:33 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Fri, Sep 8, 2017 at 10:37 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> Since v4 patch conflicts with current HEAD I attached the latest version >> patc

Re: [HACKERS] Creating backup history files for backups taken from standbys

2017-09-18 Thread Masahiko Sawada
ive_mode = off, the bytes of the backup history file are >> still written to disk, so my take on the matter is to keep the code >> simple. > > I'm OK with that. > > I'll give Masahiko some time to respond before marking it RFC. > Thanks, I'll review it and send a commen

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-18 Thread Masahiko Sawada
On Fri, Sep 8, 2017 at 9:52 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Sep 7, 2017 at 4:15 PM, Fabien COELHO <coe...@cri.ensmp.fr> wrote: >> >>>> Very very minor comments that I should have noticed before, sorry for >>>> this >

Re: [HACKERS] Small code improvement for btree

2017-09-18 Thread Masahiko Sawada
we > should use them, so I included that change as well. > Agreed. Thanks, again. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-16 Thread Masahiko Sawada
nly in the former case. In the latter case, we adopted such non-transactional behaviour. Since these behaviours would be complex for users I attached the documentation patch explaining it. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center diff

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-13 Thread Masahiko Sawada
On Thu, Sep 14, 2017 at 12:04 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Sep 13, 2017 at 8:00 PM, Arseny Sher <a.s...@postgrespro.ru> wrote: >> Peter Eisentraut <peter.eisentr...@2ndquadrant.com> writes: >>> We can break this in any number

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-13 Thread Masahiko Sawada
whole > lifetime. > > Something should be given up here. One more idea that was not yet > mentioned is to abandon attempts to drop subs and ROs simultenously and > just garbage-collect replication origins periodically, but that doesn't > sound as an elegant solution. > > &g

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-12 Thread Masahiko Sawada
On Wed, Sep 13, 2017 at 12:48 AM, Arseny Sher <a.s...@postgrespro.ru> wrote: > Masahiko Sawada <sawada.m...@gmail.com> writes: > >> FWIW, perhaps we can change the replication origin management so that >> DROP SUBSCRIPTION doesn't drop the replication origin and the

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-12 Thread Masahiko Sawada
On Wed, Sep 6, 2017 at 3:28 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Mon, Sep 4, 2017 at 11:43 PM, Arseny Sher <a.s...@postgrespro.ru> wrote: >> Arseny Sher <a.s...@postgrespro.ru> writes: >> >>> Attached patch fixes this by stopping w

Re: [HACKERS] Block level parallel vacuum WIP

2017-09-08 Thread Masahiko Sawada
On Tue, Aug 15, 2017 at 10:13 AM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Wed, Jul 26, 2017 at 5:38 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> On Sun, Mar 5, 2017 at 4:09 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wrote: >&g

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-09-07 Thread Masahiko Sawada
On Fri, Sep 8, 2017 at 7:24 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> The previous patch conflicts with current HEAD, I rebased the patch to >> current HEAD

Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager

2017-09-07 Thread Masahiko Sawada
On Fri, Sep 8, 2017 at 8:25 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Fri, Sep 8, 2017 at 10:24 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Wed, Aug 16, 2017 at 2:13 PM, Masahiko Sawada <sawada.m...@gmail.com> >> wro

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-07 Thread Masahiko Sawada
he pgbench tap test patch get through, it should be tap tested. > Thank you for the remainder, I'll add tap tests once the patch got committed. -- Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing li

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-06 Thread Masahiko Sawada
... Agreed. Attached latest patch. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench_custom_initialization_v12.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make

Re: [HACKERS] DROP SUBSCRIPTION hangs if sub is disabled in the same transaction

2017-09-06 Thread Masahiko Sawada
r before commit would be good. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-05 Thread Masahiko Sawada
en, but > maybe I just misinterpreted the diff file. My apology if it is the case. > I understood. It looks ugly in the patch but can be applied properly by git apply command. Attached latest patch incorporated the comments I got so far. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORP

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-05 Thread Masahiko Sawada
ialize_cmds = +(char *) pg_realloc(initialize_cmds, + sizeof(char) * n_cmds + 1); Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-04 Thread Masahiko Sawada
On Tue, Sep 5, 2017 at 12:24 PM, Michael Paquier <michael.paqu...@gmail.com> wrote: > On Tue, Sep 5, 2017 at 12:05 PM, Masahiko Sawada <sawada.m...@gmail.com> > wrote: >> In get_rel_oids() we often switch the memory context to vac_context >> and switch

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-09-04 Thread Masahiko Sawada
is good for a committer in my > opinion. In get_rel_oids() we often switch the memory context to vac_context and switch back. As a result almost code in get_rel_oids() is working in vac_context. Maybe we can switch memory context before and after the calling get_rel_oids? Regards, -- Masahiko Sawada

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-04 Thread Masahiko Sawada
uot;truncate pgbench_history, pgbench_branches, pgbench_tellers, > pgbench_accounts;" Agreed, and fixed. > > In passing, I think that the documentation should tell explicitely what the > default value is (aka "ctgvp"). Agreed. Attached the latest patch. Please r

Re: [HACKERS] CLUSTER command progress monitor

2017-09-03 Thread Masahiko Sawada
my environment the regression test passed. Thanks. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-03 Thread Masahiko Sawada
e in the transaction, and truncate both (or all?) tables > together. Attached latest patch incorporated the comments I got so far. Please review it. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench_custom_initialization_v9.patch

Re: [HACKERS] CLUSTER command progress monitor

2017-09-01 Thread Masahiko Sawada
pg_stat_replication| SELECT s.pid, s.usesysid, u.rolname AS usename, --- 1866,1871 == Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql

Re: [HACKERS] PG 10 release notes

2017-09-01 Thread Masahiko Sawada
se note, the feature related to default role is categorized in Permissions Management. I think the adding new default roles can be categorized in the same category to not confuse users and personally it's more suitable. "Add default monitoring roles (Dave Page)" Thought? Regards,

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-01 Thread Masahiko Sawada
. maybe not. Currently TRUNCATE pgbench_accounts command is executed within a transaction started immediately before it. If we move it out of the transaction, the table data will be truncated even if the copying data failed. Maybe we can do TRUNCATE pgbench_accounts, pgbench_history instead

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-09-01 Thread Masahiko Sawada
, something like "tables in reverse foreign key dependencies > order"? Fixed. > > case 'I': ISTM that initialize_cmds is necessarily already allocated, thus I > would not bother to test before pg_free. Agreed, fixed. Attached latest patch. Please review it. Regards,

Re: [HACKERS] [Proposal] Allow users to specify multiple tables in VACUUM commands

2017-08-31 Thread Masahiko Sawada
think we should set T_RangeVar to rangevar.type in autovacuum_do_vac_analyze function. Also, there is a small typo in dedupe_vacuum_relations_v2.patch. + /* if already procesed or not equal, skip */ + if (list_member_int(duplicates, i) || rela

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-30 Thread Masahiko Sawada
"u", though. Unlogged, like tablespace, is an orthogonal > option: other table creation options (I intend to submit one which conforms > to the TPC-B standard, that is use an INT8 balance as INT4 is not wide > enough per spec, and always use an INT8 aid) may be also unlogged

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-29 Thread Masahiko Sawada
y > v - vacuum > > I think it is mostly okay, but it is the last time to think about it. Using > "d" for cleanup (drop) would mean finding another letter for filling in > data... maybe "g" for data generation? "c" may have been chosen for "create >

Re: [HACKERS] WIP: Separate log file for extension

2017-08-29 Thread Masahiko Sawada
here we want to write log messages to separate log files by error level or purpose (server log and SQL log etc). Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make cha

Re: [HACKERS] Quorum commit for multiple synchronous replication.

2017-08-29 Thread Masahiko Sawada
On Thu, Aug 24, 2017 at 4:27 PM, Masahiko Sawada <sawada.m...@gmail.com> wrote: > On Thu, Aug 24, 2017 at 3:11 AM, Josh Berkus <j...@berkus.org> wrote: >> On 08/22/2017 11:04 PM, Masahiko Sawada wrote: >>> WARNING: what you did is ok, but you might have wanted to d

Re: [HACKERS] show "aggressive" or not in autovacuum logs

2017-08-29 Thread Masahiko Sawada
be a bit inclined to somehow show aggressive if it's > aggressive and not insert anything at all otherwise. That'd probably > require two separate translatable strings in each case, but maybe > that's OK. > > What do other people think? FWIW I prefer the Robert's idea; not insert anythi

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-28 Thread Masahiko Sawada
on and exiting instead of > returning false. Agreed, fixed. After more thought, I'm bit inclined to not have a short option for --custom-initialize because this option will be used for not primary cases. It would be better to save short options for future enhancements of pgbench. Thought? Attached

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-27 Thread Masahiko Sawada
error > which will trigger another fprintf and error above... ISTM that you should > either take into account previous comments or explain why you disagree with > them, but not send the same code without addressing them in any way. Sorry, I didn't mean to ignore, I'd just missed the com

Re: [HACKERS] Explicit relation name in VACUUM VERBOSE log

2017-08-25 Thread Masahiko Sawada
verbose logs are emitted mixed together even if -j option is specified. I sometimes search a particular table/index from the logs but also in that case it was hard to distinguish logs. This is still not primary case though. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT O

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

2017-08-25 Thread Masahiko Sawada
On Fri, Aug 25, 2017 at 4:27 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > > > On 2017/08/25 16:18, Masahiko Sawada wrote: >> >> On Fri, Aug 25, 2017 at 2:57 PM, vinayak >> <pokale_vinayak...@lab.ntt.co.jp> wrote: >>> >>> Hi Saw

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

2017-08-25 Thread Masahiko Sawada
On Fri, Aug 25, 2017 at 2:57 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > Hi Sawada-san, > > > On 2017/08/25 11:07, Masahiko Sawada wrote: >> >> On Fri, Aug 18, 2017 at 5:20 PM, vinayak >> <pokale_vinayak...@lab.ntt.co.jp> wrote: >>> &

Re: [HACKERS] ECPG: WHENEVER statement with DO CONTINUE action

2017-08-24 Thread Masahiko Sawada
On Fri, Aug 18, 2017 at 5:20 PM, vinayak <pokale_vinayak...@lab.ntt.co.jp> wrote: > > On 2017/06/20 17:35, vinayak wrote: >> >> Hi Sawada-san, >> >> On 2017/06/20 17:22, Masahiko Sawada wrote: >>> >>> On Tue, Jun 20, 2017 at 1:51 P

Re: [HACKERS] Quorum commit for multiple synchronous replication.

2017-08-24 Thread Masahiko Sawada
On Thu, Aug 24, 2017 at 3:11 AM, Josh Berkus <j...@berkus.org> wrote: > On 08/22/2017 11:04 PM, Masahiko Sawada wrote: >> WARNING: what you did is ok, but you might have wanted to do something else >> >> First of all, whether or not that can properly be called a war

Re: [HACKERS] pgbench: Skipping the creating primary keys after initialization

2017-08-24 Thread Masahiko Sawada
ngth of initialization steps would not long. Using malloced string would less the work. Ok, I changed the patch so. Attached latest v4 patch. Please review it. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center pgbench_custom_initializ

[HACKERS] Combination with priority-based and quorum-based synchronous replications

2017-08-23 Thread Masahiko Sawada
, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

  1   2   3   4   5   6   7   8   >