decide which to return.
Ah, now I understand. Sorry, I completely misunderstood your prior
email. Yes, you're right, I will change the code accordingly.
Thanks.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
t; false)
> ...
>return false;
> +} while (isdigit(**scan_length));
Yes, this is certainly correct and better than what I committed. What
was I thinking yesterday?
I think the same function is used for identifying garbage in floats
which might ask for different log
> > The first patch will reproduce the problem in ecpg's regress test.
> > The second patch tries to fix it in simple way.
Thanks for spotting and fixing. I changed your patch slightly and made
it check if the rest of the data is indeed digits, or else it would
accept something like &qu
patch to master
and backported to 9.4, 9.5, 9.6 and 10. It doesn't apply cleanly to
9.3. But then it might not be important enough to investigate and
backported to this old a version.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql)
> Isn't pgtypeslib/*.h exposed to ecpg-using applications?
No, the public interface is is include/*.h, pgtypeslib/*.h is only
internal.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at x
he fewer manual sync we need, the
better.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent vi
a reason why we, and other databases,
define it that way.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, P
set to 0.
I doubt it'll be a lot. However, it would make us differ, albeit very
slightly, from what others do. I haven't come up with a practical
problem coming from that difference though.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debi
nk there should be one? My memory might be wrong but I
don't think it's supposed to be a null terminated string.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borus
> woodlouse does not do ecpg-check, and Tom is right anyway. I need to
> get a large sign nailed to my forehead that says "Postgres is C, and
> declarations must come first."
I didn't notice either. I guess /me is getting rusty, sigh.
Michael
--
Michael Meskes
Michael a
> Unless someone has a better idea, I'd suggest working around
> that like so:
>
> #ifdef WIN32
> #ifdef _MSC_VER/* requires MSVC */
> _configthreadlocale(_ENABLE_PER_THREAD_LOCALE);
> #endif
> #endif
Let's try, committed, thanks again Tom.
Michael
--
... I wonder
> why).
I would assume it works on woodlouse as the patch has been submitted by
woodlouse's owner.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing list (pgsql-hackers
> Ha, that's interesting.
>
> Should be fixed now, please try again.
Works, thanks Magnus.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Fo
> Given that it's Friday evening in Europe, I'm betting Michael is gone
> for the day. In the interests of getting the buildfarm back to
> green,
> I'll see if I can fix this.
Correct, thanks Tom.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De
All,
I just committed a patch that is listed in the CF and had to put
somebody (I chose you Bruce :)) in as a committer because I was not
listed. Do I have to register somewhere?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian
> The v3 patch looks good to me. I've changed this patch status to Ready
> for Committer.
Thank you all, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes d
> And there are many "(0)" "S_ANYTHING" in src/interfaces/ecpg/test/ and
> src/interfaces/ecpg/preproc/.
I might have missed something here, but where/why is S_ANYTHING a problem?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|
> Some people use http://libpqtypes.esilo.com/
Never before saw this. It does not seem to have more in common than the
name, though.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot or
to carve out?
> Or from another perspective; how do other language (if any) solve this?
I'm not aware of any other language binding for pgtypeslib.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: mich
ase add a "DO CONTINUE" case to one of the test cases? Or
add a new one? We would need a test case IMO.
Thanks
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot or
before backporting. Obviously this doesn't make any sense for a doc patch, sigh.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debi
eed fix. The patch is attached.
Thanks, applied.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
t; regards, tom lane
Agreed. We will only run into problems with ecpg if some of the
existing oids change. Newly added ones will not be referenced unless
ecpg receives changes, too.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Me
e should be up to date.
Thanks for the patch, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, P
> > > I attach modified patch.
> > Thank you, committed.
>
> I don't see a git push for this?
Oops, should be there now.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael a
> I attach modified patch.
Thank you, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, Postgre
> Yes. I added two-phase commit test to "make check" test schedule
> while
> adding new two type of test.
Thank you, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael
twophase
> from schedule file and add new type of regression test.
Would it be possible to include it in "make check"? Any check that
needs manual interaction will not be executed nearly is often as the
others and become much less useful imo.
Michael
--
Michael Meskes
Michael a
> Previous 002 patch lacked to add describing PREPARE TRANSACTION.
> Attached updated 002 patch.
I just committed both patches and a backport of the bug fix itself.
Thanks again for finding and fixing.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|N
time it became the cause of this
> behavior.
> Is this a bug?
I'd say so, yes.
As soon as I find time I'll get to it including back porting your
patch.
Thank you very much for spotting and fixing.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Or
> Michael Meskes wrote:
> > The other option I can see, albeit without looking into details, is
> > allowing all comments and then testing it for the right syntax
> > after
> > parsing. This could potentially also solve the above mentioned
> > option
> > prob
lve the above mentioned option
problem.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent
ent" version the default without a new
option?
Michael
--
Dr. Michael Meskes, Geschaeftsfuehrer/CEO
Tel.: +49 (0)2166 / 99 01 0
E-Mail: michael.mes...@credativ.com
IM: m...@jabber.credativ.com
PGP: BBBC 58B4 5994 CF9C CC56 BCDA DF23 DA33 9697 8EB3
credativ international GmbH, HRB
ostgreSQL addon.
However, I think other databases do have the same statement, or don't
they?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 4
Hi,
> While investigating some other issue, we found a trivial bug of
> ecpg. The attached is a fix for that.
> ...
Thanks for spotting and fixing. Committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql
> there is a missing "EXEC" in ecpg.sgml in the list of transaction
> management commands.
Right, and the "SQL" was missing, too. Thanks for spotting, fixed in
HEAD.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes
gt; by statement_name.
Ah, now I understand. Thank you for your explanation.
I'm looking forward to seeing your patch.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL
, i.e. not executed at run time?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent
much more sense IMO.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hacke
'd prefer a technical solution over a
documentation one.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, Post
ll and
> libecpg6.dll, so that the application can fail to run with the
> incompatible versions of libpq and libecpg. FYI:
Does this mean you cannot have to versions of libpq installed on the
same Windows system at the same time?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Mich
application binary compatibility
> policy in the PostgreSQL manual. What do you think about it?
Couldn't you point your customer to the system documentation?
Personally I don't think standard system behavior should be documented
for each application relying on it but ymmv.
Michael
--
Micha
c, but a general system one as for instance the
same holds for libc.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian
t
exactly the same SQL. And we spend quite a bit of effort to make it
auto-build from the backend parser to make sure we don't lose any
changes.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at
> PS Who use ecpg? For me it's like hell.
More than you think.
I doubt you want to propose removing features that make developing new
features harder, or do you? :)
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql)
On Mon, Feb 08, 2016 at 09:20:46AM +, Huong Dangminh wrote:
> I think this fixed is also required for REL9_4_STABLE.
> Please confirm the attached patch.
Sure thing, no idea where that cherry-pick got lost.
Thanks.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at
back in the day.
Does this look right to you? If so, will you apply it?
Yes and yes. Thanks for spotting, fixed in master and the back branches.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber
also the point that changing longstanding code
creates back-patching hazards, so unless there's a clear gain it's best
not to.
Makes sense, but there is no point in adding hos if-guards to old code that
doesn't have it either,right?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael
wasn't referring to descriptor.c but to the whole preproc/ subtree.
But as I already said, since we went through the effort we can of course apply
it.
Will be in my next push.
Thanks.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian
the patch or if I should commit whatever is clear already.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux
way for placeholders, which is $1, $2, $3...
As Bruno already pointed out one could also argue that they just try to
accept what the standard asked them for.
I fail to see how such a way of arguing brings us closer to a solution,
though.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De
the standard?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing list
it is. The question mark is used in ecpg to denote a variable to
be filled-in by the process. I'm not completely sure if this was in the
standard or only implemented because several (not sure if all) other
precompiler used it as well.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot
When running the test suite of ecpg, build generates a set of obj
files and it happens that those files are not ignored in the code
tree.
Applied, thanks.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes
on, but how come these files were
only created in the ecpg testsuite? With the global .gitignore not
mentioning *.obj it appears those files are not created anywhere else.
Is the build process different for the rest of the tree?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes
a global ignore rule for .o
files it makes plenty of sense to have one for .obj files also.
Certainly better than have one rule for each ecpg test case.
Agreed. So we should revert the previous patch ...
Done.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot
A patch is attached, and the issue has been spotted by Coverity.
Regards,
Thanks, committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot
On Wed, Feb 04, 2015 at 10:07:07AM -0500, Tom Lane wrote:
Michael Meskes would be the authority on that question, so I've cc'd
him to make sure he notices this thread ...
Thanks Tom.
The leaks were in the code that takes a host variable, and converts it
into a string for sending
On Tue, Feb 03, 2015 at 10:44:17PM +0900, Michael Paquier wrote:
All those things are addressed in the patch attached.
Fixed a typo and commited. Thanks Michael for fixing and Heikki for
reviewing.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org
that much as
the codes won't be used by the server anyway. Besides, they may eventually
change and then we have to make sure to remember ecpg's copy again.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian
. Eventually that
might be all of them ... but in the meantime, we could at least
argue that we weren't breaking any case that worked well before.
This is what your patch did, right?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan
, but then the server doesn't know these either,
so the applications might break anyway.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia
PFA patch ecpg_char_ptr_arr.patch to fix this issue. It has changes as
follows
...
Thanks for finding and fixing the problem. Patch applied to complete 9 series
with only a minor change.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael
of day tomorrow? I'll be sitting on
a plane for a longer time again on Saturday. :)
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL
Thanks Ashutosh,
both patches committed and backported to the whole 9.* series.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL
On Wed, Apr 02, 2014 at 09:33:15AM +0530, Ashutosh Bapat wrote:
So, you are saying that we should try to catch such errors and report
during pre-compile time. That's better than silently corrupting the data.
Well, I think this goes without saying.
Michael
--
Michael Meskes
Michael at Fam
the years this test isn't needed anymore. The
regression suite works without just nicely.
To be honest, the whole type.c code needs a real rewrite to be better legible.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De
.
I'm sorry, but this sounds like a missing feature bug.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers
, the calculated offset of arr_col member would not coincide with
the real arr_col member's address.
Am I missing something here?
No, this looks like a bug to me. I haven't had time to look into the source
codebut the offset definitely is off.
Michael
--
Michael Meskes
Michael at Fam-Meskes
On Sun, Jan 12, 2014 at 08:28:57AM -0800, Kevin Grittner wrote:
desc.pgc:55: WARNING: descriptor outdesc does not exist
desc.pgc:86: WARNING: descriptor outdesc does not exist
Thanks, I didn't notice, fixed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com
You have to rebuild the auto-generated pgc.c, preproc.c and preproc.y or simply
remove them to force a rebuild.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing
an empty host variable instead of checking for it after the fact. But I take it
you don't mind that.
Fixed in HEAD and all back branches. Thanks for the report.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes
to figure
out why I don't see the same behaviour.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use
On Sat, Dec 28, 2013 at 08:04:09AM +0900, MauMau wrote:
OK, I'll run the ECPG regression test on Solaris without the patch.
Please wait until Jan 6 2014 or so, because we've just entered new
year holidays here in Japan.
Sure, we're no in a particular hurry.
Michael
--
Michael Meskes
Michael
parameter
to PQconnectdbParams().
Interestingly enough it works flawlessly on my system. Any idea where the
empoty host name comes from? Before accepting the patch I'd like to find out
why you got an empty host variable and I don't.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael
lengths.
How did you decide which values to put in? I fail to see a reason for choosing
exactly these values.
Mkichael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes
.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql
= -fPIC
else
before setting CFLAGS_SL = -fpic et voila XC builds just fine on S390.
So I wonder shouldn't we use -fPIC instead of -fpic for S390 in general?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes
here. :)
Checking the Debian logs it appears that all calls use *both* which seems to do
the right thing. And yes, it appears there is a change in XC that makes it
break. But still, I would think there has to be a correct set of options.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De
it, but it sure looks good to me. Feel free to commit.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian
On Sat, Nov 02, 2013 at 02:25:17PM -0400, Peter Eisentraut wrote:
This could be removed, but is it something that is actually part of what
is being tested?
Thanks for spotting Peter. Yes, this should have been used. I just committed a
fix.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot
On Fri, Jul 05, 2013 at 09:41:26AM -0400, Tom Lane wrote:
Um ... 9.3 is a separate branch now, please fix it there also.
Done. Seems I missed a new branch - yet again. Sorry and thanks for pointing it
out to me.
michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De
with chars
below 0x20. If anybody sees another character breaking ecpg, please tell me and
I'll fix it.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
On Wed, Jul 03, 2013 at 07:22:48PM +0900, MauMau wrote:
not specific to 9.3. Could you commit and backport this?
Committed to 8.4, 9.0, 9.1, 9.2 and HEAD.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes
that
need to be escaped. Gotta dig into this.
Thanks for pointing this out.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força
that it works nicely on Linux.
So what do ou mean when saying the problem also occurs on Linux?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
usage.
The directory name is in my example was test\\a. What did I miss?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força
in filenames
in #line directives, right? Apparently my examples were badly chosen as I
didn't see an error no matter how many backslashes I had.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql
On Tue, Jul 02, 2013 at 04:00:22PM -0400, Robert Haas wrote:
make you review patches against your will. Don't take it for more
than what Josh meant it as.
And that was what?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan
up the word I would describe your email with,
just for the fear of mistranslating it.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL
On Wed, Jul 03, 2013 at 09:47:13AM -0400, Robert Haas wrote:
An attempt to prod a few more people into helping review.
I can see that this pissed you off, and I'm sorry about that. But I
don't think that was his intent.
I hoped for this kind of answer from him but ...
Michael
--
Michael
in the first hand until I was
approached from other people and called a slacker in communication not related
to the CF at all.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber
on the people who are currently doing the vast
majority of review and commit.
You didn't ask! You blamed and offended people!
I won't go into details here because frankly why I have no time for reviewing a
patch is none of your business.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent via pgsql-hackers mailing
Looking around the 9.3 doc, I found a small, but not-insignificant
error in the documentation.
Thanks for finding and fixing. Patch committed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian
it was developed.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
for ecpg?
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
--
Sent
strange to forbid something in
ecpg grammar that the backend accepts, as a matter of principle.
Na, I was talking about copying from STDOUT and to STDIN. Even if this is a
very old feature I think we should fix it.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De
1 - 100 of 618 matches
Mail list logo