Re: Geometry regression tests (was Re: [HACKERS] Float output formatting
Tom Lane wrote: Pedro M. Ferreira [EMAIL PROTECTED] writes: [ patch for extra_float_digits ] I've applied this patch along with followup changes to pg_dump (it sets extra_float_digits to 2 to allow accurate dump/reload) and the geometry regression test (it sets extra_float_digits to -3). I find that two geometry 'expected' files are now sufficient to cover all the platforms I have available to test. (We'd only need one, if everyone displayed minus zero as '-0', but some platforms print '0'.) I tested on HPUX 10.20 (HPPA), Red Hat Linux 8.0 (Intel), Mac OS X 10.2.1 and LinuxPPC (PPC). I'd be interested to hear results of testing CVS tip (now 7.4devel) on other platforms. Does geometry pass cleanly for you? Yes! :) All tests passed on a dual AMD Athlon MP with Debian GNU/Linux 3.0 (Woody), kernel 2.4.18-5. Tested with a snapshot downloaded yesterday. Best regards, Pedro M. Ferreira regards, tom lane ---(end of broadcast)--- TIP 4: Don't 'kill -9' the postmaster ---(end of broadcast)--- TIP 5: Have you checked our extensive FAQ? http://www.postgresql.org/users-lounge/docs/faq.html
Re: [HACKERS] Float output formatting options
HI All, Tom Lane wrote: Bruce Momjian [EMAIL PROTECTED] writes: I am confused about this patch. I don't see extra_float_digits defined anywhere. Am I missing a patch ? Probably! :) The definition of extra_float_digits was made in float.c and the diff was sent to the list and Tom before. I think its the one Tom refers below. There were diff's to four files: src/backend/utils/adt/float.c src/backend/utils/misc/guc.c src/bin/psql/tab-complete.c src/backend/utils/misc/postgresql.conf.sample Evidently. I have the patch and was planning to apply it myself as soon as Pedro does something with the geometry types... Lots of mail in the list! ;) Its done. The diff file to src/backend/utils/adt/geo_ops.c (to handle the gemetry types) was sent some days ago. Its the one in the message where Bruce says that extra_float_digits is not defined anywhere. If you want I can send in the diff's again. Best regards, Pedro regards, tom lane -- -- Pedro Miguel Frazao Fernandes Ferreira Universidade do Algarve Faculdade de Ciencias e Tecnologia Campus de Gambelas 8000-117 Faro Portugal Tel./Fax: (+351) 289 800950 / 289 819403 http://w3.ualg.pt/~pfrazao ---(end of broadcast)--- TIP 6: Have you searched our list archives? http://archives.postgresql.org
