Re: [HACKERS] PostgreSQL 10beta1 / OpenBSD : compilation failed with libxml

2017-05-22 Thread Pierre-Emmanuel André 
On Mon, May 22, 2017 at 10:36:41AM -0400, Tom Lane wrote:
> Pierre-Emmanuel =?iso-8859-15?Q?Andr=E9?=  writes:
> > I still have an issue with OpenBSD -current and PostgreSQL 10beta1.
> 
> > common.o: In function `psql_get_variable':
> > common.c:(.text+0x114c): undefined reference to `appendShellStringNoError'
> > mainloop.o: In function `MainLoop':
> > mainloop.c:(.text+0xcd): undefined reference to `psql_scan_set_passthrough'
> > startup.o: In function `main':
> > startup.c:(.text+0x1b01): undefined reference to `psql_scan_set_passthrough'
> > collect2: ld returned 1 exit status
> 
> It looks like you are somehow linking to a pre-v10 version of
> libpgfeutils.a.  Maybe that is installed in /usr/local/lib or someplace?
> 
> > When i remove --libxml everything runs fine.
> 
> That's odd.  I think --with-libxml changes the set of -L directives,
> which could be a mechanism to explain that, but it's sure not clear
> why libxml would be bringing libpgfeutils along with it.
> 
> Note to hackers: seems like we'd better arrange for
> -L../../../src/fe_utils to appear earlier in psql's link command
> than it now does.  I think we thought we could get away with being
> sloppy because we weren't planning on libpgfeutils getting installed
> anywhere ... but that idea seems to have gone by the wayside.
> 


Hi Tom,

You're right. My build environnement was fucked up (2 versions of PostgreSQL).
I cleaned up and now everything runs fine:

# select version() ;
version
---
PostgreSQL 10beta1 on x86_64-unknown-openbsd6.1, compiled by cc (GCC) 4.2.1 
20070719 , 64-bit



(But it seems that libxml changes the order of -L directives)

Sorry for the noise.

Regards,




-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] PostgreSQL 10beta1 / OpenBSD : compilation failed with libxml

2017-05-22 Thread Pierre-Emmanuel André 
Hi,

I still have an issue with OpenBSD -current and PostgreSQL 10beta1.
I tried to build it with these options: --with-openssl=/usr --with-perl 
--with-pam=no --with-uuid=bsd --enable-integer-datetimes 
--with-system-tzdata=/usr/share/zoneinfo --with-openssl --disable-thread-safety 
--with-libxml

And I have this error:

gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -O2 command.o common.o conditional.o copy.o 
crosstabview.o describe.o help.o input.o large_obj.o mainloop.o prompt.o 
psqlscanslash.o sql_help.o startup.o stringutils.o tab-complete.o variables.o  
-L../../../src/common -lpgcommon -L../../../src/port -lpgport 
-L../../../src/interfaces/libpq -lpq -L../../../src/port -L../../../src/common 
-L/usr/local/lib -L/usr/lib -L/usr/local/lib -L/usr/local/lib  -Wl,-Bdynamic 
-Wl,-R'/usr/local/pgsql/lib' -L../../../src/fe_utils -lpgfeutils -lpq  
-lpgcommon -lpgport -lxml2 -lssl -lcrypto -lz -lreadline -ltermcap -lm  -o psql
command.o: In function `exec_command_set':
command.c:(.text+0x4e9a): warning: warning: strcat() is almost always misused, 
please use strlcat()
describe.o: In function `listTSParsers':
describe.c:(.text+0x4e06): warning: warning: sprintf() is often misused, please 
use snprintf()
large_obj.o: In function `do_lo_import':
large_obj.c:(.text+0x637): warning: warning: strcpy() is almost always misused, 
please use strlcpy()
common.o: In function `psql_get_variable':
common.c:(.text+0x114c): undefined reference to `appendShellStringNoError'
mainloop.o: In function `MainLoop':
mainloop.c:(.text+0xcd): undefined reference to `psql_scan_set_passthrough'
startup.o: In function `main':
startup.c:(.text+0x1b01): undefined reference to `psql_scan_set_passthrough'
collect2: ld returned 1 exit status
gmake[3]: *** [Makefile:34: psql] Error 1


When i remove --libxml everything runs fine.
Any ideas ?


Regards,


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PostgreSQL 10beta1 - compilation fails on OpenBSD -current

2017-05-19 Thread Pierre-Emmanuel André 
On Fri, May 19, 2017 at 01:32:37PM +0200, Pierre-Emmanuel André wrote:
> On Fri, May 19, 2017 at 12:44:27PM +0200, Pierre-Emmanuel André wrote:
> > On Fri, May 19, 2017 at 12:21:26PM +0300, Heikki Linnakangas wrote:
> > > On 05/19/2017 12:03 PM, Pierre-Emmanuel André wrote:
> > > > Hi,
> > > > 
> > > > I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this 
> > > > error:
> > > > 
> > > > gmake[3]: Entering directory 
> > > > '/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
> > > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > > -I../../../src/include -I/usr/local/include 
> > > > -I/usr/local/include/libxml2 -I/usr/local/include-c -o be-fsstubs.o 
> > > > be-fsstubs.c
> > > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > > -I../../../src/include -I/usr/local/include 
> > > > -I/usr/local/include/libxml2 -I/usr/local/include-c -o be-secure.o 
> > > > be-secure.c
> > > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > > -I../../../src/include -I/usr/local/include 
> > > > -I/usr/local/include/libxml2 -I/usr/local/include-c -o auth.o auth.c
> > > > auth.c: In function 'CheckBSDAuth':
> > > > auth.c:2265: error: too few arguments to function 'sendAuthRequest'
> > > > 
> > > > 
> > > > In auth.c, there is this call:
> > > > /* Send regular password request to client, and get the response */
> > > > sendAuthRequest(port, AUTH_REQ_PASSWORD);
> > > > 
> > > > but this function is defined like this:
> > > > static void sendAuthRequest(Port *port, AuthRequest areq, char 
> > > > *extradata,int extralen);
> > > 
> > > This was an oversight in my commit 8d3b9cce81c. It added those new
> > > arguments, but didn't update that call. I'll go fix that, thanks for the
> > > report!
> > > 
> > > You're the first to complain, and the buildfarm has been happy, so it 
> > > seems
> > > that you're the first one to try building 10beta1 with --with-bsd-auth. We
> > > have one OpenBSD box in the buildfarm, "curculio", but apparently it's not
> > > using the --with-bsd-auth option.
> > >
> > > Mikael, could you add --with-bsd-auth to curculio's configuration, please?
> > > On 9.6 and above.
> > >
> > 
> > I'm the maintainer of PostgreSQL on OpenBSD ;)
> > And the port enable --with-bsd-auth.
> > Thanks for your answer.
> > 
> > Regards,
> > 
> >
> 
> I have disabled the --with-bsd-auth and now i have these errors:
> 
> cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
> -Wendif-labels -Wmissing-format-attribute -Wformat-security 
> -fno-strict-aliasing -fwrapv -O2 -pipe command.o common.o conditional.o 
> copy.o crosstabview.o describe.o help.o input.o large_obj.o mainloop.o 
> prompt.o psqlscanslash.o sql_help.o startup.o stringutils.o tab-complete.o 
> variables.o  -L../../../src/common -lpgcommon -L../../../src/port -lpgport 
> -L../../../src/interfaces/libpq -lpq -L../../../src/port 
> -L../../../src/common -L/usr/local/lib -L/usr/local/lib -L/usr/lib 
> -L/usr/local/lib -L/usr/local/lib  -L/usr/local/lib -Wl,-Bdynamic 
> -L../../../src/fe_utils -lpgfeutils -lpq  -lpgcommon -lpgport -lxml2 -lssl 
> -lcrypto -lz -lreadline -ltermcap -lm  -o psql
> command.o: In function `exec_command_set':
> command.c:(.text+0x4e9a): warning: warning: strcat() is almost always 
> misused, please use strlcat()
> describe.o: In function `listTSParsers':
> describe.c:(.text+0x4e06): warning: warning: sprintf() is often misused, 
> please use snprintf()
> large_obj.o: In function `do_lo_import':
> large_obj.c:(.text+0x637): warning: warning: strcpy() is almost always 
> misused, please use strlcpy()
> common.o: In function `psql_get_variable':
> common.c:(.text+0x114c): undefined reference to `appendShellStringNoError'
> mainloop.o: In function `MainLoop':
> mainloop.c:(.text+0xcd): undefined reference to `psql_scan_set_passthrough'
> startup.o: In function `main':
> startup.c:(.text+0x1b01): undefined reference to `psql_scan_set_passthrough'
> collect2: ld returned 1 exit status
> gmake[3]: *** [Makefile:34: psql] Error 1
> 
> 
> 
> Any ideas ?
> 
>

Nevermind, i found the pb.


> -- 
> Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PostgreSQL 10beta1 - compilation fails on OpenBSD -current

2017-05-19 Thread Pierre-Emmanuel André 
On Fri, May 19, 2017 at 12:44:27PM +0200, Pierre-Emmanuel André wrote:
> On Fri, May 19, 2017 at 12:21:26PM +0300, Heikki Linnakangas wrote:
> > On 05/19/2017 12:03 PM, Pierre-Emmanuel André wrote:
> > > Hi,
> > > 
> > > I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this 
> > > error:
> > > 
> > > gmake[3]: Entering directory 
> > > '/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
> > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 
> > > -I/usr/local/include-c -o be-fsstubs.o be-fsstubs.c
> > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 
> > > -I/usr/local/include-c -o be-secure.o be-secure.c
> > > cc -Wall -Wmissing-prototypes -Wpointer-arith 
> > > -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute 
> > > -Wformat-security -fno-strict-aliasing -fwrapv -O2 -pipe 
> > > -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 
> > > -I/usr/local/include-c -o auth.o auth.c
> > > auth.c: In function 'CheckBSDAuth':
> > > auth.c:2265: error: too few arguments to function 'sendAuthRequest'
> > > 
> > > 
> > > In auth.c, there is this call:
> > > /* Send regular password request to client, and get the response */
> > > sendAuthRequest(port, AUTH_REQ_PASSWORD);
> > > 
> > > but this function is defined like this:
> > > static void sendAuthRequest(Port *port, AuthRequest areq, char 
> > > *extradata,int extralen);
> > 
> > This was an oversight in my commit 8d3b9cce81c. It added those new
> > arguments, but didn't update that call. I'll go fix that, thanks for the
> > report!
> > 
> > You're the first to complain, and the buildfarm has been happy, so it seems
> > that you're the first one to try building 10beta1 with --with-bsd-auth. We
> > have one OpenBSD box in the buildfarm, "curculio", but apparently it's not
> > using the --with-bsd-auth option.
> >
> > Mikael, could you add --with-bsd-auth to curculio's configuration, please?
> > On 9.6 and above.
> >
> 
> I'm the maintainer of PostgreSQL on OpenBSD ;)
> And the port enable --with-bsd-auth.
> Thanks for your answer.
> 
> Regards,
> 
>

I have disabled the --with-bsd-auth and now i have these errors:

cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -O2 -pipe command.o common.o conditional.o copy.o 
crosstabview.o describe.o help.o input.o large_obj.o mainloop.o prompt.o 
psqlscanslash.o sql_help.o startup.o stringutils.o tab-complete.o variables.o  
-L../../../src/common -lpgcommon -L../../../src/port -lpgport 
-L../../../src/interfaces/libpq -lpq -L../../../src/port -L../../../src/common 
-L/usr/local/lib -L/usr/local/lib -L/usr/lib -L/usr/local/lib -L/usr/local/lib  
-L/usr/local/lib -Wl,-Bdynamic -L../../../src/fe_utils -lpgfeutils -lpq  
-lpgcommon -lpgport -lxml2 -lssl -lcrypto -lz -lreadline -ltermcap -lm  -o psql
command.o: In function `exec_command_set':
command.c:(.text+0x4e9a): warning: warning: strcat() is almost always misused, 
please use strlcat()
describe.o: In function `listTSParsers':
describe.c:(.text+0x4e06): warning: warning: sprintf() is often misused, please 
use snprintf()
large_obj.o: In function `do_lo_import':
large_obj.c:(.text+0x637): warning: warning: strcpy() is almost always misused, 
please use strlcpy()
common.o: In function `psql_get_variable':
common.c:(.text+0x114c): undefined reference to `appendShellStringNoError'
mainloop.o: In function `MainLoop':
mainloop.c:(.text+0xcd): undefined reference to `psql_scan_set_passthrough'
startup.o: In function `main':
startup.c:(.text+0x1b01): undefined reference to `psql_scan_set_passthrough'
collect2: ld returned 1 exit status
gmake[3]: *** [Makefile:34: psql] Error 1



Any ideas ?


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] PostgreSQL 10beta1 - compilation fails on OpenBSD -current

2017-05-19 Thread Pierre-Emmanuel André 
On Fri, May 19, 2017 at 12:21:26PM +0300, Heikki Linnakangas wrote:
> On 05/19/2017 12:03 PM, Pierre-Emmanuel André wrote:
> > Hi,
> > 
> > I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this 
> > error:
> > 
> > gmake[3]: Entering directory 
> > '/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
> > cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
> > -Wendif-labels -Wmissing-format-attribute -Wformat-security 
> > -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
> > -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include
> > -c -o be-fsstubs.o be-fsstubs.c
> > cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
> > -Wendif-labels -Wmissing-format-attribute -Wformat-security 
> > -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
> > -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include
> > -c -o be-secure.o be-secure.c
> > cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
> > -Wendif-labels -Wmissing-format-attribute -Wformat-security 
> > -fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
> > -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include
> > -c -o auth.o auth.c
> > auth.c: In function 'CheckBSDAuth':
> > auth.c:2265: error: too few arguments to function 'sendAuthRequest'
> > 
> > 
> > In auth.c, there is this call:
> > /* Send regular password request to client, and get the response */
> > sendAuthRequest(port, AUTH_REQ_PASSWORD);
> > 
> > but this function is defined like this:
> > static void sendAuthRequest(Port *port, AuthRequest areq, char 
> > *extradata,int extralen);
> 
> This was an oversight in my commit 8d3b9cce81c. It added those new
> arguments, but didn't update that call. I'll go fix that, thanks for the
> report!
> 
> You're the first to complain, and the buildfarm has been happy, so it seems
> that you're the first one to try building 10beta1 with --with-bsd-auth. We
> have one OpenBSD box in the buildfarm, "curculio", but apparently it's not
> using the --with-bsd-auth option.
>
> Mikael, could you add --with-bsd-auth to curculio's configuration, please?
> On 9.6 and above.
>

I'm the maintainer of PostgreSQL on OpenBSD ;)
And the port enable --with-bsd-auth.
Thanks for your answer.

Regards,


> - Heikki
> 


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] PostgreSQL 10beta1 - compilation fails on OpenBSD -current

2017-05-19 Thread Pierre-Emmanuel André 
Hi,

I tried to build PostgreSQL 10beta1 on OpenBSD -current and i have this error:

gmake[3]: Entering directory 
'/usr/ports/pobj/postgresql-10beta1/postgresql-10beta1/src/backend/libpq'
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
-I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include-c -o 
be-fsstubs.o be-fsstubs.c
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
-I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include-c -o 
be-secure.o be-secure.c
cc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement 
-Wendif-labels -Wmissing-format-attribute -Wformat-security 
-fno-strict-aliasing -fwrapv -O2 -pipe -I../../../src/include 
-I/usr/local/include -I/usr/local/include/libxml2 -I/usr/local/include-c -o 
auth.o auth.c
auth.c: In function 'CheckBSDAuth':
auth.c:2265: error: too few arguments to function 'sendAuthRequest'


In auth.c, there is this call:
/* Send regular password request to client, and get the response */
sendAuthRequest(port, AUTH_REQ_PASSWORD);

but this function is defined like this:
static void sendAuthRequest(Port *port, AuthRequest areq, char *extradata,int 
extralen);


Regards,


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Proposal: BSD Authentication support

2016-04-08 Thread Pierre-Emmanuel André 
On Fri, Mar 18, 2016 at 06:30:35PM +1300, Thomas Munro wrote:
> On Fri, Mar 18, 2016 at 12:49 PM, Marisa Emerson <m...@insec.sh> wrote:
> > On 18/03/16 03:57, Thomas Munro wrote:
> >>
> >> You used one name in the docs and another in the code:
> >>
> >> +BSD Authentication on PostgreSQL uses the
> >> auth-postgres
> >> +login type and authenticates with the postgres
> >> login
> >>
> >> + retval = auth_userokay(user, NULL, "auth-postgresql", passwd);
> >
> >
> > Woops, fix attached.
> 
> Thanks!
> 
> I'm CCng Pierre-Emmanuel André, maintainer of the OpenBSD postgresql
> port/package, just in case he has any feedback.
> 
> Pierre-Emmanuel, here's the full thread in case you missed it:
> http://www.postgresql.org/message-id/1521c2f9465.e357a543197915.6912077634413325...@insec.sh
> 


Hi,

Sorry for the late answer.
I've tested the patch on @amd64 with the latest PostgreSQL 9.6devel. I can't 
judge the diff
itself (it looks good but i'm not a PostgreSQL developper) but everything works 
fine.
It would be a nice feature to have on OpenBSD.

Regards,



-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers