Re: [HACKERS] Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 - > 10.0

2016-04-30 Thread Tomasz Rybak
o do review) would be beneficial. For now I'm not sure what is going on with pglogical, and whether my review even mattered. Best regards Tomasz Rybak -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Interesting read on SCM upending software and hardware architecture

2016-01-27 Thread Tomasz Rybak
ange storage subsystem might help with experimentation, but even now (OK, when 9.6 is out) we might use increased IO concurrency. --  Tomasz Rybak GPG/PGP key ID: 2AD5 9860 Fingerprint A481 824E 7DD3 9C0E C40A 488E C654 FB33 2AD5 9860 http://member.acm.org/~tomaszrybak signature.asc Description: This is a digitally signed message part

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-24 Thread Tomasz Rybak
 HASH_ENTER, ); > > + > > +   if (!found) > > +   { > > +   Assert(hentry->relid = RelationGetRelid(rel)); > > +   hentry->is_cached = false; > > +   hentry->api_private = NULL; > &

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-24 Thread Tomasz Rybak
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Final part of review: protocol.txt +|origin_identifier|signed

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-21 Thread Tomasz Rybak
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested Documentation - although I haven't yet went through protocol documentation:

Re: [HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-20 Thread Tomasz Rybak
W dniu 20.01.2016, śro o godzinie 13∶54 +0800, użytkownik Craig Ringer napisał: > On 20 January 2016 at 06:23, Tomasz Rybak <tomasz.ry...@post.pl> > wrote: > > The following review has been posted through the commitfest > > application: > > > Thanks! >  

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-20 Thread Tomasz Rybak
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested I revied more files: pglogical_proto_native.c +

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-19 Thread Tomasz Rybak
The following review has been posted through the commitfest application: make installcheck-world: not tested Implements feature: not tested Spec compliant: not tested Documentation:not tested First part of code review (for about 1/3rd of code): pglogical_output.h: +

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-18 Thread Tomasz Rybak
I just quickly went through patch v5. It's rather big patch, on (or beyond) my knowledge of PostgreSQL to perform high-quality review. But during this week I'll try to send reviews of parts of the code, as going through it in one sitting seems impossible. One proposed change - update copyright

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2016-01-18 Thread Tomasz Rybak
on about long- or mid-term direction or vision. It makes harder to feel that it matters and to decide which patch look at. Both communities I feel attached to (Debian and PostgreSQL) differ from many highly visible FLOSS projects that they do not have one backing company, nor benevolent dictato

[HACKERS] Re: pglogical_output - a general purpose logical decoding output plugin

2016-01-03 Thread Tomasz Rybak
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: not tested Spec compliant: not tested Documentation:tested, failed Applies cleanly on current master

Re: [HACKERS] pglogical_output - a general purpose logical decoding output plugin

2015-11-18 Thread Tomasz Rybak
5  compatibility needed in README.md and README.plhooks? It's not much text, but I'm not sure whether they shouldn't be removed for 9.6-targeting change. -- Tomasz Rybak GPG/PGP key ID: 2AD5 9860 Fingerprint A481 824E 7DD3 9C0E C40A 488E C654 FB33 2AD5 9860 http://member.acm.org/~tomas