Re: [HACKERS] (re)start in our init scripts seems broken

2016-07-20 Thread Tom Lane
Michael Paquier writes: > On Wed, Jul 20, 2016 at 11:41 AM, Tomas Vondra > wrote: >> Is there a reason why it's coded like this? I think we should use the pg_ctl >> instead or (at the very least) check the postmaster return code. Also, >>

Re: [HACKERS] (re)start in our init scripts seems broken

2016-07-19 Thread Michael Paquier
On Wed, Jul 20, 2016 at 11:41 AM, Tomas Vondra wrote: > Is there a reason why it's coded like this? I think we should use the pg_ctl > instead or (at the very least) check the postmaster return code. Also, > perhaps we should add an explicit timeout, higher than 60

[HACKERS] (re)start in our init scripts seems broken

2016-07-19 Thread Tomas Vondra
Hi, A few days ago I ran into a problem with the init script packaged in our community RPM packages. What happened was that they initiated a restart, but this happened: # /etc/init.d/postgresql-9.3 restart Stopping postgresql-9.3 service: [FAILED] Starting