Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-04-10 Thread Andrew Dunstan
On 04/10/2017 12:43 AM, Michael Paquier wrote: > On Mon, Apr 10, 2017 at 1:01 PM, Noah Misch wrote: >> This PostgreSQL 10 open item is past due for your status update. Kindly send >> a status update within 24 hours, and include a date for your subsequent >> status >>

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-04-09 Thread Michael Paquier
On Mon, Apr 10, 2017 at 1:01 PM, Noah Misch wrote: > This PostgreSQL 10 open item is past due for your status update. Kindly send > a status update within 24 hours, and include a date for your subsequent status > update. Refer to the policy on open item ownership: >

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-04-09 Thread Noah Misch
On Wed, Apr 05, 2017 at 02:49:41AM -0400, Noah Misch wrote: > On Fri, Mar 24, 2017 at 12:26:33PM +0900, Michael Paquier wrote: > > On Thu, Mar 23, 2017 at 1:10 AM, Stephen Frost wrote: > > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > > >> On 03/22/2017 11:39

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-04-05 Thread Noah Misch
On Fri, Mar 24, 2017 at 12:26:33PM +0900, Michael Paquier wrote: > On Thu, Mar 23, 2017 at 1:10 AM, Stephen Frost wrote: > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > >> On 03/22/2017 11:39 AM, Stephen Frost wrote: > >> > * Andrew Dunstan (and...@dunslane.net)

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-03-23 Thread Michael Paquier
On Thu, Mar 23, 2017 at 1:10 AM, Stephen Frost wrote: > Andrew, > > * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: >> On 03/22/2017 11:39 AM, Stephen Frost wrote: >> > * Andrew Dunstan (and...@dunslane.net) wrote: >> >> Sync pg_dump and pg_dumpall output >> > This

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-03-22 Thread Andrew Dunstan
On 03/22/2017 12:10 PM, Stephen Frost wrote: >> Still I agree that we should have tests for both cases. > Perhaps, though if I recall correctly, we've basically had zero calls > for fsync() until this. If we don't feel like we need to test that in > the backend then it seems a bit silly to feel

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-03-22 Thread Stephen Frost
Andrew, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 03/22/2017 11:39 AM, Stephen Frost wrote: > > * Andrew Dunstan (and...@dunslane.net) wrote: > >> Sync pg_dump and pg_dumpall output > > This probably should have adjusted all callers of pg_dump in the > > regression tests to

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-03-22 Thread Andrew Dunstan
On 03/22/2017 11:39 AM, Stephen Frost wrote: > Andrew, > > * Andrew Dunstan (and...@dunslane.net) wrote: >> Sync pg_dump and pg_dumpall output > This probably should have adjusted all callers of pg_dump in the > regression tests to use the --no-sync option, otherwise we'll end up > spending

Re: [HACKERS] [COMMITTERS] pgsql: Sync pg_dump and pg_dumpall output

2017-03-22 Thread Stephen Frost
Andrew, * Andrew Dunstan (and...@dunslane.net) wrote: > Sync pg_dump and pg_dumpall output This probably should have adjusted all callers of pg_dump in the regression tests to use the --no-sync option, otherwise we'll end up spending possibly a good bit of time calling fsync() during the