Brent Dombrowski brent.dombrow...@gmail.com writes:
[ review of KaiGai-san's patch ]
Committed. Thanks for the patch, and the review.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
I have not been able to find any comments or discussion on this patch.
Contents and Purpose:
This patch removes duplicate code in opclasscmds.c. It removes the
duplicate code from DefineOpFamily by calling CreateOpFamily.
No new regression test or documentation are included
It looks like for me the bottom half of the DefineOpFamily() is
a block copied and pasted from CreateOpFamily().
It has identical logic, variable names and source code comments.
Perhaps, we can replace this code block by CreateOpFamily() call.
Thanks,
--
KaiGai Kohei kai...@ak.jp.nec.com
