On Mon, Nov 13, 2017 at 7:37 AM, Noah Misch wrote:
> On Fri, Nov 03, 2017 at 11:10:14AM +, Michael Paquier wrote:
>> I am
>> switching the patch as ready for committer, I definitely agree that
>> you are taking the write approach here.
s/write/right/.
> Committed both patches.
Thanks for do
On Sat, Oct 28, 2017 at 03:43:02PM -0700, Michael Paquier wrote:
> couldn't we envisage to just use
> malloc? pgwin32_message_to_UTF16() is called in two places in elog.c,
> and there is a full control on the error code paths.
Switching to malloc is feasible, but it wouldn't enable PostgreSQL to h
On Wed, Nov 1, 2017 at 12:07 AM, Tsunakawa, Takayuki
wrote:
> From: Michael Paquier [mailto:michael.paqu...@gmail.com]
>> On Tue, Oct 31, 2017 at 6:59 AM, Tsunakawa, Takayuki
>> wrote:
>> > When CurrentMemoryContext is NULL, the message is logged with
>> ReportEventA(). This is similar to write
From: Michael Paquier [mailto:michael.paqu...@gmail.com]
> On Tue, Oct 31, 2017 at 6:59 AM, Tsunakawa, Takayuki
> wrote:
> > When CurrentMemoryContext is NULL, the message is logged with
> ReportEventA(). This is similar to write_console().
>
> My point is that as Postgres is running as a servi
On Tue, Oct 31, 2017 at 6:59 AM, Tsunakawa, Takayuki
wrote:
> From: pgsql-hackers-ow...@postgresql.org
>> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
>> So you are basically ready to lose any message that could be pushed
>> here if there is no memory context? That does
From: pgsql-hackers-ow...@postgresql.org
> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Michael Paquier
> So you are basically ready to lose any message that could be pushed
> here if there is no memory context? That does not sound like a good
> trade-off to me. A static buffer does not
On Thu, Oct 26, 2017 at 7:10 PM, Tsunakawa, Takayuki
wrote:
> FIX
> ==
>
> Add the check "CurrentMemoryContext != NULL" in write_eventlog() as in
> write_console().
* Also verify that we are not on our way into error recursion
trouble due
* to error
Hello,
We encountered a rare and hard-to-investigate problem on Windows, which one of
our customers reported. Please find the attached patch to fix that. I'll add
this to the next CF.
PROBLEM
==
PostgreSQL sometimes crashes with the following messages. This is i