Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

On Thu, Jul 27, 2017 at 4:27 AM, Aleksander Alekseev wrote: > I like the idea. However maybe it worth considering to turn it into a > TAP test? Otherwise there is a good chance everybody will forget to run > it. For similar reason I would advise to add this patch to the

Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

On Thu, Jul 27, 2017 at 10:27 AM, Aleksander Alekseev wrote: >> Here's a script that reminds you about GUCs you forgot to put in >> postgresql.conf.sample. It probably needs some work. Does this >> already happen somewhere else? I guess not, because it found two >>

Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

Hi Thomas, > Here's a script that reminds you about GUCs you forgot to put in > postgresql.conf.sample. It probably needs some work. Does this > already happen somewhere else? I guess not, because it found two > discrepancies: > > $ ./src/tools/check_sample_config.pl > enable_gathermerge

[HACKERS] A couple of postgresql.conf.sample discrepancies

Hi hackers, Here's a script that reminds you about GUCs you forgot to put in postgresql.conf.sample. It probably needs some work. Does this already happen somewhere else? I guess not, because it found two discrepancies: $ ./src/tools/check_sample_config.pl enable_gathermerge appears in guc.c