Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

[Robert Haas]

On Thu, Jul 27, 2017 at 4:27 AM, Aleksander Alekseev
 wrote:
> I like the idea. However maybe it worth considering to turn it into a
> TAP test? Otherwise there is a good chance everybody will forget to run
> it. For similar reason I would advise to add this patch to the next
> commitfest.

Instead of adding it to a TAP test, I think we should add it to the
build process, so you get a compile failure if it finds any problems.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

[Michael Paquier]

On Thu, Jul 27, 2017 at 10:27 AM, Aleksander Alekseev
 wrote:
>> Here's a script that reminds you about GUCs you forgot to put in
>> postgresql.conf.sample.  It probably needs some work.  Does this
>> already happen somewhere else?  I guess not, because it found two
>> discrepancies:
>>
>> $ ./src/tools/check_sample_config.pl
>> enable_gathermerge appears in guc.c but not in postgresql.conf.sample
>> trace_recovery_messages appears in guc.c but not in postgresql.conf.sample
>
> I like the idea. However maybe it worth considering to turn it into a
> TAP test? Otherwise there is a good chance everybody will forget to run
> it. For similar reason I would advise to add this patch to the next
> commitfest.

Bonus points if the script can detect that a parameter's comment
forgets to include "(change requires restart)".
-- 
Michael


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A couple of postgresql.conf.sample discrepancies

[Aleksander Alekseev]

Hi Thomas,

> Here's a script that reminds you about GUCs you forgot to put in
> postgresql.conf.sample.  It probably needs some work.  Does this
> already happen somewhere else?  I guess not, because it found two
> discrepancies:
> 
> $ ./src/tools/check_sample_config.pl
> enable_gathermerge appears in guc.c but not in postgresql.conf.sample
> trace_recovery_messages appears in guc.c but not in postgresql.conf.sample

I like the idea. However maybe it worth considering to turn it into a
TAP test? Otherwise there is a good chance everybody will forget to run
it. For similar reason I would advise to add this patch to the next
commitfest.

-- 
Best regards,
Aleksander Alekseev


signature.asc
Description: PGP signature

[HACKERS] A couple of postgresql.conf.sample discrepancies

[Thomas Munro]

Hi hackers,

Here's a script that reminds you about GUCs you forgot to put in
postgresql.conf.sample.  It probably needs some work.  Does this
already happen somewhere else?  I guess not, because it found two
discrepancies:

$ ./src/tools/check_sample_config.pl
enable_gathermerge appears in guc.c but not in postgresql.conf.sample
trace_recovery_messages appears in guc.c but not in postgresql.conf.sample

I think the first should be listed in postgresql.conf.sample, but the
second should probably be flagged as GUC_NOT_IN_SAMPLE.  See attached.

-- 
Thomas Munro
http://www.enterprisedb.com


fix-sample-config.patch
Description: Binary data


check-sample-config-v1.patch
Description: Binary data

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers