Re: [HACKERS] Adding table_constraint description in ALTER TABLE synopsis

2017-10-28 Thread Robert Haas
On Thu, Oct 26, 2017 at 3:23 PM, Lætitia Avrot  wrote:
> In documentation, I've found that table_constraint is used in the ALTER
> TABLE synopsis but that definition of table_constraint is missing, so I
> submitted bug #14873.
>
> I found the table_constraint definition in the CREATE TABLE synopsis and I
> just copied/pasted it on the ALTER TABLE synopsis.
>
> The patch should apply to MASTER.I build and tested it successfully on my
> computer.
>
> There shouldn't be any platform-specific content.
>
> You will find enclosed my patch. I tried my best to follow instructions on
> how to submit a patch.

I'd say you did a good job.  Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers


[HACKERS] Adding table_constraint description in ALTER TABLE synopsis

2017-10-26 Thread Lætitia Avrot
Hi,

In documentation, I've found that table_constraint is used in the ALTER
TABLE synopsis but that definition of table_constraint is missing, so I
submitted bug #14873.

I found the table_constraint definition in the CREATE TABLE synopsis and I
just copied/pasted it on the ALTER TABLE synopsis.

The patch should apply to MASTER.I build and tested it successfully on my
computer.

There shouldn't be any platform-specific content.

You will find enclosed my patch. I tried my best to follow instructions on
how to submit a patch.

Regards,

Lætitia
diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index 234ccb7..41acda0 100644
*** a/doc/src/sgml/ref/alter_table.sgml
--- b/doc/src/sgml/ref/alter_table.sgml
***
*** 85,90  ALTER TABLE [ IF EXISTS ] name
--- 85,101 
  OWNER TO { new_owner | CURRENT_USER | SESSION_USER }
  REPLICA IDENTITY { DEFAULT | USING INDEX index_name | FULL | NOTHING }
  
+ and table_constraint is:
+ 
+ [ CONSTRAINT constraint_name ]
+ { CHECK ( expression ) [ NO INHERIT ] |
+   UNIQUE ( column_name [, ... ] ) index_parameters |
+   PRIMARY KEY ( column_name [, ... ] ) index_parameters |
+   EXCLUDE [ USING index_method ] ( exclude_element WITH operator [, ... ] ) index_parameters [ WHERE ( predicate ) ] |
+   FOREIGN KEY ( column_name [, ... ] ) REFERENCES reftable [ ( refcolumn [, ... ] ) ]
+ [ MATCH FULL | MATCH PARTIAL | MATCH SIMPLE ] [ ON DELETE action ] [ ON UPDATE action ] }
+ [ DEFERRABLE | NOT DEFERRABLE ] [ INITIALLY DEFERRED | INITIALLY IMMEDIATE ]
+ 
  and table_constraint_using_index is:
  
  [ CONSTRAINT constraint_name ]

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers