Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On Wed, Nov 5, 2014 at 8:30 PM, Peter Geoghegan p...@heroku.com wrote: Thanks for the review. Committed with some copy-editing based on Andreas's comments. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On Fri, Nov 7, 2014 at 12:52 PM, Robert Haas robertmh...@gmail.com wrote: Committed with some copy-editing based on Andreas's comments. Thank you both. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription:

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On 11/06/2014 02:30 AM, Peter Geoghegan wrote: Thanks for the review. On Wed, Nov 5, 2014 at 4:33 PM, Andreas Karlsson andr...@proxel.se wrote: I looked at the changes to the code. The new code is clean and there is more code re-use and improved readability. On possible further improvement

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On 10/10/14, 7:26 PM, Peter Geoghegan wrote: Both Robert and Heikki expressed dissatisfaction with the fact that B-Tree index builds don't use sortsupport. Because B-Tree index builds cannot really use the onlyKey optimization, the historic oversight of not supporting B-Tree builds (and CLUSTER)

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On Wed, Nov 5, 2014 at 8:36 AM, Jim Nasby jim.na...@bluetreble.com wrote: Did anything ever happen with this? I consider this to be related to the abbreviated keys stuff, although it is clearly independently valuable (so it could be reviewed independently). Since Robert ran out of time to work

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

On 10/11/2014 02:26 AM, Peter Geoghegan wrote: Both Robert and Heikki expressed dissatisfaction with the fact that B-Tree index builds don't use sortsupport. Because B-Tree index builds cannot really use the onlyKey optimization, the historic oversight of not supporting B-Tree builds (and

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

Thanks for the review. On Wed, Nov 5, 2014 at 4:33 PM, Andreas Karlsson andr...@proxel.se wrote: I looked at the changes to the code. The new code is clean and there is more code re-use and improved readability. On possible further improvement would be to move the preparation of SortSupport to

[HACKERS] B-Tree index builds, CLUSTER, and sortsupport

Both Robert and Heikki expressed dissatisfaction with the fact that B-Tree index builds don't use sortsupport. Because B-Tree index builds cannot really use the onlyKey optimization, the historic oversight of not supporting B-Tree builds (and CLUSTER) might have been at least a little