Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-07 Thread Peter Geoghegan
On Fri, Nov 7, 2014 at 12:52 PM, Robert Haas wrote: > Committed with some copy-editing based on Andreas's comments. Thank you both. -- Peter Geoghegan -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpr

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-07 Thread Robert Haas
On Wed, Nov 5, 2014 at 8:30 PM, Peter Geoghegan wrote: > Thanks for the review. Committed with some copy-editing based on Andreas's comments. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-06 Thread Andreas Karlsson
On 11/06/2014 02:30 AM, Peter Geoghegan wrote: Thanks for the review. On Wed, Nov 5, 2014 at 4:33 PM, Andreas Karlsson wrote: I looked at the changes to the code. The new code is clean and there is more code re-use and improved readability. On possible further improvement would be to move the

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-05 Thread Peter Geoghegan
Thanks for the review. On Wed, Nov 5, 2014 at 4:33 PM, Andreas Karlsson wrote: > I looked at the changes to the code. The new code is clean and there is more > code re-use and improved readability. On possible further improvement would > be to move the preparation of SortSupport to a common funct

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-05 Thread Andreas Karlsson
On 10/11/2014 02:26 AM, Peter Geoghegan wrote:> Both Robert and Heikki expressed dissatisfaction with the fact that > B-Tree index builds don't use sortsupport. Because B-Tree index builds > cannot really use the "onlyKey" optimization, the historic oversight > of not supporting B-Tree builds (an

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-05 Thread Peter Geoghegan
On Wed, Nov 5, 2014 at 8:36 AM, Jim Nasby wrote: > Did anything ever happen with this? I consider this to be related to the abbreviated keys stuff, although it is clearly independently valuable (so it could be reviewed independently). Since Robert ran out of time to work on abbreviated keys (hope

Re: [HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-11-05 Thread Jim Nasby
On 10/10/14, 7:26 PM, Peter Geoghegan wrote: Both Robert and Heikki expressed dissatisfaction with the fact that B-Tree index builds don't use sortsupport. Because B-Tree index builds cannot really use the "onlyKey" optimization, the historic oversight of not supporting B-Tree builds (and CLUSTER

[HACKERS] B-Tree index builds, CLUSTER, and sortsupport

2014-10-10 Thread Peter Geoghegan
Both Robert and Heikki expressed dissatisfaction with the fact that B-Tree index builds don't use sortsupport. Because B-Tree index builds cannot really use the "onlyKey" optimization, the historic oversight of not supporting B-Tree builds (and CLUSTER) might have been at least a little understanda